GitLab

We were getting an error because |insertBefore| requires the second argument to
be a direct child of its |this| object, and in the sync dialog, that is not the case.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9562050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130
TEST=none


Review URL: http://codereview.chromium.org/9585004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124692 0039d316-1c4b-4281-b951-d872f2087c98

Also rename some not-yet-used button assets to have shorter names.

BUG=113075
TEST=none
TBR=davemoore@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9583017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9562008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116207
TEST=set RestoreOnStartupURLs policy, list in dialog is disabled

Review URL: https://chromiumcodereview.appspot.com/9561006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124689 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leak in BrowserMainPartsPosix::PostMainMessageLoopStart

BUG=29675
TEST=Run Valgrind on Chrome OS
R=willchan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9572017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124688 0039d316-1c4b-4281-b951-d872f2087c98

Blacklist sdhook32.dll that is part of "Spybot - Search & Destroy Live Protection".
We'd seen the cases of crashes caused by that DLL. Looks that it modifies IAT
of kernelbase.dll and then unloaded itself without unpatching IAT, causing
delay load of ffmpeg to crash.

Verified that blacklist really works. Installed version of ""Spybot - Search & Destroy"
with "Live Protection" on my old XP machine, attached the debugger, and saw sdhook32.dll
in all unmodified chrome processes. Copied Chrome with my changes to that machine,
launched, and saw sdhook32.dll only in the browser, not in the renderer.

BUG=110983

Review URL: http://codereview.chromium.org/9568013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124687 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 116383
TEST= none

Review URL: http://codereview.chromium.org/9566008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124686 0039d316-1c4b-4281-b951-d872f2087c98

Remove the duplicated prototypes and typedefs now that we have a NaCl
header file to get them from that can be #included from Chromium
without conflicts.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2628
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/9565046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124685 0039d316-1c4b-4281-b951-d872f2087c98

Requires setting background.allow_js_access to false in manifest.

BUG=113444
TEST=Example hosted app has different processes in different tabs.


Review URL: http://codereview.chromium.org/9508008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124684 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113399
TEST=Manual

Review URL: http://codereview.chromium.org/9582011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124682 0039d316-1c4b-4281-b951-d872f2087c98

Some fixes split off from https://chromiumcodereview.appspot.com/9570064/ to try and make the omnibox_view_browsertest.cc tests less flaky and make it possible to use the HQP in them.

BUG=none
TEST=none
TBR=mrossetti
Review URL: https://chromiumcodereview.appspot.com/9586012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124681 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9582009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124680 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for races in SequencedWorkerPool

BUG=115987
TEST=TSAN Bots go green on Linux
R=akalin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9583015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78085
TEST=unit_tests


Review URL: http://codereview.chromium.org/9518008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124678 0039d316-1c4b-4281-b951-d872f2087c98

The performance hit may be too high.

BUG=116401
TEST=


Review URL: http://codereview.chromium.org/9562009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124677 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppression for leak in LoggingTest_Dcheck_Test

BUG=116559
TEST=LoggingTest.Dcheck
R=akalin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9586010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124676 0039d316-1c4b-4281-b951-d872f2087c98

Added a script to remove comments from the extension api JSON files before
processing for the extension docs. We will now be able to comment in the JSON
files, and they should be much easier to read. Also added the license header
to all the JSON files.

BUG=114233
TEST=Put comments in one of the JSON files and remake the docs. They will make
with no problems.


Review URL: http://codereview.chromium.org/9447090

TBR=cduvall@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9582013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124675 0039d316-1c4b-4281-b951-d872f2087c98

This change attempts to reduce the load time of the file manager (especially on slow Alex devices) by trimming unnecessary work done in javascript and reducing layouts.

- Enable batch updating in cr.ui.Table (exactly how it's done in cr.ui.List).
- Add more 'on complete' callbacks to some of the FileManager infrastructure so we know when to stop batch UI updates.
- Use batch updates for some operations which profiling indicates causes non-trivial amounts of duplicated work.  In particular, in my testing this reduces the number of (sometimes expensive) List.redraw() calls on startup for the table from 6 down to 1, and for the roots list from 4 down to 2.

Measurements on alex are quite variable, but these changes result in about 70ms savings on startup (or about 17% of the time spent under 'v8.callChromeHiddenMethod' - i.e. JS callbacks through the extension system, which itself is about 1/3rd of total load time).

The majority of file manager load time is spent inside of v8, and there are many more opportunities like these to trim various code paths.  But it seems clear that major improvements are going to require more drastic approaches (eg. I'm experimenting with painting the initial UI after parsing/running a small fraction of the JS).

BUG=105181
TEST=


Review URL: http://codereview.chromium.org/9379023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124674 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124673 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9582010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9581007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124671 0039d316-1c4b-4281-b951-d872f2087c98

After this is landed I will remove ui/resources/aura/wallpaper.png in CL 9566044.

BUG=105508
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9567037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124670 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9583001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124669 0039d316-1c4b-4281-b951-d872f2087c98

Each gesture point stores a "point_id," which is used for state transitions in the GestureRecognizer.
The point_ids are maintained such that the set of point_ids is always contiguous, from 0 to the number of current touches.
A lower point_id indicates that a touch occurred first.

BUG=113144
TEST=GestureRecognizerTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123989

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124071

Review URL: http://codereview.chromium.org/9452024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124668 0039d316-1c4b-4281-b951-d872f2087c98

Making the me2me host compiling and running on Windows. This includes making it a window application and converting syslog to EventLog.


Review URL: http://codereview.chromium.org/9567010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9564029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124666 0039d316-1c4b-4281-b951-d872f2087c98

If this isn't a channel message, it will be easier to delay specific unscheduled command buffers rather than delaying the entire channel.

BUG=112349
TEST=


Review URL: http://codereview.chromium.org/9567028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109343
TEST=PanelBrowserTest.ResizePanel


Review URL: http://codereview.chromium.org/9517010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124664 0039d316-1c4b-4281-b951-d872f2087c98

This regression is due to lack of 'type' information of task in task list data from the handler to javascript. This has been caused by http://crrev.com/119052.

BUG=115380
TEST=manual

Review URL: http://codereview.chromium.org/9535008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/9565041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124662 0039d316-1c4b-4281-b951-d872f2087c98

- Make AppListModel flat, i.e. remove AppListItemGroupModel and its view;
- Move BuildAppListModel from ShellDelegate into AppListViewDelegate;
- Make AppListModelBuilder ready to support simple query;
- Make AppListItemView based on CustomButton and get rid of its listener
  interface since we can use ButtonListener for that now;
- Update UI based on M19 mock:
  - AppListItemView show label on its right instead of bottom;
  - AppListItemView has a mouse hover effect now;
  - AppListModelView show AppListItemView tiles alphabetically from top to
    bottom instead of from left to right;
  - AppListView to occupy full screen include area behind the launcher;
  - AppListView to have a 0.4 black shade;

BUG=98308
TEST=Verify applist should look like M19 mock.

Review URL: https://chromiumcodereview.appspot.com/9559005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124661 0039d316-1c4b-4281-b951-d872f2087c98

Added a script to remove comments from the extension api JSON files before
processing for the extension docs. We will now be able to comment in the JSON
files, and they should be much easier to read. Also added the license header
to all the JSON files.

BUG=114233
TEST=Put comments in one of the JSON files and remake the docs. They will make
with no problems.


Review URL: http://codereview.chromium.org/9447090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124660 0039d316-1c4b-4281-b951-d872f2087c98

WillStartRequest.

R=rdsmith@chromium.org
BUG=114853

Review URL: http://codereview.chromium.org/9522006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124659 0039d316-1c4b-4281-b951-d872f2087c98

whose values are determined by others (e.g. APP_NOTIFICATIONS on APPS).
Make the hand-written code use the system, and add {APP,EXTENSION}_SETTINGS.

R=akalin@chromium.org
TBR=estade@chromium.org
BUG=114974
TEST=unit_tests --gtest_filter=*Sync*


Review URL: http://codereview.chromium.org/9500005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124658 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies the code a bit, and makes it possible to handle Stop() more cleanly.

BUG=None
TEST=Existing metrics all continue to work as normal


Review URL: http://codereview.chromium.org/7001003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109817
TEST=unit_tests --gtest_filter=MetricsLogTest.*


Review URL: http://codereview.chromium.org/9559017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:26961
TEST=GDataFileSystemTest.CreateDirectory, GDataFileSystemTest.FindFirstMissingParentDirectory

Review URL: http://codereview.chromium.org/9561009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9572010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9550002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124652 0039d316-1c4b-4281-b951-d872f2087c98