GitLab

Swipe from shelf generally means go to home, which would imply going
back if the home screen is showing search, or non-initial apps page.

BUG=1064739, 1057317

Change-Id: If9bb00a4879d4ec4c9605ac2d472912095ca1091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199182Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768967}

Instead of excluding countries using Finch params, add that list in
client code. See the associated bug for more context.

R=xinghuilu

Fixed: 1064457
Change-Id: Ic4a8d7be4c66ad2b6e3de71186906e48d2ec3462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195647
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768966}

Multiply R, G, B samples by alpha if alpha_option is
kAlphaPremultiplied.

If the frame has an alpha plane, call media::PaintCanvasVideoRenderer
only if the pixel format is I420 (8bpc) and alpha_option is
kAlphaPremultiplied, because that is the only YUV pixel format that
libyuv supports with an alpha plane and media::PaintCanvasVideoRenderer
enables RGB premultiplication by alpha when calling
libyuv::I420AlphaToARGB().

This allows us to enable the AVIF image tests guarded by
FIXME_SUPPORT_10BIT_IMAGE_WITH_ALPHA and
FIXME_SUPPORT_12BIT_IMAGE_WITH_ALPHA.

Bug: 1072134
Change-Id: I47fffcdf2a7421578a02e92c44e40696c5884afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200436Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#768965}

Also adding placeholder js_type_check() targets for the remaining
cr_elements/ Mocha test files.

This is done to facilitate the parallelization of the effort to add JS
type checking for WebUI tests. It makes it easier to see which parts of
the code are not type checked yet.

Bug: 1000989
Change-Id: I5bd77fe43ef43b574d6631633800b25c7cfe0f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199181Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768964}

A tag (struct, class, union or enum) is free-standing if its declaration
is not immediately used as part of a type of a field or variable.  See
also clang::TagDecl::isFreeStanding method.  Example of a
non-free-standing struct:
  struct NonFreeStandingStructCanHaveAName {
    int some_field;
  }* ptr_to_the_non_free_standing_struct;

After this CL, the rewriter will avoid rewriting pointers to
non-free-standing structs, because 1) such structs are relatively rare
and 2) such structs are difficult to rewrite correctly (essentially the
definition of the struct has to be used as a template argument of
CheckedPtr).

Bug: 1069567
Change-Id: Ib571344594795334be90bef5350a467d5841d96d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173575
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768963}

The Metal test shaders are compiled in a function that comes from
a PostTask.  There is currently no path through which a PostTask
will end up running on a ThreadPriority::DISPLAY thread.

Change the Metal test code to create a ThreadPriority::DISPLAY
thread and do its work there. A separate change is making that
correspond to a pthread priority of 50.

Of note is that Metal's callback to Chrome comes from a Metal-created
thread which has priority 31.

Also change the default test shader to be a Compile instead of a
Link (the Link tests have not been completed).

Bug: 974219
Change-Id: Ieb5ab0748b3aa255ee7dd3348870ddf812caa682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200357Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768962}

https://boringssl.googlesource.com/boringssl/+log/a810d82575ecbde26406fa583371f807f8721ed7..78b3337a10a7f7b3495b6cb8140a74e265290898

Bug: none
Change-Id: Ib9538ea7ab2b4660f19f751da1598f01699ccd5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202385
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768961}

https://android.googlesource.com/platform/external/perfetto.git/+log/09d3485a9556..70e7f5841429

git log 09d3485a9556..70e7f5841429 --date=short --first-parent --format='%ad %ae %s'
2020-05-14 primiano@google.com Merge "UI: Fix time bounds capping of updateLocalTime()"

Created with:
  gclient setdep -r src/third_party/perfetto@70e7f5841429

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ieba765d975da900bc3cf85ced958478ac809fb03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202480Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768960}

DisplayDamageTracker waits for all clients to respond if BeginFrame was
dispatched to them in a vsync. If we're throttling the BeginFrame for
any reason, ensure we also don't expect damage from the client for that
vsync.

R=sadrul@chromium.org

Change-Id: I3419abbfd2fd99ef113c03c5ad6cd75ee887ba17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200083
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768959}

Bug: 1082886
Change-Id: Ic40a94010622efa41a04a9a2524cdd5106945220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202427
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768958}

With this change, the value of a specific field type can only be
filled a limited number of times into a specific form.

Bug: 1075734
Change-Id: I7af1535d4877a4847ab84a5c11c70a1be35647a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172299
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Auto-Submit: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#768957}

In chrome new tab landing page, there are some
iframes which navigate to useful urls. These urls
are prevented from loading which causes a mismatch
between expectation.

This cl solves the problem by avoiding throttling
blocking subframes in per app time limits.

Bug: 1076194
Change-Id: I236fc914adca2709312978dac3c3be743b61909c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200377
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768956}

No change to production logic.

This simplifies Service-related tests by adding ServiceConnectionHelper.
This can be used in a try-with-resources pattern to temporarily bind to
a Service, and automatically unbind when you're done.

The main benefit is this moves assertions out of the
onServiceConnected() callback, putting them back on the test thread (see
http://go/no-asserts-on-main-thread). This also simplifies test logic by
removing the need for helper methods and coordinating binding/unbinding
across different helper method calls.

Fixed: 1082017
Test: run_webview_instrumentation_test_apk -f MetricsBridgeServiceTest.*
Test: run_webview_instrumentation_test_apk -f VariationsSeedServerTest.*
Change-Id: I6b87206c17fbbf1da845f3bb5dbec495e15eabf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197201Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768955}

This reverts commit eb95adf5.

Reason for revert: Flaky test fixed.

Original change's description:
> Revert "Reland "Persist Reader Mode theme and font family settings on desktop.""
> 
> This reverts commit d1173dbd.
> 
> Reason for revert: DomDistillerViewerSourceBrowserTest.UISetsPrefs flaky
> 
> Original change's description:
> > Reland "Persist Reader Mode theme and font family settings on desktop."
> > 
> > This reverts commit 23979013, which
> > reverted an earlier implementation of this CL in commit
> > a18fd063 due to
> > https://crbug.com/1065341.
> > 
> > The main functional difference between this and the original version is
> > where the JavaScript code calls the pref-storing functions. They were
> > previously called inside useTheme() and useFontFamily() instead of the
> > UI callbacks. Changes to the synced prefs result in a series of
> > observers being notified, which ultimately led to the useTheme() and
> > useFontFamily() methods being called again, potentially leading to an
> > infinite loop and the behavior seen in the bug.
> > 
> > The updateThemeSelection() method from the original CL was excluded in
> > this reimplementation because it was unintentionally never called in the
> > original CL. Omitting it helps reduce the scope of the CL and highlight
> > the important changes.
> > 
> > Bug: 1016615, 1065341
> > Change-Id: Ifd0e71027afd196267419ed81f7bdc0d78978a98
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152901
> > Reviewed-by: Emily Stark <estark@chromium.org>
> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Commit-Queue: Aran Gilman <gilmanmh@google.com>
> > Cr-Commit-Position: refs/heads/master@{#762524}
> 
> TBR=dmazzoni@chromium.org,estark@chromium.org,wychen@chromium.org,gilmanmh@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1016615, 1065341, 1075439
> Change-Id: I222e95940848b68fa8158fd64aaca76048ed96db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167751
> Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
> Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#762756}

TBR=dmazzoni@chromium.org,estark@chromium.org,wychen@chromium.org,hendrich@chromium.org,gilmanmh@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1016615, 1065341, 1075439
Change-Id: Id1033620710d17d45c2df85a126b44a1f226e8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170422Reviewed-by: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#768954}

1. Mismatch between computed and used style of transform-style CSS.
2. Additional grouping (flattening) properties.

Bug: 1008483

Change-Id: I06d8940bca56a4843b2389dece057095565d68ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202379Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768953}

This flag was added to keep the line cache code until we
refactor to share more logic with simplified layout. The
new line cache landed at r768067 <crrev.com/c/2185249>.

Existing tests for old line cache were ported to the new
line cache in <crrev.com/c/2198867> and <crrev.com/c/2198704>.

Bug: 982194
Change-Id: I2de77a91f77b063a5c3cff7bb44d5904dd2b4685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198852
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768952}

Android needs to pass its native unwinder into StackSamplingProfiler
since it is provided out of band, wihin a dynamic feature module, and
not built into the profiler.

Bug: 1004855
Change-Id: I9a1471d0deb09a8555ce641fdcef743aa2c56373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202319Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768951}

Platform side dlcservice daemon will be up prior to Chrome's
initialization of DBus clients. Registering the signal exposed by
dlcservice should happen immediately on Chrome side's initialization of
dlcservice client.

BUG=chromium:1071656
TEST=./unit_tests

Change-Id: If2aa6dbececf155f91aa0014a904aef21ea6acba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199923
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jae Hoon Kim <kimjae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768950}

In the next cls, I added a new story tag SimpleCanvas and I moved tests
from blink/perf_tests/canvas to perf/page_set/rendering. So that canvas
perf tests can be ran with rendering benchmark.

Bug: 1077148

Change-Id: I55372610a2816a554946ecc77d530b1a5981d787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175497
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768949}

- Launching the app is behind a feature flag.

Screenshot of changes: https://screenshot.googleplex.com/oaYDOJUKfNt

Bug: 1053704
Change-Id: I54e764e846e0fda7671908f24f732e83de14cfea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194855
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768948}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: If5f9943bf33226dec8429d559c2d62375fe8c41b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202483Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768947}

Bug: 1021566
Change-Id: If73c54ea7a480c5c83566c5b1290b04c6ecce0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190836Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768946}

We want to measure performance of production build, not DCHECKs.

TBR=jmadill

Bug: angleproject:4637
Change-Id: I259af0944bbaf21b1a26b976865bce09397176d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202676Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768945}

If we had an empty linebox with a float inside it (and the float was
shifted due to other floats) it was possible for that linebox to fail
the DCHECK in:
ng_block_layout_algorithm.cc:1584
DCHECK(!normal_child_had_clearance || !is_self_collapsing);

Both of these conditions were true.

This patch changes the normal_child_had_clearance variable to only be
true if it was a *block* child (not inline), pushed by floats.

Bug: 1064987
Change-Id: Ie326437a637cc57d1b17f91ac5e49847fd13c983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137377
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768944}

This delays creation of the WebLayer class loader until it is actually
needed, which saves a couple MB of memory until WebLayer is used.

Bug: 1061512
Change-Id: I2e0d3fb47ce79be0d7d4eac2421a5c7dc3487a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202660Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768943}

This change was generated with:
  find . -type f | xargs sed -i -e 's/\bDialogDelegate:://g'
followed by some manual cleanup.

Bug: None
Change-Id: I042650c53bfd7e1d7fbab4cd963dced5a7a7aaab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202141
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768942}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bd950196d58a..2c3d0672ade4


Created with:
  gclient setdep -r src-internal@2c3d0672ade4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC rogerta@google.com,dfried@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: rogerta@google.com,dfried@google.com
Change-Id: Iecb0ca2b8891f02eac27f308c1e0845501b50eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202003Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768941}

This is in preparation for moving EG2 to CQ. These two form factors run
in ios-simulator but not on any builder running EG2 tests. Adding these
to catch any issue before moving EG2 to CQ.

Bug: 1079456
Change-Id: I7a59250c87f9da7a76c74886fc39d3e6b15acc3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186999
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768940}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/90c7477737b9..8e272a6a2895

git log 90c7477737b9..8e272a6a2895 --date=short --first-parent --format='%ad %ae %s'
2020-05-14 tmathmeyer@chromium.org Don't word wrap long lines for titles and other properties.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@8e272a6a2895

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1080571
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie959db328aa2cce9d9860eecafe56646a0e14439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202479Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768939}

Bug: 1069567
Change-Id: I0cd32b0a49c81efb02e862155aab6bf3d79d1c49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197146
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768938}

This change makes the function name more specific
for the web app installation dialog.

Change-Id: Ia09e1d5bbd26ba24f2baaeb1c95bbb6feaba1592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202497Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768937}

Test: Manual (added a dummy experiment to the shell and verified it was
Test: set).
Bug: 1066554
Change-Id: Idcb984615431693ed8277228d36a9f49f07339ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201766Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768936}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9963e1930e93..25881af541ec

git log 9963e1930e93..25881af541ec --date=short --first-parent --format='%ad %ae %s'
2020-05-14 cjmcdonald@chromium.org uprev_lib: Add richer return type to UprevChromeManager.uprev
2020-05-14 saklein@chromium.org commands.py: Disable eclean for factory install image.
2020-05-14 cjmcdonald@chromium.org pytest: Skip 'inside_only' tests when run with --no-chroot
2020-05-14 engeg@google.com cbuildbot: stop retrying builds
2020-05-14 shaochuan@chromium.org cros_mark_android_as_stable: verbose buildbot logging
2020-05-14 bpastene@chromium.org cros_chrome_sdk: Remove old items from the cache at every invocation.
2020-05-14 vapier@chromium.org chroot_lib: convert to python3 only
2020-05-14 vapier@chromium.org cros_sdk_lib: convert to python3 only
2020-05-14 vapier@chromium.org build_failure_message: convert to python3 only
2020-05-14 vapier@chromium.org build_summary: convert to python3 only
2020-05-14 vapier@chromium.org cidb/factory: convert to python3 only
2020-05-14 mmortensen@google.com Add GetBuildMetadata firmware/ec_firmware values and service method.
2020-05-13 henrysun@google.com octopus: shut down 11297.83 firmware branch builder
2020-05-13 inglorion@chromium.org cros_chrome_sdk: Enable use_goma_thin_lto when using Goma and ThinLTO
2020-05-13 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@25881af541ec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: Icdd2ca57da0435c8447a87ce1bf47f36e293161f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201998Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768935}

This is a reland of b7c7185e

TBR=avi

Original change's description:
> Move InsertStyleSheet out of TestRunnerForSpecificView
>
> R=avi@chromium.org
>
> Bug: 866140
> Change-Id: I4684093db40f628b273c343352a74118830df824
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202157
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#768829}

Bug: 866140
Change-Id: Icc9772b1380a0ecccafa992baa08e81f798cae0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202619Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768934}

Generated by //tools/gn/roll_gn.py

https://gn.googlesource.com/gn/+log/5ed3c9cc..ab32747a

    ab32747a Make rebase_path("//foo", "//foo/bar/baz") return "../..".
    ac6cc95f Allow rlib linking into C++ targets.
    07f614a8 Cease to specify extern dirs for proc macro deps.
    f8c5cf1d Fixing Rust targets depending on C source sets.
    6523a5f8 Add script for finding unreachable targets
    207400ce build/gen.py: Add --link-lib=LINK_LIB option.
    16ab9cab Make "gn clean out/gn*" work.
    6ed85ec5 Speedup --json=ide and --export-compile-commands=default
    7c5d1002 Speed up generation of input files list.
    14c9f946 Fix GCC compilation error
    edf6e8e2 Add StringOutputBuffer class.
    d2e84de8 Forbid Rust source_sets.
    4cd7fe15 Avoid duplicating -Lnative rustc arguments.
    4580b415 Remove duplicated -Ldependency arguments to rustc.
    58af66ba Remove minor compiler warning
    222ae505 rust-project.json support
    56f058e1 Add support for Resources build phase to generated Xcode project
    0695796d Modernize code in xcode_object.{h,cc}
    6a6163c8 Fix formatting of PBXFileReference
    3f916fba Set expected values by Xcode 11.4
    d7a8d663 Fix formatting of PBXContainerItemProxy
    e858fe6f Sort test file references used for indexing XCUITest test cases
    106738e2 Add filetypes for .xctest and .xpc files
    2ca0e81b Fix formatting of COMPILER_FLAGS in generated project
    ec938dda Speed up label comparison
    d6131075 format: Don't crash on non-literal import
    a38ba1c8 README.md: Correct link to Quick Start guide
    82d673ac format: Fix formatting not taking into account suffixes
    5b7fa2a7 Fix incorrect line endings in win_util.h

Bug: none
Change-Id: I3b58ada2b8c92870e7ccce2dcf9f99014e3848b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202658
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768933}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/30ef5cb43761..053213d049fa

git log 30ef5cb43761..053213d049fa --date=short --first-parent --format='%ad %ae %s'
2020-05-14 demorri@microsoft.com Add a pan-project presubmit check for commits in tree

Created with:
  gclient setdep -r src/third_party/depot_tools@053213d049fa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:869594
Tbr: agable@chromium.org
Change-Id: Ibe6fb761006f232dbf04b85106af49536e13f5f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202478Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768932}

TBR=govind@chromium.org

Change-Id: I5a3c5446f8c1d225005605776f25880336518ba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202519Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768931}

The avoided conversion breaks compilation of string-literal based global
initialization like the example below:

    struct MyStruct {
      int foo;
      CheckedPtr<const char> bar;
    }
    MyStruct g_foo = {
        123,
        // Invokes CheckedPtr<char>'s constructor:
        "string literal"
    };

Bug: 1069567
Change-Id: I897a1fad9222b904ea6f70fd23bc508d253ff97d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161146
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768930}

Before: https://screenshot.googleplex.com/2ougwchZvqU
After: https://screenshot.googleplex.com/Xq9nNPQQaQA

Fixed: 1081984
Change-Id: Ie7124973ade76e81f8a1559ca28e335347034a7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200417Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768929}

crrev.com/c/2199891 introduces a reusable class for pointer
interactions for non-button views. This class internally handles
all the delegate callbacks. So usage is simplified to a single line.

This CL should have no impact/change on the UI.

Bug: 1073961
Change-Id: I219588b8354fc199d3e38f659c82010c001946fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199707Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768928}