GitLab

Review URL: https://codereview.chromium.org/492423002

Cr-Commit-Position: refs/heads/master@{#291813}

instread of QuicClientSession's constructor to make it easier for server
side code to do the same.

Call QuicClientSessionBase::InitializeSession() after constructing
QuicCryptoClientStream.

This is done per discussion in interal change: 72671781

The following are the earlier related issues:
  https://codereview.chromium.org/393953009/
  https://codereview.chromium.org/407193002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/481103003

Cr-Commit-Position: refs/heads/master@{#291812}

We've recevied feedback that conflating maximized and full-screen is not what
users expect. This CL builds on https://codereview.chromium.org/498813003/ to
remove this functionality and instead add an explicit full-screen button to
the window frame.

Note that the icon is a placeholder until we can get UX resources to design a
better one.

BUG=404693

Review URL: https://codereview.chromium.org/491873004

Cr-Commit-Position: refs/heads/master@{#291811}

Review URL: https://codereview.chromium.org/494993005

Cr-Commit-Position: refs/heads/master@{#291810}

BUG=407396
NOTRY=true
TBR=ager@chromium.org
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/502233002

Cr-Commit-Position: refs/heads/master@{#291809}

Revert "Move core web_view code to extensions." (patchset #6 of https://codereview.chromium.org/496873006/)

This reverts commit 63bf863b.

This breaks the app_shell build for the reasons jamesr describes (src/extensions now depends on generated headers from src/chrome, but there cannot be a dependency from extensions -> chrome).

Hypothetical repro on Linux:
* rm -rf out/* && gclient runhooks && ninja -C out/Debug -j 1000 app_shell

chrome/browser/extensions/api/capture_web_contents_function.h:9:10: fatal error: 'chrome/common/extensions/api/types.h' file not found

Original issue's description:
> Move core web_view code to extensions.
>
>
> BUG=352290
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1218a23163baab9f53d70e9a63030db13ef04d04

TBR=fsamuel@chromium.org,yoz@chromium.org,kalman@chromium.org,sky@chromium.org,dmazzoni@chromium.org,jamesr@chromium.org,hanxi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=352290

Review URL: https://codereview.chromium.org/502273002

Cr-Commit-Position: refs/heads/master@{#291808}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/500123003

Cr-Commit-Position: refs/heads/master@{#291807}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/467303005

Cr-Commit-Position: refs/heads/master@{#291806}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/500243002

Cr-Commit-Position: refs/heads/master@{#291805}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/503903002

Cr-Commit-Position: refs/heads/master@{#291804}

The previous code removed symbols from clang builds based on what GYP used to
do. But GYP changed this logic when clang was set to the default. GN was then
left with clang on by default, but no symbols.

This adds some additional GYP flag parity work.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/501173002

Cr-Commit-Position: refs/heads/master@{#291803}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/501183003

Cr-Commit-Position: refs/heads/master@{#291802}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503163002

Cr-Commit-Position: refs/heads/master@{#291801}

Revert of Exclude OutOfProcessPPAPITest.Instance_LeakedObjectDestructors. (patchset #1 of https://codereview.chromium.org/500273002/)

Reason for revert:
Unnecessary after the revert in https://codereview.chromium.org/502143003/.

Original issue's description:
> Exclude OutOfProcessPPAPITest.Instance_LeakedObjectDestructors.
>
> It caused a use-after-free in DrMemory.
>
> BUG=407372
> NOTRY=true
> TBR=raymes@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4121155aeb26a6e04a002c62d5b157c6c922fe88

TBR=raymes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407372

Review URL: https://codereview.chromium.org/472463004

Cr-Commit-Position: refs/heads/master@{#291800}

retry info map, even if all data reduction proxies are bypassed. Therefore,
to check if all data reduction proxies are bypassed,
consider two cases:

!fallback_allowed: if the primary is on the map, we consider all data reduction
proxies to be bypassed.

fallback_allowed: if (at least) the fallback is on the map, we consider all
data reduction proxies to be bypassed.
We still see if the primary is in the map to check if it has the min_retry_delay.

BUG=401281

Review URL: https://codereview.chromium.org/464023002

Cr-Commit-Position: refs/heads/master@{#291799}

TBR=vrk@chromium.org
BUG=404767
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/503183002

Cr-Commit-Position: refs/heads/master@{#291798}

It's flaky per bug.

BUG=407409
TBR=amistry@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/501003003

Cr-Commit-Position: refs/heads/master@{#291797}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/478053003

Cr-Commit-Position: refs/heads/master@{#291796}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/504953003

Cr-Commit-Position: refs/heads/master@{#291795}

Memory test failure: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/33712

Error message:
Suppression (error hash=#07239B8B18CB7B1B#):
For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Uninitialized
fun:_ZN8keyboard21KeyboardLayoutManager14SetChildBoundsEPN4aura6WindowERKN3gfx4RectE
fun:_ZN4aura6Window9SetBoundsERKN3gfx4RectE
fun:_ZN3ash4test71VirtualKeyboardRootWindowControllerTest_ClickWithActiveModalDialog_Test8TestBodyEv
}

TBR=jyasskin
BUG=NONE

Review URL: https://codereview.chromium.org/480723006

Cr-Commit-Position: refs/heads/master@{#291794}

BUG=400472

Review URL: https://codereview.chromium.org/500623002

Cr-Commit-Position: refs/heads/master@{#291793}

Database enumeration was decoding id as VarInt, but it's a plain Int.

R=cmumford@chromium.org
BUG=407015

Review URL: https://codereview.chromium.org/503913002

Cr-Commit-Position: refs/heads/master@{#291792}

BUG=407204
TEST=installer_util_unittests
TEST=install x64 stable.  Check chrome://chrome shows 'm' and not 'unknown-m'.

Review URL: https://codereview.chromium.org/467303004

Cr-Commit-Position: refs/heads/master@{#291791}

in ExtensionActionAPI. This also cleans up
ExtensionToolbarModel and PageActionController, since they
had too much knowledge about how to execute these actions.
We also get to consolidate code in views, since now executing
page and browser actions has a single API.

Woohoo for -100 lines of code!

BUG=406447

Review URL: https://codereview.chromium.org/496863003

Cr-Commit-Position: refs/heads/master@{#291790}

BUG=401180

Review URL: https://codereview.chromium.org/499363003

Cr-Commit-Position: refs/heads/master@{#291789}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503113004

Cr-Commit-Position: refs/heads/master@{#291788}

BUG=401542
TEST=none
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/466223008

Cr-Commit-Position: refs/heads/master@{#291787}

Review URL: https://codereview.chromium.org/487233004

Cr-Commit-Position: refs/heads/master@{#291786}

Occlusion tracker converts Rects to QuadF, then does MapClippedQuad,
then BoundingBox(), then ToEnclosedRect(). Instead, add methods to
MathUtil that mirror the {Map,Project}EnclosingClippedRect
methods but for an enclosed rect instead, that work only when the
transform preserves 2d axis alignment.

In the common case, this avoids converting the integers to floats just
to convert back to ints using the costly safe conversion methods.

R=enne

Review URL: https://codereview.chromium.org/495873002

Cr-Commit-Position: refs/heads/master@{#291785}

Revert "Revert of Replace StreamListenSocket with StreamSocket in HttpServer. (patchset #29 of https://codereview.chromium.org/296053012/)"

This reverts commit 0b2f33f4.

This is relanding CL of https://codereview.chromium.org/296053012/, which broke http server unittests because http server doesn't send response synchronously any more.
This CL fixes unittests by reading responses completely.

Patch set #1 is same to the original CL.
Patch set #2 is the diff.

BUG=371906
TBR=pfeldman@chromium.org,darin@chromium.org,gunsch@chromium.org,mnaganov@chromium.org

Review URL: https://codereview.chromium.org/487013003

Cr-Commit-Position: refs/heads/master@{#291784}

The LTHI always notifies the scheduler of context loss.
The single thread proxy no longer asks LTHI if the
context is lost.  In-flight composite actions just go
ahead and draw.

BUG=402511

Review URL: https://codereview.chromium.org/505713004

Cr-Commit-Position: refs/heads/master@{#291783}

BUG=374990
TEST=manual

Review URL: https://codereview.chromium.org/390443006

Cr-Commit-Position: refs/heads/master@{#291782}

BUG=304341
TEST=popup menus still work

Review URL: https://codereview.chromium.org/501583003

Cr-Commit-Position: refs/heads/master@{#291781}

Revert of Minor changes to allow Pepper InstancePrivate tests to pass with gin (patchset #3 of https://codereview.chromium.org/472693002/)

Reason for revert:
Caused failures in DrMemory:

UNADDRESSABLE ACCESS of freed memory: writing 0x031c0278-0x031c0279 1 byte(s)
# 0 ppapi_tests.dll!`anonymous namespace'::InstanceSO::~InstanceSO             [ppapi\tests\test_instance_deprecated.cc:48]
# 1 ppapi_tests.dll!`anonymous namespace'::InstanceSO::`scalar deleting destructor'
# 2 ppapi_tests.dll!pp::deprecated::`anonymous namespace'::Deallocate          [ppapi\cpp\dev\scriptable_object_deprecated.cc:126]
# 3 ppapi_proxy.dll!ppapi::CallWhileUnlocked<>                                 [ppapi\shared_impl\proxy_lock.h:123]
# 4 ppapi_proxy.dll!ppapi::proxy::PluginVarTracker::DidDeleteInstance          [ppapi\proxy\plugin_var_tracker.cc:281]
# 5 ppapi_proxy.dll!ppapi::proxy::PPP_Instance_Proxy::OnPluginMsgDidDestroy    [ppapi\proxy\ppp_instance_proxy.cc:194]
# 6 ppapi_proxy.dll!PpapiMsg_PPPInstance_DidDestroy::Dispatch<>                [ppapi\proxy\ppapi_messages.h:670]
# 7 ppapi_proxy.dll!ppapi::proxy::PPP_Instance_Proxy::OnMessageReceived        [ppapi\proxy\ppp_instance_proxy.cc:143]
# 8 ppapi_proxy.dll!ppapi::proxy::Dispatcher::OnMessageReceived                [ppapi\proxy\dispatcher.cc:69]
# 9 ppapi_proxy.dll!ppapi::proxy::PluginDispatcher::OnMessageReceived          [ppapi\proxy\plugin_dispatcher.cc:238]
#10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage                      [ipc\ipc_channel_proxy.cc:273]
#11 ipc.dll!base::internal::Invoker<>::Run                                     [base\bind_internal.h:1253]
#12 base.dll!base::debug::TaskAnnotator::RunTask                               [base\debug\task_annotator.cc:62]
#13 base.dll!base::MessageLoop::RunTask                                        [base\message_loop\message_loop.cc:436]
#14 base.dll!base::MessageLoop::DeferOrRunPendingTask                          [base\message_loop\message_loop.cc:445]
#15 base.dll!base::MessageLoop::DoWork                                         [base\message_loop\message_loop.cc:552]
#16 base.dll!base::MessagePumpDefault::Run                                     [base\message_loop\message_pump_default.cc:32]
#17 base.dll!base::MessageLoop::RunHandler                                     [base\message_loop\message_loop.cc:408]
#18 content.dll!content::PpapiPluginMain                                       [content\ppapi_plugin\ppapi_plugin_main.cc:141]
#19 content.dll!content::RunNamedProcessTypeMain                               [content\app\content_main_runner.cc:415]
#20 content.dll!content::ContentMainRunnerImpl::Run                            [content\app\content_main_runner.cc:764]
#21 content.dll!content::ContentMain                                           [content\app\content_main.cc:19]
#22 content::LaunchTests                                                       [content\public\test\test_launcher.cc:475]
#23 main                                                                       [content\test\content_test_launcher.cc:123]

First appeared in http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%29/builds/631/steps/memory%20test%3A%20content_browsertests/logs/stdio.

Original issue's description:
> Minor changes to allow Pepper InstancePrivate tests to pass with gin
>
> This includes some minor changes which allow tests to when NPObject is replaced
> by gin in pepper:
> -Add shared library exports for use of PepperTryCatch and ScopedPPVarArray in
> tests.
> -Add gin as a dependency to content_unittests for use in host_var_tracker_unittest
> -Change TestInstanceDeprecated so that it doesn't execute a script from the
> ScriptableObject upon destruction. The reason for this is that the garbage
> collector is manually run from the destructor of the plugin Instance object.
> This results in destruction of the ScriptableObject and then javascript is
> re-entered via ExecuteScript. This should never happen outside tests because
> the garbage collector won't be run synchronously. Instead of running
> ExecuteScript, which just set a variable in the Instance object to verify
> that the ScriptableObject was correctly destroyed.
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/92c3074f4b4417924115f880657f1ec15da0e0ba

TBR=dmichael@chromium.org,raymes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351636,407372

Review URL: https://codereview.chromium.org/502143003

Cr-Commit-Position: refs/heads/master@{#291780}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/503873003

Cr-Commit-Position: refs/heads/master@{#291779}

Revert of Stop all PeerConnections upon suspend from Blink side (patchset #3 of https://codereview.chromium.org/475263002/)

Reason for revert:
Causing browser crashes due to race, BUG=404767.

Original issue's description:
> Stop all PeerConnections upon suspend from Blink side
>
> BUG=403618
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291213

TBR=jiayl@chromium.org,vrk@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403618

Review URL: https://codereview.chromium.org/482443003

Cr-Commit-Position: refs/heads/master@{#291778}

BUG=406580
TEST=None

Review URL: https://codereview.chromium.org/501143003

Cr-Commit-Position: refs/heads/master@{#291777}

This change moves all the encrypted media code out of WebMediaPlayerImpl
and into a EncryptedMediaSupportImpl class. This removes the encrypted
media related content/ depencencies from WebMediaPlayerImpl so that it
will be easier to move WebMediaPlayerImpl to a location where it can
be reused by Mojo.

Review URL: https://codereview.chromium.org/501473003

Cr-Commit-Position: refs/heads/master@{#291776}

It caused a use-after-free in DrMemory.

BUG=407372
NOTRY=true
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/500273002

Cr-Commit-Position: refs/heads/master@{#291775}

NOTRY=true

Review URL: https://codereview.chromium.org/491243003

Cr-Commit-Position: refs/heads/master@{#291774}