- 22 Feb, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/113e5df9..07cf1f5a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id69fd5bf75b1cfb0c087c58c4b81b1796ea7d23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069164Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743788}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe1df04b. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5f3cb8bb498e9cda27ff497752f0658291a01dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069162Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743787}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/165da89015c7..adf008a9f500 git log 165da89015c7..adf008a9f500 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@adf008a9f500 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6894313889454cdc161af8c8443745d6ecb18b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743786}
-
Findit authored
This reverts commit eed7024d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 743767 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWVkNzAyNGRlMmQ5MDNkYzU0ZjAwMzgwYzMyMWQwMTA0YmU2NmUyNAw Sample Failed Build: https://ci.chromium.org/b/8887789665458415472 Sample Failed Step: browser_tests Sample Flaky Test: LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable Original change's description: > Add support for loading predictor to use hints from optimization guide > > Will add metrics in a subsequent CL. This shouldn't affect any current > metrics since the support is all behind a feature flag. > > Bug: 1050101 > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743767} Change-Id: Ie30a3a73e89bace0febe11c558d7be4c83501936 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069258 Cr-Commit-Position: refs/heads/master@{#743785}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eacec98a3499..a741abb98362 git log eacec98a3499..a741abb98362 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 jmadill@chromium.org Vulkan: Rename CommandGraphResource to Resource. 2020-02-21 spang@chromium.org Reformat GN files Created with: gclient setdep -r src/third_party/angle@a741abb98362 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I108cb534975d8c13a271bac30f30eeb074b04ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067747Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ebfcd52ceee..7f19b54d3263 Created with: gclient setdep -r src-internal@7f19b54d3263 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5e5f155e5b91702fcf6ef0489b67457e50bec17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743783}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88fd132a05e8..165da89015c7 git log 88fd132a05e8..165da89015c7 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@165da89015c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9a6119241875e909bae019e6d26661e55e199ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067752Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4db453d6..113e5df9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic05aacb55288fde57a0baa716026ef0976a379bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069160Reviewed-by:
-
Tom Anderson authored
This CL makes AutofillPopupFooterView respond to theme changes. Previously, the separator color was only initialized on creation, when the NativeTheme has not yet been set. R=pkasting Change-Id: I9bb8a511beca58e4d6f1d40a1f832bce922b6431 Bug: 914974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063892 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743780}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I3b6e9988007429a5d708678312c89822348b005e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068311Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743779}
-
Xiaohan Wang authored
Use logging::SystemErrorCodeToString to pretty print failed HRESULTs. For example, for E_FAIL in Foo function, the message looks like: Foo: failed with "Unspecified error (0x80004005)" Change-Id: I28426b0447f8cdd0ea21768c93208cf637992a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068921Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743778}
-
Xiaohan Wang authored
This is a one-off namespace that's only used in mf_helpers.h. Remove it to be consistent with other media code. Change-Id: I08478a3bf644fbbf695b5fb0b6d6e92a5c4fb29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068306 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
Instead, use media/base/win/mf_helpers.h. Change-Id: Ia3c018928e6c1aab0357ace07c87dcc8d30a2126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068719 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If33551dc0da7dceed44d99b9ead7f2e353c507e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067753Reviewed-by:
-
Kazuki Takise authored
This CL handles another edge case for the snap fraction logic. The issue is, at the end of drag-moving PIP, if the resting position is not along any of the edges of the movement area because, for example, the PIP window is snapped to some system UI (hotseat, system tray, etc). This CL ensures to forcefully adjust the PIP bounds to the movement area without considering other obstacles. BUG=b:149889040 TEST=Drag move the PIP window along some system UI and confirmed TEST=the PIP window didn't jump to the left screen edge. Change-Id: I67457d0708d79c6ce6c9a243eb11e3f90965468b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065695 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743774}
-
Kazuki Takise authored
BUG=b:149889710 TEST=Manually confirmed swipe to dismiss works Change-Id: I62cbe45ca855a0a485fad4c1dedeb893865c92fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064232 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e6832de5af7..1a85d581c934 git log 0e6832de5af7..1a85d581c934 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-22 nifong@google.com Expose 4x4 matrices on canvas in a way similar to SimpleMatrix, add example. Created with: gclient setdep -r src/third_party/skia@1a85d581c934 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I5a5cef43b49c9ba216b3c4478a8f0fa3febb314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067746Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c588f36ff15c..5ca404665a4c git log c588f36ff15c..5ca404665a4c --date=short --first-parent --format='%ad %ae %s' 2020-02-22 chriswailes@google.com Merge "Added additional metrics to android_startup" Created with: gclient setdep -r src/third_party/perfetto@5ca404665a4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I962bc7b0b9474bacd57430c9863b58ecfac7c0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068976Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de47ef6c..4db453d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I17902f4b9b1e4b7968e2da64a63f78736d1906c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067979Reviewed-by:
-
Sadrul Habib Chowdhury authored
We already have checks in place to prevent underflows. So remove the explicit check that was introduced to check other underflows, but it is tripping tests for valid sequences. So remove the DCHECK. We also report the length of the sequences in UMA, and according to the data, the lengths are: 50%ile: < 20 99%ile: < 500 99.5%ile: < 800 So underflows are not a concern at the moment. BUG=1052790 Change-Id: Ia87b3fae331b01c483468887894f16364938a624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068894 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743769}
-
Theresa Wellington authored
Set Android.MultiWindowMode.Active to expire never since this is a topline metric for monitoring multi-window mode usage on Chrome for Android. BUG=1052895 Change-Id: I8d83c27687f4a153e10b1fdc1a1f8a3b8a9c78a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064628Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#743768}
-
Sophie Chang authored
Will add metrics in a subsequent CL. This shouldn't affect any current metrics since the support is all behind a feature flag. Bug: 1050101 Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#743767}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0676630ddb0..4ebfcd52ceee Created with: gclient setdep -r src-internal@4ebfcd52ceee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I51fe9f257013b926b2123c1d8c22d1fa234d5a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068973Reviewed-by:
-
Alexis Savery authored
Add another year to the expiration date for: Platform.ZramIncompressiblePages Platform.ZramIncompressibleRatioPercent.PostCompression Platform.ZramIncompressibleRatioPercent.PreCompression These are used by the storage team to monitor the amount of pages in zram that are incompressible. If the number of incompressible pages becomes significant then we should reevaluate how we deal with them and consider enabling the zram backing device. Bug: chromium:1046011 Test: ran validate_format.py Change-Id: I90fb9790ab6e2b74a2a5ceed5ee51ccc2a283412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063332 Commit-Queue: Alexis Savery <asavery@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#743765}
-
Xiaohan Wang authored
It reports file line numbers to UMA which is really not that useful. By removing this function, we can use the default macro in mf_helpers.h. Tbr: isherman@chromium.org Change-Id: Ie682c6946410b2dd953fcd8b6e0d0ca7280e1561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068652Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings users page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I287dbd4b650ce7a4c5ddab1eb8f212763155b99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067665 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#743763}
-
Annie Sullivan authored
Bug: 1049160 Change-Id: I610c04194d86fee56162a0f2f430cbabb243abe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067668Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743762}
-
Alexis Savery authored
Add another year to the expiration date for Platform.StatefulLifetimeWrites This is used by the storage team to track the stateful lifetime writes to help determine storage needs. Bug: chromium:1045993 Test: ran validate_format.py Change-Id: Iff886c1f11d41fc9eaaa914baf0ac6e1acbb721e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063335 Commit-Queue: Alexis Savery <asavery@chromium.org> Reviewed-by:
-
Matthew Porter authored
Currently, clicking in an editable field with a pen does not invoke the virtual keyboard as is expected per Microsoft standards described here https://support.microsoft.com/en-us/help/4057757/windows-10-get-to-know-the-touch-keyboard This change adds pen clicks as a triggerable event for the virtual keyboard on Windows Bug: 1020448 Change-Id: I965d87af56759596f37424e1fdd1fd63032fd25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029193 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743760}
-
Yuly Novikov authored
TBR=kbr Bug: 1007018 Change-Id: I3bb61ce35bce1e980aac44de6c557bd55316ee98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895961Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#743759}
-
Junyi Qiu authored
Currently Page.navigate() supports setting the referrer, but not referrer-policy. It always uses the default referrer-policy. Some clients want set a specific non-default `referrer-policy` along with the URL set in referrer field. BUG=b/149020493 R=alexmos@chromium.org, caseq@chromium.org, zoeclifford@chromium.org Change-Id: I90be78f26e1cd1b05517fa3ba93771a545044886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053170 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#743758}
-
Robin Lewis authored
Bug: 1054976 Change-Id: I1fdb624c49f7901186b552f835a77b88b1e6ee76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068919 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#743757}
-
Kazuki Takise authored
Currently, pressing the home button in splitview in tablet mode causes unwanted maximized events for snapped windows. In TabletModeWindowManager#OnOverviewModeEndingAnimationComplete(), we intend to prevent this from happening by checking the snapped windows. However, in HomeScreenController#GoHome(), EndSplitView() is called before EndOverview(). As EndSplitView() remove the snapped windows from the the splitview controller, when EndOverview() is called, the above logic to prevent them from being maximized is not working. We can just fix this by killing overview before finishing splitview. BUG=b:149315216 TEST=Manually confirmed pressing the home button in splitview in TEST=tablet mode didn't cause unwanted maximized events. Change-Id: I5ba411fca03f9c63afc7ae3084eb08473e562b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067840Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Adam Langley authored
Noise internals will be used by both sides of the caBLE v2 handshake and so can usefully be split out. BUG=1002262 Change-Id: Ib28bbb1a51d34cd7aaa65b49bf8a988e263e3690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065422Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#743755}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I8d770ebb90a2e63454e85071c06e173cd745c0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068949Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743754}
-
Daniel Rubery authored
This CL adds a helper class SafeBrowsingTokenFetcher which thinly wraps signin::AccessTokenFetcher to fetch OAuth tokens for for Safe Browsing communications Bug: 1051679, 1041912 Change-Id: Ibbe8af3bbb1c2c77130e5b86308574ad9b843320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057738 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743753}
-
Robin Lewis authored
Bug: 1054984 Change-Id: I0202a269d635ac44a7cb86b04f273183a20bc16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068879Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8410164ab122..1773f37de61e git log 8410164ab122..1773f37de61e --date=short --first-parent --format='%ad %ae %s' 2020-02-22 ehmaldonado@google.com gclient_utils: Add temporary_file method. Created with: gclient setdep -r src/third_party/depot_tools@1773f37de61e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051631 Tbr: agable@chromium.org Change-Id: I61706ec8f677740c87e63db876104976cb7eec03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068971Reviewed-by:
-
Tom Anderson authored
This is needed for building the snap package on the CQ/CI bots. BUG=1055026 R=thestig Change-Id: I7da96dd382e629c166357b90a4a700289673682d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068869 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#743750}
-
Sorin Jianu authored
Bug: 1054696 Change-Id: I1a58cf0bbef49db004702f88a5575dc54c848ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069019Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743749}
-
