- 28 Jun, 2018 40 commits
-
-
Harald Alvestrand authored
This seems to not have been caught by CQ. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1110221 TBR=haraken@chromium.org Bug: 856643 Change-Id: Ib17dcaeb656f114527f3d31f16dc2bb9971b6f95 Reviewed-on: https://chromium-review.googlesource.com/1118556Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#571185}
-
John Abd-El-Malek authored
TBR=atwilson Bug: 844950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I92e5e1f9f28489ec265c89a11c932af47a8a48b7 Reviewed-on: https://chromium-review.googlesource.com/1113029 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#571184}
-
Nicolas Ouellet-payeur authored
We already don't save "Never translate <website>". We want the same behavior for "Never translate <language>" in order to be consistent. Additionally, the "Always translate" button doesn't work in incognito mode. 1. Remove the "Always translate <language>" button in incognito mode, on desktop and Android. 2. Don't persist "Never translate <language>" if clicked in incognito mode, but still apply it to the current session. Needs more work to update the iOS UI. Bug: 793925 Change-Id: I53f9bbd8dbcf605ef0682bf993b2835ab0ba92aa Reviewed-on: https://chromium-review.googlesource.com/1115204Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#571183}
-
Boris Sazonov authored
https://crrev.com/c/1110371 added some preferences from PrivacyPreferences to SyncAndServicesPreferences. This CL removes these preferences from PrivacyPreferences if UnifiedConsent feature is enabled so they aren't shown in two different screens. Bug: 814728 Change-Id: Ic1e573a13aebd2d8df056e1da6299d15f9a8bfdc Reviewed-on: https://chromium-review.googlesource.com/1117074Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571182}
-
Elad Alon authored
Bug: 775415 Change-Id: I69c7fcae44cd2d330c175da5ad588d861fd17e95 Reviewed-on: https://chromium-review.googlesource.com/1116793 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571181}
-
Patrick Monette authored
Now that the ThirdPartyConflictsManager can be destroyed at runtime, it is no longer safe to pass an unretained reference to the ModuleListFilter to a background task. Also fixes setting the ThirdPartyConflictsManager's terminal state in its destructor. Change-Id: Idcc5f5aa6c69911d29c402c91372fce6bf376df5 Reviewed-on: https://chromium-review.googlesource.com/1112459 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#571180}
-
Daniel Zhang authored
1. Pagination buttons were enlarged from 4dip radius to 5dip radius 2. Pagination button stroke width was changed to 2dip from 1dip 3. Removed padding between buttons 4. Enlarged InkDrop radius. Bug: 856678 Change-Id: Ie4754848373a635a045c7366462e6bcde0499194 Reviewed-on: https://chromium-review.googlesource.com/1114306 Commit-Queue: Daniel Zhang <oxyflush@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#571179}
-
Weidong Guo authored
In homecher, suggestion chips will replace suggested apps. 1. Modify SuggestionChipView to alter between assistant style and app list style based on input parameter. 2. Add the SearchResultSuggestionChipView which contains a SuggestionChipView. 3. Add the SuggestionChipContainerView to contain a list of suggestion chips. Bug: 855282 Change-Id: I3ee78198aafa5c480f97ee3d3bf9a6aa70504e20 Reviewed-on: https://chromium-review.googlesource.com/1112436 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571178}
-
Matt Swartwout authored
Bug: None Test: None Change-Id: Ib4e8dde9bee345b877064cbe00b21bc5827912ad Reviewed-on: https://chromium-review.googlesource.com/1117755Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#571177}
-
Sorin Jianu authored
This change introduces a Priority parameter for component_updater::OnDemandUpdater::OnDemandUpdate. The change is mechanical for the existing implementation. Bug: 857215 Change-Id: I736b2ece704a8dda8d8f2d5a0d6d6419ceb22402 Reviewed-on: https://chromium-review.googlesource.com/1111558Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571176}
-
Yuly Novikov authored
TBR=kbr@chromium.org Bug: 857527 Change-Id: I3b8cc86a3728dab2633f2dda0ebf1eb6090cdb35 Reviewed-on: https://chromium-review.googlesource.com/1118755Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571175}
-
Orin Jaworski authored
Omnibox entity suggestions with two lines of text will layout as before, but now if the second line description is absent, the primary content text line will be vertically centered. Bug: 856703 Change-Id: Ie672ccece28be79d18bf6f7f07f9937af434178d Reviewed-on: https://chromium-review.googlesource.com/1115760 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#571174}
-
Benoit Lize authored
Some detached requests fail because the network changes between requests. Retry the request in this case, only once. Bug: 851399 Change-Id: Ic77c28e5ac49fecaf634e4a225c8f443f75e2560 Reviewed-on: https://chromium-review.googlesource.com/1118262Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571173}
-
Ted Choc authored
https://developer.android.com/reference/android/Manifest.permission.html#FOREGROUND_SERVICE BUG= Change-Id: Ie3e01cea3d810373d804c2a56d42d5f4f44607f9 Reviewed-on: https://chromium-review.googlesource.com/1117135Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#571172}
-
Sigurdur Asgeirsson authored
Bug: 854598 Change-Id: I457e8940a4ad5ff4aa89cfae4415f0addd1e6a64 Reviewed-on: https://chromium-review.googlesource.com/1118621 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#571171}
-
Xiaoqian Dai authored
This reverts commit fed0e8ec. Reason for revert: It broke most of the chrome_informational builders at BuildPackages stage. See crbug.com/857133 for details. Original change's description: > Pull GN via CIPD package > > This is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1112840. > > > The gn binary will be downloaded into third_party/gn. This CL rolls > buildtools forward to a revision where the gn binary is a stub that > prints an error message and returns 1. This is to avoid depending > on the old location, and helping users relying on gn auto regen. > > Update mb.py to use the new location. > > Update explicit location in ios/web_view/BUILD.gn for the new location. > > Update explicit location in > tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new > location. > > Update explicit location in tools/licenses.py with for the new location. > > Update explicit location in testing/libfuzzer/gen_fuzzer_owners.py. > > Bug: 855791 > Bug: 856883 > Bug: 856884 > Bug: 856878 > Bug: 856899 > Bug: 857107 > Bug: 857110 > Change-Id: Iedaa29161e56cc90beafd802efca3a6c12859c58 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1117264 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571031} TBR=dpranke@chromium.org,scottmg@chromium.org Change-Id: I28962c879b7bc24e809b29427122bb425e9450a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855791, 856883, 856884, 856878, 856899, 857107, 857110 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118825Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#571170}
-
Avi Drissman authored
It was reenabled in f73246ba. No, it is still flaky. BUG=845267 TBR=kbr@chromium.org Change-Id: I4ad193b01738945c63dfa12585be7b9354408b49 Reviewed-on: https://chromium-review.googlesource.com/1118528Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#571169}
-
Tommy Li authored
This reverts commit fe55ead6. Reason for revert: UX direction change. Original change's description: > Revert "Omnibox UI Refresh: Align Omnibox text to new Suggestion text" > > This reverts commit 0830cdf0. > > Reason for revert: UX direction change. > > Original change's description: > > Omnibox UI Refresh: Align Omnibox text to new Suggestion text > > > > The goal of the CL is to re-align the Omnibox text to match the new > > Refresh spec. > > > > In the new Refresh spec, the text has a different indentation depending > > on whether or not the popup is open, so this CL resets the insets > > of the OmniboxViewViews whenever the popup opens or closes. > > > > It also updates LocationBarView to no longer ignore the left-inset > > value of the OmniboxViewViews. We used to also ignore the right-inset > > value, but we stopped doing that recently [1]. > > > > After no longer ignoring the left-inset value, we update the > > non-Refresh value to the correct value of 0 (to keep things looking > > the same), and update the Refresh value to 2, which matches mocks. > > > > We are updating the inset of the OmniboxViewViews textfield instead of > > the bounds of the textfield because we want the whole area to remain a > > clickable I-beam, even if we indent the text a bit. > > > > [1] https://codereview.chromium.org/2642893002/diff/100001/chrome/browser/ui/views/location_bar/location_bar_view.cc > > > > Bug: 849779, 823535 > > Change-Id: I8c2a9e4934a78efec0d3d6cd60c63181be2d92c4 > > Reviewed-on: https://chromium-review.googlesource.com/1096491 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > > Commit-Queue: Tommy Li <tommycli@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#566834} > > TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 849779, 823535 > Change-Id: Icf9e2f004042be6f25b9a86d23f269f5ebf0fd90 > Reviewed-on: https://chromium-review.googlesource.com/1117218 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570847} TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org Change-Id: Ib5afb6cc4e892594e3cfdd0c775ae6ef1e4f862f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849779, 823535 Reviewed-on: https://chromium-review.googlesource.com/1118785Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#571168}
-
Mark Pilgrim authored
Bug: 855620 Change-Id: Id4da3e42581147261f706c15f3649a38fad52ff1 Reviewed-on: https://chromium-review.googlesource.com/1117031 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571167}
-
Amy Qiu authored
Move tough_compositor_cases.py into the rendering folder and refactor classes to inherit from RenderingStory Bug: 849392 Change-Id: I0a675d99f81a7588612e648e9ad5c3fef210e8d1 Reviewed-on: https://chromium-review.googlesource.com/1117574 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571166}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a26de2500503..dc66ef9dc48b git log a26de2500503..dc66ef9dc48b --date=short --no-merges --format='%ad %ae %s' 2018-06-28 lucferron@chromium.org Vulkan: Add simple test to trigger issue of buffer.write tests 2018-06-28 geofflang@chromium.org VK: Support pbuffer surfaces. 2018-06-28 jmadill@chromium.org Roll SPIRV-Tools and SPIRV-headers (June 2018) Created with: gclient setdep -r src/third_party/angle@dc66ef9dc48b The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I41c21a478cdae8bfb23fe992c2f8f6a53d40d12d Reviewed-on: https://chromium-review.googlesource.com/1118569Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571165}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/385804514edf..fcb04d853ec4 git log 385804514edf..fcb04d853ec4 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 26581113047a..a26de2500503 (2 commits) 2018-06-28 senorblanco@chromium.org GrTessellator: handle collinear final vertex. 2018-06-28 caryclark@skia.org fix doc catalog 2018-06-28 brianosman@google.com Revert "Revert "Temporary fix for SkImage_Lazy handling of color spaces"" Created with: gclient setdep -r src/third_party/skia@fcb04d853ec4 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851409 TBR=jcgregorio@chromium.org Change-Id: Id3edcb82a300a5a5a2eadb463682fb24b7ba1fb7 Reviewed-on: https://chromium-review.googlesource.com/1118505Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571164}
-
Yi Gu authored
TBR=carlosk@chromium.org NOTRY=true Bug: 857520 Change-Id: I585202f174ab0cd9376ec38b41a3de4cd2f5927c Reviewed-on: https://chromium-review.googlesource.com/1118746Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571163}
-
Xiaocheng Hu authored
This is a preparation patch for crrev.com/c/1117716, which reveals some LayoutNG bugs in non-standards mode. Since non-standards mode is of low priority for now, this patch converts these tests to standards mode to unblock the pending CL. Note: fast/css/first-letter-first-line-hover.html is a ref test, whose ref file is also modified. Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icd62340740c52efd62cf6a36a06442a336639476 Reviewed-on: https://chromium-review.googlesource.com/1117919Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571162}
-
chrome://safe-browsingDaniel Rubery authored
Render: https://screenshot.googleplex.com/nvBOZqHXENq Bug: 849351 Change-Id: I8004424ed05d0b424fd9918c0e36d49d954bcabc Reviewed-on: https://chromium-review.googlesource.com/1117443 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#571161}
-
Amy Qiu authored
Move key_noop_cases.py into rendering folder and refactor to inherit from RenderingStory class Bug: 849393 Change-Id: I5db6ea904ac82b23eaf8abac0203b2552a43f364 Reviewed-on: https://chromium-review.googlesource.com/1118281Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571160}
-
Mike Dougherty authored
This is a reland of 0c2015e1 TBR=eugenebut@chromium.org Original change's description: > Disable WebStateTest.MessageFromIFrame test. > > TBR=eugenebut@chromium.org > > Bug: 857129 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909 > Reviewed-on: https://chromium-review.googlesource.com/1117300 > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570882} Bug: 857129 Change-Id: I62a341ccebb1ceef892a2f07eb0faae4d87476d7 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118685Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#571159}
-
Geoff Lang authored
Android is not possible yet because we can't pass flags to the test executable. BUG=angleproject:2635 Change-Id: I2c8247c9231895a729575229a820f1720d845c6f Reviewed-on: https://chromium-review.googlesource.com/1117210Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571158}
-
Miguel Casas authored
kCanvas2DImageChromium [0] is a FeatureFlag enabled by default in Mac and CrOS allowing for using GL CHROMIUM_image extension for HTML Canvas Contexts. This CL exposes this flag to chrome:flags so it can be used for debugging e.g. crrev.com/c/1056168 etc. In CrOs, the flag goes unused now [1], so nothing changes there. [0] https://cs.chromium.org/chromium/src/content/public/common/content_features.cc?type=cs&q=kCanvas2DImageChromium&g=0&l=83 [1] https://cs.chromium.org/chromium/src/content/child/runtime_features.cc?type=cs&q=enable_canvas_2d_image_chromium&g=0&l=156 Bug: 839970 Change-Id: I94a3646e996b996f6901d9414734801d1aa2bfab Reviewed-on: https://chromium-review.googlesource.com/1117328 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#571157}
-
Jan Wilken Doerrie authored
This change implements initiating GATT connections for WinRT. While currently no GATT discovery is attempted, this will be provided in a future CL. GATT connections are created by obtaining an instance of BluetoothLEDevice. Bug: 821766 Change-Id: I7f20127a84b781859300af18b31da0e9ee24a32b Reviewed-on: https://chromium-review.googlesource.com/1090217 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#571156}
-
Bruce Dawson authored
Including Windows.h causes namespace pollution and build-time costs due to the heavy use of macros and the large size of the headers. This removes a #include of Windows.h from range.h that is currently causing problems. Bug: 855717, 796644 Change-Id: I26abd068ed1c4a5ca65092258dd45ccd076c2b20 Reviewed-on: https://chromium-review.googlesource.com/1117739 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#571155}
-
Elly Fong-Jones authored
This is a reland of f824b3a3 Original change's description: > variations: add client config for ViewsBrowserWindows > > Bug: 827247 > Change-Id: Ic09c38f7b658b1f6d79ecec8a6d0895aca44d797 > Reviewed-on: https://chromium-review.googlesource.com/1017460 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565782} Relanding the CL. Bug: 827247,851463 TBR: isherman@chromium.org Change-Id: Ic3b23594fa74b24023924ad4107bf262e641bfb7 Reviewed-on: https://chromium-review.googlesource.com/1106498Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#571154}
-
Erik Luo authored
When migrating [1] formatting logic from ConsoleViewMessage.js to BrowserConsole.js, we forgot to add the line that tries to show a localizedFailDescription. [1] https://chromium-review.googlesource.com/c/chromium/src/+/920541 Bug: 816743 Change-Id: Ic3e6cc49b8634a12fe8667c19fdc4623780075db Reviewed-on: https://chromium-review.googlesource.com/1115872Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#571153}
-
danakj authored
Currently its using WebLayerTreeViewImplForTesting but it only uses the cc::LayerTreeHost, not the WebViewImpl things, so it just needs a LayerTreeHost itself. This helps us toward removing the WebLayerTreeView interface. R=chrishtr@chromium.org Bug: 838693 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia60ea4128ed029f09ee4abe012ee62f315633c88 Reviewed-on: https://chromium-review.googlesource.com/1117656 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#571152}
-
Nico Weber authored
Makes incremental builds of blink_core 31% faster in jumbo builds. (Non-jumbo builds that use PCHs (i.e. not goma builds at the moment) already got this speedup without this change.) reviews.llvm.org/rL335466 made PCH files much more effective in component builds on windows. Regular (non-jumbo) component builds of blink_core now build 42% faster. In Jumbo builds, full builds are only a bit faster with PCHs enabled after that change (26m52s instead of 27m33s with just jumbo; jumbo + PCH before that change was 27m41s), but incremental build time goes from 32s to 22s for touching one cc file and relinking blink_core.dll, which is a considerable speed-up. Reverts https://chromium-review.googlesource.com/c/chromium/src/+/962785 Bug: 809010 Change-Id: I985dd16dacaa9f655ae2a9329b33ad92229a1ab6 Reviewed-on: https://chromium-review.googlesource.com/1116901Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#571151}
-
Kevin Schoedel authored
Events at the RewriteEvent() interface are in raw screen coordinates, but TouchExplorationController internally uses DIP coordinates. Some rewritten events were incorrectly generated using DIP coordinates. Bug: b/73383411 Test: manual Change-Id: Ib126692e51aaf034a95cd9b50b599e4bd76cbcac Reviewed-on: https://chromium-review.googlesource.com/1117469 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#571150}
-
danakj authored
Use cc::LayerTreeHost instead, as these tests just need to use cc APIs for testing painting. They do not use the WebViewImpl etc layer. NOTRY=true Bug: 838693 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ide21fc6acdbd4c1171987f964ea6b157e79789e0 Reviewed-on: https://chromium-review.googlesource.com/1117622 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571149}
-
Yi Gu authored
TBR=jochen@chromium.org NOTRY=true Bug: 857488 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I36166c547f9c5c5b9d69d01742a20f6673c8f15e Reviewed-on: https://chromium-review.googlesource.com/1118534 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571148}
-
Ehsan Karamad authored
The code in FixupURL does not properly handle "about:blank" variants where some letter in "blank" is uppercase. This CL fixes the issue by returning "about:blank" when the lowercase of the input URL is "about:blank". Bug: 857201 Change-Id: Ia1ff719d142ae8f2a346cbca231e52a811e9b77c Reviewed-on: https://chromium-review.googlesource.com/1117627Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571147}
-
Guohui Deng authored
Bug: None Test: None Change-Id: I5de8c272bb5d82c135e35a210f5c3948befd155f Reviewed-on: https://chromium-review.googlesource.com/1117848Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#571146}
-