- 17 Aug, 2018 40 commits
-
-
Calder Kitagawa authored
Phase 2 of the work to replace url_template with action and params as per the updated WebShareTarget spec: https://wicg.github.io/web-share-target/. This work stops the parser from parsing |url_template| for |share_target| and instead parses |action| and |params|. This will effectively disable any downstream dependencies which trigger when |url_template| is populated. Disabled codepaths are in chrome/browser/webshare and chrome/android/webapk. This will be quickly remedied before M70. See the bug for a detailed plan for performing these changes. Bug: 871788 Change-Id: If15f1158ae439286c7a2d64538842c21fd1b9d5f Reviewed-on: https://chromium-review.googlesource.com/1168115 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584146}
-
Yuankai Yu authored
Apple doesn't allow advertising with service data, as a result we are advertising the EID in the form of service UUID in the advertisement. Chrome on Mac advertises in this form, however Chrome on all platform needs to parse this form of advertisement as well since iOS phone can only advertise in this form. Bug: 875074 Change-Id: I654d2cfbbf5692cf9b17876b2d05bfad07f7bba2 Reviewed-on: https://chromium-review.googlesource.com/1171253 Commit-Queue: Yuankai Yu <yyk@google.com> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584145}
-
Nico Weber authored
Also make notification_helper_unittests run on the CrWinAsan* bots since they now run tests on Win10 and that suite only has issues on Win7. Some tests currently fail under asan. I'm for now not running the suites containing these tests at all. I'll fix (or disable individual tests) and gradually add the missing test suites: - cc_unittests fails LayerTreeHostBlendingPixelTest, https://crbug.com/875223 - install_static_unittests fails GetSandboxSidPrefix, https://crbug.com/875225 - sbox_integration_tests fails TestAddressSanitizer, https://crbug.com/875242 - browser_tests (and viz_browser_tests and network_service_browser_tests) fail PictureInPicture (https://crbug.com/873234), MouseLeave (https://crbug.com/856169) - sync_integration_tests fails MC_MergeDifferentBMModelsModeratelyComplex, https://crbug.com/875239 Bug: 869973 Change-Id: I5173419ac0a9ed4879dcfc91614ffc335d749b04 Reviewed-on: https://chromium-review.googlesource.com/1179087Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#584144}
-
Robert Ma authored
Looks like the test is in fact flaky-timeout on all platforms. TBR=foolip No-Try: True Bug: 875249 Change-Id: I9e6a3c96afbf539c8c685ef079993c138826ea18 Reviewed-on: https://chromium-review.googlesource.com/1180248Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#584143}
-
Jennifer Apacible authored
TBR=sandersd@chromium.org NOTRY=true (disabling a test) Bug: 875278 Change-Id: I26c070fc09e5c7798fcbed324286c7b4e7ece379 Reviewed-on: https://chromium-review.googlesource.com/1180247Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584142}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c56ab263b32979b6e310e777b91895220200af7 Reviewed-on: https://chromium-review.googlesource.com/1180175Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#584141}
-
Jennifer Apacible authored
It is flakily crashing. TBR=sandersd@chromium.org NOTRY=true (disabling a test) Bug: 875390 Change-Id: I22c9fd4a28ef513682b3dac7c5c2706c4cdd0b37 Reviewed-on: https://chromium-review.googlesource.com/1180180Reviewed-by:
-
Jennifer Apacible authored
TBR=rohitrao@chromium.org NOTRY=true (disabling tests) Bug: 875313 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib632b4395c18c417832a43d4cbe1082bfc8a7044 Reviewed-on: https://chromium-review.googlesource.com/1180173Reviewed-by:
-
Mounir Lamouri authored
The custom control fullscreen detection will be used to override DisplayType so that an inline playback that is "effectively fullscreen" will be represented as fullscreen with regards to watch time. Bug: 875083 Change-Id: Ie5ced38ae559cfa3d1cfc046cd94a4a34b139ccb Reviewed-on: https://chromium-review.googlesource.com/1178998Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#584138}
-
Robert Sesek authored
Generating the test data at build time is causing issues on certain bots. The files are too large to commit to source control, so store them in the CIPD package chromium/chrome/test_data/safe_browsing/dmg. Bug: 817663 Change-Id: Iebf45db581e2bfdefab0eda32722f81cf036d900 Reviewed-on: https://chromium-review.googlesource.com/1175041Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#584137}
-
Xida Chen authored
Previously the CL was reverted because it hits a DCHECK in the test. The reason is that in the test, the guest web contents is ready, but it is not yet attached to the render widget host view. This CL fixes the problem by waiting for at most of 200ms for the guest web contents to be attached. I have ran this locally for more than 20 times and there is no failure. Patchset 1 is the same as the CL that was reverted, so that it is easier to review Bug: 873211 Change-Id: I5c36da5be5d812bbd5f1964605fc6697166a2539 Reviewed-on: https://chromium-review.googlesource.com/1177884 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#584136}
-
Alexandr Ilin authored
This CL makes the predictor compatible with the network service. All used APIs correctly work with the disabled network service as well, so there is no need to keep both code paths. Since all requests to the NetworkContext should be made on the UI thread, this CL modifies predictors::PreconnectManager class so it lives entirely on the UI thread instead of IO thread. We cannot issue synchronous requests to the proxy resolution service with the network service. This CL removes skipping preresolving in cases when a proxy is enabled, since it relies on synchronous call to the proxy resolution service. Follow-up CL that sends an asynchronous request to the proxy resolution service in parallel with a resolve host request will be submitted shortly. Bug: 809583 Change-Id: I1afe9895fc1fba163d8519df465f98a4c6a5e552 Reviewed-on: https://chromium-review.googlesource.com/1165550 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584135}
-
Dale Curtis authored
There are bugs in MediaCodec on Marshmallow that are trivially hit when using this API there, so we need to limit our usage to Nougat. This also partially reverts a speculative fix to MediaCodecBridge, but not the log message for errors it added. BUG=873094 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4762456ed18a4c26f1f730d736cfd1f94c9dbe48 Reviewed-on: https://chromium-review.googlesource.com/1180062Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584134}
-
Jennifer Apacible authored
TBR=tedchoc@chromium.org NOTRY=true (disabling a test) Bug: 875372 Change-Id: Ia51964a62207de7300b159e80a3e4816af8f579b Reviewed-on: https://chromium-review.googlesource.com/1180165Reviewed-by:
-
Jennifer Apacible authored
NOTRY=true (disabling tests) Bug: 875137, 622387 TBR: dtseng@chromium.org Change-Id: I625e4bcf454fb7dcdf67e83cfbe2ac643d9d8c7e Reviewed-on: https://chromium-review.googlesource.com/1179974 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
-
Tessa Nijssen authored
This is a reland of http://crrev/c/1178467. TextSuggestionsTouchBarControllerTest.InvalidRange was modified so that it sets the controller's text and range before calling updateTextSelection:range:offset:. Previously, -updateTextSelection:range:offset: could receive an invalid range from WebContentsTextObserver::DidChangeTextSelection(). This invalid range would then cause a crash in -requestSuggestions. A check has been added to -updateTextSelection:range:offset: to make sure that a selection with an invalid range is not passed to -requestSuggestions. This should prevent future crashes. TextSuggestionsTouchBarControllerTest.InvalidRange tests that an invalid range does not crash the controller and is handled properly. Bug: 717553 Change-Id: I579cac326c3de86321286d4981c05e15f844021b Reviewed-on: https://chromium-review.googlesource.com/1180068Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
-
Dale Curtis authored
This reverts commit ac8b0d15. Reason for revert: Did not fix the issue. Original change's description: > Speculative MCVD fix: Bind OnBuffersAvailableCB on known good thread. > > Crash dumps are unclear and the issue seems resolved on Pixel hardware, > but some earlier stack traces suggest we're getting a null TaskRunner > when attempting to BindToCurrentLoop during CreateCodec(). As such > move binding to a known good thread. > > This should be reverted if the issue is not fixed. If it is fixed > there's additional work to be done to understand the consequences > of CreateCodec() being called on an unexpected thread. > > BUG=873094 > TEST=none > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I2928d7866c1f40de63f526ee7393d2d8b90884f2 > Reviewed-on: https://chromium-review.googlesource.com/1175092 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583067} TBR=dalecurtis@chromium.org,tguilbert@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 873094 Change-Id: I0d7824f4caacbc8663d05b8b62f2bff2061f45a7 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1179339Reviewed-by:
-
Peter Collingbourne authored
The new implementation works by embedding debug info in object files instead of parsing compiler warning output. As a result, our official builds are much less noisy. See the new header file ui/base/resource/whitelist.h for details on how it works. It is also simpler because it does not rely on wrapper scripts for collecting the set of whitelisted resource ids. As a result we no longer need, and can remove, the wrapper scripts for the compiler and ar. It is also theoretically more precise because it only whitelists resource ids mentioned in archive members that were chosen by the linker, although I didn't see an improvement in monochrome. It may be possible to gain even more precision by extending the compiler (see comments on bug) but first we'd need to investigate whether that would be worth it. Bug: 648475, 684788 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I12d83a8aaffa42c3afcdcc834f7dd7536b7a9248 Reviewed-on: https://chromium-review.googlesource.com/1174012Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#584129}
-
Khushal authored
The CanvasImageProvider locks images, limited by a budget, to avoid GPU discardable ref churn. In the non deferral mode, these images are released on an external signal indicating the end of a task which mutated the canvas. The above mechanism is brittle, and can result in holding this memory for long durations depending on when the release is triggered. Instead queue a task each time we start adding images to this list, to ensure they are eventually cleared. R=ericrk@chromium.org, fserb@chromium.org Bug: 872117 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie9179e498ef70c78ac091a15aa871b16ae5d80ca Reviewed-on: https://chromium-review.googlesource.com/1179376Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#584128}
-
Nasko Oskov authored
The OnConnect method has been removed from the service_manager::Service class, but was left in a comment. Change-Id: Iab8d940928b3a7927ba1e0da16deea02df3d6ecb Reviewed-on: https://chromium-review.googlesource.com/1180001 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Clark DuVall authored
This is similar to dns_api.cc, in that there is no way to cancel the request. Bug: 874659 Change-Id: I7fdc70d786a7b86e3a92ea2c8de6a108bcfa2aaf Reviewed-on: https://chromium-review.googlesource.com/1179263Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584126}
-
bsheedy authored
Makes the VR bisect compatible with both the old method of running perf tests (directly calling run_benchmark) and the new method (calling run_performance_tests). Which method to use is dynamically chosen based on the current commit's position relative to the CL that changed which format the VR tests use on swarming. Bug: 865533 Change-Id: I235c59c8df2f340c0d9407f0b204d65e74eea18a Reviewed-on: https://chromium-review.googlesource.com/1178625Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584125}
-
Sammie Quon authored
Also fix a crash on shutdown if one of those dialogs is open in overview. Test: manual Bug: 850028 Change-Id: I31917875dc7a1c770c61f48b04766e49ef4b9786 Reviewed-on: https://chromium-review.googlesource.com/1178891 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#584124}
-
Jennifer Apacible authored
Bug: 875306 TBR: rakina@chromium.org Change-Id: I9931c29235114845ada33661169c5152096bb165 Reviewed-on: https://chromium-review.googlesource.com/1180061 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
-
Clark DuVall authored
This is a reland of dccf844a This was reverted because NetworkContextConfigurationBrowserTests were failing on Mac due to crbug.com/843324. This is because those tests call AddSimulatedFailure() on the host resolver, which now sends those rules to NetworkServiceTest (which doesn't work on Mac). I disabled the NetworkContextConfigurationBrowserTests on Mac that run with network service enabled. Original change's description: > Convert dns_api.cc to mojo host resolver > > Bug: 874658 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I576d2877ec71df8e489d349916f758ba6fe74263 > Reviewed-on: https://chromium-review.googlesource.com/1176725 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583878} TBR=wfh@chromium.org,jam@chromium.org Bug: 874658 Change-Id: Ib26c612a450a48818a10f817bd2d309292d4c9ea Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1179922Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Emircan Uysaler authored
This CL hooks up use-fake-device-for-media-stream and use-fake-ui-for-media-stream flags for getdisplayMedia() calls for enabling testing in the future. - Use fake-ui chooses a default device. If fake-device is specified, that takes priority. - Fake-device type can be modified by flag args. Bug: 326740 Change-Id: I4e97941743fa2149f88bc3714beb4d833da42e48 Reviewed-on: https://chromium-review.googlesource.com/1177448Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584121}
-
Yue Li authored
Bug: b/112704035 Test: Manual Test Change-Id: I83e3acab1399e3e43e5c9e9f3022c96809a3881e Reviewed-on: https://chromium-review.googlesource.com/1179301Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#584120}
-
Sandra Sun authored
The scroll offsets returned from blink are only integers. However, if the target snap offset is fractional, it will never reach the destination and will oscillate between the two closest integers until it reaches the maximum time duration. In this patch, we end the snap fling if we've reached the 1-pixel range of the destination. Bug: 866517 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I185fd4267c626e1f4e561e9bd92a962c8f289d38 Reviewed-on: https://chromium-review.googlesource.com/1159088Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#584119}
-
Sky Malice authored
This CL changes pref names that are not backwards compatible. This should be fine because no users have used this Feed functionality yet. Histogram names and variables were not changed because they need to be identical to legacy values. Bug: 874970 Change-Id: I142bc70b2a00c0d04c3b499b79a33a7ad6e149d7 Reviewed-on: https://chromium-review.googlesource.com/1178240Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584118}
-
Leonard Grey authored
Currently, the bookmark bar uses the view hierarchy as its "model": bookmark buttons are force ordered to the child view index that matches their order in the model node (so that child_at(i) is the ith button), and GetBookmarkButtonCount() is implemented as: `return child_count() - 6;` This is fragile, and less than ideal for keyboard traversal. This change tracks the buttons separately in a vector, and maintains proper focus traversal. This is setup for Cocoa-style button dragging (as well as a fix for issue 841785). Bug: 712248, 841785 Change-Id: I236e34503d021ff0f27974f731f6abcb4d62f829 Reviewed-on: https://chromium-review.googlesource.com/1177908 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584117}
-
Yue Li authored
Bug: None Test: Local compile Change-Id: I2561b396bd871c8146af4a0b492091cd6bb63b2a Reviewed-on: https://chromium-review.googlesource.com/1179264Reviewed-by:
-
Theresa authored
Register a MemoryPressureListener and trim the Stream memory when a memory pressure signal is received. BUG=860049 Change-Id: I60c7669649c1e085e0de7610fbf45b10ba327c53 Reviewed-on: https://chromium-review.googlesource.com/1178894 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#584115}
-
Joshua Pawlicki authored
Extension updates are unaffected by this CL. Bug: 740715 Change-Id: Ib1a563f62ed923ecc06300d171a83935ef18a1ef Reviewed-on: https://chromium-review.googlesource.com/1167987 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584114}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/6e5fd1672be5..1c78a7ba9366 git log 6e5fd1672be5..1c78a7ba9366 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 dschuff@chromium.org Update more uses of gsutil for new bot config Created with: gclient setdep -r src/native_client@1c78a7ba9366 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: Iada28666b8d792aaa0034d607341b18665e80c7d Reviewed-on: https://chromium-review.googlesource.com/1180003Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584113}
-
Jennifer Apacible authored
It is flakily crashing. TBR=sandersd@chromium.org NOTRY=true (disabling a test) Bug: 875336 Change-Id: Ia134612a0fc11edcdcac8a3c5420e7bd40dc39f3 Reviewed-on: https://chromium-review.googlesource.com/1180074Reviewed-by:
-
Oksana Zhuravlova authored
This change removes the listener template parameter from DeviceSensorEventPump and any dependencies on WebDevice*Listener. Bug: 861902 Change-Id: I91ec5f709eaa74acca35fa884e971f3f60e8f294 Reviewed-on: https://chromium-review.googlesource.com/1176199Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#584111}
-
apacible authored
This reverts commit 0609fce6. Reason for revert: ios tests failing -- see crbug/875313 Original change's description: > [AF][IOS] Split Autofill settings page into two separate pages > > Splits Autofill settings page into two separate pages, one for addresses > and the other for credit cards. > > Bug: 860526 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I8f02f93fbd54fc17c2b97e5a97d9d5a08f729197 > Reviewed-on: https://chromium-review.googlesource.com/1173314 > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583716} TBR=rohitrao@chromium.org,mahmadi@chromium.org Change-Id: If4646cab4665d962e4ee166516a961390cb54436 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860526 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1179342Reviewed-by:
-
Geoff Lang authored
TBR=kbr@chromium.org BUG=693090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia1e99a3f928db453808fc9b1cba80feb6d4ac383 Reviewed-on: https://chromium-review.googlesource.com/1179819 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584109}
-
Maja Kabus authored
Bug: 739170 Change-Id: Ia0ec627627b8ad6b208eb9351f3e7786e6d2c9b2 Reviewed-on: https://chromium-review.googlesource.com/1177752 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#584108}
-
Ned Nguyen authored
This is causing failure in https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8937935288322083600/+/steps/generate_build_files/0/stdout Bug: 828444 Change-Id: I7643fed1efd9ee12d4854dc1aec54a137818604c Reviewed-on: https://chromium-review.googlesource.com/1179615Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#584107}
-
