GitLab

Bug: None
Change-Id: I5729ca7f84b19d09aa1bae586e5c921ad997bb43
Reviewed-on: https://chromium-review.googlesource.com/640380
Commit-Queue: Kári Tristan Helgason <kthelgason@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501571}

This CL's intention is to adjust to the change of WebIDL's specification.

Before this CL, MaplikeRest's types cannot be annotated.

After this CL, however, MaplikeRest's types can be annotated types.

In order to check if ASTs are dumped correctly and if the code generator works correctly,
I also added pattern match based tests and code generator's tests.

Bug: 714866
Change-Id: I0cf998e609f635f1a9068ae8904e536bf9e6caa4
Reviewed-on: https://chromium-review.googlesource.com/664497Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Lisa Suzuki <lisabelle@google.com>
Cr-Commit-Position: refs/heads/master@{#501570}

* Improve rounding; use std::round() or gfx::ToRoundedInt() more.  In most cases
  this was a no-op from our existing behavior, but a few places were rounding
  negative numbers incorrectly (toward positive infinity rather than away from
  zero).  This eliminates the need for local helpers or MathUtil::Round().
* Prefer C++ to C library functions (e.g. powf() -> std::pow())
* Eliminate unneeded #includes/#defines.
* git cl format
* Shorten code

Bug: none
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I19f42f51db3cdbca8ff634af9391da151b985d50
Reviewed-on: https://chromium-review.googlesource.com/658043
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501569}

TBR=eae@chromium.org

Bug: 636993, 758816
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I22b14e3a042607d46cc8f3173fa7fbdfaefae5dc
Reviewed-on: https://chromium-review.googlesource.com/663004Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501568}

This reverts commit cc477ff2.

Reason for revert: Looks like this broke Chromium OS asan tests https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23602/steps/ash_unittests

Original change's description:
> splitview: Cleanup window selector unittests.
> 
> Move splitview window selector unittests to their own test class.
> 
> Bug: None
> Test: ash_unittests
> Change-Id: I8153c916a05ef9ab6011105ca670dfc0e73ee257
> Reviewed-on: https://chromium-review.googlesource.com/661327
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501487}

TBR=oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org

Change-Id: I998514803173091629c5ccc679ac42bf82e121a7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/663699Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501567}

When camera device fails to open, the camera HAL can terminate the Mojo
channel before Chrome does, resulting a Mojo connection error and
setting the VCD internal state to kError.

BUG=b:65525047
R=wuchengli

Change-Id: If785cb426b4ce048146a795fa1d28ea183c6267a
Reviewed-on: https://chromium-review.googlesource.com/659697Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501566}

When the menu Widget closed on drop of bookmark, the attempt to
reset |data_source_| in DragDropClientMac::Drop() caused crash
because the DragDropClientMac is deleted along with the Widget
in the |drop_helper_.OnDrop()|. So, clear |data_source_| before
calling |drop_helper_.OnDrop()|.

Beside the crash issue, there was another issue that custom types
of ui::OSExchangeData items are not copyed into NSPasteboardItem
used in the dragging session. This is because the types set for
NSPasteboardItem does not contain the custom types such as bookmark.
So, instead of using SupportedPasteboardTypes() for NSPasteboardItem,
use OSExchangeDataProviderMac::GetAvailableTypes() to include any
custom types contained in the ui::OSExchangeData items.

Bug: 673192
Change-Id: Ib98cca2058c4898a17db7bfced97264fbc653e14
Reviewed-on: https://chromium-review.googlesource.com/648886
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501565}

Sometimes, drag&drop shadows will show thumbnails, and if those haven't
been loaded yet, it will show filenames. However, the thumbnails are
might have been preloaded by other parts of the filesapp, so use these
if possible.
Still keep the old logic as a fall-back.

Bug: 755792
Tested: manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6a716984bd8854655e4bada2851ef69ab0f7a8b4
Reviewed-on: https://chromium-review.googlesource.com/654499
Commit-Queue: Marianne Thieffry <mariannet@google.com>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501564}

The original patch caused buildbot failures because it didn't rebaseline
the newly added wpt innerText getter tests. This is fixed in this one.

Original change's description:
> Stop TextIterator from emit double newlines after H4~6 elements
>
> TextIterator currently may add two consecutive newlines after an
> H4, H5 or H6 element, while the spec of innerText doesn't have
> this case at all.
>
> This patch removes the extra newline to make TextIterator more
> spec-complicant.
>
> Note: TextIterator should eventually remove double newline emission
> also for H1~3. This patch removes it only for H4~6 to keep the
> amount of rebaselined tests small.
>
> Bug: 752672,758816
> Change-Id: I32583c194a829f52411555125e77590e36ccf838
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
> Reviewed-on: https://chromium-review.googlesource.com/661937
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501297}

TBR=yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,simonp@opera.com

Bug: 752672,758816
Change-Id: I9f6414635d257a309eca0f7f28882c7ebdc90e94
Reviewed-on: https://chromium-review.googlesource.com/664122
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501563}

This change enables pixel canvas recording by default on Chrome OS
platform. It also adds a flag in chrome://flags to toggle the feature.

Bug: 764097
Change-Id: Iae7657fc4ec1bb9a1162267476d1f2fc167f99d9
COMPONENT: Chrome OS, Compositor, UI
Reviewed-on: https://chromium-review.googlesource.com/661778
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501562}

https://skia.googlesource.com/skia.git/+log/79a3aafc34c1..adf17dc52ff4

$ git log 79a3aafc3..adf17dc52 --date=short --no-merges --format='%ad %ae %s'
2017-09-12 benjaminwagner Add new task to run the float-cast-overflow sanitizer.
2017-09-12 benjaminwagner Update omitted Bazel tests.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: Icd0ee233ba899f52d79400561d9e67925fa7bffa
Reviewed-on: https://chromium-review.googlesource.com/664307Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501561}

This reverts commit bc49021b.

Reason for revert: Caused SEGV in browser_tests and webkit_layout_tests.

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/44465
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/5207
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/32519


Original change's description:
> Invalidate partial rectangle during paint invalidation
> 
> Record partial invalidation rectangle in LayoutObject::
> InvalidatePaintRectangle(). During paint invalidation, get the rect and
> invalidate it.
> 
> This CL is for SPv1, and prepares for SPv2 partial raster invalidation.
> 
> Bug: 732612
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I65b96e47fa105258e6f677e2923c361585ecfbda
> Reviewed-on: https://chromium-review.googlesource.com/663977
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501548}

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org

Change-Id: I53140c2754ca3cf9cc29cf15f2284dc4fa39a14e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 732612
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/664321Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501560}

This patch updates the modal permission prompt ui to not show a trailing
full stop. Since we share the strings with infobar code, for now we just
remove the full stop in code.

Bug: 760360
Change-Id: I6ec4821d7e2f81df76656048bde1bb712dab32dd
Reviewed-on: https://chromium-review.googlesource.com/658169
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501559}

This reverts commit cc477ff2.

Reason for revert: ASan detected heap-use-after-free in SplitViewWindowSelectorTest.WindowGridSizeWhileDraggingWithSplitView.

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23602

Original change's description:
> splitview: Cleanup window selector unittests.
> 
> Move splitview window selector unittests to their own test class.
> 
> Bug: None
> Test: ash_unittests
> Change-Id: I8153c916a05ef9ab6011105ca670dfc0e73ee257
> Reviewed-on: https://chromium-review.googlesource.com/661327
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501487}

TBR=oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org

Change-Id: Ie609324d8a10bc3f35951d583df5c7782a03aae9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/663107Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501558}

As a follow-up to https://chromium-review.googlesource.com/658016,
this adds a layout test that makes sure module scripts are preloaded.

Bug: 740886
Change-Id: Iffa21862444d940750d03bf7cb744812cd87f4a1
Reviewed-on: https://chromium-review.googlesource.com/664498
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501557}

Only compile, 83/83 fail at the moment.

Bug: 764423
Change-Id: Ia49a9b5e119c84de651484938357ede133c56dda
Reviewed-on: https://chromium-review.googlesource.com/663603Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501556}

This is using the deprecated Speed Index. Apparently something changed that
broke us. We aren't really using this benchmark and can probably delete it
outright but let's wait until the new PWA benchmark is landed.

Bug: 763153
Change-Id: I0fe734a145e9cf20b741f128e67456aff29e956c
Reviewed-on: https://chromium-review.googlesource.com/663799Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501555}

There are no corresponding tests.

Bug: 603396
Change-Id: Iaa3b2f1219b8482e7a5bb56ab4cd7fe7604dcb78
Reviewed-on: https://chromium-review.googlesource.com/664462
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501554}

This is preparation to move some code from
chrome/browser/chromeos/arc to components/arc,
so that those moved code can refer prefs.

BUG=739097
TEST=Ran trybot.

Change-Id: I0f52e80a88c7d34b7833d86e4db97cd94eb253ba
Reviewed-on: https://chromium-review.googlesource.com/642640Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501553}

namespace is always "Event". We don't need to treat it as a variable.
This CL helps move_blink_source.py to replace "Event*Factory.h" in
EventFactory.cpp.tmpl with "event_*_factory.h".

Bug: 578345
Change-Id: Ib46b4c39549cd5e564d836fa705c4f574762d38f
Reviewed-on: https://chromium-review.googlesource.com/663800Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501552}

Bug: 745385
Change-Id: Id0dff9b0610770a8bd781ae4274cbae96f3a67cc
Reviewed-on: https://chromium-review.googlesource.com/640450Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com>
Cr-Commit-Position: refs/heads/master@{#501551}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9e197dff..17f4706e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I2e1cc4eee3dd93333203c50442965b510aabf271
Reviewed-on: https://chromium-review.googlesource.com/664260Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501550}

CHECKs proved this to be the cause of the crash in the bug. While
there are some suggested fixes in the bug that are preferable, this
patch patch simply avoids reentering PerformScrollAnchoringAdjustments
which will prevent the crash.

Bug: 745686
Change-Id: Ic2a156cb344b6b32e5aa4d5c3164421a033c757e
Reviewed-on: https://chromium-review.googlesource.com/657600Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501549}

Record partial invalidation rectangle in LayoutObject::
InvalidatePaintRectangle(). During paint invalidation, get the rect and
invalidate it.

This CL is for SPv1, and prepares for SPv2 partial raster invalidation.

Bug: 732612
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I65b96e47fa105258e6f677e2923c361585ecfbda
Reviewed-on: https://chromium-review.googlesource.com/663977Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501548}

This patch
- Deleted custom implementations of ParseSingleValue and ParseShorthand
  since all the properties handled here have been implemented in
  property APIs.
- Added default implementation to generated CSSProprtyAPI header instead
- Deleted CSSPropertyAPIBaseCustom.cpp as it was now empty.

Bug: 668012
Change-Id: Ib969064802eb2724556f1bfffc12761263d98081
Reviewed-on: https://chromium-review.googlesource.com/664457Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501547}

BUG=740063
TEST=build

Change-Id: Idbb52590a586dbc55bba52979eec8a2790d8ac60
Reviewed-on: https://chromium-review.googlesource.com/593427Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501546}

Like mojo::edk::WatcherDispatcher the map within a WatcherSet typically
only contains 2 entries and thus a base::flat_map is more appropriate
than a full std::map.

Change-Id: I7e93ea95c4037468512aa5991672779f8636f8ea
Reviewed-on: https://chromium-review.googlesource.com/664179Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501545}

[AppCache + NetworkService] Support retrieval of appcached resources for navigations that redirect to new locations.

Bug: 715632
Change-Id: I675c1ab44cf53121077f87d4beb1abf496e638a6
Reviewed-on: https://chromium-review.googlesource.com/654143Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501544}

As a workaround for M62, we were setting default context title
|display_source| for some specific notifications.
For the detailed background, see the original CL
https://crrev.com/c/662501 and the bug https://crbug.com/761900 .

As all the caller side fixes have been landed, and the workaround
is merged to M62 release branch, we can now remove this.

Caller side fix CLs:
* ARC notifications
  https://crrev.com/c/647391
  https://crrev.com/c/654119
* Sign-in error notifications
  https://crrev.com/c/648891
  https://crrev.com/c/657138
* HaTS notification https://crrev.com/c/646413
* CUPS notification https://crrev.com/c/648539

TEST=manual
BUG=none

Change-Id: Ie358b8a2070ff3870629d0b6d46e2a2b2fc9f5ba
Reviewed-on: https://chromium-review.googlesource.com/662485Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501543}

Bug: 763147
Change-Id: I208cb359494aec7c49faa1ced7586532f96b4708
Reviewed-on: https://chromium-review.googlesource.com/656757
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501542}

Fixing a regression by https://codereview.chromium.org/2952043002/.
Print Preview requires native paths to write PDF files.
I explicitly set NATIVE_PATH as the restriction for save-as dialog, and added a comment about the
Google Drive handling of Chrome OS save-as dialog as it is a bit tricky.

Bug: 761576
Change-Id: Ibabd428e26cfd0d96a1f65dadc5c0fa4b565e956
Reviewed-on: https://chromium-review.googlesource.com/662920Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501541}

This reverts commit bfe88542.

Reason for revert: Still causes MSAN to fail, theory as to why was wrong.

Original change's description:
> Reland "Scale heights of BrowserControls in compositor by DSF"
> 
> This is a reland of 030794ca
> with deviceScaleFactor obtained from global device to avoid
> MSAN problem.
> 
> Original change's description:
> > Scale heights of BrowserControls in compositor by DSF
> > 
> > Bug: 737777
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I711e05e8747850041f2c799d3b482da34e7e520d
> > Reviewed-on: https://chromium-review.googlesource.com/645906
> > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
> > Reviewed-by: Alexandre Elias <aelias@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#500841}
> 
> Bug: 737777
> Change-Id: I6a27221ce5baac8573e0f074895a657eaf21183f
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/662500
> Reviewed-by: Alexandre Elias <aelias@chromium.org>
> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501482}

TBR=aelias@chromium.org,jaebaek@chromium.org

Change-Id: Iad497cd293392108c42d7155ec2ac697f38fcccd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 737777
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/663569Reviewed-by: Alexandre Elias <aelias@chromium.org>
Commit-Queue: Alexandre Elias <aelias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501540}

Affected *.py are mainly for C++-code generators.  This will fix #include
paths in generated code.

_update_basename() replaces only basenames of checked-in files. So we
need to update V8Foo.h individually.

Bug: 578345, 760462
Change-Id: I65ebabc2d11f2a50d60bd11b9242adaffc4030c5
Reviewed-on: https://chromium-review.googlesource.com/662877
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501539}

BUG=764583
TBR=dpranke@chromium.org

Change-Id: Iecad83e72eead668d7ea06f414ebed3d55c6171e
Reviewed-on: https://chromium-review.googlesource.com/664437Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501538}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/36e9ca06..9e197dff

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I034eada40a15977b7b85540b13c943665cf1a9a7
Reviewed-on: https://chromium-review.googlesource.com/664005Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501537}

TextSuggestionMenuTest#menuDismissesWhenTappingOutside() was broken in the original CL. It
tried to send a touch directly to the WebContents view, bypassing the
SuggestionsPopupWindow. In debug builds, this caused a DCHECK from trying to add a second
active suggestion marker overlapping the first one, which was actually counted as a test
pass. In release builds, the DCHECK wasn't hit, and the menu would close very briefly and
reopen, causing a test failure.

I talked to changwan@ about if we should fix the test by sending the tap to the
SuggestionPopupWindow's content view, and he advised that since dismissing a PopupWindow
when tapping outside is built-in behavior, it's sufficient to test that calling
SuggestionsPopupWindow.dismiss() behaves properly.

This is a reland of 3fc7721d
Original change's description:
> Add support for Android SuggestionSpans
> 
> This is the final CL to add support for Android SuggestionSpans (at least ones
> not marked with FLAG_MISSPELLING; there will be one or more additional CLs to
> add support for those). This CL includes:
> 
> - Changes to ImeAdapter to make it pass SuggestionSpans into
>   InputMethodController
> 
> - Changes to InputMethodController to make it create suggestion markers from the
>   passed-in SuggestionSpans
> 
> - Additional methods in TextSuggestionController for getting the list of text
>   suggestions under the cursor, and applying a suggestion
> 
> - More Mojo code to pass information about text suggestions back-and-forth
>   between browser and renderer code
> 
> - Changes to SuggestionsPopupWindow and TextSuggestionHost so we can show either
>   a spell check or a text suggestion menu
> 
> Bug: 672259
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I3f30543586901baec4648d265874a303efafbd44
> Reviewed-on: https://chromium-review.googlesource.com/627172
> Commit-Queue: Ryan Landay <rlanday@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Alexandre Elias <aelias@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501335}

Bug: 672259
Change-Id: I4c893fc7dd74d2a31d032454385ff8e83e7c13a8
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

TBR=tedchoc@chromium.org,yosin@chromium.org,xiaochengh@chromium.org,rsesek@chromium.org,aelias@chromium.org,changwan@chromium.org

Change-Id: I4c893fc7dd74d2a31d032454385ff8e83e7c13a8
Reviewed-on: https://chromium-review.googlesource.com/664089
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501536}

Also adds a test, and a --logcat flag for better matching of logcat
lines.

Bug: 713710
Change-Id: Ie21030b3c4e68d02cfb2e0d65d2c4c4f00624a80
Reviewed-on: https://chromium-review.googlesource.com/657265Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501535}

Before this CL, in ServiceWorkerScriptURLLoader,
ServiceWorkerVersion::SetMainScriptHttpResponseInfo() is called regardless of
a resource request type. As the function name indicates, that must be called
only when the main script of the service worker is being loaded. This CL fixes
it.

Bug: 748415
Change-Id: Idcf2a295340eaa03bccd4f49b8759cf149665fa9
Reviewed-on: https://chromium-review.googlesource.com/662957
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501534}

This change can disable the feature on some environments which are
going well, but this is a simple fix to fix the build error on
"32-bit ASAN V8 ARM Builders" bots.


Bug: 760120
Change-Id: I09dc29b61118409baf7f7b538ce376574df175be
Reviewed-on: https://chromium-review.googlesource.com/662962Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501533}

Preload for <script type="module"> was disabled to prevent duplicate
loads due to credentials mode mismatch. This patch teaches the preload
scanner to set correct fetch parameters for module scripts (credentials
mode and always use UTF-8) and re-enable preload.

Change-Id: I0defc0b87681357eaccf24dd8f7a4250a0fa86f4
Reviewed-on: https://chromium-review.googlesource.com/658016
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501532}