GitLab

Records URLs of all NavigationContexts for URL whitelisting, and makes
last committed IDs available for WebState objects.

Bug: 792662
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If512086a73a893e8e0c4c49df28b4ef624764761
Reviewed-on: https://chromium-review.googlesource.com/877398
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539281}

When taking a snapshot from an SkSurface, it internally maintains a
cached copy of the SkImage which is invalidated only when the canvas
contents change. This ensures re-using cached texture uploads from this
image on subsequent uses.

However, when building a PaintImage using this SkImage we generate a
new content id for each draw, resulting in a cache miss on cc's decode
cache and re-upload with color conversion. Ensure that we use a stable
PaintImage::ContentId for the same SkImage.

R=junov@chromium.org

Bug: 814226, 814219
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie1d8ebb40ccf98593dac3e6f65ca705054e6d90b
Reviewed-on: https://chromium-review.googlesource.com/932942
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539280}

Bug:816645
Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9

TBR=sky@chromium.org

Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9
Reviewed-on: https://chromium-review.googlesource.com/938387
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539279}

This adds a histogram for tracking the PageEndReason in the
SecurityStatePageLoadMetricsObserver for pages during OnComplete (so
tracking committed page loads only), split up by the final SecurityLevel
of the page. This also adds histograms for tracking the time on page split
by final SecurityLevel, and the security level at OnCommit and at
OnComplete.

Modifies the PageEndReason enum to be explicitly numbered, and added it
to enums.xml for histogram tracking.

Adds histogram tracking to each relevant browser test for the SSPLMO,
and adds a new test for the page being reloaded.

This also changes the behavior of the SSPLMO slightly. Before, if the
SiteEngagementService did not exist, the SSPLMO would not get created.
Now, it gets created, but the SiteEngagement tracking pieces are gated
on the SiteEngagementService existing.

Bug: 803540
Change-Id: Ic368dd3cb86557f147f49a7206c9919c93ec1a3b
Reviewed-on: https://chromium-review.googlesource.com/914468
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539278}

TBR=eae@chromium.org

Bug: 816614
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Icc16b53ce783c24072901a9d1ddb658e8c54f589
Reviewed-on: https://chromium-review.googlesource.com/938401
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539277}

When using a non-lazy (bitmap) image in the GPU cache, we assume the
upload to be scaled at the mip-level required for draw, when we
actually use the original image for the upload. Fix this by considering
non-lazy scaled images as lazy generated. This also ensures we use
lower gpu memory, by caching downscaled uploads.

R=ericrk@chromium.org

Bug: 815045, 814219
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4b7d3f4edbcf0e5ba5574512f662a3fdf53cabd6
Reviewed-on: https://chromium-review.googlesource.com/935441Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539276}

R=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: Icc2d9d0fedbeb4f2c99cccd7a9120b92b3375ad9
Reviewed-on: https://chromium-review.googlesource.com/922806
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539275}

LayoutBox::ForegroundIsKnownToBeOpaqueInRect is used to compute
whether a box's background is obscured and works by recursively
checking if any child fully covers the box's background. This
logic did not consider children with css clip and a parent would
incorrectly be considered opaque even if a child was partially
transparent because of css clip.

The check for css clip (!HasAutoClip()) has been added in
IsCandidateForOpaquenessTest instead of
LayoutBox::BackgroundIsKnownToBeOpaqueInRect because css clip
applies to both foregrounds and backgrounds. A test has been added
for this tricky case (BackgroundNotObscuredWithCssClippedGrandChild).

Bug: 581441
Change-Id: Ia49627d7244920512511ed876692868cf8e81177
Reviewed-on: https://chromium-review.googlesource.com/936055Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers (OOO) <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539274}

16MB is rather large and is not great for mobile. BoringSSL by default uses a
100kB limit, which is already quite generous. Match that.

Bug: none
Change-Id: I4bf01e68dc9e60e02af373af31e5b0f68a5f29e2
Reviewed-on: https://chromium-review.googlesource.com/938123Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539273}

This CL adds a FakeKeychain implementation that stores data in memory.
This makes it easier for testing keychain logic without mocking keychain
API calls.

Bug: 811380
Change-Id: I2958c8e65eaeee61477498bb6d54ad90609ad20c
Reviewed-on: https://chromium-review.googlesource.com/931994Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539272}

Bug: 808075, 816143
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4a60a4e32218c1864a73036f08fc31d49b73c1c2
Reviewed-on: https://chromium-review.googlesource.com/927302Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539271}

Most of this CL is simply plumbing these APIs from the UrlRequest Java API to net::URLRequest.
I'm also bumping the API version number so that users have a way to identify APIs with this
support.

I'm also adding support to Cronet's Java impl.  This required moving my ThreadStatsUid class from
Cronet's native impl jar to Cronet's common impl jar (as ThreadStatsUid is now used by both the
native and Java impls).  This required some BUILD.gn changes:  In the cronet_package/ output
directory we build jars for Cronet's various impls.  Since deps of android_library's are only
pulled into android_binary's but not into the android_library's output jar, to build Cronet jars
containing all of the necessary deps so they can be used independently of Chromium's build infra we
must manually unzip dependent jars and zip them back (package them back) into jars that can then be
used independently.  Cronet previously did this for our native impl jar, but with this change I now
do this for our common impl jar as well.  I tried to make this more explicit in Cronet's BUILD.gn
file by moving these deps that should be used both for compiling the jar and repackaging the jar
into separate "_java_deps_to_package" variables to avoid duplicating them at compile and repackage
time.

I added a test for the new APIs.  Cronet tests run with StrictMode enabled to catch leaks.  This
however turned up a couple issues in my AndroidNetworkLibrary.SocketFd class:
1. In Android versions prior to Marshmallow, ParcelFileDescriptor.detachFd() didn't actually detach
   from the file descriptor and a later invocation of finalize() could inadvertently close a socket
   that might still be in use.  I fixed this by generating FileDescriptors in a different way on
   Android version prior to Marshmallow.
2. Calling SocketFd.close() didn't actually result in a call to SocketImplFd.close() as I had
   intended because Socket.close() doesn't close the SocketImpl unless it had previously been
   created.  I fixed this by avoiding the need to call close().

Bug: 520198
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib697ba6b9a9f1618ec6fedfec6004f4af7f38989
Reviewed-on: https://chromium-review.googlesource.com/930086
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539270}

https://pdfium.googlesource.com/pdfium.git/+log/9141116074f9..611431decd9a

$ git log 914111607..611431dec --date=short --no-merges --format='%ad %ae %s'
2018-02-26 thakis Fix -Wunused-variable warning if building with V8 snapshots disabled.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic32651af7414cab5a347d1d982547e483d37a011
Reviewed-on: https://chromium-review.googlesource.com/938284Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539269}

* Use isTopFrame to determine when to reset resources panel

BUG=810000

Change-Id: I8cfde733fee4e97b7066411d849a844bc58525c5
Reviewed-on: https://chromium-review.googlesource.com/934962
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539268}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f438ff743a4b..6f83031f3d0e

$ git log f438ff743..6f83031f3 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 shenghuazhang [cipd] Support cipd dependencies hooked under same directory

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I2e263dbf3e06e250f8708657def4b476e9b02907
Reviewed-on: https://chromium-review.googlesource.com/938161
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539267}

Currently we use a synchronize mojo call to push the DNS rules to
network service process in browser test.

However, this causes tests to hang on Android, that browser test in
browser process waits on utility process to create
NetworkServiceTestHelper, but the utility process also waits on browser
process to send the command lines in Java to utility through Android's
aidl call, which is blocked by sync mojo call on launcher process.

Utility process Java main thread is wait on command lines in here:
https://chromium.googlesource.com/chromium/src/+/66.0.3348.3/base/android/java/src/org/chromium/base/process_launcher/ChildProcessService.java#158

We send command line from launcher process to utility process here, this
call is dispatched through message loop and blocked by the sync call.
https://chromium.googlesource.com/chromium/src/+/66.0.3348.3/base/android/java/src/org/chromium/base/process_launcher/ChildProcessConnection.java#480

In this CL, we send the DNS rules after browser-child process
connection is established, to avoid the deadlock on Android.

Bug: 783374
Change-Id: I3f7db4eba80fd263b1d37bcaa0ddcb1d83414485
Reviewed-on: https://chromium-review.googlesource.com/923283
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539266}

TBR=elawrence@chromium.org

Change-Id: I1799dffc510505f7048d7eaec8db8e613fd3e594
Reviewed-on: https://chromium-review.googlesource.com/938144Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539265}

Storage APIs (DOM Storage, WebSQL, FileSystem, Indexed DB,
Cache Storage API) use the DatabaseIdentifier type and helper
functions as a way to map origins to pathnames on disk. Add
overloads/additional methods to allow url::Origin to be used
without converting at each call site.

Bug: 598424
Change-Id: I61d0ee9881ff563d1ea693b88e3a9ce3acdff027
Reviewed-on: https://chromium-review.googlesource.com/935295Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539264}

The mp3 bitstream is not well-formed, it's essentially just an
aggergation of raw mp3 packets. Common practice (including our
own MP3 demuxer in MSE) is to scan the input bitstream for things
that look like mp3 packets and decode only those while discarding
the rest.

ffmpeg had a bug where they did not properly discard junk from
the end of the file (despite discarding it everywhere else), this
adds a test to ensure it does not regress.

BUG=794782
TEST=new unittest

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I322e22fef3ebfa585369edb9d2c5d2ae2bb3afb4
Reviewed-on: https://chromium-review.googlesource.com/935143Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539263}

Without an OnChannelError() handler on the QuitListener, the test can
hang if the IPC channel disconnects before the Quit message is received.
Adding an explicit handler will make it easier to diagnose this failure
mode.

Also migrates DCHECK()s in some existing OnChannelError() handlers in
tests to use CHECK(), to avoid those tests potentially hanging in
Release builds.

Bug: 816606, 816620, 764015
Change-Id: Ibe6ffc7ecd02f6029c74a7b3c1190030b656056f
Reviewed-on: https://chromium-review.googlesource.com/936427Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539262}

Change-Id: I482d7704ae75d42b7ac20d58db65cb4ec81249b0
Reviewed-on: https://chromium-review.googlesource.com/937996
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539261}

Bug: 812035
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6827ab046a0e52cb37f8af6b9ee99a2c14dee652
Reviewed-on: https://chromium-review.googlesource.com/930474Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539260}

are more thoroughly vetted.



Change-Id: I4462bb8e6749f907dd6b5dc933fdbf01b62456cd
Reviewed-on: https://chromium-review.googlesource.com/935427Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539259}

https://webrtc.googlesource.com/src.git/+log/bd7b461f16b5..9f79a92e2642

$ git log bd7b461f1..9f79a92e2 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I0a3954e3a871645e4e7bbc17303651da2a652619
Reviewed-on: https://chromium-review.googlesource.com/938022
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539258}

Fuzz tests showed that this can be nullptr in case of a lost channel to gpu host.
Therefore, we should still check before using this naked ptr.

Bug: 816439
Change-Id: I38a16f10dca2a4397ed410890352c12878b172f3
TBR: dcastagna@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/937990Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539257}

Bug: 814128
Change-Id: Ib4585da0192392d4de6f3308369a23f686b1d611
Reviewed-on: https://chromium-review.googlesource.com/926127Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539256}

This reverts commit fa5503b8.

Reason for revert: Causing visual glitches on non-low-end webview (issue 816356). Also causing a larger than expected memory regression (issue 815270). Will fix and re-land.

Original change's description:
> Use glUnpremultiplyAndDitherCopyCHROMIUM in GPU Raster
> 
> This change addresses banding issues by using the newly added
> glUnpremultiplyAndDitherCopyCHROMIUM.
> 
> In cases where we previously rasterized into a RGBA4444 target, we
> instead rasterize into a temporary RGBA8888 target, then do an
> unpremultiply/dither copy into the RGBA4444 target.
> 
> This means that tiles may be either unpremultiplied or premultiplied, so
> we need a way to pipe this information to the GLRenderer so it can
> blend correctly. This change introduces a is_premultiplied property to
> ContentDrawQuadBase to handle this.
> 
> Bug: 789153
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I8bb2af2a94934ca7fe79a180d65bff253163c98c
> Reviewed-on: https://chromium-review.googlesource.com/899866
> Reviewed-by: enne <enne@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538686}

TBR=kenrb@chromium.org,enne@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 789153, 815270, 816356
Change-Id: I4faf63e575471c6830fcb5475b35870cf436c398
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/937883Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539255}

This CL changes how |sampleRate| in AudioWorkletGlobalScope is updated.

Previously, the sample rate was updated when the first processor was
created, thus accessing the sample rate in the class definition phase
gives 0 value. With this CL, the sample rate is initialized as soon
as the global scope is created, before the script is loaded/parsed.

Bug: 815313
Test: http/tests/webaudio/audio-worklet/global-sample-rate.html
Change-Id: I994ee70c10ed93618b28c7d29df42b5d458c74f8
Reviewed-on: https://chromium-review.googlesource.com/935747
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539254}

Consolidate the frame-sink registration in one place in aura (Window),
for aura. It used to be spread between aura (WindowPort*), and content
(DelegatedFrameHost), which made it tricky to follow. This then makes
it easier to move all FrameSinkId management inside the aura::Window
(from the various WindowPort implementations).

BUG=none

Change-Id: I37943eace983a31485dc6c0587d90619781b7021
Reviewed-on: https://chromium-review.googlesource.com/935490Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539253}

Previously we recorded the exact pak compression ratios in .size files.
This results in minor changes to 1k+ unrelated symbols due to changes in
compression. Use a mostly accurate static constant instead to make .size
files comparable across runs.

Bug: 814078
Change-Id: I63c78379898ef02885ae86e0b95df95d51965918
Reviewed-on: https://chromium-review.googlesource.com/938122Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539252}

external/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html
regressed after the change in bug.

TBR=jochen@chromium.org

Bug: 816556
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic8e15dbe0c629dcbb3f35859cb614525a1427683
Reviewed-on: https://chromium-review.googlesource.com/937903
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539251}

settings-toggle-button, and cr-toggle need to be migrated from 'click' to 'tap'
at the same time, otherwise calling stopPropagation() has no effect.

Bug: 815173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I847ca9892de3c108269995c10647ff16d935d8a5
Reviewed-on: https://chromium-review.googlesource.com/937904Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539250}

Using wpt-import in Chromium ff1d9bfd.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12964

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure

TBR=danyao

No-Export: true
Change-Id: Ic624f75dcffd6df1f5162c8efda1e22518fb1114
Reviewed-on: https://chromium-review.googlesource.com/937571
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539249}

This CL adds a download button for development purpose in
chrome://download-internals.

Also remove the incognito check because incognito support is work in
progress now.

Bug: 766299
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib2cbeac0f4b41d8769ee5991fb650bfa71a56938
Reviewed-on: https://chromium-review.googlesource.com/927832
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539248}

When Chrome is in the foreground, it treats onLowMemory() as
CRITICAL pressure and ignores TRIM_MEMORY_RUNNING_CRITICAL
trim level.

Turned out this is an oversight, and in fact according to UMA
RUNNING_CRITICAL is delivered 6 times more frequently than
onLowMemory(). See the bug for more details.

This CL treats RUNNING_CRITICAL trim level as CRITICAL pressure,
and adds tests.

Bug: 813909
Change-Id: I7e6d650881ed6e67b171f2cb29d593fc1b4acd3b
Reviewed-on: https://chromium-review.googlesource.com/935669Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539247}

https://chromium.googlesource.com/catapult.git/+log/766143cf63df..4607515962f8

$ git log 766143cf6..460751596 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 charliea Delete obsolete comment about BattOr perf bots

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I5ffe4cd25217055eba74ecb173c4709d5d188d79
Reviewed-on: https://chromium-review.googlesource.com/937882
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539246}

LayoutText::PositionForCaretOffset() and ::CaretOffsetForPosition() hit
DCHECK when called on LayoutWordBreak. This patch adds LayoutWordBreak
handling on them so that the functions can be called normally.

The handling simply assumes that LayoutWordBreak is fully collapsed text,
which matches the behavior in legacy layout.

No fixing to NGOffsetMapping is needed, as it already (unintentionally)
treats LayoutWordBreak as collapsed.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Bug: 811418
Change-Id: I23061a63e386e522841626fa36e3cd24e1431afc
Reviewed-on: https://chromium-review.googlesource.com/936433Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539245}

This allows BVC to intercept the animated fullscreen disabling action
for new foreground tabs.

Bug: 809120
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8b3e4865a98cde6eeb36cd8fbd6d1ec05983d5ce
Reviewed-on: https://chromium-review.googlesource.com/935442Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539244}

The bit is sent to all subframes instead of only the main frame. This is
a quick fix until a better one is found that will not break OOPIF.

This CL also de-recursify `HasBeenActivated()`

Bug: 810822
Change-Id: Ib8f494749221da5ec27f5a9b92d531de6d06a5d9
Reviewed-on: https://chromium-review.googlesource.com/934451Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539243}

select_to_speak.js was getting too messy so this moves
automation node related logic into a separate class.

Bug: 803160
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6867864f5ccefc14f4a5b98a31af5220d16f8259
Reviewed-on: https://chromium-review.googlesource.com/937802
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539242}