GitLab

Bug: 863089
Change-Id: I0e95f78799a2550aeb89b2b980b2d5cdb16142d2
Reviewed-on: https://chromium-review.googlesource.com/1156003Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579464}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/131b85f314db..aa1425d9d877


Created with:
  gclient setdep -r src-internal@aa1425d9d877

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ibc51dbd27acc16222b54021ccbd4d937f313c15a
Reviewed-on: https://chromium-review.googlesource.com/1156904Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579463}

"media/base/video_codecs.h" includes
"third_party/libaom/av1_buildflags.h" which is a generated header. This
should be a public_deps since it's included in another header file.

Change-Id: Ie9b340f5866174b0d33ea5289e9ca83aa26db3f8

Bug: 868764
Change-Id: Ie9b340f5866174b0d33ea5289e9ca83aa26db3f8
Reviewed-on: https://chromium-review.googlesource.com/1154528Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579462}

https://webrtc.googlesource.com/src.git/+log/304da796abc6..2a99c0bf6765


git log 304da796abc6..2a99c0bf6765 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 alessiob@webrtc.org Fix MovingMoments::CalculateMoments.
2018-07-31 ssilkin@webrtc.org Increase RtpFrameReferenceFinder's frame buffer length to 100 frames.
2018-07-31 buildbot@webrtc.org Roll chromium_revision fb3a9711..36ff521e (579262:579363)


Created with:
  gclient setdep -r src/third_party/webrtc@2a99c0bf6765

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:866925,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7829d349a5886e7cd5dfa9877f07e1848d09cf1f
Reviewed-on: https://chromium-review.googlesource.com/1156905Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579461}

(see the bug) From the traces the service/process creation gets posted to the
IO thread during startup.
It may be delaying startup for some other services needed for the first paint, or it may be
just eating up CPU when the load is already quite high. We'll experiment with delaying
the service launch.

Bug: 867461
Change-Id: I048e33d049e665d8e9489046c5813918d8077524
Reviewed-on: https://chromium-review.googlesource.com/1153248
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579460}

Listen to the WebContents muted state in MediaSession. If
the WebContents is muted then we should act as if the
player has no audio.

This stops muted tabs from getting audio focus.

BUG=863438

Change-Id: I8218f225cd79d8490a805d46ad4606829742dd5e
Reviewed-on: https://chromium-review.googlesource.com/1141144Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579459}

https://android.googlesource.com/platform/external/perfetto.git/+log/37a1543bfe3a..c2ace4e71f59


git log 37a1543bfe3a..c2ace4e71f59 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 michaschwab@google.com Fix All Tracks Import


Created with:
  gclient setdep -r src/third_party/perfetto@c2ace4e71f59

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I211953ded41cbd96f95649d0fd86342fe018c245
Reviewed-on: https://chromium-review.googlesource.com/1156489
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579458}

Bug: 842913
Change-Id: I834c962a21faeb53cb64acb4a4202cf7cfe0af9e
Reviewed-on: https://chromium-review.googlesource.com/1149185
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579457}

This reverts commit 77605f5e.

Reason for revert: The CL was reverted because two components
were depending on the os_crypt source_set, resulting in issues
with the component build.  I made os_crypt into a component
itself in https://chromium-review.googlesource.com/1155309,
which should fix the problem, and make the CL safe to re-land,
without modification.

Original change's description:
> Revert "NetworkContext: Always create the CookieStore and ChannelIDStore"
>
> This reverts commit 41e3c570.
>
> Reason for revert: https://crbug.com/868536 - DCHECK being hit because OSCrypt isn't set up.
>
> Original change's description:
> > NetworkContext: Always create the CookieStore and ChannelIDStore
> >
> > This CL makes NetworkContexts create CookieStores and ChannelIDStores in
> > the hybrid URLRequestContext creation path, where the embedder starts
> > configuring a URLRequestContextBuilder, and the NetworkContext finishes
> > configuring it.
> >
> > The reduces redundant code, lets us test the new path in production
> > before we ship the network service, and will allow Isolated App
> > URLRequestContexts to need less code when they're updated to use the
> > hybrid configuration path (Which I plan to do in a followup CL).
> >
> > The NetworkContext constructor that takes an already-initialized
> > URLRequestContext is not modified in this CL.
> >
> > Bug: 789644
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo
> > Change-Id: Ibf40ae6497e7be06b0a666bc664ea943e145cae9
> > Reviewed-on: https://chromium-review.googlesource.com/1152083
> > Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> > Reviewed-by: Clark DuVall <cduvall@chromium.org>
> > Commit-Queue: Matt Menke <mmenke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#578740}
>
> TBR=mmenke@chromium.org,morlovich@chromium.org,cduvall@chromium.org
>
> Change-Id: Ia9f914fac8b0fa624210363dd55333a0dfa20531
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 789644
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1153232
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578808}

TBR=mmenke@chromium.org,morlovich@chromium.org,cduvall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 789644
Change-Id: I958d52e4d3ef343b88f89f410bd009a166d00ef5
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1156664Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579456}

https://chromium.googlesource.com/catapult.git/+log/cf56f6f1be08..100f0ee2ceb7


git log cf56f6f1be08..100f0ee2ceb7 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 wangge@google.com Use `--ignore-certificate-error` if in Compatibility Mode
2018-07-31 sadrul@chromium.org tabs: Report tab-switching request delay.


Created with:
  gclient setdep -r src/third_party/catapult@100f0ee2ceb7

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866881,chromium:858944
TBR=sullivan@chromium.org

Change-Id: Icfdb76c18f63fc0451154b71e6df45b6a19a85cb
Reviewed-on: https://chromium-review.googlesource.com/1156488Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579455}

This is a reland of c31de326. The CHECK
that was triggering (crbug.com/868341) has been removed but the change
is otherwise the same. The CHECK will be readded once all of the bugs
that it reveals are fixed (crbug.com/869154)

Original change's description:
> Fix invalid handle errors found with App Verifier
>
> ChildProcessData was holding a raw ProcessHandle which meant that there
> was no guarantee that the handle would be valid when it was used. This
> change switches to a ScopedHandle on Windows, with the associated
> duplication of the handle, so that it is guaranteed to be valid. This
> fixes a frequently encountered use of an invalid handle that was
> detected by Application Verifier. This change also adds a CHECK to
> base::GetProcId to check for use of invalid handles even when not using
> Application Verifier.
>
> ChildProcessData::handle is now a private member so all references to
> it were updated to use accessors.
>
> When ChildProcessData::SetHandle is called the handle is duplicated.
> When a ChildProcessData object needs to be copied an explicit
> Duplicate function is called.
>
> An IsHandleValid helper function was added.
>
> An invalid test was removed because it was triggering the CHECK in
> base::GetProcId.
>
> Bug: 417532,821453,865805
> Change-Id: I7e38140335c0140536919341f011f144f150c88f
> Reviewed-on: https://chromium-review.googlesource.com/1145767
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578419}

Bug: 417532, 821453, 865805, 868341, 869154
Change-Id: I022982f447cce4649618f4413e960f5639ad750a
Reviewed-on: https://chromium-review.googlesource.com/1155498Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579454}

This ensures that deserialize -> serialize produces the same result as
deserialize -> serialize -> deserialize -> serialize for a particular
reproducer discovered by clusterfuzz. It was previously possible for
the first serialization to produce a different result than the second
one in the following way:

- the first deserialize would set the matrix type initially to unknown
  (in FixupMatrixPostSerialization) but then set it to the correct
  matrix type as a side effect of creating a transfer cache entry
  (see the following stack trace):

 #0  0x00000000006c9f70 in SkMatrix::getType() const () at ../../third_party/skia/include/core/SkMatrix.h:140
 #1  0x00000000006d3f3d in SkMatrix::isIdentity() const () at ../../third_party/skia/include/core/SkMatrix.h:155
 #2  0x00000000006d1031 in SkMatrix::invert(SkMatrix*) const () at ../../third_party/skia/include/core/SkMatrix.h:1152
 #3  0x0000000000a7e330 in SkGradientShader::MakeSweep(float, float, SkColor4f const*, sk_sp<SkColorSpace>, float const*, int, SkShader::TileMode, float, float, unsigned int, SkMatrix const*) () at ../../third_party/skia/src/shaders/gradients/SkGradientShader.cpp:886
 #4  0x0000000000a7e1c0 in SkGradientShader::MakeSweep(float, float, unsigned int const*, float const*, int, SkShader::TileMode, float, float, unsigned int, SkMatrix const*) () at ../../third_party/skia/src/shaders/gradients/SkGradientShader.cpp:863
 #5  0x0000000000dc2e0d in CreateSkShader() () at ../../cc/paint/paint_shader.cc:397
 #6  0x0000000000daf94d in Read() () at ../../cc/paint/paint_op_reader.cc:522

- the first serialize would write out the correct matrix type verbatim
  from the data structure

- the second deserialize would set the matrix type to unknown but would
  not end up setting it to the correct matrix type because a transfer
  cache entry exists so we follow this code path instead:

  https://cs.chromium.org/chromium/src/cc/paint/paint_op_reader.cc?l=519

- the second serialize would again write the matrix type verbatim from
  the data structure, but this time it would be unknown.

This change fixes the problem by always writing unknown.

Bug: 868966
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idfb1dcf82e652b696dde5427d9890b0ff6d9a268
Reviewed-on: https://chromium-review.googlesource.com/1156127Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579453}

OmniboxPopupContentsView squelched any queries for tooltips by returning
null from GetTooltipHandlerForPoint(). This change removes it. Doesn't
seem to make a difference, but tooltips now work for the tab switch
button and result view more generally.

Bug: 853929
Change-Id: I995af95362bca165495052444b1432ee875fc5e7
Reviewed-on: https://chromium-review.googlesource.com/1155744Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579452}

virtual/gpu/fast/canvas/canvas-blending-gradient-over-pattern.html times out on
Linux and Mac, so labeling as slow.

NOTRY=true
TBR=fserb@chromium.org

Bug: 866850,869276
Change-Id: I973034fa00e46504db0d528b72c726913a46c675
Reviewed-on: https://chromium-review.googlesource.com/1156999
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579451}

The header file is obsolete and will be deleted in webrtc cl
https://webrtc-review.googlesource.com/c/src/+/90410.

Bug: webrtc:6854
Change-Id: Ia3dff6686d8135ad54df8436f2c0125472c936bf
Reviewed-on: https://chromium-review.googlesource.com/1156388
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579450}

ResolutionNotificationControllerTest.MultipleResolutionChange.

TBR=tetsui@chromium.org,yoshiki@chromium.org,estade@chromium.org

Bug: 869401
Change-Id: Ic2cd931481cc43ac900c829f8f6b82a4e632ce63
Reviewed-on: https://chromium-review.googlesource.com/1156850Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579449}

This reverts commit f9b39463.

Reason for revert: Not meant for m70

Original change's description:
> cros: Disable views login by default
> 
> This CL is targeting only for m69.
> 
> Bug: 869411
> Change-Id: Ie0cf9c8eb0f98b53ac3e7c4fda5585185ce95b9c
> Reviewed-on: https://chromium-review.googlesource.com/1156875
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579432}

TBR=xiyuan@chromium.org,jdufault@chromium.org

Change-Id: I09b0cb12eb8d6c1e66cc7081fe66009e90be4a92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869411
Reviewed-on: https://chromium-review.googlesource.com/1156926Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579448}

Newer pylint warns when files have trailing blank lines.  Trim them.

Bug: 866772
Change-Id: I34e4325d071fde874558cee68c0460ecde5023c7
Reviewed-on: https://chromium-review.googlesource.com/1147718Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579447}

The token is required to prevent fingerprinting of receiver IDs across
profiles. It was introduced for Receiver objects sent by via Cast SDK
and is used by Cast MRP in a previous patch. This patch adds the use
of token to DIAL MRP as well.

Bug: 808720
Change-Id: I73bcad3ec361a3b48b0e97850ab4370fdd710418
Reviewed-on: https://chromium-review.googlesource.com/1155799
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579446}

BUG=869185

Change-Id: I9785566ea733c97da198251f752b33a3a9a31e57
Reviewed-on: https://chromium-review.googlesource.com/1155811Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579445}

Change-Id: I7100ad20d78b39c630edeadee1c1ea4fe2970ad4
Reviewed-on: https://chromium-review.googlesource.com/1156143Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579444}

Bug: 814906
Change-Id: I34fea3500218fee452d2c6134002cdb3aa43d071
Reviewed-on: https://chromium-review.googlesource.com/1149085Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579443}

Add a Safe Browsing Interstitial Page for Trick to Bill.

Add a Trick to Bill enum to SBThreatType and
SBInterstitialReason.

Overview CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1148598

Testing:
- SafeBrowsingBlockingPageTest.TrickToBillPage unit test

Bug: 867518
Change-Id: I0f5c342f419c2f326c7f25fa7e965d47ed242bbd
Reviewed-on: https://chromium-review.googlesource.com/1150917Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579442}

This reverts commit 68793bfa.

Reason for revert: SDK appears to make SSH connection to VM flaky.

Original change's description:
> Roll Fuchsia SDK from be1455d02b09 to 0e8488b5f1c0
>
>
> The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
> TBR=cr-fuchsia+bot@chromium.org
>
> Change-Id: Ife1784c580c2b4fb9e19f6a24fcd4111dc0e54e3
> Reviewed-on: https://chromium-review.googlesource.com/1155791
> Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#579219}

TBR=fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org

Change-Id: Ib5f8aab6e5bdf123c9c57b3c29aee1fd0e157f96
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869452
Cq-Include-Trybots: luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
Reviewed-on: https://chromium-review.googlesource.com/1155616Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579441}

Their use was removed in 6c0aed57.

BUG=829347

Change-Id: Ia5e99e49ba53cb4a416fda37407fdf5faa516f27
Reviewed-on: https://chromium-review.googlesource.com/1156845Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579440}

Remove WebContentsObserver from DisplayCutoutHostImpl

BUG=859241

Change-Id: Icd79a7ae476afe5c5b1e4a778a93b7f411d512cf
Reviewed-on: https://chromium-review.googlesource.com/1130224Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579439}

While we're here, also alphabetize the file.

Bug: none
Change-Id: If6de2987266a4a6272a0eebad5d3562cdde1c07f
Reviewed-on: https://chromium-review.googlesource.com/1156307Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579438}

In stable since M65.

Bug: 657748
Change-Id: I25bd7ae44e3084b3a198eff6bad811118a460d52
Reviewed-on: https://chromium-review.googlesource.com/1156548
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579437}

The Bluetooth stack will drop a Connect request while there is a
Connect request pending. The request's callback is never called.

This CL queues concurrent Connect requests to avoid this issue.

Bug: internal 111887604
Test: cast_bluetooth_unittests
      Try concurrent Connect requests, second request returned
      successfully.

Change-Id: I187330f94f75c643c896549d49f8e00a7ff3e195
Reviewed-on: https://chromium-review.googlesource.com/1155998Reviewed-by: Bailey Forrest <bcf@chromium.org>
Commit-Queue: Tiansong Cui <tiansong@google.com>
Cr-Commit-Position: refs/heads/master@{#579436}

Having the response allows the caller to do things like examine the
rcode (which may provide more information about the failure).

Bug: 142918, 506227
Change-Id: I0fb562542ac866d12ad2a8887d8c15c8c8e92a01
Reviewed-on: https://chromium-review.googlesource.com/1152925Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Rob Percival <robpercival@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579435}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/45880cd3..e8e10fdf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I14dbcfd8107ebcb2e5a06fe893bb70de8c9e0a06
Reviewed-on: https://chromium-review.googlesource.com/1156479Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579434}

SafeBrowsingContextImpl is ref counted, and its first reference used to
be made in its constructor through base::Bind. The reference is passed
to the IO thread, and released when the task is destroyed.
However, if PostTask failed or the posted task ran soon even before the
constructor has finished, the SafeBrowsingContextImpl instance may be
destroyed before the construction has completed.

Though the SafeBrowsingContextImpl case is safe, even if
`new SafeBrowsingContextImpl` returns a stale pointer, this hits an
sanity check that is being added to base::Bind.

This CL moves the PostTask() out of the constructor, and holds an
reference to the instance while base::Bind is called to avoid the
check failure.

Bug: 866456
Change-Id: Iee58de1e4cd807ff858985f9831e48f4a903bbd4
Reviewed-on: https://chromium-review.googlesource.com/1156332Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579433}

This CL is targeting only for m69.

Bug: 869411
Change-Id: Ie0cf9c8eb0f98b53ac3e7c4fda5585185ce95b9c
Reviewed-on: https://chromium-review.googlesource.com/1156875Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579432}

This patch fixes an issue with the scrim that would cause it to become
invisible if re-shown while hiding. The onAnimationEnd event would
remove the scrim from the tree when it was still needed. This is
resolved by making the animator listener one that is cancel-aware. The
scrim is not removed from the tree if the animation is canceled (if
the animation should end early, the #end() method should be called
instead).

Bug: 865109
Change-Id: I5a83bc486a2798ddca8dca4fefc6a0a340fa1613
Reviewed-on: https://chromium-review.googlesource.com/1156482Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579431}

BUG=chromium:861998
TEST=manual

Change-Id: Icd98a6c5c0d94c7adbb57a3d104b633440b38f09
Reviewed-on: https://chromium-review.googlesource.com/1156394Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579430}

In LayoutNG computing the border outsets turned out to be more expensive
than expected. Change NGBoxFragmentPainter to compute it lazily instead.

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I623e0f3a0fd62ee853843ba31e8e4075c0599938
Reviewed-on: https://chromium-review.googlesource.com/1153302Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579429}

https://chromium.googlesource.com/angle/angle.git/+log/67c388e6c04e..2eb65034db71


git log 67c388e6c04e..2eb65034db71 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 jmadill@chromium.org Add Context::getActiveBufferedAttribsMask.


Created with:
  gclient setdep -r src/third_party/angle@2eb65034db71

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Iae6c8a8f145d787f98512ee6c8311047f987fa91
Reviewed-on: https://chromium-review.googlesource.com/1156744Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579428}

GetLatestInFlightSurface will return null if fallback surface doesn't
exists which might happen after garbage collection, hence causing
jittering when resizing.
This CL refactor SurfaceManager::GetLatestInFlightSurface to return a
surface in the case when fallback is non-existent.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib95b4ca3f8819b668022fd9b6942304b07cef340
Bug: 868447
Reviewed-on: https://chromium-review.googlesource.com/1153088Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#579427}

This is needed for supporting profiling and code coverage reporting on
ChromeOS and Android.

Bug: 843356,865376
Change-Id: I36836a7876c5e9230b33594362ac029bc1670c86
Reviewed-on: https://chromium-review.googlesource.com/1153653Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579426}

The FakeServer used in many tests runs on the UI thread (which is very
questionable, but hard to change).

FakeServerHttpPostProvider::MakeSynchronousPost (running on the Sync
thread) posts to the UI thread and waits for a response.
ProfileSyncService::Shutdown (running on the UI thread) waits for the
Sync thread to stop.
If these two events intersect, we get a deadlock between the UI thread
and the Sync thread.

As a workaround, this CL adds a timeout to MakeSynchronousPost.

This was exposed by https://crrev.com/c/1148392, but the problem really
existed all along.

Bug: 856179
Change-Id: I099953f1231fadd4ad4cb845daabfd055e9ab5a2
Reviewed-on: https://chromium-review.googlesource.com/1156587
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579425}