GitLab

Eliminate separate boolean tracking socket writeability in
QuicConnection; query the writer instead. This CL tries to minimize
behavior changes, so no actual bugfixes. Connection will now check
writer's status instead of its local flag, so it will refuse to
write sooner.

Merge internal change: 59603011
https://codereview.chromium.org/138843003/


Change QUIC's SendAlgorithmInterface to have a separate UpdateRtt
method instead of passing it in with every acked packet.

This fixes a bug where the RTT was not being updated when
retransmitted packets were acked and one where a very large RTT could
be used when packets are acked before being sent.

Merge internal change: 59572874
https://codereview.chromium.org/138843003/

Break out of the loop in QuicSession::OnCanWrite if the QuicConnection
is congestion control blocked.  This fixes a weird form of starvation
among same-priority streams caused by streams often ending up in the
same order in the WriteBlockedList before and after
QuicSession::OnCanWrite.

Stop iterating through QUIC write blocked streams if the connection is
congestion-control blocked to avoid starvation of same-priority
streams.  Not flag protected.

Merge internal change: 59513911
https://codereview.chromium.org/139103002/


Fix a bug where the packet was put into unacked packets when it was
serialized and acked before being sent.

This was only ever seen on Chrome with very short RTTs.

Merge internal change: 59408566
https://codereview.chromium.org/133683010/


WriteBlockedList for QUIC that prioritizes Crypto and Headers streams
over data streams. Not flag protected.

Merge internal change: 59400238
https://codereview.chromium.org/137893008/


Create an interface for explicit notification of Dispatcher about
blocked writers; port TimeWaitListManager to the new interface.

Merge internal change: 59396227
https://codereview.chromium.org/138503006/


Remove WritePacket() from internal server's QuicDispatcher;
Integrating internal changes to clean up QuicDispatcher.

Merge internal change: 59346874
https://codereview.chromium.org/131743007/


Reset QUIC's retransmission counters whenever a new packet is acked
which updates the RTT estimate.

Previously the counters were only done when the left edge was acked,
which could cause excessive backoff when the connection was making
progress.

Merge internal change: 59292726
https://codereview.chromium.org/138273004/


Implement QuicPacketWriterWrapper. This lets us replace or embellish
the low-level writer without disturbing connections that keep a
pointer to the top level.

Merge internal change: 59287995
https://codereview.chromium.org/138273004/


Use basictypes.h consistenly in QUIC code instead of macros.h and/or
integral_types.h

Simply refactoring includes. Sync'ed with internal source code
for include of basictypes.h.

Merge internal change: 59287325
https://codereview.chromium.org/136853005/


Use the right priority when marking QUIC streams write blocked via
QuicFdWrapper::SetReady.  Not flag protected.

Used NULL instead of nullptr.

Fixed QuicReliableClientStreamTests to pass. Activated the
QuicReliableClientStream in the QuicSession so that session's
MarkWriteBlocked knows about the stream.

Merge internal change: 59263642
https://codereview.chromium.org/136523005/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/131743009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245204 0039d316-1c4b-4281-b951-d872f2087c98

This is a short term fix for a crash due to gfx::Screen access after ash shutdown, to be merged to 33.

Better fix is https://codereview.chromium.org/138003007/ but it's too large, risky to merge.

BUG=334585
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/130483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245203 0039d316-1c4b-4281-b951-d872f2087c98

This CL is the equivalent of CL 136573002 for enrollment: It ensures that
when a user authenticates via SAML during enrollment, that user's e-mail
address is used to enroll the device.

BUG=332132
TEST=Manual

Review URL: https://codereview.chromium.org/130303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245202 0039d316-1c4b-4281-b951-d872f2087c98

Align ashmem region sizes to page size after ashmem creation failed.                                                                                                                                                                                                                                                           

When ashmem creation failed the new size (twice smaller) used to retry wasn't
page-aligned.

This also moves the page alignment function to the allocator's anonymous
namespace since it's now an implementation detail (since the allocator is
always used).

BUG=331832

Review URL: https://codereview.chromium.org/136723005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245201 0039d316-1c4b-4281-b951-d872f2087c98

A 'click' event can't be handle an activation by keyboard.

BUG=329166
TEST=manually tested

Review URL: https://codereview.chromium.org/128023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245200 0039d316-1c4b-4281-b951-d872f2087c98

Currently -[AppController applicationDidFinishLaunching:] and
-[AppController windowLayeringDidChange:] can trigger a synchronous load
of the last used _browser_ profile, even when no browsers are being
opened, and that profile is not required. This causes delays when the
app launcher or app shims are launched for a profile that doesn't match
the last used browser profile, because both profiles must be loaded and
initialized.

This change moves ChromeBrowserMain's GetStartupProfilePath() from an
anonymous namespace to startup_browser_creator.h so that AppController
can share the logic that determines the profile loaded when the browser
process starts up.

The shim process is tweaked slightly to ensure it passes
`--show-app-list` for the app launcher shim, similar to the Windows app
launcher. This allows a newly created browser process to determine that
the first thing it will be doing is showing a launcher.

BUG=178260, 262848

Review URL: https://codereview.chromium.org/127343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245199 0039d316-1c4b-4281-b951-d872f2087c98

Firefox 21 changed the directory layout within Firefox.app.
Some libs and content were moved from Firefox.app/Content/MacOS to
Firefox.app/Content/MacOS/browser, and this new location was
read as app_path_ by the importer. However, libnss3.dylib is still
in Firefox.app/Content/MacOS.

Changing utils to set app_path_ based on compatibility.ini's
LastPlatformDir (which always has Firefox.app/Content/MacOS)
instead of LastAppDir (which was changed to
Firefox.app/Content/MacOS/browser).

'searchplugins' subdir was moved into the new 'browser' subdir
so search engine importing code has to be adjusted.

Enabling Firefox importer browser tests on Mac. They didn't
work because they attempted to use Windows nss libraries. 
They should have been using Mac-specific libraries which are 
already available for Mac unit tests.

BUG=321112, 48007

Review URL: https://codereview.chromium.org/117123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245198 0039d316-1c4b-4281-b951-d872f2087c98

1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds)
2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048

Review URL: https://codereview.chromium.org/109483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245197 0039d316-1c4b-4281-b951-d872f2087c98

> Add the UI compositor to the Mac build
> 
> Move the bulk of the files in content/browser/aura to
> content/browser/compositor, since they're not aura-specific.
> 
> Build all of those files in the Mac build, and add ui/compositor
> to the dependencies of the Mac build. These files will soon only
> be excluded from the Android build.
> 
> BUG=314190
> 
> Review URL: https://codereview.chromium.org/137893007

TBR=ccameron@chromium.org
BUG=335083

Review URL: https://codereview.chromium.org/137853019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245195 0039d316-1c4b-4281-b951-d872f2087c98

This broke the wtf_unittests when compiling with gcc:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/16904

TBR=cevans@chromium.org, thestig@chromium.org
BUG=

Review URL: https://codereview.chromium.org/139153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245194 0039d316-1c4b-4281-b951-d872f2087c98

Seems to be causing lots of layout test failures on Win7

> Don't set the scroll styles (WS_VSCROLL and WS_HSCROLL) for WS_POPUP windows.
> 
> This causes issues with select boxes on Windows 7 where hovering at the end of the window returns the scroll WM_NCHITTEST
> codes. Works fine on Windows 8. In any case we don't want the scrolling styles set on windows other than the main Chrome window
> which is the only window which should be receive mousewheel messages.
> 
> I moved the scroll style setting code from the HWNDMessageHandler::OnCreate function to HWNDMessageHandler::Init function as that
> would prevent the initial WM_SIZE message from hiding the scrollbar. The other change is to hide the scrollbars and readd the
> scroll styles if we are sizing the window, when the sizing completes. Basically when we receive the WM_EXITSIZEMOVE message.
> For normal sizing operations we continue to do this in WM_SIZE as before.
> 
> From testing on my thinkpad with Win7, desktop with Win7 and Win8 this works well.
> 
> BUG=334454,334541
> R=sky@chromium.org, sky
> 
> Review URL: https://codereview.chromium.org/137403008

TBR=ananta@chromium.org

Review URL: https://codereview.chromium.org/137443018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245191 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245188 0039d316-1c4b-4281-b951-d872f2087c98

Causing 'check_license' failure on 'Linux' builder
http://build.chromium.org/p/chromium/builders/Linux/builds/46649

> Add libwebm in third_party.
> 
> libwebm will be used by chromoting client to generate WebM stream for
> MediaSource API.
> 
> BUG=321825
> 
> Review URL: https://codereview.chromium.org/134643003

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/139993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245187 0039d316-1c4b-4281-b951-d872f2087c98

This flag flip accidentally shows the UI in Windows
but it should not.

> Flag-flip of app-list-voice-search. Now it's on by default.
> 
> BUG=333914
> R=xiyuan@chromium.org
> TEST=manually
> 
> Review URL: https://codereview.chromium.org/139293007

TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/139293012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245184 0039d316-1c4b-4281-b951-d872f2087c98

* Refactor code in preparation for safe math operations.
* Support float type for numeric casts.
* Expose IsValueInRangeForNumericType as part of the API.
* Add saturated_cast.

BUG=332611
R=akalin@chromium.org, willchan@chromium.org

Review URL: https://codereview.chromium.org/131063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333919

Review URL: https://codereview.chromium.org/139553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334319
NOTRY=True

Review URL: https://codereview.chromium.org/138873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245181 0039d316-1c4b-4281-b951-d872f2087c98

The EME event names in Blink have been renamed, so update the calls to use the new names.

BUG=224786

Review URL: https://codereview.chromium.org/138753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245180 0039d316-1c4b-4281-b951-d872f2087c98

This gives back original behavior, making Layer and Window reset
bounds when RecreateLayer is invoked.

BUG=328062
TEST=covered by test now
R=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/139463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331588

Review URL: https://codereview.chromium.org/138743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245178 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/138723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245177 0039d316-1c4b-4281-b951-d872f2087c98

Previously NaCl targets were using _untrusted suffix which makes the
purpose of these targets hard to understand. This CL renames some targets in src/third_party.

Also removed toolsets field from modp_b64_nacl.gyp

Review URL: https://codereview.chromium.org/138673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333441

Review URL: https://codereview.chromium.org/138653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245175 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333309

Review URL: https://codereview.chromium.org/138613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245174 0039d316-1c4b-4281-b951-d872f2087c98

When the user request sync events dump on the sync_internals page,
he can check a box to say if he wants to dump also the node content.
If he doesn't check it, then the node is not stringyfied and it returns
a "[Object object]" message.

This changes this behaviour and replaces the message with a "REDACTED",
that looks better on the .csv file and makes it clear that the user
requested this option, insted of being a stringyfier or any other bug.

BUG=333365

Review URL: https://codereview.chromium.org/138563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245173 0039d316-1c4b-4281-b951-d872f2087c98

Define gcc_toolchain and variables cc, cxx, ar, ld, toolchain_cpu_arch and
toolchain_os for MIPS Linux build of Chromium.

BUG= gclient runhooks fails for MIPS-Linux
TEST= build Chromium for MIPS-Linux

Review URL: https://codereview.chromium.org/138483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245172 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a larger effort to remove unnecessary subclass of pixelref from chrome/blink, to allow for faster evolution/iteration of bitmap/pixelref development in skia.

BUG=

Review URL: https://codereview.chromium.org/138473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245171 0039d316-1c4b-4281-b951-d872f2087c98

A fix for the bidi leak was committed as blink r164996 thus the
suppressions are no longer needed.

R=thakis@chromium.org
BUG=333572

Review URL: https://codereview.chromium.org/138453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496
NOTRY=true
R=sky@chromium.org,avi@chromium.org

Review URL: https://codereview.chromium.org/138363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245169 0039d316-1c4b-4281-b951-d872f2087c98

The capitalization on two of the histograms were wrong, and
it was missing a TimeOnline value.

R=isherman@chromium.org
BUG=209709
TEST=Start chrome, and browse to chrome://histograms to make sure
these enums now exist after starting a VPN connection.

Review URL: https://codereview.chromium.org/138343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245168 0039d316-1c4b-4281-b951-d872f2087c98

Adding a LaunchApp command to Chromedriver using the Chrome management API in the background extension, this will give developers an improved way to launch apps over having to navigate to the chrome://apps page and click on the app tile.

BUG=

Review URL: https://codereview.chromium.org/114403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334278

Review URL: https://codereview.chromium.org/138413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245166 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
R=erg@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/138343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245165 0039d316-1c4b-4281-b951-d872f2087c98

Previously no API is provided to report drive sync errors to JavaScript side.
This CL adds the API and colllecs erros by using OperationObserver.

BUG=260510

Review URL: https://codereview.chromium.org/137903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334461
R=xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/138273006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245163 0039d316-1c4b-4281-b951-d872f2087c98

Create HpackEncodingContext, HpackHeaderTable, and HpackEntry classes,
which are based on the draft
http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-04 .

Implement some basic tests.

This implementation is based on
https://github.com/akalin-chromium/httpbis-header-compression and
https://codereview.chromium.org/22074002/ (which was based on an
earlier draft).

This lands server change 55803359 by akalin.

R=akalin@chromium.org

Review URL: https://codereview.chromium.org/138243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245162 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/332504

R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245010

Review URL: https://codereview.chromium.org/138223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496
R=ananta@chromium.org,finnur@chromium.org

Review URL: https://codereview.chromium.org/138213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245160 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334878

TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/138143013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245159 0039d316-1c4b-4281-b951-d872f2087c98

Set the debug app for user build devices programatically.
This allows running some telemetry benchmarks without any intervention.

BUG=334007
TEST=tools/perf/run_benchmark -vvvv --browser=android-chrome --show-stdout octane

Review URL: https://codereview.chromium.org/138093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245158 0039d316-1c4b-4281-b951-d872f2087c98