- 18 Jul, 2018 40 commits
-
-
Orsi Batiz authored
Changing src attribute of HTMLMediaElement from DOMString to URLString Adding SetSrc to html_media_element.cc which takes USVStringOrTrustedURL as argument Added tests Bug: 739170 Change-Id: Ifde2c90add06cb7ba55596e3cbc06fb160ee2378 Reviewed-on: https://chromium-review.googlesource.com/1141737 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#576045}
-
Matthew Cary authored
These benchmarks will be used to train the new production android orderfile. This is a reland of crrev.com/c/1124561 which was reverted due to presubmit errors which have been fixed. Bug: 843561 Change-Id: Id200a5957d20d19dc7fe83555c04aa9cecf51f27 Reviewed-on: https://chromium-review.googlesource.com/1125842Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#576044}
-
Devlin Cronin authored
Bug: 840412 Change-Id: I3da214023c2e896266e171cb153d367c43d6b2ba Reviewed-on: https://chromium-review.googlesource.com/1141069 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576043}
-
Ian Clelland authored
This reverts commit 4c9cbfb5. Sorry for the revert -- this is failing on one of the ChromeOS builders: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/7968 You can see several failed tests in this log output: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940668796232357776/+/steps/interactive_ui_tests/0/logs/All__x2f_PasswordManagerBrowserTestWithConditionalPopupViews.AutofillLoginSignupForm__x2f_1/0 Original change's description: > [Android] Change suggestions based on frame of focused field > > With this CL, the renderer notifies the password accessory controller > when the focus moves to or away from valid input fields. > > Bug: 854152, 854150, 854149, 853742 > Change-Id: I63f075ce238db8b77c784e945eea8ec83d8d4344 > Reviewed-on: https://chromium-review.googlesource.com/1124466 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575977} TBR=vasilii@chromium.org,dvadym@chromium.org,piman@chromium.org,fhorschig@chromium.org,mkwst@chromium.org Change-Id: I01cc79e8dc98e29cbdb1a61c6da5a4cf021fcbfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854152, 854150, 854149, 853742 Reviewed-on: https://chromium-review.googlesource.com/1141825Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#576042}
-
Tiger Oakes authored
Continuation of work in bug 646094. Preparing to activate an errorprone check to flag context#getApplicationContext calls. The goal is to prevent storing the resulting context as a class property, and instead use ContextUtils. Bug: 846456 Change-Id: I23cfa6b2d02b77f056d16ea447b6a6528c2143ce Reviewed-on: https://chromium-review.googlesource.com/1096005Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#576041}
-
Allen Bauer authored
TBR=estade@chromium.org Bug: 863117 Change-Id: Ie131dfdbc7620b8ce8f14948224089ac9ffa15bb Reviewed-on: https://chromium-review.googlesource.com/1138642Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#576040}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c428ea5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21539 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, scottmg@chromium.org: external/wpt/domxpath mkwst@chromium.org: external/wpt/x-frame-options TBR=foolip No-Export: true Change-Id: Ie38ce374b93e56af9b92fe01cf6d631b37bd8e93 Reviewed-on: https://chromium-review.googlesource.com/1141656 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576039}
-
Anita Woodruff authored
This CL has two effects when notifications are disabled for Chrome: 1. Adds a link to 'Turn on permissions for Chrome' to the site settings of websites that have allowed/blocked notifications. 2. Replaces Settings > Site Settings > Notifications page with a link to 'Turn on permission for Chrome in Android Settings'. See screenshots at https://goo.gl/hVqEwN These effects are guarded behind a flag in about://flags ('Enable app notification status messaging'). Bug: 691898 Change-Id: Ib7b59905cfc4edcc2a80cd6aad45700714502abc Reviewed-on: https://chromium-review.googlesource.com/1140633Reviewed-by:
-
Maja Kabus authored
helper.js changed to helper.sub.js. URLS.safe modified to work with wpt. Bug: 739170 Change-Id: I89e0efdb07c94e78be826c8807d0577ede8a97ec Reviewed-on: https://chromium-review.googlesource.com/1141725Reviewed-by:
-
Christos Froussios authored
When showing the manual fallbacks, we create a PasswordFormManager and pass it to the UI. Previously, this was done by creating a provisional save manager and moving it, but if we failed to move it, it would remain and signal that a submission in the previous navigation. I've refactored the showing of the manual fallbacks to have no side effects on |provisional_save_manager|. Bug: 859156 Change-Id: Iaf41b201bc6c812f483fdb355f8414a77b0a034f Reviewed-on: https://chromium-review.googlesource.com/1138322 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#576036}
-
Daniel Bratell authored
Chromecast wants to scroll exactly like Android and for that the code cloned the mobile scrolling code, but simpler and easier and with less code and fewer jumbo compilation errors is to just use the existing code directly. Only a minor code difference existed and that is controlled with a conditional statement instead now. Bug: 813911 Change-Id: I9d037da9b58c1ad0916dc22ee194328c113075cd Reviewed-on: https://chromium-review.googlesource.com/1136541Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#576035}
-
vitaliii authored
Bug: 840357,850428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I21266676a5e097dac3d7cc75dbff8b65a2ce9d1e Reviewed-on: https://chromium-review.googlesource.com/1141724 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576034}
-
yoshiki iguchi authored
- Adds Rounded corner mask to NativeViewHost of ARC notification - Makes corners of ARC notification background rounded Bug: 847784 Test: Manual (see ARC notification and confirm it has rounded corners) Change-Id: I859f1cbe0ee410fd4852d5b162c43670f6d541f7 Reviewed-on: https://chromium-review.googlesource.com/1100355 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#576033}
-
stkhapugin@chromium.org authored
- Reenable tests that rely on the share menu. - Fix -openShareMenu test helper - Fix location bar's trailing button accessibility: now it's correctly updated when it's switched between voice search and share. Bug: 849932, 835871 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I01101fb34ce57464e2722a753e5e3ad9c71bbd3f Reviewed-on: https://chromium-review.googlesource.com/1140161 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#576032}
-
Christian Dullweber authored
euckr-decode-ksc_5601.html is failing on WebKit Mac10.13. https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20(retina)/36 Tbr: jsbell@chromium.org Bug: 864994 Change-Id: I5773da2363a7d4b3a9bf85b307fd6ab4b0e7790f Reviewed-on: https://chromium-review.googlesource.com/1141875 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576031}
-
Farah Charab authored
Use the map passed in the parameters of the resource fetch priority finch study to schedule resource loading tasks on Blink. Bug: 860545 Change-Id: I156afc89a347cc26816070679d2a8a568217720a Reviewed-on: https://chromium-review.googlesource.com/1140155Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576030}
-
Christian Dullweber authored
fast/dom/Window/window-focus-self.html is failing on Windows. https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/38018 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/38017 Tbr: kochi@chromium.org Bug: 816766, 863067 Change-Id: Ie54d5722b6c9c76d548d43a190ab827f051cdeb9 Reviewed-on: https://chromium-review.googlesource.com/1141869 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Danyao Wang authored
This is causing crashes in M68. From code inspection, everywhere NavigationContext is created, a navigation item unique ID is set. So the only other possibility is somewhere between when the context is created and |webView:didFinishNavigation|, the pending item associated with the context disappeared. Not updating the error retry state in this case is not detrimental. It only affects use cases when network error is to be displayed, which is a small fraction of all page loads. Bug: 851969,854752 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I71f911e402ccc002b0bfd8c2ef6686926b73d147 Reviewed-on: https://chromium-review.googlesource.com/1141134Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#576028}
-
Moe Ahmadi authored
1) Removes the logic to bring the most recently used suggestion to the front of the list for consistency with other platforms. 2) Keeps the GPay logo as the first suggestion when "Clear Form" is moved the front of the list. Bug: 852529 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f214078f2a64507a0c326665d5dce9a2f35d7f4 Reviewed-on: https://chromium-review.googlesource.com/1140900Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576027}
-
gogerald authored
Bug: 863974 Change-Id: Idfeae3e29ff93b0897e822035d2f35282b6c8ca1 Reviewed-on: https://chromium-review.googlesource.com/1141046 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#576026}
-
vitaliii authored
Temporarily move consent_auditor_factory.{h,cc} to ios/chrome/browser/sync. Otherwise I cannot wire ControllerDelegateOnUIThread for USER_CONSENTS in ios_chrome_sync_client, because consent_auditor_factory depends on UserEventService, which is located in sync folder (i.e. this leads to BUILD.gn cycle). The plan is to move it back once it does not depend on UserEventService anymore (i.e. USER_CONSENTS are completely launched). Bug: 840357,850428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2157e913ee6d6d3adde86b3121fdb021aed3614c Reviewed-on: https://chromium-review.googlesource.com/1141583Reviewed-by:Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576025}
-
Oriol Brufau authored
They are implemented behind the CSSLogical runtime flag. Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ Spec: https://drafts.csswg.org/css-logical/#inset-properties BUG=850004 TEST=external/wpt/css/css-logical/logical-box-inset.html The test still has some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: I296bf83bb7200f1215b7f088284d34c6c69259c9 Reviewed-on: https://chromium-review.googlesource.com/1138620Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#576024}
-
Mohamed Amir Yosef authored
This CL implements the following: 1. Committing local bookmark deletions. 2. Adjust a browser test in /single_client_bookmarks_sync_test.cc to remove the requirement of merge logic in the case of USS. This change should be rolled back upon implementing USS merge logic. Bug: 516866 Change-Id: I98ed87de7e1124dc535290a4f47faf21f1691668 Reviewed-on: https://chromium-review.googlesource.com/1127170 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
This CL is implementation of overriding of prefilled values in username fields if the server believes that these values are placeholders. The life of server prediction for filling prefilled values is the following (it's called may_use_prefilled_placeholder in code): 1. The server sends it and it's propagated as part of FormStructure to FormParser (it's implemented before this CL). 2. It's parsed in password_field_prediction.cc to PasswordFieldPrediction 3. FormParser puts it to PasswordForm. 4. In password_form_fill_data.cc it's propagated to PasswordFormFillData 5. It's sent to the renderer over MOJO 6. PasswordAutofillAgent uses it to override prefilled values if any. The reason of putting processing may_use_prefilled_placeholder in FormParser not in NewPasswordFormManager is that NewPasswordFormManager should know nothing about form structure, it's FormParser responsibility to process it. Small deletion of dead code is done: parameter |set_selection| from FillUserNameAndPassword, since it's never set to true. Initial CL: https://chromium-review.googlesource.com/c/chromium/src/+/1124474 TBR=mkwst@chromium.org Bug: 847793, 831123 Change-Id: I5f9a98d755400b2ab9706d27578764a0b46b3f86 Reviewed-on: https://chromium-review.googlesource.com/1140321Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Koji Ishii authored
2nd review following the same criteria as before; the images match, or less, by reviewing build 8068. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6da3c540b87a0d30974d6f825f23c026a03a0486 Reviewed-on: https://chromium-review.googlesource.com/1141755 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576021}
-
Jérôme Lebel authored
Fix for crrev.com/c/1138621. Opening the account settings was missing from the patch. This test runs on iPad without Bijou UI. See: https://chromium-review.googlesource.com/c/chromium/src/+/1138621/15/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm#b447 TBR: rohitrao@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I42668af76d53475667ac4ec8a02859fa834132fb Reviewed-on: https://chromium-review.googlesource.com/1141573 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576020}
-
Hirokazu Honda authored
This adds the checker that the number of Decode()s in flight is less than or equal to the requested number. In addition, by this change, (1) if a decoder is deleted, doesn't execute DecodeNextFragment() and doesn't check the number of Decode()s, (2) doesn't DecodeNextFragment() in NotifyResetDone() caused by MID_STREAM_RESET or RESET_AFTER_FIRST_CONFIG_INFO, because requested number Decode()s are being executed. BUG=chromium:834170 TEST=VDA unittest at kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icdb94ff57b824690cf8346e7d9c6889ba57ae0d3 Reviewed-on: https://chromium-review.googlesource.com/1130970Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#576019}
-
Ramya Nagarajan authored
This addresses the issue where a previously signed-in user logs out, but their album info is not cleared due to the auth error. Bug: 864011 Change-Id: I2935d5428367a6d18fff5889a6f3c424b50f9983 Reviewed-on: https://chromium-review.googlesource.com/1139900 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Wez authored
Sync2Ptr was a temporary type, used during migration of SyncPtr APIs from returning |bool| to |zx_status_t|, to remove risk of implicit conversions to |bool|. Some libzx call-sites (e.g. use of zx::process::self()) are also updated to be compatible with changes in the latest Fuchsia SDK. TBR: dcheng, jochen Change-Id: I9e9350931e18f2bddc0ef7234d225821cf7d22f1 Reviewed-on: https://chromium-review.googlesource.com/1141659 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#576017}
-
kristipark authored
Before: https://screenshot.googleplex.com/uaoCMDztv5s.png After: https://screenshot.googleplex.com/zZnYTUShvnX.png Bug: 863452 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I41986b5288daa1c68135b9ca6fb6828c4cd444a9 Reviewed-on: https://chromium-review.googlesource.com/1141223 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Chris Hamilton authored
This allows session restored tabs to persist their time since last use across sessions, allowing them to be appropriately prioritized. BUG=800885 Change-Id: Ic578b93b418d07d83b47b9ae4e9ea561800f9fcc Reviewed-on: https://chromium-review.googlesource.com/1140785 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#576015}
-
yoshiki iguchi authored
This CL adds a metrics of - Scroll by touch on message center - Scroll by arrow key on message center - Scroll by mouse wheel on message center Bug: 854470 Test: None Change-Id: I11cad33ceaa192ee0afe3e6712632181ba055be0 Reviewed-on: https://chromium-review.googlesource.com/1120089 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Ned Nguyen authored
This reverts commit f53c3ea9. Reason for revert: break media_perftest (crbug.com/864942) Now I look at the code, I also have concerns about the approach of the CL. Please discuss with me on the approach to implement the feature. Original change's description: > Reland #3 of "gtest perf tests: Output well formed test results json" > > This reverts commit 3cf9eadf. > > Reason for revert: Will fix errors > > Original change's description: > > Revert "Reland "Reland "gtest perf tests: Output well formed test results json""" > > > > This reverts commit 4da4a0c8. > > > > Reason for revert: Failing on mac and windows. I will add more comments to crbug.com/855234 > > > > Original change's description: > > > Reland "Reland "gtest perf tests: Output well formed test results json"" > > > > > > This reverts commit 89c5e790. > > > > > > Reason for revert: Testing possible fixes > > > > > > Original change's description: > > > > Revert "Reland "gtest perf tests: Output well formed test results json"" > > > > > > > > This reverts commit f02c92e1. > > > > > > > > Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315 > > > > > > > > Original change's description: > > > > > Reland "gtest perf tests: Output well formed test results json" > > > > > > > > > > This reverts commit 9eeaba4e. > > > > > > > > > > Reason for revert: Will re-land with fix > > > > > > > > > > Original change's description: > > > > > > Revert "gtest perf tests: Output well formed test results json" > > > > > > > > > > > > This reverts commit 71b865f4. > > > > > > > > > > > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307) > > > > > > > > > > > > Original change's description: > > > > > > > gtest perf tests: Output well formed test results json > > > > > > > > > > > > > > This CL changes the run_gtest_perf_test.py script to output well formed > > > > > > > test results json. > > > > > > > > > > > > > > Bug: 855234 > > > > > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 > > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1112635 > > > > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > > > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#570943} > > > > > > > > > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > > > > > > > > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac > > > > > > No-Presubmit: true > > > > > > No-Tree-Checks: true > > > > > > No-Try: true > > > > > > Bug: 855234 > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1118238 > > > > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > > > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > > > > > Cr-Commit-Position: refs/heads/master@{#571083} > > > > > > > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > > > > > > > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: 855234 > > > > > Reviewed-on: https://chromium-review.googlesource.com/1118789 > > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#571245} > > > > > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > > > > > Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 855234 > > > > Reviewed-on: https://chromium-review.googlesource.com/1119445 > > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > > > Cr-Commit-Position: refs/heads/master@{#571321} > > > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > > > Change-Id: I25bc4bb1f77031d95dd70347bfed886112b76218 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 855234 > > > Reviewed-on: https://chromium-review.googlesource.com/1120798 > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#571968} > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > Change-Id: I031c5d6204e0b53fa2719168a38292455d676167 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 855234 > > Reviewed-on: https://chromium-review.googlesource.com/1124539 > > Reviewed-by: Emily Hanley <eyaich@chromium.org> > > Commit-Queue: Emily Hanley <eyaich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#572183} > > Change-Id: I6c994148908ed9a223b8b59219b6b4a6957cd9ca > Bug: 855234 > Reviewed-on: https://chromium-review.googlesource.com/1125420 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575747} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org Change-Id: I250655ba8a77cbee8ea46d7471c4691e761fa88e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855234 Reviewed-on: https://chromium-review.googlesource.com/1141824Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#576013}
-
Matthew Cary authored
Previously, the profiling tools selected the first connected devices. This gives inconsistent and surprising results if there is more than one device connected. This change asserts that either exactly one device is connected, or the device is explicitly specified via a new --device flag. Bug: 843561 Change-Id: I51e310b83028876936bc8e042d96c9e16044360b Reviewed-on: https://chromium-review.googlesource.com/1124843Reviewed-by:
-
Colin Blundell authored
Upcoming work will add APIs to IdentityManager to interact with the user's Gaia accounts in the cookie jar. To implement these APIS, IdentityManager will need to interact with GaiaCookieManagerService. In preparation for that work, this CL threads GaiaCookieManagerService in to IdentityManager. Design doc: https://docs.google.com/document/d/1hcrJ44facCSHtMGBmPusvcoP-fAR300Hi-UFez8ffYQ/edit?pli=1#heading=h.y7yywe14x23d TBR=rohitrao@chromium.org Bug: 859882 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I40f1abd6c8beca89476567bbb94979ad42ff7df1 Reviewed-on: https://chromium-review.googlesource.com/1140156 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
Change-Id: I42be273b8ca5c5c6bcf2dff9f1599559f99bbe5b Reviewed-on: https://chromium-review.googlesource.com/1141571Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#576010}
-
Mihai Sardarescu authored
This CL moves the passphrase section just below the account if the user has set a a custom passphrase and if Unified Consent is enabled. Changing the strings and fixing the vertical spacing between the elements in the enter passphrase section will be addressed in a follow-up CL. Mock: https://drive.google.com/open?id=1vAn34VbmHuiEpp8jQaB4v9K2T-G-ziqU Screenshot: https://drive.google.com/open?id=1OizYyUmyAEView0RrJkZfinxt-Rtz5Xp Bug: 834361 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5b7401c641291439f1bd61e6acd1523102b8a667 Reviewed-on: https://chromium-review.googlesource.com/1133380Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#576009}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77552dbce365..5dbb0c3db56a git log 77552dbce365..5dbb0c3db56a --date=short --no-merges --format='%ad %ae %s' 2018-07-18 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 04f0f133032c..e2c00841a55f (1 commits) Created with: gclient setdep -r src/third_party/skia@5dbb0c3db56a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I27a868a649457d77eb6304987b402ba89798f44f Reviewed-on: https://chromium-review.googlesource.com/1141608Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576008}
-
Marc Treib authored
It was kind of an artificial state: All the other states are mutually exclusive and form a clear hierarchy, but auth errors can coexist with most of the other states. In that case, we'd "override" the overall state to be AUTH_ERROR, which made it impossible to check whether, e.g., the SyncEngine was initialized. This CL removes the AUTH_ERROR state - interested clients will have to call GetAuthError() again, which they probably had to do anyway to check for transient vs. persistent errors etc. Bug: 839834 Change-Id: I829a1495671a34eb783d56dc73519025f9bfed7b Reviewed-on: https://chromium-review.googlesource.com/1141578Reviewed-by:
-
Matt Menke authored
The goal of this log was not to enter suspending mode while uploading a large resource, but it also causes hanging POST requests, sometimes used for chat channels, to prevent a system from entering suspend mode. It also can keep systems awake after their lid is closed, consuming battery unexpectedly. Chrome is the only browser that does this. We'll either need to port the behavior to work with the network service, or remove it from Chrome before we ship the network service (So it's one less difference between Chrome with / without the network service). We opted to go with the latter approach, since the current behavior can cause problems. There's also a wake lock web API under discussion, though not yet shipped. TBR=jam@chromium.org Bug: 571250, 789673 Change-Id: I6e121b9a862496dfb2da630a180cd00cdde30528 Reviewed-on: https://chromium-review.googlesource.com/1140207 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#576006}
-
