- 23 Sep, 2020 40 commits
-
-
Dave Tapuska authored
This fixes failing tests that are testing the reception of received bounds as the DIPs -> Blink Space -> DIPs caused a larger rectangle. BUG=1131389 Change-Id: Ie3be0990060d7252d70702d7abd72c1a3c7463ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425397 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#809954}
-
adoneria authored
Bug: 1131618 Change-Id: I1cbdfeb79ed0b86afe8351bfd10f642851adfb87 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427126 Commit-Queue: Anjali Doneria <adoneria@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#809953}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600840405-f4d8e4031cebaee3fd15a03b0f21d18ea0743d9a.profdata to chrome-mac-master-1600883819-b4e54673a8ac66af896b73e5221cf1b275c98c77.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibd6d5c1afb96a866ec7625ffa7ff4e6820ececcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809952}
-
Natalie Chouinard authored
Add Google Sans Bold (weight: 700) to the list of fonts preloaded from GMS Core and available to the renderer via IPC. Bug: 1129668 Change-Id: If301467c25eb40f177d8fc5530eeadb0d49d5314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427027Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809951}
-
Peter Wen authored
Removing lint suppressions allows our new code to benefit from these lint checks. Regenerate lint-baseline.xml to account for UseCompoundDrawables moving from lint-suppressions.xml to lint-baseline.xml. Removed from lint-suppressions.xml: - UseCompoundDrawables - UselessParent - UseMinSdkAttributes - ValidFragment - VisibleForTests - WebViewApiAvailability - WrongCall Bug: 1116130 Change-Id: I89623b3f2c448b2332c39147892dff9d0d2b6001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422466 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809950}
-
David Black authored
Selection ring indicates the HoldingSpaceItemView's selected state. This CL also adds the APIs that will be used by HoldingSpaceItemView's delegate to update selected state. Note that this CL uses kPlaceholderColor (red) for the selection ring. This will be updated in later CLs. Bug: 1129981 Change-Id: Ie582d29934f3f36d3bea7fe99fcbcb718c4432b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424588 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809949}
-
Min Qin authored
The test is failing on some bot as the download is still in progress This CL ask the test to wait for the download to enter a canceled state. BUG=1130550 Change-Id: Icfeb01ebbab20cd901cefe16870b6cbe98be3d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422163 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809948}
-
Michael Thiessen authored
The tests weren't destroying the WindowAndroid they created, the fix is trivial. I also replaced the deprecated TestUtils#runOnUiThreadBlocking since I was touching this file anyways. Bug: 1130845 Change-Id: I4b570e31dc6161e5df45d93160f23c92d5c3bfd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427205 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#809947}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: If30a652c2b564104135b6f3d239c8a3e0f78ce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426363Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#809946}
-
Lei Zhang authored
Bug: 537099 Change-Id: I7d006d2a563de005b22945f0eabb723f86657862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416563 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#809945}
-
David Van Cleve authored
We're seeing a pretty high failure rate for Trust Tokens issuance via the Fetch API on Windows. This CL adds some logging to help debug this by recording the net errors for Trust Tokens operations associated with subresource requests. It: - expands URLLoaderCompletionStatus to store a Trust Tokens operation type as well as a Trust Tokens operation status code; - adds logging code in resoure_load_stats.cc to log this error; and - adds a new Trust Tokens browser test confirming that a couple diverse cases log the correct errors (successful Trust Tokens operation begin followed by a network-level error; unsuccessful Trust Tokens operation). Fixed: 1128180 Change-Id: I2ae6b1c5e81fc8ffaa4e9e912a994f5181af1a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416882Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#809944}
-
Xinghui Lu authored
See the discussion thread linked in https://crbug.com/1103015#c15. before: http://screen/5TxkBPCY3kXKtCa after: http://screen/9kcGmdc3ptJp4q7 Bug: 1103015 Change-Id: I0a074e8023be0fd1455d566ff508d128994ecdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422713Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809943}
-
Peter Kasting authored
This matches what the underlying RenderText already does. It probably doesn't matter much, since the width itself is "average character width * n", which isn't going to result in a reliable pixel-precise value, but it does mean that, on Windows, sizing a Textfield to n characters (which are in theory based on the width of 'x'), then typing n 'x's, no longer results in the Textfield scrolling slightly. Bug: none Change-Id: Idea1473438037836f8a50e260c5b2ac261830a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421028 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809942}
-
Elly Fong-Jones authored
This test flakily times out or fails on all platforms. Bug: 1131622 Change-Id: I06e4c9e0ea81a24678e70bdaba0bfbb529916a41 Tbr: megjablon@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426266Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#809941}
-
Sean Gilhuly authored
ColorTransformPixelTest and CopyOutputScalingPixelTest have complicated test parameterization types, so leave them be. Bug: 1047820 Change-Id: I9e403ab07214c712c6c6393b08b4f53929a868dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425336 Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#809940}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600861496-aa5ced2b846bf1462377e76f5270436b4108dec5.profdata to chrome-linux-master-1600883819-6d81c41c506f5dfe6d7f3151056b14ae70cf74e3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I9ec0bc8f78e8669b8d016eff246c508bebb4aac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427230Reviewed-by:
-
Kyle Horimoto authored
This class will be shared between BLE and Nearby connection flows, so this CL moves its initialization to SecureChannelImpl. Bug: 1106937 Change-Id: I376f83b8ded699940131da0ebaf97656838b2a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425428 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#809938}
-
Roman Arora authored
Bug: 1128599 Change-Id: I39bbf3f9aadc6f74d99dd54e3b768e01d7026e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417548Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#809937}
-
Henrique Nakashima authored
The Lorenz builder runs every couple of hours and updates the graph at the new location. Load the graph from there in the hosted version. Bug: 1111056 Change-Id: I7b051b9ba1b06eadba4d09c1613a4b9d714f3780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427127 Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0de987471899..52c1ebb26cdd 2020-09-23 landrey@webrtc.org Turn off indexing for upload completion token time fields 2020-09-23 landrey@webrtc.org Roll out upload completion token for all webrtc requests 2020-09-23 landrey@webrtc.org Turn on datastore for upload completion tokens and meaurements. 2020-09-21 bpastene@chromium.org devil: Roll ADB to 1.0.41 (Version 30.0.3-6597393). 2020-09-21 heiserya@google.com Add a flag to WPR and run_benchmark to disable fuzzy matching of URLs 2020-09-21 landrey@webrtc.org Add exception message to upload completion token 2020-09-21 landrey@webrtc.org Update /uploads api to return diagnostics data. 2020-09-21 landrey@webrtc.org Add info to upload completion token measurements If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1005504,chromium:1020982,chromium:1114061,chromium:1122516,chromium:1128357 Tbr: nuskos@google.com Change-Id: I3868db933263d20b89943f01887258d370eda0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427143Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/399a0eba..19ce8322 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1ceed382646890c7c3d41789779e22d686fb29ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426470Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809934}
-
Sébastien Séguin-Gagnon authored
This is a reland of d777f5d0 Original change's description: > Reland "[Empties] Enable the IllustratedEmptyStates field trial testing config." > > This is a reland of 74b8ec6f > > Original change's description: > > [Empties] Enable the IllustratedEmptyStates field trial testing config. > > > > Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295 > > Reviewed-by: Sergio Collazos <sczs@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: sebsg <sebsg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805136} > > Change-Id: Ieb3e461efb4c55e7ef601417819cc4470e8fe4cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401398 > Commit-Queue: sebsg <sebsg@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Auto-Submit: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807867} Change-Id: I0c3a85ef61dc74064e9e9d49a27a5efe1e333452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418891Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809933}
-
Elly Fong-Jones authored
This reverts commit 992e5b90. Reason for revert: newly added browser test SCTReportingServiceBrowserTest.ReportsSentAfterNetworkServiceRestart is flaky on Network Service Linux: [20444:20444:0923/122248.098203:FATAL:browser_test_base.cc(616)] Check failed: !IsInProcessNetworkService(). Can't crash the network service if it's running in-process! Original change's description: > Send SCT reports to Safe Browsing > > This implements sending new SCT audit reports to the Safe Browsing > servers for opted-in users. The SCTAuditingCache now sends reports using > a SimpleURLLoader when new reports are sampled for sending to Safe > Browsing. This reporting is configured by the SCTReportingService via a > new NetworkService::ConfigureSCTAuditing() API. This redesign eliminates > the round-trips between the network service and the browser process > entirely by having the SCTReportingService configure which network > context (and URLLoaderFactory) the SCTAuditingCache should use to send > reports (in this case, we use the system network context). > > This also: > - Removes the OnSCTReportReady Mojo API. > - Moves the feature flag for opt-in SCT auditing from services/network/ > into chrome/ now. > - Adds the network traffic annotation for opt-in SCT auditing. > - Extends the existing SCTReportingService browser tests to track > whether reports sent their results to the reporting server. > - Adds unittests covering reports being sent. > - Adds an optimization where empty reports are stored for reports that > we do not sample (and thus will never be sent to the server), rather > than storing the full report object. > > Bug: 1082860 > Change-Id: I29fd0ee1cb9c2d5c850601e0b54203363d4f8282 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331755 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809867} TBR=meacer@chromium.org,mek@chromium.org,mmenke@chromium.org,alexmos@chromium.org,estark@chromium.org,robertogden@chromium.org,cthomp@chromium.org,nicolaso@chromium.org Change-Id: Iead4df3a118f2241c5a3da1fdc0486f986b7e566 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427209Reviewed-by:
-
Mason Freed authored
Quirks mode layout is slower than no-quirks. Bug: 1131185 Change-Id: Ie5421ac90e24f9e8936b431e745ffed07bbfd770 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424670 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#809931}
-
Ben Pastene authored
We capture the logs in system integration Tast tests, but not small gtest tests. But it appears some gtests do need system logs, so this pulls them for every gtest as well. Also update old uses of the arg name. Bug: None Change-Id: I47de8617575dfda5a74d9d1319f3d9dbaad4714b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424817Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#809930}
-
Aya ElAttar authored
1. Added DataLeakPreventionRulesList policy. 2. Added DlpRulesManager to be responsible for parsing the rules and providing an API for other services. Bug: 1121987 Change-Id: I819503645f0513bc643e37c9f1468c304e6ef239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377928 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#809929}
-
Michael Hansen authored
This adds a mechanism to rotate the Nearby Connections advertisement and Bluetooth MAC address every [12, 15) minutes. This is to protect user privacy by preventing tracking using this data. Spec: go/nearby-chrome-bt Bug: b:154846485 Change-Id: I841aa103fb374a4812ab928bc862af026835a03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419692 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#809928}
-
Xi Han authored
This flag is already 50% on stable, enable it by default. Bug: 933358 Change-Id: Idebaa9a0544f0da022240864a96c38718df04332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426727Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809927}
-
DongJun Kim authored
This patch is for refactoring RespondWithCallback class and include below changes. - Expose RespondWithCallback from PaymentAppProviderImpl. - Adds helper class like as "ServiceWorkerCoreThreadEventDispatcher" it appears that all of the functions that access WebContents on the service worker core thread are for dispatching some type of event. - Remove InvokeRespondWithcallbacksRepository then ServiceWorkerCoreThreadEventDispatcher owns an instance of InvokeRespondWithCallback instead and manage its lifetime. Bug: 1075687 Change-Id: I34ee154600a137ef47a03f797f15da689d205a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368660 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809926}
-
Stepan Khapugin authored
Creates new class ContentSuggestionsSchedulerAppAgent which brings together all the Content Suggestion service notifications code. Introduces AppStateAgents (app state associated objects). Adds a new AppStateObserver method, sceneDidConnect:, that allows for unified logic between iOS 12 and 13. Bug: 1072366,1094916 Change-Id: Idd520e71668e6fc230b73eb3485085bf423b39bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414223 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809925}
-
Lei Zhang authored
Pull out a hard-to-read conditional into its own boolean variable. Also remove an unused variable and compact code after that. Change-Id: I34b101a9fb95f734a4cb67967ad5874ca4d7a7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425425Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809924}
-
Daniel Murphy authored
This change adds missing metrics on the chrome://apps page for webapps. These metrics help us track usage, as well as os integration failures (in this case specifically from installing 'locally' from chrome://apps, where the app exists in sync already). Change-Id: I467c0adf0ecec8db998d62ec0471201eb82d887c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419115 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#809923}
-
Peter Kasting authored
Bug: none Change-Id: I32c7ef252d2fbfa4b4d5c3868c8e65c360f54929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424929 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Mohamed Heikal authored
`create_srcjar = false` was needed during the transition to moving R.java generation to android_library targets. Now this variable is unused (the variable is asserted to be false), clean up all references. TBR=#mechanical change, noop Bug: 1073476 Change-Id: Ie272288eb4988d0e4bdb8aeebc9b4debb08fbcfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426243 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#809921}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2daeda990573..8134d1f70669 2020-09-23 tvanderlippe@chromium.org Cleanup _loadModules in Runtime 2020-09-23 tvanderlippe@chromium.org Add back + button for style insertion of stylesheets 2020-09-23 jacktfranklin@chromium.org Ensure that data setters in components take an interface 2020-09-23 changhaohan@chromium.org Add collapsable Computed pane into Styles pane 2020-09-23 tvanderlippe@chromium.org Typecheck network/NetworkLogView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1073899,chromium:1129881,chromium:1131500 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9b8bcc22d80630824168c320162d7ce2e438b648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426804Reviewed-by:
-
danakj authored
This should not happen, and we're crashing the renderer when it does but we need more info to determine why it is happening. I have narrowed it down to being browser-initiated by code inspection but the number of ways a NavigationRequest gets created and put in a RenderFrameHost is too numerous to continue reasonably on that path. R=avi@chromium.org,dcheng@chromium.org Bug: 1125106 Change-Id: I6f9db7c7386298208bb39c9f91fa1dbf91e1eb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413563 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Yuheng Huang authored
We need to pass in some floating point feature flags to WebUI. Adding this method to make it possible. Bug: 1099917 Change-Id: I1d9cd115c2234d66239fe555ed89aee3314df779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426608Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#809918}
-
Alison Maher authored
In cases where an oof element's static position was taken in a later fragmentainer than the start of its containing block, we would calculate the wrong start offset and starting fragmentainer for the oof. To fix this, instead of passing fragmentainer_consumed_block_size (which is the consumed column block size up to the column that the static position was taken in), update the containing_block_offset to be the offset from the start of the containing block to the root fragmentation context, as well as update the static position to be relative to this adjusted containing_block_offset. Bug: 1079031 Change-Id: I48c08e7debd291fa3acfa77af0bb6d242cedbbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422213 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809917}
-
Yulun Wu authored
Bug: 1130865 Change-Id: I6ff276495f08928a68be3cd53a2681c37a14dd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423263Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809916}
-
Torne (Richard Coles) authored
On Android, SIGQUIT is masked by default and handled specially by ART to generate stack traces on demand (usually during an ANR or bugreport) in a way that does not intrinsically terminate the process (though the process may be killed afterward in some cases). Apps that use WebView sometimes unmask SIGQUIT in the browser process due to having their own crash handler or similar, and if that happens, we don't want to treat this as a browser process crash and generate a minidump, as there's no real way to know why the signal was sent. Just disable handling SIGQUIT on Android in the browser process. This leaves child processes alone; they only run our code so can't end up with SIGQUIT accidentally unmasked. Fixed: 1077890 Change-Id: Iff896135f0ff417f92dbf660d58569774eb4a0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426471Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#809915}
-
