GitLab

When a view changes size, it's important to call PreferredSizeChanged()
so that its parent knows it might need to re-layout or repaint.

The current code either fails to call PreferredSizeChanged() or instead
lays out the current view in a couple of cases relevant to the toolbar,
preventing us from using a consistent layout manager. This CL is a
prerequisite for actually switching to a layout manager for the toolbar.

Bug: 898632
Change-Id: I7154eb6ac58a11eca9069b25655a6c2666a704e0
Reviewed-on: https://chromium-review.googlesource.com/c/1372715
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615969}

This change makes sure we save the clean exit value if the connection to
the child process is lost.

Bug: 911716
Change-Id: I9e0ac28e4ed18a3852fa157a4ce1295552d79bc4
Reviewed-on: https://chromium-review.googlesource.com/c/1370644Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615968}

The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call
to Delegate::DoWork in the following scenario:

  1. Start a run loop and schedule DoWork.
  2. In DoWork, start a second run nested run loop which quits immediately.
  3. After the nested run loop quits, schedule another DoWork which quits the
     original run loop.

After step #3, the message pump would call DoWork again because the nested
run loop triggered the execution of the nesting deferred work source.

This patch fixes the issue by checking whether the further work is allowed
before calling DoWork. Note that this check can't be done just for the nested
deferred work source, because in the flow above that source is what triggers
the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.

The patch also includes a fix to
WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the
following sequence in it (while a select menu is open):

  1. Quit an outer run loop.
  2. Post a task onto an inner run loop to continue the test.

The assumption here was that a select menu causes an inner run loop to
be active while the menu is open. This wasn't strictly correct: the
inner run loop is a native (CoreFoundation) run loop as opposed to a
base::RunLoop, which can't be explicitly exited with RunLoop::Quit().
This means that the Quit() in step #1 affects the same run loop as the
PostTask in step #2, i.e., the task is prevented from running.

This patch changes the test to only quit the test run loop after the
posted task (which closes the select menu) has run.

Bug: 891670
Change-Id: I6fe21289205664c4e1b1469547495667c753f56d
Reviewed-on: https://chromium-review.googlesource.com/c/1373754Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615967}

Previously, the UnapplySteadyStateElisions method had a wrong early
exit for when ONLY the path was elided.

This CL removes that early exit and replaces it with a more robust
check.

Bug: 912671
Change-Id: I1046d54c678a560f1562ff375aba134c1ad01627
Reviewed-on: https://chromium-review.googlesource.com/c/1372849Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615966}

Bug: 908139
Change-Id: Ie328baa725217abe3dbbb144d166671f2933403b
Reviewed-on: https://chromium-review.googlesource.com/c/1356004Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615965}

Reset last known cursor in RenderWidgetInputHandler
upon receiving a mouse leave event so the very next
set cursor command in this widget always sets the
cursor.

This change originally failed
CursorUpdateReceivedFromCrossSiteIframe
test and fixes were added to EventHandler to stop
sending set cursor message when mouse is on a
remote embedded iframe by the embedder.

Bug: 899525
Change-Id: I0a7114bccc7c3087b4993a212e5d5a8c1b39a03b
Reviewed-on: https://chromium-review.googlesource.com/c/1365085
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615964}

Bug: 622387
Change-Id: Idddd32bf271f28fb5d22cbef54b4250e636e2f6f
Reviewed-on: https://chromium-review.googlesource.com/c/1372312
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615963}

With https://chromium-review.googlesource.com/c/chromium/src/+/1371020
landed, MSE pipeline_integration_fuzzers no longer appear to emit
spurious gtest failure messages.

However, the non-MSE (SRC=) media_pipeline_integration_fuzzer still
emits such messages.

This change narrows the close_fd_mask=1 libfuzzer option to no longer be
used for the MSE fuzzers. It remains for the SRC
pipeline_integration_fuzzer until the underlying spurious gtest messages
are fixed.

BUG=894460
TEST=Local build of MSE pipeline integration fuzzers does not produce
options files, but SRC fuzzer still does.

Change-Id: I1bcd642892fd909dbd1f9c639ae9a58cac4cad0f
Reviewed-on: https://chromium-review.googlesource.com/c/1373034Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615962}

Also handles a possible security exception when trying to grant
permissions that chrome probably already has.

Change-Id: I6c6ed7e35885ac4784e1f6b13c3bd9b16aaf9571
Reviewed-on: https://chromium-review.googlesource.com/c/1374390
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615961}

This callback is deprecated. Clients should use |TitleWasSet|
to listen for title changes and |DidFinishNavigation| for
|window.location.replace|.

Bug: 720786, 546218
Change-Id: Ic8e0dbbb773b8943ddca3961440af553901aa799
Reviewed-on: https://chromium-review.googlesource.com/c/1372850Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615960}

This is a reland of 28e9c18c

Original change's description:
> Add replay button to Picture-in-Picture window when video ends
> 
> This CL makes sure there's a new replay button visible in the PiP window
> when video ends. This icon comes from Material Icons library at
> https://material.io/tools/icons/?icon=replay.
> 
> https://i.imgur.com/I1n90tM.png
> 
> Bug: 911620
> 
> Change-Id: Ibfcb96b9c69228ad74afe96ec00eb0e28d335ad8
> Reviewed-on: https://chromium-review.googlesource.com/c/1360852
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615846}

Bug: 911620
Change-Id: I8d994d2feb32dd6b83185d9ec3fb44af0be5f977
Reviewed-on: https://chromium-review.googlesource.com/c/1374229Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#615959}

region:
- make it read similarly to other containers

cell:
- include the name in the output format. Note we prioritize the cell index, so users would hear/in braille
c1 cellname

Test: manually (including in Docs with braille mode off).
Change-Id: I93503f1d523a9aac09ac92298c38669fc8a3c222
Reviewed-on: https://chromium-review.googlesource.com/c/1372424
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615958}

Bug: 910670
Change-Id: Ieac8ffe1ebaf49c4faad10fc83791d384231ac32
Reviewed-on: https://chromium-review.googlesource.com/c/1372910
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615957}

OnDidLoadResourceFromMemoryCache calls new NotifyExternalCacheHit
when network service is active as to properly update the cache with an external hit.

Bug: 893323
Change-Id: Ia21b3441122a55d8eb5a8c7e508b4243ab500cda
Reviewed-on: https://chromium-review.googlesource.com/c/1366435
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615956}

This is to pick up
https://chromium.googlesource.com/infra/infra/+/25958d48e89e980e2a97daeddc977fb5e2e1fb8c

Change-Id: I71d7e1ca56cf575cc37db4a3e2bdf5b1e02da0a7
Reviewed-on: https://chromium-review.googlesource.com/c/1374050
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615955}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f7831a8afd6..dfed8e9b27e3


Created with:
  gclient setdep -r src-internal@dfed8e9b27e3

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I80d9a53db7027ae86eee734dde3cc506c53d159a
Reviewed-on: https://chromium-review.googlesource.com/c/1374134Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615954}

Bug: None
Test: CQ
Change-Id: I41f3989df237c8ecce55c1d2ac503402c5f95dca
Reviewed-on: https://chromium-review.googlesource.com/c/1355435Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615953}

https://android.googlesource.com/platform/external/perfetto.git/+log/ff2d54966a03..38b36666a125


git log ff2d54966a03..38b36666a125 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 hjd@google.com Merge "trace_processor: Regression test for counter is null"
2018-12-12 fmayer@google.com Merge "fuzzing: Fix buffered_frame_deserializer_fuzzer for too large sizes."
2018-12-12 fmayer@google.com Merge "profiling: Add persist.heapprofd.enable."


Created with:
  gclient setdep -r src/third_party/perfetto@38b36666a125

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iaa1bb3c08beb55f35747383eb94fe12e711fadec
Reviewed-on: https://chromium-review.googlesource.com/c/1374133Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615952}

See related bug entry for details.

BUG=912117
R=nyquist@chromium.org, thildebr@chromium.org

Change-Id: I7d1a46f84fe58c4b93a03b9445ae6902831d0538
Reviewed-on: https://chromium-review.googlesource.com/c/1373847Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615951}

This is a reland of 0ed2b6ca

Original change's description:
> [Fuchsia] Generate more complete GN target names for FIDL packages.
> 
> FIDL package names consist of multiple dot-delimited segments, to allow
> scoping of packages to avoid clashes. Our GN generator script was using
> only the final segment of each package's name, resulting in clashes,
> e.g. between fuchsia.auth and fuchsia.modular.auth, if both were
> present in the SDK.
> 
> We continue to generate targets under the //third_party/fuchsia-sdk/sdk
> namespace, but use the full name rather than only the final segment,
> e.g. custom.modular.auth would become custom_modular_auth.
> 
> We also special-case the top-level "fuchsia" namespace to be ignored,
> e.g. fuchsia.modular_auth becomes just modular_auth.
> 
> Bug: 910670
> Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380
> Reviewed-on: https://chromium-review.googlesource.com/c/1372892
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615763}

Bug: 910670
Change-Id: I2b7c5d766f5ee7cfe2d31b10f8410075efd52288
Reviewed-on: https://chromium-review.googlesource.com/c/1373276Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615950}

The file name of DOMWindowStorage should be dom_window_storage.h, change
it in blink/renderer/modules/storage/README.md

Change-Id: I3b42c6ab325ed31564c460b5d380d30011629d71
Reviewed-on: https://chromium-review.googlesource.com/c/1373491Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615949}

If both Lite Page Redirect previews and Resource Loading Hint previews
are enabled, the first one hides the second one currently due to different
triggering point in the code. This CL is a bug fix to avoid that hiding
via heuristic that favors the PageHint based optimizations if there are
known to be PageHints for the host. This assumes we should not add
PageHints for hosts where we don't think their treatment is better than
Lite Page Redirect previews.

Also adds a Finch controllable parameter to favor Lite Page Redirect (ie,
switch back) so we can experiment with both.

Bug: 913680
Change-Id: I6aa0aacc24b1e3f338a42f76d56cad94b34f5f01
Reviewed-on: https://chromium-review.googlesource.com/c/1371081
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615948}

The amount of mirroring streams far outnumber the number of microphone
streams, which causes these histograms to poorly represent microphone
streams. This change ensures that the AudioInputDevice histograms
keeps measuring the same thing when the mirroring service is enabled.

Also fix lint.

Bug: 912926
Change-Id: Ib08b9a5a452d0ece9494b30aa23c02d0d18e1bd1
Reviewed-on: https://chromium-review.googlesource.com/c/1370166
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615947}

User timing's mark() was throwing when called with a well-known name
inside a worker. According to the spec and tests, it should only throw
in such a case on the main thread.
This CL aligns our implementation with the spec.

Change-Id: Idb43038105301a41cd7d2c676ca1fc401a684058
Reviewed-on: https://chromium-review.googlesource.com/c/1373830Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615946}

This patch turns the omnibox results adapter into a generic utility
that can conceivably be used by any list represented by models.

Since the view type returned by getView is not guaranteed to return
a view of that type, we need a means of checking it. This patch adds
a tag to views in that list that identify what type it is. This should
allow lists that aren't necessarily recycler views to work correctly
with heterogeneous lists.

This patch also removes some unneeded property reset logic that was
specific to omnibox suggestions.

Bug: 901952
Change-Id: Ic4e51bd527849c9177eedc18389d7ff7f70cde84
Reviewed-on: https://chromium-review.googlesource.com/c/1366484
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615945}

Chrome should not specify the kShellWindowId_AlwaysOnTopContainer,
instead it should set InitParams.keep_on_top. Ash will then put the
widget in the correct container and set kAlwaysOnTop correctly
(expected by TabletModeWindowManager and potentially other code).

Additionally, on Chrome OS, unparented dialogs should be associated
with the user that opened the dialog so that the dialogs do not appear
when switching user. (MultiUserWindowManagerClient::SetWindowOwner).

This CL also cleans up some remaining calls to
chrome::ShowWebDialogInContainer, instead setting the container id
in chrome::ShowWebDialog for system modal dialogs only.

Bug: 888711
Change-Id: I3ca16d3094ec632c834eec27ce4e9545c38b9308
Reviewed-on: https://chromium-review.googlesource.com/c/1367086Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615944}

This allows us to implement new WebSettings APIs downstream.

Bug: 891743
Change-Id: Iba5ba659afd6b65c4101398b7964b10ae0379bb2
Reviewed-on: https://chromium-review.googlesource.com/c/1373755Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615943}

This reverts commit 10edbbe8.

Reason for revert: Causing purple on FYI bots:

<The executable does not exist or a dependent library is missing>
<Check for missing .so/.dll in the .isolate or GN file>
e.g., https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20(Intel)/9078

Original change's description:
> Dawn: use Dawn's temporary test targets for isolates.
> 
> The plan is to move the actual test targets in Dawn to Dawn's
> src/test directory. This change makes Chrome temporarily point at
> some intermediate proxy targets, so we can move the real ones
> without breaking Chrome.
> 
> Bug: dawn:61
> Change-Id: I27a66a0daffe212da3fe2a0aaba7d4a250a376ea
> Reviewed-on: https://chromium-review.googlesource.com/c/1373892
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615895}

TBR=thakis@chromium.org,senorblanco@chromium.org,cwallez@chromium.org

Change-Id: Ic5f3778259e37d3818e7dee1a04bb49a66bff27a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:61
Reviewed-on: https://chromium-review.googlesource.com/c/1374369Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615942}

When ResolveHostParameters::dns_query_type is set to TXT, a relevant
DNS/MDNS query will be made with text record results in
ResolveHostRequest::GetTextResults().  Will always use DNS or MDNS
resolver as the System/Proc resolver only supports address queries.

Lots of necessary changes to MockDnsClient.  Rules now allow specifying
a full DnsResponse rather than just IPAddresses, and added a couple
helper methods to create such response objects.  Rewrote and cleaned up
all the response generation code to support the changes.

Bug: 846423
Change-Id: I7298c73e7293ed4415eaa57c8d750111295dfbda
Reviewed-on: https://chromium-review.googlesource.com/c/1352529Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615941}

- The GCPW installer will now try to find the first 'gaia' user name that is not
used in order to create the account used to run the GLS for GCPW.
- Once a username is determined it will stored in the LSA for fetching when needed.
- Added a maximum number of attempts for finding a valid username.

Bug: 896391
Change-Id: Iad7da2dc011ba76bee0cb3b2fdcf4f1195c425a1
Reviewed-on: https://chromium-review.googlesource.com/c/1370718
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615940}

This is a speculative fix of rare flakiness. Before this CL, in rare
cases, each client would have a different fake time value. Combined with
another rare race condition in converting server addresses to local
addresses, it would result in initial sync never converging.

Bug: 911953
Change-Id: Ic628cac80b0ffd8977bb29fa5948109366801803
Reviewed-on: https://chromium-review.googlesource.com/c/1373843
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615939}

Testing of message loop idle seems not relevant to the tests
and is bound to be flaky in browser_tests.

Bug: 914380, 883680
Change-Id: Iac6862c995ae105b8451f0cbcb544f64473c0d85
Reviewed-on: https://chromium-review.googlesource.com/c/1374199Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615938}

In ExecutePerformActions function, we add the code to handle touch
inputs. However, right now we are using EventTarget.dispatchEvent() to
send touch events, we should use another way to dispatch the touch
events.

Bug: chromedriver:1897
Change-Id: Idbecb39270d3abf80a30e5fd13fc0f5ff2ba5b3f
Reviewed-on: https://chromium-review.googlesource.com/c/1372663Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615937}

Switch chrome to use interface that
does not expose internal Skia concept.

R=fmalita@chromium.org, danakj@chromium.org

Bug: 913930
Change-Id: I3373c791095d4eeb3590f23f474e9c5a3f88a207
Reviewed-on: https://chromium-review.googlesource.com/c/1371924Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Cary Clark <caryclark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615936}

Happiness Tracking Surveys is a Googles internal web based survey provider
This Change paves the way to display a survey inside a bubble. and allows
a survey to be viewed at chrome://hats

Bug: 807714
Change-Id: I056c824881fd484cde6355e697f98062b4710221
Reviewed-on: https://chromium-review.googlesource.com/c/1271414Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615935}

BUG=914393

Change-Id: Ia9813b162121de8c3763ccafc6525a628370f5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1371936
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615934}

Bug: None
Change-Id: I5386437fb075291a49d0e1aeb08c780fc23bcda3
Reviewed-on: https://chromium-review.googlesource.com/c/1372562Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615933}

NativeBackgroundTask now allows subclasses to indicate if they support
lite mode. If they do, the EmptyBrowserParts that it creates would also
signal the same to native.

Bug: 913480
Change-Id: I85bf27e9edd5b01cee7756c7a951cd95d3e9520e
Reviewed-on: https://chromium-review.googlesource.com/c/1370580Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615932}

As the crash stack in the bug below shows, V4L2CaptureDevice may be destructed
on a different thread than where it was constructed. Therefore, we should use
RefCountedThreadSafe instead of RefCounted.

Bug: 899203
Change-Id: I71c3f08d65852f34ee44a20032d2f3a3b403eb44
Reviewed-on: https://chromium-review.googlesource.com/c/1374151Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615931}

This will be queried in ExtensionAppShimHandler::OnProfileLoaded, where
we will check that the pid's signature.

Bug: 913362
Change-Id: I6fd144b26fad182d040f302f078a343cd2ab6cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1373433
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615930}