- 29 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5829c03d383e..2c0d6a9404cd git log 5829c03d383e..2c0d6a9404cd --date=short --no-merges --format='%ad %ae %s' 2018-11-29 jmadill@chromium.org WebGL: Fix DrawElements test and remove size check. Created with: gclient setdep -r src/third_party/angle@2c0d6a9404cd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I1dadc9a160917ab030dc01c69e9d07a4ba9fafce Reviewed-on: https://chromium-review.googlesource.com/c/1354622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612021}
-
Andrew Comminos authored
The HTML5 spec recently refactored WindowBase64 into WindowOrWorkerGlobalScope, removing the need to reflect this in our IDL. {btoa,atob} implementations have been merged into window_or_worker_global_scope.{cc,h}. This CL has no behavior changes. Bug: 701498 Change-Id: Ib40b30e166ef3e4c0c92791f3ffecbb7bd1bed0b Reviewed-on: https://chromium-review.googlesource.com/c/1351141Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#612020}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0559d9d48f8b..7c8f33a1f59c git log 0559d9d48f8b..7c8f33a1f59c --date=short --no-merges --format='%ad %ae %s' 2018-11-29 tsepez@chromium.org Use CFWL_Widget::Is*() helpers 2018-11-29 tsepez@chromium.org Allow PDFium to suggest V8 flags via public/ API. 2018-11-29 thestig@chromium.org Remove remaining "exceptions" in fxbarcode. 2018-11-28 tsepez@chromium.org Avoid CFWL_Widget::m_pProperties null check. 2018-11-28 tsepez@chromium.org Replace CFWL_Widget::IsInstance() with IsForm(). 2018-11-28 tsepez@chromium.org No need to check CFX_Barcode::Create() return value Created with: gclient setdep -r src/third_party/pdfium@7c8f33a1f59c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic6b9105a225ec7101f00346b3112790a1193c612 Reviewed-on: https://chromium-review.googlesource.com/c/1354619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612019}
-
Xu Xing authored
Bug: 889122 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I797dab237ccf1629fe0c7d0e1152ecac1d00c8d4 Reviewed-on: https://chromium-review.googlesource.com/c/1286198 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612018}
-
Kurt Horimoto authored
This currently only records attempted link previews, since the feature is not actually supported yet. If the histogram shows that users are frequently attempting to use the 3D touch link preview API, additional actions may be added. Bug: 897261 Change-Id: I7cec3daa242146f50ae329a20624c79dd361310d Reviewed-on: https://chromium-review.googlesource.com/c/1351787 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612017}
-
Clark DuVall authored
Bug: 872343 Change-Id: I54395ae26ee9c2202e77580f76b82f766270fff8 Reviewed-on: https://chromium-review.googlesource.com/c/1352947 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#612016}
-
Tony de Luna authored
Fixes controlled buttons not propagating disabled state down to the paper buttons. Caused connection buttons to be enabled in some instances where they should be disabled. TEST=browser_tests --gtest_filter=*CrSettingsInternetDetailPageTest* BUG=804455 Change-Id: I878c572e1fc55c8cbf1b4d0d362f27d1f2d0ee8b Reviewed-on: https://chromium-review.googlesource.com/c/1347062 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612015}
-
Hitoshi Yoshida authored
We designed to parse IDL files at collecting per component, but we found it duplicates the work. This CL drops the parsing phase in collecting IDL information per files, and hence we collect IDL information as a collection of AST objects. This CL also updates GN dependency to enroll all IDL files including generated files in the output collections. Bug: 839389 Change-Id: Ic014c8081c214f23ffffe932db04d5023841a3d1 Reviewed-on: https://chromium-review.googlesource.com/c/1322669Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#612014}
-
Erik Luo authored
(Behind experiment) This CL makes these links keyboard navigable: - Links found in Console logs with source=Network - Links found in Console stack traces Bug: 865674 Change-Id: Icc11d5441e5d7963ffa0b41b07cc8fcdf4575d39 Reviewed-on: https://chromium-review.googlesource.com/c/1318817 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#612013}
-
Miguel Casas authored
Fix RamGpuMemoryBuffer enum naming that was forgotten, and some style nags. Bug: 902585 Change-Id: Ieede0b6b7164ed8a50c60d94a4449a91bf944eaf Reviewed-on: https://chromium-review.googlesource.com/c/1354405Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#612012}
-
Hirokazu Honda authored
VAConfig created in GetMaxResolution_Locked() is not destroyed. It should be destroyed in the end of the function. BUG=None TEST=VDA unittest on eve Change-Id: Ia7e53bb7f9414232820ac6cd5e4eb85777f18ed4 Reviewed-on: https://chromium-review.googlesource.com/c/1348152Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612011}
-
Xianzhu Wang authored
ForeignLayerDisplayItem's location and size should always equal to the cc layer's offset_to_transform_parent and bounds, respectively. Removing them can simplify logic and reduce duplicated data. Let ForeignLayerDisplayItem create its client by itself. The client returns VisualRect based on the geometry of the cc layer. Let ForeignLayerDisplayItem::DrawsContent() return false because it doesn't issue paint operations. This enables us not to repaint a foreign layer display item when the cc layer changes geometry, though this is not the case for now because we need to update the geometry of the cc layers during paint. However, with the duplicated data removed, we can decouple cc layer geometry update from paint if needed. Change-Id: Idac393608467933bf1eda3691aa4f4cd6379f27e Reviewed-on: https://chromium-review.googlesource.com/c/1352971 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612010}
-
Charles Zhao authored
Bug: 902196 Change-Id: If1de22019158abde2c1b75d17d5096d5ec43d500 Reviewed-on: https://chromium-review.googlesource.com/c/1353047Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612009}
-
Esmael El-Moslimany authored
Bug: 908388 Change-Id: Iecdfd9081cb56769bac3643589c145e648e7bbe4 Reviewed-on: https://chromium-review.googlesource.com/c/1354309Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#612008}
-
Eric Roman authored
Bug: 908654 Change-Id: I184bbfd27ff1116bccb1e5cb9a9ef1e19cacd26d Reviewed-on: https://chromium-review.googlesource.com/c/1351906 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612007}
-
Sergey Ulanov authored
Renamed PlatformFontLinux to PlatformFontSkia and enabled that code on Fuchsia Also removed unnecessary platform if-defs in that code. TBR=sky@chromium.org (for renames under //chrome/browser) Change-Id: Ic51db62d87e2bf33e6095ce42e91a69862c3b402 Reviewed-on: https://chromium-review.googlesource.com/c/1313873 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#612006}
-
Devlin Cronin authored
Update APIPermission and ManifestPermission (and their subsequent subclasses) to return a std::unique_ptr from the Clone(), Diff(), Union(), and Intersection() methods. This makes the ownership of the return result significantly more clear. Update all usages of these methods as well. Bug: 907661 Change-Id: I5110014cca0af9b5364fd8fa8bdcdfc4fee58195 Reviewed-on: https://chromium-review.googlesource.com/c/1347777 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612005}
-
Xianzhu Wang authored
Stat on top 25 sites showed that the objects that have PaintProperties but not LocalBorderBoxProperties were only 1% of all objects having PaintProperties. Most of them were objects with link highlight and some SVG objects with paint properties. This fixes a bug in svg/text/text-selection-text-08-b.svg that the opacity was not applied on the selection tint. This will simplify handling in situations e.g. when we need to know the transform state of an object with link highlight. Change-Id: Iaa48469e69a96c3decb739d6b49526519556b869 Reviewed-on: https://chromium-review.googlesource.com/c/1354221 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612004}
-
Nigel Tao authored
Just names and icons for now. More features will come in future commits. Tested manually, with "chrome --enable-features=AppService". BUG=826982 Change-Id: I465daa7597e5172792d185e8b33228b127879057 Reviewed-on: https://chromium-review.googlesource.com/c/1349155 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#612003}
-
Michael Spang authored
This fixes a crash if you don't pass --enable-features=OzoneDrmMojo. Oops. Bug: 861853 Test: run_content_shell with no arguments Change-Id: I5408ca9323b8481ed6c5f092172b75f2181c94fe Reviewed-on: https://chromium-review.googlesource.com/c/1354502Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612002}
-
John Budorick authored
Note that this does not affect mac_chromium_rel_ng. Bug: 908929 Change-Id: I4834ae78bb0e037a2def2fd73762b5a90c0ef949 Reviewed-on: https://chromium-review.googlesource.com/c/1354131Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#612001}
-
Troy Hildebrandt authored
Adds a SharedProtoDatabase that owns a LevelDB instance. The shared database provides a way to get SharedProtoDatabaseClients to access the shared DB with a unique namespace/prefix. The SharedProtoDatabase instance is provided through the KeyedService ProtoDatabaseProvider so the shared database is tied to the appropriate profile directory. Bug: 870813 Change-Id: I433518c3fee4d37abcaa0c7efa94e7912da521ec Reviewed-on: https://chromium-review.googlesource.com/c/1332009Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612000}
-
David Black authored
This is preferred over unchecked observers. Bug: b:120097552 Change-Id: Id44822dce375e3400baa336fee3154ad99d18d7f Reviewed-on: https://chromium-review.googlesource.com/c/1354569 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#611999}
-
Mustafa Emre Acer authored
Bug: 909944 Change-Id: Ic3304d8a0244a9cea5b5a3b151f8245b8c8269eb Reviewed-on: https://chromium-review.googlesource.com/c/1354642 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#611998}
-
David Black authored
The chain of ownership between AssistantResponseProcessor and UI elements that were being processed was overly complicated. Previously, it was possible for callbacks to fire when the underlying UI element had already been destroyed. Now, we refactor processing logic so that processors are bound to the response/element that they are processing. As such, lifecycle complications are drastically simplified. Bug: b:119674543 Change-Id: I04a08f29ffaf0178d409c7bc0e5d84292993d1ae Reviewed-on: https://chromium-review.googlesource.com/c/1350961 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#611997}
-
Xianzhu Wang authored
It was the same as GraphicsLayer::CcLayer() and was easily to be mixed up with Graphics::ContentsLayer() which returns the real contents layer. Change-Id: I260791979cdd82c42dd23eb20bd5fdb522898b37 Reviewed-on: https://chromium-review.googlesource.com/c/1354440Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611996}
-
Eliot Courtney authored
applied both times. Bug: 908337 Test: Open and close a Chrome PIP window twice. Slide out animation is Change-Id: I617e008070f733184d635486ea3c14b260838c8b Reviewed-on: https://chromium-review.googlesource.com/c/1350026 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#611995}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a2476d29456..22619c2e1a6d git log 1a2476d29456..22619c2e1a6d --date=short --no-merges --format='%ad %ae %s' 2018-11-28 csmartdalton@google.com Remove instanced flush WAR for Skylake 2018-11-28 csmartdalton@google.com Reland "Prefer GrAAConvexPathRenderer over ccpr" 2018-11-28 herb@google.com Move the empty glyph checks into the common code 2018-11-28 kjlubick@google.com [canvaskit] Fix arc() call 2018-11-28 kjlubick@google.com gn format gn/opts.gni 2018-11-28 michaelludwig@google.com Reland "Initial definition of fill rect op" 2018-11-28 herb@google.com Fix up GrGlyphCache ctor 2018-11-28 reed@google.com remove legacy hinting-enum guards Created with: gclient setdep -r src/third_party/skia@22619c2e1a6d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860021 TBR=borenet@chromium.org Change-Id: Id2658c8e866288fad7c8b9ab819b62c31e2571b4 Reviewed-on: https://chromium-review.googlesource.com/c/1354337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611994}
-
Eric Roman authored
This preserves its previous behavior (localhost now bypasses the proxy). Bug: 901896 Change-Id: I2d651b6ff8828d3f344fed0aecf4fb4ae4c31eb8 Reviewed-on: https://chromium-review.googlesource.com/c/1354646Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611993}
-
Ryan Tseng authored
Bug: 889542 Change-Id: I59055c2ce9b6af9026ee8284dd3f943cc0d7d179 Reviewed-on: https://chromium-review.googlesource.com/c/1252625 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#611992}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c959e1230546..70282bd00ee9 git log c959e1230546..70282bd00ee9 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 treehugger-gerrit@google.com Merge "Fix MSAN and debug build." 2018-11-28 primiano@google.com Merge "perfetto: fix MSAN bugs in ftrace muxer" Created with: gclient setdep -r src/third_party/perfetto@70282bd00ee9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I94a144d1601fcb0032ee3d940c701480892cf979 Reviewed-on: https://chromium-review.googlesource.com/c/1354618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611991}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2e2b85af56153b60836ae799e45623dcf25c48e4 Reviewed-on: https://chromium-review.googlesource.com/c/1351147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611990}
-
Matt Falkenhagen authored
This is the same fix as r583483 did for issue 872078. As that commit description says: "Before this CL, this test tried to get performance entries right after Response#text() is resolved, but Chrome doesn't guarantee that there will be a performance entry for the response at that point. This CL changes the test to use PerformanceObserver so that we can make sure that there will be a performance entry for the response." Bug: 846631 Change-Id: Ia8aaf82939f4457b7e2427bbefacce79150fbb20 Reviewed-on: https://chromium-review.googlesource.com/c/1353032 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611989}
-
Dean Liao authored
LOG_ASSERT() platform and factory pointers in case they are null. BUG=None TEST=None Change-Id: If40e3cfffcd64a15de0010f7cd57e987b1955023 Reviewed-on: https://chromium-review.googlesource.com/c/1352122Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#611988}
-
jonross authored
viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an allocation time for that viz::LocalSurfaceId. The purpose of this allocation time is to determine how long it takes for a surface to get embedded once an ID has been allocated for it. There was some concern raised about drift between LocalSurfaceIds and allocation times and so a previous CL bundled the two together in a class. This CL plumbs LocalSurfaceIdAllocation to more places to ensure the two quantities remain in sync with one another. This CL plumbs removes various accessors on ParentLocalSurfaceIdAllocator that return a LocalSurfaceId. This is to encourage future plumbing of LocalSurfaceIdAllocation instead. Bug: 655231 TBR: boliu@chromium.org Change-Id: I304cff6343dc73a26c12852fa33ed5926223b320 Reviewed-on: https://chromium-review.googlesource.com/c/1330217 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#611987}
-
Carlos IL authored
Change-Id: I7f39643ed0a932adf0d4677ff4e676fe0b9cec00 Reviewed-on: https://chromium-review.googlesource.com/c/1352574 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#611986}
-
Mohsen Izadi authored
Multi-Process Mash by default runs Viz in Ash process. There is a --enable-viz flag used to run it as a separate process. This CL changes that flag to a feature named MashOopViz and adds it to chrome://flags page. When Viz runs properly as a standalone process, we can get rid of this flag and make it the default behavior for Mash. Then, --in-process-gpu flag can be used to run Viz in Ash process. BUG=862384 Change-Id: I3015a0936a7287e7a7106c86bbed55863eabdbbe Reviewed-on: https://chromium-review.googlesource.com/c/1349478Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611985}
-
Christian Biesinger authored
The CSSWG would like to apply align-content to single-line flexboxes as well: https://lists.w3.org/Archives/Public/www-style/2018Nov/0007.html https://github.com/w3c/csswg-drafts/issues/3052 Add a use counter for that to see if it is web-compatible. TESTED=Manually using chrome://histograms R=eae@chromium.org, tabatkins@google.com Change-Id: I3af67474937c8c589e8235c451b358b839556d1f Reviewed-on: https://chromium-review.googlesource.com/c/1354539 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#611984}
-
Miguel Casas authored
This CL changes the call to vaCreateContext() to use a set of dummy VASurfaceIDs and removes the then unnecessary parameter from CreateContext(). Bug: None Change-Id: Ibe64deb21ff2f9fabf351740389a60eb44ff1636 Reviewed-on: https://chromium-review.googlesource.com/c/1351747 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611983}
-
Jered Gray authored
The previous logic in OptimizationGuideService created an optimization_guide::proto::Configuration object on a background thread and then used task posting to send it on to PreviewsHints::CreateFromConfig(), where it was used to create a PreviewsHints object on another background thread. In all, there were two tasks posted that included the config object as a parameter, one on the background thread and one on the UI thread. Including it as a parameter in a task requires a full copy of the protobuffer. This means that a full copy of the config protobuf, which can be as large as 1.8MB (the size of the current Brazil one on Canary), was occurring on the UI thread. In local performance measurements, making a single copy of a 600KB version of the protobuf took several milliseconds (it amounted to roughly 60% of the time taken by the initial component string parsing and 60% of the time taken by PreviewHints::CreateFromConfig()). Given that we were incurring the cost of two copies, one of which was on an extremely high priority thread, it makes sense to change the logic to eliminate the need for the copies. The logic has been altered so that OptimizationGuideService no longer immediately processes the component, but instead notifies the observers that it is available and allows them to trigger the processing. This eliminates both copies of the configuration protobuf, as it is now created where it is used. Additionally, OptimizationGuideServiceObservers are now immediately notified of the hints component when they register if one is already available. This will enable the PreviewsOptimizationGuide to wait until the HintCacheLevelDBStore is fully initialized before registering for the component, and in the future will potentially allow it to avoid processing the configuration altogether when the store already has the latest version cached. New unittests have been added and older ones have been updated to accommodate the new logic. The related browser tests have also been modified to be more robust, where they now wait for a signal from a local histogram indicating that hint processing is complete. Bug: 908985 Change-Id: I330fcc35f14388b8a704d3180bd758e7327e9892 Reviewed-on: https://chromium-review.googlesource.com/c/1351719 Commit-Queue: Jered Gray <jegray@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611982}
-