- 04 Oct, 2018 39 commits
-
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I23aa26a0e16bf3809c5b12d161f808582d1b1e88 Reviewed-on: https://chromium-review.googlesource.com/c/1250081 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#596471}
-
Anand K. Mistry authored
In DEBUG builds, the PNaCl translation takes a significant amount of time, causing zip browser test TIMEOUT flakes on the bots. Recover the FilesApp browser test feature used to declare ZipTests and for the zip browser tests, tell the zip-archiver extension to preload the NaCl module before it's needed, so its translation starts as early as possible during zip browser tests. BUG=889703 Change-Id: Ic16a4b4e53a4be88bae8ee5d2c2caa8baaa1487b Reviewed-on: https://chromium-review.googlesource.com/c/1257464Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596470}
-
Ehsan Chiniforooshan authored
The test uses results.FindAllPageSpecificValuesNamed to verify existence of metrics which does not work for TBMv2 metrics. Bug: 891836 Change-Id: Ib1ee4e8081268ad5be846040058db44d013feab3 Reviewed-on: https://chromium-review.googlesource.com/c/1259942 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#596469}
-
Daniel Murphy authored
This change adds all of the OnionSoup mojo pointers to StorageNamespace, and creates a new global called StorageController. This inherits most of the functionality of the StorageNamespaceController but adds the necessary mojo pointers. The inspector agents are moved to live in the StorageNamespaces. This facilitates how they will be used after the event dispatching model is changed for onion-souping. Bug: 781870 Change-Id: I0bf0b7fffcf9c6b6870b636954f130b655642a0c Reviewed-on: https://chromium-review.googlesource.com/c/1232195 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#596468}
-
Ned Nguyen authored
Bug: 828472, 828468 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I8028741debe7cada46bd94442076716fe4765e5a Reviewed-on: https://chromium-review.googlesource.com/c/1260306Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#596467}
-
rbpotter authored
Currently the pdf viewer forwards the keyCode property from key events. However, this property is deprecated, see: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode Add the non-deprecated code property to the list of properties to serialize. Note: this caused a problem with key handling in Print Preview, when Print Preview was updated from using keyCode to code to identify the escape key. Bug: 890724 Change-Id: I259dd36e344f8a5095487b71df8e96d85e3af47b Reviewed-on: https://chromium-review.googlesource.com/c/1256111Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596466}
-
Christopher Cameron authored
Require that the parent of a NativeWidgetMac always be either - an NSView in the NSWindow of another NativeWidgetMac - a nil NSView Remove WidgetOwnerNSWindowAdapter (which enabled this functionality) and BridgedNativeWidgetOwner (the interface it implements). Update tests that happen to use this functionality so that they don't use native view parents. Bug: 859152 Change-Id: I69ea160852be5a44c7e2952445bd1115de72bd8e Reviewed-on: https://chromium-review.googlesource.com/c/1258292 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#596465}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/75bbf56da825..e135eaf8c70a git log 75bbf56da825..e135eaf8c70a --date=short --no-merges --format='%ad %ae %s' 2018-10-03 selcott@google.com Add eve-arcvm overlay to build config. Created with: gclient setdep -r src/third_party/chromite@e135eaf8c70a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib469af7b755961c4ddf500e183003db507fa9197 Reviewed-on: https://chromium-review.googlesource.com/c/1260214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596464}
-
Maggie Chen authored
When there is a new swapchain size request, don't recreate a new swapchain immediately. Instead, use the previous swapchain size until the the new size has been requested for 30 frames. Then create a new swapchain with the new size. We can achieve the same onscreen video size by adding this size delta to the transform matrix calculation. Bug:885182 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I846b8bcb0753a9bd9ccce8329354dc55decc1481 Reviewed-on: https://chromium-review.googlesource.com/c/1235316Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596463}
-
Eugene But authored
Add |using chrome_test_util::OmniboxText| to avoid unnecessary linebreaks. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I76ea7cd146bcec18e843ac13e510dbe06a983eea Reviewed-on: https://chromium-review.googlesource.com/c/1260018Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#596462}
-
sczs authored
Since the legacy recent_tabs and history code has been deleted these views are no longer being used. Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I27af5f605f9088356b2e59566362be53710d45be Reviewed-on: https://chromium-review.googlesource.com/c/1259425Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#596461}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/61d8d025d568..80482dc264c5 git log 61d8d025d568..80482dc264c5 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 tsepez@chromium.org Remove unused method CPDF_ActionFields::GetFieldsCount() 2018-10-03 tsepez@chromium.org Remove unused method CPDF_Bookmark::GetColorRef. Created with: gclient setdep -r src/third_party/pdfium@80482dc264c5 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If0089a419792fd289f5e9619593c848ae65675dd Reviewed-on: https://chromium-review.googlesource.com/c/1260220Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4d422c290779..1395134c3438 git log 4d422c290779..1395134c3438 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jmadill@chromium.org Remove more uses of gl::ErrorOrResult. Created with: gclient setdep -r src/third_party/angle@1395134c3438 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I0a87ed0d87196bad828168d25be11f2780eb07c8 Reviewed-on: https://chromium-review.googlesource.com/c/1260143Reviewed-by:
-
Amos Lim authored
Replace NullString with EmptyString of interfaces includes CanvasFillStrokeStyles as per the spec of CanvasRenderingContext2D[1], OffscreenCanvasRenderingContext2D[2], and PaintRenderingContext2D[3]. [1] https://html.spec.whatwg.org/multipage/canvas.html#canvasrenderingcontext2d [2] https://html.spec.whatwg.org/multipage/canvas.html#the-offscreen-2d-rendering-context [3] https://drafts.css-houdini.org/css-paint-api/#paintrenderingcontext2d Bug: 497307 Change-Id: Iacfa82976b9c32266f427f4b8d0aa2408473aaf2 Reviewed-on: https://chromium-review.googlesource.com/c/1255083Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#596458}
-
Min Qin authored
Currently we use something like "No permission" for notification text. On download shelf, it is "Failed - No Permission", which is better as user will know download actually failed. BUG=888786 Change-Id: I0e7809d1a06db454cfe43c5df05da58595a02b31 Reviewed-on: https://chromium-review.googlesource.com/c/1259223Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596457}
-
Becca Hughes authored
Switch the content MediaSession code to using the audio focus service on non-Android platforms. BUG=875004 Change-Id: I8171a7351a7d64065564fe5f75937e1abaef8e7c Reviewed-on: https://chromium-review.googlesource.com/c/1207657Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596456}
-
Jered Gray authored
Top-level whitelisting for a URL with a PreviewsType of RESOURCE_LOADING_HINTS doesn't make much sense as the optimizations come from the page hints and the page hints themselves can provide more accurate whitelisting data. Because of this, the existence of top-level whitelisting with a PreviewType of RESOURCE_LOADING_HINTS indicates a bug with the component's hints. We're now DCHECKing if the component's hints include top-level RESOURCE_LOADING_HINTS whitelisting. IsWhitelisted() itself has been split into IsWhitelistedAtTopLevel() and IsWhitelistedInPageHints(). IsWhitelistedAtTopLevel() is skipped if the type is PreviewsType::RESOURCE_LOADING_HINTS. Additionally, some const-related cleanup was done with function calls in PreviewHints and HintCache. Lastly, ResourceLoadingHintsBrowserTest has been modified to test the full hint flow where it sets and uses page hints. Doing this exposed an issue with ResourceLoadingHintsHttpsWhitelistedRedirectToHttps, which was incorrectly passing as a result of some faked data (redirects don't currently work with hints). The test has been disabled until hints are made to work with redirects. Change-Id: I165ccb9ffeba742840a9def15e283a0e254dbb86 Reviewed-on: https://chromium-review.googlesource.com/c/1256007 Commit-Queue: Jered Gray <jegray@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#596455}
-
Trent Apted authored
There once was a ScriptExecutionObserver::Delegate, but it disappeared in some past refactoring. The lifetime around ScriptExecutionObserver is quite complex, and relies on base::ObserverList being a SupportsWeakPtr, which we want to stop doing for https://crbug.com/888973. There is now exactly one ScriptExecutionObserver implementation (ActivityLog), and the observer list only ever has exactly 1 or zero observers in it; added and removed in concert with a TabHelper. WebViewGuest also has an ObserverList<ScriptExecutionObserver>, but it never added any observers to it. We can instead make ActivityLog responsible for the lifetime of its callbacks from ScriptExecutor. It already dispenses WeakPtrs to itself. Bug: 888973 Change-Id: Ic773bbcbabea70627b48ef8e0e29ff4e16d1e1f5 Reviewed-on: https://chromium-review.googlesource.com/c/1256398 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596454}
-
Alexei Filippov authored
Change-Id: Ie47791cbbf4bcbf23a7bbdb3622440f5693727dd Reviewed-on: https://chromium-review.googlesource.com/c/1260342Reviewed-by:
-
Alan Cutter authored
This CL removes a TODO for making PageActionIconView inherit from Button. It is no longer needed because IconLabelBubbleView inherits from Button. Change-Id: I8e92c6d3cf43e235168d676361264ad1971e9488 Reviewed-on: https://chromium-review.googlesource.com/c/1258669Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596452}
-
Kent Tamura authored
Introduce content::FileSelectListener, which receives the result of FileSelectHelper. An implementation class of FileSelectListener will implement blink.mojom.FileChooser mojo interface in a following CL. a) Add content::FileSelectListener - content/public/browser/BUILD.gn - content/public/browser/file_select_listener.h b) Receive FileSelectHelper arguments, and call its methods to notify results instead of RFH::FilesSelectedInChooser() and RVH:: DirectoryEnumerationFinished(). - chrome/browser/file_select_helper.cc - chrome/browser/file_select_helper.h c) Add FileChooserImpl class implementing content::FileSelectListener. A FileChooserImpl instance is passed to RenderFrameHostDelgate:: RunFileChooser(). RFH::FilesSelectedInChooser() is removed because FileChooserImpl receives a file list, and it sends the list via IPC. - content/public/browser/render_frame_host.h - content/browser/frame_host/render_frame_host_impl.cc - content/browser/frame_host/render_frame_host_impl.h d) Add ViewFileChooser class implementing content::FileSelectListener. A ViewFileChooser instance is passed to WebContentsDelegate:: EnumerateDirectory(). RVH::DirectoryEnumerationFinished() is called by ViewFileChooser instead of FileSelectHelper. - content/browser/web_contents/web_contents_impl.cc - content/browser/web_contents/web_contents_impl.h e) Add FileSelectListener argument, and call FileSelectListener::FileSelected() instead of RFH::FilesSelectedInChooser(). Maintain a FileSelectListener instance in AwWebContentsDelegate class. - android_webview/browser/aw_web_contents_delegate.cc - android_webview/browser/aw_web_contents_delegate.h f) Add FileSelectListener argument, and forward it to another function or call FileSelectListener::FileSelectionCanceled() - chrome/browser/android/tab_web_contents_delegate_android.cc - chrome/browser/android/tab_web_contents_delegate_android.h - chrome/browser/devtools/devtools_window.cc - chrome/browser/devtools/devtools_window.h - chrome/browser/extensions/extension_view_host.cc - chrome/browser/extensions/extension_view_host.h - chrome/browser/ui/apps/chrome_app_delegate.cc - chrome/browser/ui/apps/chrome_app_delegate.h - chrome/browser/ui/browser.cc - chrome/browser/ui/browser.h - components/guest_view/browser/guest_view_base.cc - components/guest_view/browser/guest_view_base.h - content/browser/frame_host/render_frame_host_delegate.cc - content/browser/frame_host/render_frame_host_delegate.h - content/public/browser/web_contents_delegate.cc - content/public/browser/web_contents_delegate.h - extensions/browser/app_window/app_delegate.h - extensions/browser/app_window/app_window.cc - extensions/browser/app_window/app_window.h - extensions/shell/browser/shell_app_delegate.cc - extensions/shell/browser/shell_app_delegate.h g) Add FileSelectListener argument, and call FileSelectListener::FileSelected() instead of RFH::FilesSelectedInChooser() - chrome/browser/ssl/security_state_tab_helper_browsertest.cc - content/test/content_browser_test_utils_internal.cc - content/test/content_browser_test_utils_internal.h h) Add MockFileLister and pass it to RunFileChooser() to avoid null dereference. - content/browser/web_contents/web_contents_impl_browsertest.cc FYI: All-in-one CL: https://chromium-review.googlesource.com/1170454 Bug: 869257 Change-Id: I190159bd5819d228c703028584b9929aa2ad80c2 Reviewed-on: https://chromium-review.googlesource.com/c/1251182Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#596451}
-
Karan Bhatia authored
This CL adds support for runtime host permissions to the Declarative Net Request API. Changes: - The behavior of REQUIRE_HOST_PERMISSION_FOR_URL_AND_INITIATOR is modified for the case when an extension has access to the initiator but the access to the request url is withheld. In this case, the extension is granted access to the request. This is similar to the current behavior of REQUIRE_HOST_PERMISSION_FOR_URL (used by web request API) and necessary for runtime host permissions to work. This allows extensions to intercept withheld cross-origin requests from a frame to which they have access. - RulesetManager is modified to notify the chrome layer that access to a request was withheld. This is necessary for us to track an extension's blocked/withheld actions on a tab. This CL also paves the way to transition the web request API to require host permissions to the initiator i.e. REQUIRE_HOST_PERMISSION_FOR_URL_AND_INITIATOR. BUG=157736, 809680 Change-Id: Ic4737a55a3ad6f88625149bcb39eefeb84df7d91 Reviewed-on: https://chromium-review.googlesource.com/c/1256219 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
There is a clear separation between fields used for StartNavigation vs CommitNavigation. For now, we can pass four parameters directly. In the future, we should probably put all parameters to WebNavigationParams. Bug: none Change-Id: I4b1a0dac46bb4057b950c1cc8044303903d39f10 Reviewed-on: https://chromium-review.googlesource.com/c/1250124 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Karan Bhatia authored
Currently we might not correctly update the wants-to-run badge UI for an extension if it has a withheld web request. Fix this by notifying the extension action API to update the badge UI, whenever the first withheld web request for an extension is registered on a web contents. BUG=891549 Change-Id: Ibd5c639a878857bd96f2d7cc8a967b2750dabf57 Reviewed-on: https://chromium-review.googlesource.com/c/1258321 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4504a652c071..8841085abeb9 git log 4504a652c071..8841085abeb9 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c3bef3e7b028..1395134c3438 (3 commits) Created with: gclient setdep -r src/third_party/skia@8841085abeb9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ic56b2c751e094f1ce698de42d6bc51447b82c80f Reviewed-on: https://chromium-review.googlesource.com/c/1260144Reviewed-by:
-
Becca Hughes authored
Adds an audio focus flag that enables audio focus manager but disables enforcement of a single media session. This gives us the option of enabling audio focus tracking without the user facing change of enforcing a single media session. BUG=875004 Change-Id: I5415ec76db7b22d4d91ea98c92e3f1515d9df97b Reviewed-on: https://chromium-review.googlesource.com/c/1231915 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596446}
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9eefb234301b9bc8a9c4912d032eaf83a0b80d93 Reviewed-on: https://chromium-review.googlesource.com/c/1253983 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b0b10e58. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25765 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm meade@chromium.org: external/wpt/web-animations mstensho@chromium.org: external/wpt/css/css-multicol rego@igalia.com: external/wpt/css/selectors rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7da8ce11e662b2e9f84baa1e8aad5e01f8a76036 Reviewed-on: https://chromium-review.googlesource.com/c/1259943 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#596444}
-
Joel Einbinder authored
DevTools ignores whitespace-only text nodes. But if a text node that previously had text becomes whitespace-only, no childNodeRemoved event is fired and DevTools would get confused. Bug: 880372 Change-Id: I8f740a6e32d1c1a15a32443a2a702996028f64fa Reviewed-on: https://chromium-review.googlesource.com/c/1257899 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
-
Ben Pastene authored
R=jbudorick Bug: 876587 Change-Id: I322398cb10d4c68de8e31231759ebac322c6cbe6 Reviewed-on: https://chromium-review.googlesource.com/c/1260263Reviewed-by:
-
Xing Liu authored
When serializing the in-memory vpx video frame into MojoSharedBufferVideoFrame, we currently don't consider the padding in each plane in YUV frame, but we pass the strides, which will trigger a DCHECK. This CL also allocates the padding in each plane into the shared memory. Alternatively, we may remove the padding when copying data. Bug: 891794 Change-Id: I6a81c8f8afcd8ff063f90523773ba07aac2eb7fa Reviewed-on: https://chromium-review.googlesource.com/c/1260007Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596441}
-
Gang Wu authored
Should call image loader's destroy after StreamLifecycleManager::destroy to avoid race condition, since StreamLifecycleManager may ask image loader between FeedImageLoader::destroy and StreamLifecycleManager::destroy. Change-Id: Ib291ef3716e118c2ba66ffe1e26165f259bcfeaf Reviewed-on: https://chromium-review.googlesource.com/c/1260008Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#596440}
-
Victor Costan authored
All callsites wrap the raw pointers into std::unique_ptrs already. This will make the code a bit easier to read. Change-Id: I8b0a3bd3497f944a8d0a1fc2e69d5c641f965de9 Reviewed-on: https://chromium-review.googlesource.com/c/1259804 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
David Trainor authored
- Update caption messages for in-progress downloads. - Fix assert failure around being unable to resume. - Fix notification persisting after cancel request. BUG=864223 Change-Id: Ie60aea0288bbd076599d71b89fa60e1ce54ffd29 Reviewed-on: https://chromium-review.googlesource.com/c/1258243 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596438}
-
Christian Fremerey authored
Bug: 820608 Change-Id: I8b6831e3b8b5e6070b8e712dba5c9588e6277f8e Reviewed-on: https://chromium-review.googlesource.com/c/1258986Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596437}
-
Steven Bennetts authored
This CL renames ChromeKeyboardControllerObserver -> ChromeKeyboardControllerClient and makes it a client of the keyboard::mojom::KeyboardController interface. Currently the client primarly serves as an observer, using the mojo interface instead of implementing KeybardControllerObserver directly. For trivial header removal from input_method_engine_base.cc: TBR=shuchen@chromium.org Bug: 843332 Test: keyboard_unittests --gtest_filter=KeyboardControllerMojoImplTest Change-Id: Id3de37e5bef9dddadc1561a14201f4577421826a Reviewed-on: https://chromium-review.googlesource.com/c/1246746Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596436}
-
Thomas Guilbert authored
Currently, successfully starting/stopping/starting RemotePlayback runs into a DCHECK, because we never properly clean up on RemotePlayback stop. This CL fixes the issue and gets rid of a TODO. Bug: 790766 Change-Id: Ieca32cd175741e5c1ae7e55879ae4a224d67b76c Reviewed-on: https://chromium-review.googlesource.com/c/1260282Reviewed-by:
-
Devlin Cronin authored
In practice, Extension objects are pretty much always const. Update ExtensionBuilder::Build() to return a const Extension object, rather than a mutable one. TBR=tapted@chromium.org (c/b/apps, c/b/ui, c/b/web_applications) TBR=stevenjb@chromium.org (c/b/chromeos, c/b/notifications) TBR=dalecurtis@chromium.org (c/b/media) TBR=holte@chromium.org (c/b/metrics) TBR=vakh@chromium.org (c/b/safe_browsing) TBR=treib@chromium.org (c/b/supervised_user) TBR=raymes@chromium.org (c/c/pepper_permission_util_unittest.cc) Bug: 889925 Change-Id: I7da674b29e209540803acfd40576c7daba3da2a3 Reviewed-on: https://chromium-review.googlesource.com/c/1256167 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Jun Choi authored
WebAuthN BLE UI flow should guide the user through pairing UX if no FIDO BLE devices have been paired with the system previously. If there is at least one FIDO BLE device that is paired beforehand, we should default to "activate BLE security key" flow. As so, implement logic to store address of BLE security keys. Bug: 877344 Change-Id: I5d376311fc2dc4b73ceab0ed43ef5b8fbd0ffdbc Reviewed-on: https://chromium-review.googlesource.com/c/1253065 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596433}
-
- 03 Oct, 2018 1 commit
-
-
Scott Chen authored
This CL cleans up the remnants of the NUX Experiments bulid configs. Including: - removing os_win and google_chrome_branded build flag. - removing prefs that tracks if the one-off NUX experiments were seen. - fixing closure compile errors now that it needs to build on non-official bots. Bug: 874153 Change-Id: I03c1ed09c54f5ba91944bcb31837e80a0ee1fc74 Reviewed-on: https://chromium-review.googlesource.com/c/1252906 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#596432}
-
