- 10 Aug, 2020 15 commits
-
-
Jiewei Qian authored
This CL adds a RegisterAutoGrantedPermissions method WebUIAllowlist. This method allows registering a list of permissions, instead of doing a for-loop. Also adds a comment about permissions (and content settings) commonly wanted by WebUIs. Bug: 1109773 Change-Id: I50c05d3b2b7672978dbf53c267ddcaa0352c0545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336425Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#796297}
-
Maggie Cai authored
This CL fixes the sharesheet button type in file_manager.css. BUG=1097623 Change-Id: I902164400191bafcefe09489129e2441dd0a2838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335851Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#796296}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bcddb0efbf60..ea2f3a43df40 2020-08-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia3c977f47e147e1e45161ddb139304b94bd0cfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dbe3f25ad27..c255306f7cd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I57aa3031ef6ed401b07caea1abfb157d618f0e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345093Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796294}
-
Miyoung Shin authored
This is a reland of a7c54a0f Original change's description: > Fix a crash in WebUIMessageHandler::AllowJavascript > > If WebUI's JS is sending the message when we navigate cross-site, > then we use the new process ID from WebContents in > WebUIImpl::CanCallJavascript and a CHECK crash will happen. > > This CL changes to use the old process ID from RFH in > WebUIImpl::CanCallJavascript. > > Bug: 1110276 > Change-Id: Ie827060b637dbd3aa4c7ad771c0cb4862763ced2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326050 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#793816} Bug: 1110276, 1112189, 1112238 Change-Id: I02916364f8cb3871ab4cdf17cd2827a5f1cfbb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335213Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#796293}
-
Zhuoyu Qian authored
Bug: 1100751 Change-Id: I93cf812110c67bdd105678057af49469d24ebd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335716 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#796292}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ibfa1420915f08f9afd0ca8c7bf11d92848d470b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345490Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796291}
-
Sergei Datsenko authored
Don't drop errors on the floor when can't identify of find the mentioned file. Bug: 1012031 Change-Id: I39111b68a6e719bdf989b4e29aba67f270d256ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342226Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#796290}
-
Ahmed Mehfooz authored
Bug: 1111969 Change-Id: I5fafeb1002852d5c584209e4da2bb492b72113fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343006 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796289}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/101a5829d50f..1662e97f324e 2020-08-10 jiawei.shao@intel.com Add tests for lazily initializing indirect buffers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I129f58ac2ffff62b44365742a4ebaa68ed25ac37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796288}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596990221-f7c51694ae9bdb5086b4bb0c066d592c9842dbc8.profdata to chrome-mac-master-1597017082-f8f51ec7c105c76c8c188f2df326b7b00c9b3e5a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I75f5211412da1cc29ac03da97f797c5deb74048b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796287}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb506f87ca90..6dbe3f25ad27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I5c3b58412792ad38d85eb5e000968698c465511f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345524Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796286}
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/UZ0LaGP4pONeWSmuhGzTHaNGXAnBjLFccXtfgum0L4QC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202008090800_RC00.html Bug: b/161193454, b/163023477, b/162996761 Fixed: 1112752 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ie0060eb5151bbb308ca6e26b0218549b0417cbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344327 Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#796285}
-
My Nguyen authored
According to spec, max width should be 488dp. Annotation_label sets to 16 else it will resize when in multi-line. Current view: http://screen/VNjzkDSKZ0D Spec: go/assistive-inputs-figma Bug: 1094843 Change-Id: I80fdb6a38f4139d5e4b52ea14e156364d7a243f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344435 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#796284}
-
Melissa Zhang authored
This CL removes margins and ensures Actions appear before apps. Bug: 1097623 Change-Id: I787cb122e60f569a2085060ad32044fb9e86c437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342334Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796283}
-
- 09 Aug, 2020 25 commits
-
-
Dylan Cutler authored
We want to abort the instrumentation as early as possible for users not in the study, so each overload has its own guard clause. Bug: 973801 Change-Id: Ifed7e75ef90cff0bc41cad2eeaaeaf5bea340e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341809 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#796282}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ac006783519..cb506f87ca90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4a5d160374f614a8512ef78952a7a64ff7c223be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796281}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I51e985fc81e4526f0a0403c56f3c906652dbea0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344822Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796280}
-
Josh Simmons authored
allow experimentation and capability testing. Bug: 1111229 Change-Id: I4737f4b52737977619f98f6cc18a166eeae89a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328254Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#796279}
-
My Nguyen authored
Based on UX Writing review, update the learn more string. Current view: http://screen/JQq8aOgGExX Also update font size to 11 according to spec go/assistive-input-figma Bug: 1094843, 1113612 Change-Id: Ic70c29cd101ab813e4fb72b881b616d5c188c327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344433Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23d59f2f20fb..3ac006783519 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I22a1d181fca998d14d581064e3d4677f946cbf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345435Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796277}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596969922-273270c5768fa245d6eb486d3911a64a186d6010.profdata to chrome-mac-master-1596990221-f7c51694ae9bdb5086b4bb0c066d592c9842dbc8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I3be31b4ffabb2f03623e98c79d5fd1b49a6f4734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345400Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796276}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1114450 Change-Id: Ie0518baca0bbc3f7835864dea236bcf2b676864e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344663Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796275}
-
Mugdha Lakhani authored
Bug: 1096088 Change-Id: I5e95537b9d194c83bbb483dc38a19358437c8a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339993 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#796274}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ecdc9f6fa97..23d59f2f20fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I015890d5e8fc378ac7f4a0cab92a4890066df612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796273}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icf785abd1ae4e64840d6dd9bede6eaf6dd221727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796272}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf362adbfd65..4ecdc9f6fa97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I8f79020ce1d16accdd855879f92d049d807bbf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345284Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796271}
-
Clemens Arbesser authored
This reverts commit 42ccdaf3. Reason for revert: This CL breaks onboarding (crash after onboarding is accepted) Original change's description: > [Autofill Assistant] Remove intent validation for password scripts > > As password scripts have a confirmation step, we don't need to validate > an intent to change a password. > We still need to check whether a running script is a password script (if > yes, the password manager should be notified that a script is running). > For that, we will check whether |TriggerContext| has > PASSWORD_CHANGE_USERNAME param. (For convenience, this CL moves that > parameter's name and also kOverlayColorsParameterName to > trigger_context.cc). > > This CL also changes what origin is used for password store request. If > a password script is started from Settings, GetLastCommittedURL is not > set yet. So, we have to use the deep url provided. > > Bug: 1086109 > Change-Id: I7c38388b06f433dc51bce1a2b54a7d48bb322bfc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332594 > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Milica Selakovic <selakovic@google.com> > Cr-Commit-Position: refs/heads/master@{#795844} TBR=kolos@chromium.org,arbesser@google.com,selakovic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1086109 Change-Id: Ifdeb001ae708abcbe22635299141a61923b7e852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345304Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#796270}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596951804-2e38ee79c378ef6490301a31a86a3e3f9ffa7699.profdata to chrome-mac-master-1596969922-273270c5768fa245d6eb486d3911a64a186d6010.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I408c82dc356f65b6ce8807e06a325fbfcbffba1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796269}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b7bbeb4dbdd7..cf362adbfd65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I17d4b51f8d4a7dea7a5bef6530514a12c6eb021b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345127Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796268}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb8faf172ef3..bcddb0efbf60 2020-08-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If37d1847c12068b57362029a2d3371cc3d61b2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796267}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae5d21e08bc1..b7bbeb4dbdd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9e6b20957d25b74c16ee55d3e1db1df3e9f5f506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345125Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796266}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/839b4bc4c1d6..eb8faf172ef3 2020-08-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic08a0e5e1b8460ce2be991e8b8492bfb3d0ce4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796265}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5084ad24221ff533c60e978583b8331b465a8108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345124Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796264}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596906920-d9c268cee334ba8e96e8c161b05d8af21fcc527d.profdata to chrome-mac-master-1596951804-2e38ee79c378ef6490301a31a86a3e3f9ffa7699.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9b630d1a32106aa63a5add9452fd3d7c96453593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344947Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796263}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e24a4c24c03..ae5d21e08bc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Idd1de121ff40e7a76e3e3035717486a1076a41bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796262}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.25-1595848892-benchmark-86.0.4208.0-r1 to 86-4183.39-1596449559-benchmark-86.0.4221.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9e937ab3ef19841430ffa2f29b898c3b160bffb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796261}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.39-1595842708-benchmark-86.0.4208.0-r1 to 86-4183.48-1596448621-benchmark-86.0.4221.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I99fa4b1d4cccde3f75fad56d027ca43f6d6fd626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796260}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.39-1595845830-benchmark-86.0.4208.0-r1 to 86-4183.48-1596451266-benchmark-86.0.4221.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0d2910a13e5803231303cbccb78daa6ed411aac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344934Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796259}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie6004b9a783db3f506d3aaea3ae2febd69cfbad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345007Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796258}
-