GitLab

I fear that if we don't do this, we may not be able to add things in the
future when we need to.

Bug: none
Change-Id: I94c49b8a5a336051ae7a62928fc48e4300649b19
Reviewed-on: https://chromium-review.googlesource.com/895392
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534700}

This reverts commit 744ac3cb.

Reason for revert: Causing tree closure, https://crbug.com/809399

Original change's description:
> Automated Commit: Committing new LKGM version 10378.0.0 for chromeos.
> 
> TBR=chrome-os-gardeners@google.com
> 
> Change-Id: I528bfa26dc2aa797c5c2e5911fa28f6055a03f67
> Reviewed-on: https://chromium-review.googlesource.com/903566
> Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534661}

TBR=chrome-os-gardeners@google.com,chromeos-commit-bot@chromium.org

Change-Id: Ic6927bf3095a02736c79c5c8db6b5568194c1fd5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/904862Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534699}

Bug: 771643
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4d2973be5eb7b13351de62d283b5feb88fa42490
TBR: 
Reviewed-on: https://chromium-review.googlesource.com/903104Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534698}

Like previous RLS rebaselines, the layer trees reflect composited
scrolling layers for documents, the elimination of PLC layers on
iframes, and "flattenInheritedTransform": false (crbug.com/778060).

"Child Containment Layer" appears for iframes that are composited by
transform, but lack scrolling layers because they have no overflow or
have scrolling="no" (crbug.com/784053).

Bug: 544140
Change-Id: I03f5cf370724ff2f00de8f8f6b497fa0f39af76e
Reviewed-on: https://chromium-review.googlesource.com/902746Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534697}

This test uses a client side redirect which causes two navigations.  The
first navigation loads the html document which has a meta refresh tag in
it. The second navigation is caused by the redirect itself. The existing
code would only wait for the *first* navigation to complete.

On fast machines, this isn't a problem as the race would be usually won
and the redirected page would be present when we reached the GetTitle
check. On slower machines, it seems that this race is more frequently
lost.

This CL changes the test to wait for two navigations before continuing.

Bug: 809187
Change-Id: If88bff4bcd8ff3cb5be23b54b9675c3edbe17983
Reviewed-on: https://chromium-review.googlesource.com/903239Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534696}

In a hack was added to remember the position of last mouse down/up for context menus. The hack was
intended to fix the position of context menu for BrowserPlugin-based <webview>'s under
CSS-transforms. The code was added here: https://codereview.chromium.org/1293963002

With <webview> being implemented on top of OOPIFs now we no longer require such a hack to draw
the context menu correctly. The code is currently stale and does not ever get called.

Bug: 533069
Change-Id: I5f78c02210f0255c66df3f01622b6a0ffead801e
Reviewed-on: https://chromium-review.googlesource.com/900702
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534695}

Bug: 809537
Change-Id: I54951259e0b64944c92c0d28e06f16e4584b7460
TBR: reillyg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/904643Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534694}

Assuming based on a small amount of evidence that there may be a bug
causing some ChannelAssociatedGroupController instances to leak, this CL
ensures that in such cases, the object's outgoing message queue will not
also leak.

Bug: 808725
Change-Id: I256dd264b811f9ccb8e8e3ee86f2b58f916f1560
Reviewed-on: https://chromium-review.googlesource.com/902813Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534693}

TBR=jmadill@chromium.org

BUG=809297
BUG=angleproject:2303

Change-Id: I5bd998c3b7eec3dfbba2a8012eba61da0e2b4041
Reviewed-on: https://chromium-review.googlesource.com/904686Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534692}

The user hash of the active user is needed so crosh can determine which
logged in user initiated a command. Crosh will use this data to pass the
correct paths to commands that run containers on Chrome OS.

Bug: 770766

R=chirantan@chromium.org, tbarzic@chromium.org, vapier@chromium.org
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Change-Id: I0e9ef3685dc3f01f15cfb428594b2f9752586676
Reviewed-on: https://chromium-review.googlesource.com/896105Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534691}

Bug: 807324

Without the proper fix, this image is truncated. Test that it is not.
This image was posted to the bug (as d_AppReq.png), and the owner has
given permission to use it:

https://bugs.chromium.org/p/chromium/issues/detail?id=807324#c25

Change-Id: I114017e3cc625e0ac6c69056e34b0ee1ad906bb0
Reviewed-on: https://chromium-review.googlesource.com/904262Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534690}

This CL update the wpt test pointerevent_pointerlock_after_pointercapture.

Previously this test request pointer lock on pointermove, it got a
pointerlockerror event because it doesn't request the lock in a user gesture.
This CL change the test to send lock request by a right click.

Bug: 805052
Change-Id: I27b60475ccda94ca59e018ab76550379bc3852e4
Reviewed-on: https://chromium-review.googlesource.com/902450Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534689}

This issue was identified in the Russian translation, in which the
translation currently used doesn't make sense in that context. We
decided to make the string more specific and add a meaning tag to
keep it from sharing translation with other "Reset" strings in
Chrome (such as reset some color).

Change-Id: Ic8d279d450abfdce718d65be752fe8ee6cdeaf31
Reviewed-on: https://chromium-review.googlesource.com/902808
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534688}

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I4187878bfb627fb0983dca3a218c65f86d889f7c
Reviewed-on: https://chromium-review.googlesource.com/902624Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534687}

Bug: 717696
Change-Id: I6ff0a2ca192b2fe11426f59336a5e5efe2a8b76e
Reviewed-on: https://chromium-review.googlesource.com/887724Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534686}

Pass correct status of network to error handler's constructor.

R=jam@chromium.org, juliatuttle@chromium.org

Change-Id: Ie48ab19418c87f20f0b441fbe1ab6d44a503da22
Reviewed-on: https://chromium-review.googlesource.com/878327
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534685}

This lets me change how it's actually passed to op-specific Complete
callbacks freely, which I want to do, but is easier to review as a
separate change, plus moving a unique_ptr to int feels a bit... silly.

Change-Id: If8a3f445779477c4388daf060608fe64858507ec
Reviewed-on: https://chromium-review.googlesource.com/902522Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534684}

Currently Android Chrome is opening LINK tab as second in
new context menu with two tabs. It can lead to many mistakes
when user want to use fast "Open in new menu" for links.

Patch is forcing changing tabs order and opening this menu
on LINK tab in every situation.

Bug: 799417
Change-Id: I1ef989a62501859c45e8a0ee36e6e685e234ed72
Reviewed-on: https://chromium-review.googlesource.com/880945
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534683}

Following bot results are included.
3583 3584 3590 3592

8 lines were removed and 34 lines were deflaked by consecutive results
since 3530.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iabc3379f135f494fc26af2fb8b9c41acd771846d
Reviewed-on: https://chromium-review.googlesource.com/903525
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534682}

40 rebaselines from a manual review of the ToT bot result at:
https://storage.googleapis.com/chromium-layout-test-archives/linux_layout_tests_layout_ng/3573/layout-test-results/results.html
3573

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id8eeebf05202c345d97b673b1fbd7c1d6dcef407
Reviewed-on: https://chromium-review.googlesource.com/903208
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534681}

Bug: 809383
Change-Id: I579866fdcecb747365aabb91e8e53d36486b38db
TBR: lazyboy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/903771Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534680}

Bug: 809367
Change-Id: If1a3e114a0bb31bfb99d54ec17396bb6bf556227
TBR: haraken@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/903922Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534679}

This is useful when we have a window hierarchy like this:
  WebContentsViewAura (x=0, y=0, w=10, h=10)
    RenderWidgetHostViewAura (x=0, y=0, w=10, h=10)
The WebContentsViewAura is covered by a child, but when comes
the time to determine the occlusion state of the WebContents,
we would like to get NOT_OCCLUDED.

Asking clients of the API to traverse the window tree themselves
to determine whether a window has a non-occluded child would be
error-prone, as occlusion states aren't updated atomically
(e.g. if Hide() is called on the RenderWidgetHostViewAura, its
occlusion state will be updated to OCCLUDED before the occlusion
state of the WebContentsViewAura is updated to NOT_OCCLUDED).

Bug: 668690
Change-Id: I3a2777be37ce697d7215396b6626bce6ff72416c
Reviewed-on: https://chromium-review.googlesource.com/832828
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534678}

This experiment is no longer useful, and it has been decided
to not implement the feature with the Chromium component
updater. Instead, Chrome on Android will rely on split APKs
to reduce the size of the main application APK.

BUG=766746
R=sorin@chromium.org,mpearson@chromium.org,waffles@chromium.org

Change-Id: I13d934e8f82a239688c9c1d02be3f3e299b8587b
Reviewed-on: https://chromium-review.googlesource.com/902104Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534677}

Reasoning given in the umbrella bug (crbug.com/806965).

TBR=jam@chromium.org

Bug: 806965
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7014b91a610c49e98fda3c78917637efb26f54f1
Reviewed-on: https://chromium-review.googlesource.com/901663
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534676}

This CL introduces a CommitSameDocumentNavigation method in mojom::Frame, along
with a specific path to handle it in FrameLoader. Same document navigations are
handled very differently from different document navigations in the renderer,
and this simplifies the code path for their handling when the same-document
navigation is browser-initiated. This is a preparatory work for introducing
per-navigation Mojo interfaces. These interfaces will only be used for
different document navigations. Same-document navigations will still be handled
by the Frame directly, through the IPC this CL introduces.

This CL also fixes an issue with same-document navigations in out-of-process
iframes. Browser-initiated same-document navigations would see their
FrameLoadType recomputed at commit type, which sometimes caused them to be
wrongly classified as non same-document and dropped. By taking a same-document
path from the start, we ensure that FrameLoader doesn't recompute the
FrameLoadType for same-document navigations.

Bug: 788901,784904
Change-Id: Ie2fbef9afd9c99d22b7bb6d33170eaa5e32de622
Reviewed-on: https://chromium-review.googlesource.com/817296Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534675}

Bug: chromium:807886
Change-Id: I5bc1a654954d65b527e297a27ae7d3417e97b3e6
Reviewed-on: https://chromium-review.googlesource.com/902799
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534674}

Bugs reassigned:
* https://crbug.com/807128: recently filed, dupe to 622387?
* https://crbug.com/637525: was duped to 754870
* https://crbug.com/615908: was duped to 754870
* https://crbug.com/724923: was duped to 622387
* https://crbug.com/808343: recently filed, dupe to 622387?
* https://crbug.com/435449: marked as “fixed” but still disabled. Dupe
                            to 754870?
* https://crbug.com/725420: was fixed and test re-enabled! \o/ Remove
                            the TODO.

Bug: 622387, 754870
Change-Id: I4fb525e09a5c50aa521697b187baac310eade7a9
Reviewed-on: https://chromium-review.googlesource.com/901265Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534673}

This reverts commit 61a0f661.

Reason for revert: Broke jumbo builds.

Original change's description:
> Extract signed exchange contents from CBOR
> 
> This patch teaches SignedExchangeHandler to decode signed exchange
> body encoded with the application/http-exchange+cbor format [1].
> 
> The test file origin-signed-response-iframe.htxg was created using
> gen-signedexchange of [2] with the following command:
> 
> gen-signedexchange -uri https://example.com/test.html \
>     -content test.html -o origin-signed-response-iframe.htxg \
>     -miRecordSize=100
> 
> where test.html is the html part of origin-signed-response-iframe.php
> before this patch.
> 
> [1] https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#rfc.section.5
> [2] https://github.com/WICG/webpackage/pull/119
> 
> Bug: 803774
> Change-Id: I4d7bf5215e825cfa084c431db6d2cc87219d0a34
> Reviewed-on: https://chromium-review.googlesource.com/897172
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534643}

TBR=kinuko@chromium.org,ksakamoto@chromium.org,kouhei@chromium.org

Change-Id: I07fe69d5feb7c4fe7a9087863feebe8ea672832d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803774
Reviewed-on: https://chromium-review.googlesource.com/903982Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534672}

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug: 624694, 804694
Change-Id: I0c9b53b15ddca0b65312f599f1cc83ace14f8b75
Reviewed-on: https://chromium-review.googlesource.com/896678Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534671}

This patch changes "cjk-segmentation.html" to utilize |selection_test()| for
ease of maintenance.

Bug: 679977
Change-Id: I16b890ca44f5de5199282ffb9c7d82ba1ed7d56c
Reviewed-on: https://chromium-review.googlesource.com/903025Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534670}

chrome.bookmarks.removeTree is asynchronous. The test wasn't waiting
for the result of removeTree before proceeding, hence there was flakiness.
This CL changes the test (getRecentSetup) so that we wait for all steps
to complete before proceeding to next test.

This CL also modifies BookmarksRemoveTreeFunction to not inherit from
BookmarksRemoveFunction. Instead make both of them inherit from
a separate base (BookmarksRemoveFunctionBase). This eliminates the
potential of incorrectly calculating |recursive| variable, because the
current code relies on pointer equality (ExtensionFunction::name() ==
BookmarksRemoveTreeFunction::function_name()) test. The pointer
equality check isn't supposed to be stable and it readily fails
on ASAN bots.

Bug: 383452
Change-Id: Idf3995750b4f7ab647caebe8d1c777a19e708d1e
Reviewed-on: https://chromium-review.googlesource.com/899853
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534669}

This is a reland of 9784fa2f.
(was: reverted due to potential perf regresssion crbug.com/806216)

Original change's description:
> Remove dead code after multiple shadow removal [2/5]
>
> Remove
>  - ElementShadow::YoungestShadowRoot()
>  - ElementShadow::OldestShadowRoot()
>
> TBR=mlamouri@chromium.org for media_controls
>
> Bug: 795221
> Change-Id: I391b737acf04b45978ab1474725314442c979a06
> Reviewed-on: https://chromium-review.googlesource.com/828344
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531452}

TBR=mlamouri@chromium.org for media_controls

Bug: 795221
Change-Id: I01c0bc0565c525346c4de2e0f51a2b81c945accf
Reviewed-on: https://chromium-review.googlesource.com/903643Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534668}

This test is flaky with the ServiceWorker servicification
More details in https://crbug.com/808964.

The previous test was checking the UseCounter immediatly after a new
window loads. It is racy because the UseCounter state is sent in
ServiceWorkerProviderHost::SendSetControllerServiceWorker(). In the case
of a very slow browser process, it can happens after the new window
loads.

Instead of checking the UseCounter state after a window loads, it uses
an observer to wait until its state is updated.

Bug: 808964
Change-Id: I53c2bf2775a837a3a4b0c6cf9b196f26fe7b7f5e
Reviewed-on: https://chromium-review.googlesource.com/901610Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534667}

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug: 624694, 804694
Change-Id: Ia70a8e31394d9d3e6897271a0aa88027824467ef
Reviewed-on: https://chromium-review.googlesource.com/901062
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534666}

Editor::FindStringAndScrollToVisible only used in TextFinder.cpp, split
it to FindRangeOfString() and ScrollToVisible(), move ScrollToVisible()
to TextFinder.cpp as a static function.

Bug: 672405
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ic86f7bf824c41c3c01bec29e266df32388f59309
Reviewed-on: https://chromium-review.googlesource.com/903203Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534665}

This was causing a crash in interactive_ui_tests on Windows each time a
test timed out.

Based on a comment deep in WebRTC's capture code about a UI message
loop, I had previously taken pains to run a loop when capturing the
screen. Following some changes to base, this leads to a DCHECK failure
when the RunLoop is started. Looking deeper in WebRTC, I don't think
that a UI message loop is needed for the use at hand. In particular, the
comment was with regards to the use of the magnification API. Use of
this API is explicitly disabled by SaveDesktopSnapshot, so the capturer
is fully synchronous and doesn't need a message loop at all.

BUG=756338
R=sky@chromium.org

Change-Id: I92679a213e7bdf8dde03e0ab8e02c36f0fe2804b
Reviewed-on: https://chromium-review.googlesource.com/899349Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534664}

The test is a unit test, put it in the proper target.

Bug: None
Change-Id: I7b872fab8682552ae63161149c8ededfbcf9c27c
Reviewed-on: https://chromium-review.googlesource.com/903243
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534663}

This patch removes a redundant class specifier |LayoutObject::| for
|SetSelectionState()| call in |SetSelectionStateIfNeeded()| because
it is non-virtual member function for improving code health.

Change-Id: I68b58d07c5452e36e05b1a20a3e5d20eeee90237
Reviewed-on: https://chromium-review.googlesource.com/903524Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534662}

TBR=chrome-os-gardeners@google.com

Change-Id: I528bfa26dc2aa797c5c2e5911fa28f6055a03f67
Reviewed-on: https://chromium-review.googlesource.com/903566Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534661}