GitLab

BUG=127299
TEST=
1. go to chrome://bookmarks/
2. be sure, the cursor focus is in the search box
3. take a look at the search box
4. It should be the same as the search box in chrome://downloads/ when focused


Review URL: https://chromiumcodereview.appspot.com/10383200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137522 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a PyAuto test for the DeviceGuestModeEnabled policy which
enables/disables guest login on Chrome OS devices.
As a prerequisite, the browser automation framework is fixed so that it
does not wait for the login screen to be shown when the account picker
is enabled instead.

BUG=128343
TEST=New PyAuto ChromeosDevicePolicy.testGuestModeEnabled


Review URL: https://chromiumcodereview.appspot.com/10382197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137521 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes ImageSkia more like SkBitmap. The goal is to make swapping from SkBitmap to ImageSkia easier.

Notable changes:
- ImageSkia can be cheaply copied
- Added extractSubset, will remove after SkBitmaps have been converted to ImageSkia
- Modified API to look more like SkBitmap

Review URL: https://chromiumcodereview.appspot.com/10245003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137520 0039d316-1c4b-4281-b951-d872f2087c98

Found via Eclipse.

BUG=none
TEST=none
R=groby


Review URL: https://chromiumcodereview.appspot.com/10391167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137519 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137518 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10377177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137515 0039d316-1c4b-4281-b951-d872f2087c98

It needs this for Password Manager. It could be that we could just construct the Password Manager for this type, but this is the simplest fix.

http://crbug.com/127110
TEST=See bug, configure proxy with auth required and open GAIA frame at sign in screen.

Review URL: https://chromiumcodereview.appspot.com/10388166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org
TBR=tim@chromium.org, davemoore@chromium.org, scottbyer@chromium.org, keybuk@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10391158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137511 0039d316-1c4b-4281-b951-d872f2087c98

SelectAll when activating the omni box via touch. Regular (short) touch should now work the same way as mouse left click and a long press the same as right click.

BUG=127293
TEST=Activate the omni box via touch.  All the text in the omni box should be selected.


Review URL: https://chromiumcodereview.appspot.com/10332197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124269
TEST=None yet, except that tests pass; will be used for further testing.

Review URL: https://chromiumcodereview.appspot.com/10391170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10389161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137502 0039d316-1c4b-4281-b951-d872f2087c98

In addition to the at-launch reauthorization, this adds an at-update
reauthorization step. It only runs for users not on a system Keystone ticket,
because the updater runs as root when on a system ticket, and root can't read
individual user's Keychains. The at-update reauthorization is intended to
handle the reauthorization for users who rarely restart Chrome and might miss
out on the at-launch step during the window where Chrome is signed by the old
certificate but has the new reauthorization code in place. The at-update
reauthorization step can remain in place even after the certificate switch
occurs by shipping an old reauthorization stub binary signed with the old
certificate.

BUG=108238
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10377173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137501 0039d316-1c4b-4281-b951-d872f2087c98

Revert 136042 - Make sure only the main browser process and service proceses are allowed to create the profile directory.

This patch lets Chrome start with profile located on a network share on
Windows Vista and newer.

BUG=120388
TEST=Start Chrome with --user-data-dir pointing to a network share location and try to navigate to a web page. This should not lead to a hang of the renderer.


Review URL: https://chromiumcodereview.appspot.com/10332056

TBR=pastarmovj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85132
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10083060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137498 0039d316-1c4b-4281-b951-d872f2087c98

removed the unnecessary files that I didn't remove in last CL.

TBR=cpu@chromium.org
BUG=10381138
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10389149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137497 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10386171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137496 0039d316-1c4b-4281-b951-d872f2087c98

There were two subtle changes in how we stored the file system metadata
in a proto file, and each change broke compatibility in a subtle way.
We should discard the proto file if old formats are detected.

Note that the protobuf definitions in gdata.proto were kept compatible.
The problem was in how we stored data in the protobuf, and the changes were
subtle.

BUG=128133
TEST=confirmed that the google drive loaded with the stale GCache directory from josh

Review URL: https://chromiumcodereview.appspot.com/10384204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137492 0039d316-1c4b-4281-b951-d872f2087c98

We do this by keeping a list of pre-sync deleted GUIDs, which is populated whenever a TemplateURL entry is removed from the DB during startup merging. We then use this list to ignore the appropriate entries from Sync, and to inform Sync that they should be deleted.

BUG=128210
TEST=unit_test TemplateURLServiceSyncTest.PreSyncDeletes


Review URL: https://chromiumcodereview.appspot.com/10384188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137490 0039d316-1c4b-4281-b951-d872f2087c98

It was broken by https://chromiumcodereview.appspot.com/10384140.

SOLINK_MODULE(target) out/Release/remoting_host_prefpane.prefPane/Contents/MacOS/remoting_host_prefpane
Undefined symbols:
  "_modp_b64_decode", referenced from:
      -[Me2MePreferencePane onApply:] in me2me_preference_pane.o
ld: symbol(s) not found

This doesn't happen in the components build because the prefpane still
depends on base via

 tools/gyp-explain.py     remoting_host_prefpane modp_b64
These paths lead from remoting/remoting.gyp:remoting_host_prefpane#target to third_party/modp_b64/modp_b64.gyp:modp_b64#target:
remoting/remoting.gyp:remoting_host_prefpane#target -> remoting/remoting.gyp:remoting_base#target -> base/base.gyp:base#target -> third_party/modp_b64/modp_b64.gyp:modp_b64#target

BUG=none
TEST=none
TBR=lambroslambrou

Review URL: https://chromiumcodereview.appspot.com/10389178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=gbillock

Review URL: https://chromiumcodereview.appspot.com/10387155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137488 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109630

Review URL: https://chromiumcodereview.appspot.com/10284008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137487 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114644
R=asargent@chromium.org
TEST=Docs should no longer show up as a default app for new profiles

Review URL: https://chromiumcodereview.appspot.com/10332206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137486 0039d316-1c4b-4281-b951-d872f2087c98

Two fixes are added. 1) We stay in the loop only if we will call
DoPayloadRead or DoPayloadWrite in the next iteration. 2) Don't call
BufferRecv again if BufferRecv has reported EOF before.

Each fix alone prevents the infinite loop.  The second fix is less risky.
If necessary, we can go with just the second fix.

R=rsleevi@chromium.org
BUG=127822
TEST=SSLServerSocketTest.WriteAfterPeerClose in net_unittests

Review URL: https://chromiumcodereview.appspot.com/10382186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137485 0039d316-1c4b-4281-b951-d872f2087c98

Move compilation thread into its own class to make future multiple 
implementations easier. Also split LocalTempFile into its own file to break
circular dependency.

R= sehr@google.com,jvoung@google.com,robertm@chromium.org
BUG=none
TEST=nacl_integration


Review URL: https://chromiumcodereview.appspot.com/10377157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137481 0039d316-1c4b-4281-b951-d872f2087c98

On ARM without libpci, vendor_id and device_id will return 0, and we should not disable GPU features because of this.

BUG=
TEST=ARM bots
TBR=sheu
Review URL: https://chromiumcodereview.appspot.com/10406011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137480 0039d316-1c4b-4281-b951-d872f2087c98

This makes ImporterHost use the cross platform function instead of using the one
that is Windows specific.

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10391097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137479 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9425014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137478 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this change, if we were to delete a newly-created item before
informing the sync server of its existence, it would end up in an
unusual state.  We do not commit deleted items unless they were known to
sync server.  However, these items were still considered to be
'unsynced' (ie.  waiting to be committed to the server) and therefore
impossible to entirely remove from the sync directory.  They remain
forever both IS_DEL and IS_UNSYNCED.

This had a few side-effects.  The most serious is that this behaviour
could cause directory corruption.  If we created a folder and a bookmark
within it, then deleted that bookmark before it had a chance to sync,
the bookmark would remain in a zombie state.  When we finally got around
to committing its parent folder, the folder's ID will change.  The
zombie bookmark's PARENT_ID will not be updated, leaving us with a
dangling reference that will be detected as directory corruption the
next time sync is loaded.  See crbug.com/125381 for details.

Another effect is that locally deleted, never synced UNIQUE_CLIENT_TAG
could have strange effects later on. If a foreign client were to create
an item with the same UNIQUE_CLIENT_TAG and sync it, this client would
conflict-resolve the update against the zombie entry.  The zombie entry
would win, the newly created item would be deleted, and the deletion
synced back to the server.  This may not be an entirely bad thing, but
it is a behaviour that's changed following this patch.  From now on, the
deleted item will be overwritten (if it still exists, which it probably
won't).

Finally, we now have a mechanism for permanently deleting these items.
With this patch applied, these items will no longer have the unsynced
bit set, so they will be deleted on restart by DropDeletedEntries().

This patch changes PutIsDel() to clear the IS_UNSYNCED bit of entries
which were never committed to the sync server.  The remainder of the
changes either add or update existing tests.

BUG=125381
TEST=SyncerTest.ClientTagUncommittedTagMatchesUpdate,
SyncableDirectoryTest.ChangeEntryIDAndUpdateChildren_DeletedAndUnsyncedChildren


Review URL: https://chromiumcodereview.appspot.com/10389103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137476 0039d316-1c4b-4281-b951-d872f2087c98

Update gtalk version. Note -- skipping presubmit since this is just swapping binaries (no code change) and the upload fails because the change is too large.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128199
TEST=aura_shell_unittests passed


Review URL: https://chromiumcodereview.appspot.com/10382178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137474 0039d316-1c4b-4281-b951-d872f2087c98

In case of LT2P-IPsec VPN configurations, the code would read the
Recommended flags for username and password from the wrong dictionary,
resulting in the corresponding text boxes being disabled inadvertently.

BUG=chromium:128097
TEST=See bug.


Review URL: https://chromiumcodereview.appspot.com/10377168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10382193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137472 0039d316-1c4b-4281-b951-d872f2087c98

The NaClIPCAdapter was not leaking, but the Channel deletion is posted as a task that the test was not running. This makes all the NaClIPCAdapter test cases do RunAllPending on shutdown to delete stuff. Unfortunately, one of the tests results in calling "Close()" on the channel in one of these tasks, and that fails for IPC::TestSink, because IPC::Channel::Close dereferences channel_impl_ unconditionally, and the channel_impl_ is NULL for TestSink. So this patch also makes Channel::Close() do nothing if channel_impl_ is NULL.

BUG=127954
TEST=


Review URL: https://chromiumcodereview.appspot.com/10383167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137471 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit e9c5d5d4.

TBR=fischman@chromium.org
BUG=None
TEST=vmtests go green

Review URL: https://chromiumcodereview.appspot.com/10386176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=functional/apptest.py


Review URL: https://chromiumcodereview.appspot.com/10386144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124269
TEST=Enable ash-notify in chrome://flags and ensure that ash system notifications for low batter appear instead of desktop notifications
TBR=ben for ash/

Review URL: https://chromiumcodereview.appspot.com/10406010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128388
TEST=See issue

Review URL: https://chromiumcodereview.appspot.com/10389175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137464 0039d316-1c4b-4281-b951-d872f2087c98

suspect the page is closing the constrained dialog, which deletes the
delegate so that if the dialog attempts to use the delegate we crash.

BUG=127370
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10383213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126682
TEST=See issue + ensure failing to connect to a wifi or VPN with bad credentials re-displays the connect dialog.
TBR=jhawkins for webui

Review URL: https://chromiumcodereview.appspot.com/10392097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137461 0039d316-1c4b-4281-b951-d872f2087c98

CID=103929
TBR=kalman@chromium.org

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10387143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137460 0039d316-1c4b-4281-b951-d872f2087c98