GitLab

This change will harden the setAutocomplete API making programming
errors less likely.

Previously the interactionModel parameter was stringly typed, now it is
typed as a enum so API misuse will be caught by closure's type checker.

This change was motivated by the thread on line 256 of the following CR:
https://crrev.com/c/1737872/3/third_party/blink/renderer/devtools/front_end/ui/ARIAUtils.js

Screenshot (proof the api still works): https://i.imgur.com/0geTYIg.png

Change-Id: I7f4fdd6009f182219db16c2e0ed3d9bfe4c663d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832247
Commit-Queue: John Emau <John.Emau@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706254}

This CL fixes a bug causing the color well selection ring to be scrolled
into view if it receives focus. The color well has overflow:hidden to
contain the selection ring within its bound, and so when the ring is at
the edge of the well, it is partially hidden. However, when the ring
gets focus (currently only possible via tab/shift-tab), the default
focus behavior shifts content and brings the ring wholly into view.

The .focus API has a preventScroll option that can used to prevent this.
However, there is currently no way to prevent the default focus behavior
from scrolling, which is what happens on tab. There has been some
discussion on this Github thread
(https://github.com/whatwg/html/issues/834) about this problem, but as
of now, no solution has been proposed to prevent tab or the default
focus behavior from scrolling. As a result, the fix being applied
herewith turns off the default tab behavior by calling preventDefault
on a tab keydown event and implements a custom tab functionality for the
color picker on top of .focus with preventScroll. (Instead of applying
this only to the color well, it felt more consistent to do it for the
entire color picker.)

There is another related bug in the color picker, where the selection
rings of the color well and hue slider do not receive focus when they
are clicked. This is also being fixed with this change, with a call to
.focus with preventScroll on mouse down. As a result of this additional
change, several tests started to fail due to the addition of a focus
rect around color selection rings. To minimize the rebaselining needed
with this change (as well as future changes), some tests that do not
need to be pixel tests have been rewritten as test harness tests. The
ones that need to remain pixel tests now have new baseslines that show
the focus rect.

Bug: 1013347
Change-Id: Ie985767cb64bc099c107223b75e3b21612a411dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854166
Commit-Queue: Sanket Joshi <sajos@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706253}

Bug: 1001839
Change-Id: Id27380f95b5c06f938826d4ec9a4725577034718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861041Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706252}

This reverts commit 61ae3ddf.

Reason for revert: Causing flaky GPU process crashes on Chrome OS webgl video tests
Bug: 1014756

Original change's description:
> media/gpu/v4l2vd: move stateless-specific parts into backend class
> 
> There are two V4L2 decode APIs: stateless and stateful. In the VDA era
> these were implemented as two completely separate classes
> (V4L2VideoDecodeAccelerator and V4L2SliceVideoDecodeAccelerator), which
> resulted in a lot of duplicated code and bugs due to fixes not being
> replicated on both classes.
> 
> For the VD-based decoder, we want to avoid doing the same error and
> use a single V4L2 decoder, supported by different backends depending on
> which V4L2 API we are using.
> 
> This CL is the first step towards that direction: it splits the
> V4L2SliceVideoDecoder into its general V4L2 part and the one that is
> specific to the stateless API.
> 
> Bug: 1003223
> Test: video_decode_accelerator_tests passing on Kevin.
> 
> Change-Id: I373f3ea739b6799ecad009d053ca7e415b8484bd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840034
> Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: David Staessens <dstaessens@chromium.org>
> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705894}

TBR=akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org

Change-Id: Ieb4fe2152e8d8a2c21a5eccaa5c13bdaf5c3b91d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1003223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864095Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706251}

For Chrome OS we just get it from the active user. For other platforms
we do the same but only as a best effort since we are not testing it,
so after a NOTREACHED(), and replacing the current best-effort return
of an empty string.

Bug: chromium:1012048
Test: browser_tests
Change-Id: I8af942cfb01f9be6c0061b1271a395fe3768f1b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859676Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706250}

R=pkasting@chromium.org

Bug: 1014142
Change-Id: I1056cae1b0702cf3a525b336fd49468bc32001c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859682
Auto-Submit: Stephen Lin <stephenlin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Stephen Lin <stephenlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706249}

This CL adds CommonAppsNavigationThrottle to handle URL for Intent
Picker with the App Service intent handling. Currently this only
includes querying apps with a URL and launching apps with a URL for
ARC apps and PWAs. Persistency and metrics are not implemented yet. This is a
simplified version to test the intent handling for the App Service. Later
this file will be implemented properly and replace the
AppsNavigationThrottle and ChromeOSAppsNavigationThrottle.

BUG=853604

Change-Id: I0b6b5a4cd9547f67ee2c8758692184b53d173e38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859419Reviewed-by: Maajid <maajid@chromium.org>
Reviewed-by: Shao-Chuan Lee <shaochuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706248}

This reverts commit a9df5b29.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 706076 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E5ZGY1YjI5ZmEyMzliNzQ5N2VjMmQ1NTFlNWNmNDQ3MDMzMGRiNDUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/15311

Sample Failed Step: browser_tests

Original change's description:
> Handle Safety Tip learn more link in page info
> 
> Bug: 1007497
> Change-Id: I4498d39cabf4736a697294ad027082a53894a623
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857166
> Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Commit-Queue: Livvie Lin <livvielin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706076}


Change-Id: I017d2046e5fce908c8f86ea2b2726d88b590a3da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1007497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864001
Cr-Commit-Position: refs/heads/master@{#706247}

Bug: 987646
Change-Id: I218a1e8857b1a22554e6e6435e0a42699938c5f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862728
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706246}

Bug: 992235
Change-Id: I306376ffee367eab9eb96b47b7c238d73018f5b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863128Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706245}

We're unsure if there are errors stemming from one of the APIs that the
DriveQuickAccessProvider implicitly relies on. This CL adds debug
metrics for all operations that could error within the provider.

There are a lot of metrics here, and we plan to remove them once we're
confident the feature is working as intended.

Bug: 1011221
Change-Id: Iea9a3ee3237de88fe30bba6705adcebd962338b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857800Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706244}

This CL ensures that fido_authentication_info is not set if it does not contain
any data.

Bug: 949269
Change-Id: I27ced9ba881d17c66bfc10c8467f9588ff91c091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863642Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#706243}

This is a leftover from the patch of:
"[WebSocket] Do not send response headers for failed handshake."
https://chromium-review.googlesource.com/c/chromium/src/+/1847592

Change-Id: I9f18da76d3ff69ef04b1492890831a6ca2611202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860735
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706242}

Even though the suggestion view and the keyword view take up the same space,
that doesn't mean the suggestion view is guaranteed to be at least as large as
the keyword view.  Use the max of the two sizes.

Bug: none
Change-Id: Ia08506e8ce2742ce09833930572c278c2ceb9909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857652
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706241}

TBR=meacer@chromium.org

Change-Id: Id2dba6d14a42857c4de7e37c24ca7ef30b5aa7a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862665
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706240}

In order to detect potential rage click type user unhappiness with the
DeferAllScript previews, we need the ClickInputBurst count metric
recored to UKM so we can determine sites that should not receive the
preview.

Bug: 1014532
Change-Id: Ib91c1574dd04689d846ce7eebf83193d48424751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854782Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706239}

In the sources panel, the "More options"button should be marked with aria-haspopup="true" since the menu that opens is a popup which must be closed/escaped before the rest of the content in the page can be accessed.
MAS 1.3.1

Bug: 963183

Change-Id: I20183e6d35aa85b9705763de4a4c433ae1325505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665299Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Anubha Mathur <anubmat@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706238}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6dd74cc6ed0..821fe40443ea


Created with:
  gclient setdep -r src-internal@821fe40443ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Id3d13335b84ad4a58600db5c0f1c6c4f005eace3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862271Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706237}

* For all fields currently available for a Fuchsia Semantic Node,
convert from a Chrome AXNodeData.

Testing: Added unit tests, AXTreeConverterTest.

Bug: 973095
Change-Id: I95b899f1bdd9a516067483ed441cfe098fd6e5a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832822
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706236}

In ARC, activation of a window is mapped to activity stacking.
Notifications, which are not activities, are always placed at the top
of windows.

When an inline notification and an activity with an input field are
shown at the same time, it causes an issue because regardless of the
activity having focus, the notification always receives keyboard input.

In order to fix that, we have to forward ash side activation through
mojo and reflect it to the NOT_FOCUSABLE flag of notifications.

A Tast test for this will be added.

Android side CL: http://ag/9537575

TEST=manual (Follow the repro steps in the bug.)
BUG=b:142103828

Change-Id: Ifda5532b498ef9ea01ee70836813ae700a6ec58f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855545Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706235}

https://skia.googlesource.com/skia.git/+log/b7c5bac9da28..20c626aa2358

git log b7c5bac9da28..20c626aa2358 --date=short --no-merges --format='%ad %ae %s'
2019-10-15 senorblanco@chromium.org Update Dawn backend to ToT.  This is about 3 months of changes.
2019-10-15 egdaniel@google.com Remove use of GrColorType as in param in SimpleTextureEffect.fp to just constructor param.

Created with:
  gclient setdep -r src/third_party/skia@20c626aa2358

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@google.com

Bug: None
Change-Id: I35d7bfb335459364bfa5fa9fc8cf29e9b3283cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862270Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706234}

DO NOT REVERT THIS CHANGE. This change may cause discontinuities in
perf results by
changing which bot stories are run on. It does not make any changes to
Chrome itself. More info in the following post on perf sheriff group:
https://groups.google.com/a/chromium.org/forum/#!topic/perf-sheriffs/IQFj65XeslM

The current shard map and the timing data have been 6 months old.
In order to have a better optimized shard map, we need to refresh
the timing data and re-generate the shard map.

Timing data and shard map are refreshed by running the following
script:
/src/tools/perf/generate_perf_sharding

Currently we have 18 shard maps to update and only 17 of them are
updated in this CL. The other one android-nexus5x-perf was updated
in an earlier CL together with the shard size change in:
https://chromium-review.googlesource.com/c/chromium/src/+/1862995

Bug: chromium:1013767
Change-Id: Idcc0e07cef67e989e34a0bc88e62771149b1bc15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861000
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706233}

Using wpt-import in Chromium a37797f5.
With Chromium commits locally applied on WPT:
6386d9d8 "Update service_worker_unregister_and_register()"
f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/IndexedDB

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I5a8f1e303f2276b66f008f1cf7151c6102e9b919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863436Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706232}

Now CupsProxyService correctly updates CupsPrintersManager when it
successfully installs a printer into CUPS. Since any print job involves
many IPP requests, each of which could trigger a printer install, this
caching debug daemon calls.

Bug: chromium:945409
Test: updated unit_tests pass
Change-Id: I4d0cba3e5cbe35c5acd2a78fc5a94ff73da5cf1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863729Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706231}

Bug: 1014671
Change-Id: Ia84e5de9664859c0f5ba53ad0b32e13ffc761451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863733Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706230}

AppListControllerImpl::OnDisplayConfigurationChanged is called when the
screen rotates.

We recently refactored some visibility functions, this caused the bug.
We should check presenters visibility, not the target visibility.

Bug: 1012432
Change-Id: I2033484115de22f72fac997258c4013872e2d784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861154
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706229}

Marking the checkbox container as a group role and labeling it meets the
following WAI WCAG 2.1 success criteria and allows for screen readers to
announce the group label when focusing on a checkbox.

1.3.1 Info and Relationships - Level A
https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships

3.3.2 - Labels or Instructions - Level A
https://www.w3.org/WAI/WCAG21/quickref/#labels-or-instructions

Screenshot (NVDA Speech Viewer): https://i.imgur.com/ptmRGzu.png
Screenshot (Accessibility Tree): https://i.imgur.com/EUTyhTV.png

Bug: 963183
Change-Id: Ia801a9a74ca897b6bc94705d72109bd231b00653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695853Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: John Emau <John.Emau@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706228}

Bug: 859382
Change-Id: I42dcd7219cb0dba659f201d022444265a6a4b183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864012Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706227}

Previously the accessible name for the audio context selector was 'BaseAudioContext'.

With this change the accessible name becomes `Audio context: ${content title}`
and if no context is selected: `Audio context: (no recording)`.

This is a much better experience for screen reader users and meets success
criteria for WCAG 2.5.3 Label in Name https://www.w3.org/WAI/WCAG21/quickref/#label-in-name

Test page: https://mdn.github.io/webaudio-examples/audiocontext-states/

Screenshot (NVDA Speech Viewer):  https://i.imgur.com/m5pKYnx.png (NOTE: This screenshot was taken with https://crrev.com/c/1626643 applied to better screen reader support)
Screenshot (Accessibility Tree): https://i.imgur.com/e04n8m9.png

Bug: 963183
Change-Id: I89e14599313766e7bd2be8a6a953df28c648dbe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711008Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: John Emau <John.Emau@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706226}

Change-Id: Id28394f3d11e190c58b05e37dbdfbef34d95a7d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862857
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706225}

This CL allows the user to select "open now" to open a download, while
the deep scanning is still pending. This is important for enterprises
which don't want the large increase in user friction caused by blocking
access to the file.

New UI screenshots: https://screenshot.googleplex.com/xwXViHi2u3R.png
                    https://screenshot.googleplex.com/RE102LjRAA2.png
Mocks: https://docs.google.com/presentation/d/1MH7zM5YiuCZr3jYsqkTJRC0cqtdo8wuWZOOQ66jptVk/edit#slide=id.g5d9bcde872_0_0

Bug: 980777
Change-Id: I8a2e6844ff5ab68c4faa3e75a0e4eed2064a3be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848357
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706224}

Bug: 1012878
Change-Id: I9c4c887d9fb5465d38da1cabbe1b52437235f948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863468Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706223}

This is a roll using my internal change to the exporter script
(http://cl/274893271). The main motivation is to roll the change to the
BUILD.gn file (to get the proto_java_library target), although this
also rolls miscellaneous proto changes which have landed since the last
roll.

Bug: 1011991
Test: None
Change-Id: Ibcbe003f0c386bd2081944c77ecc26a3cd88d559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862727
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706222}

As the macOS GPU sandbox now allows LaunchServices connections, remove
the API call telling it not to connect to LS.

Bug: 871280
Change-Id: Ic70da6796b6980c60c2e9ebdd897ccd4f588ea9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863630
Auto-Submit: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706221}

Use the attached browser CreateParams rather than
BrowserList GetLastActive.

It feels safer that the attached browser will always
be the one that we want whereas BrowserList GetLastActive
may not be so reliable.

Bug: 1012169
Change-Id: Ifbbc13aa797db7942f5ce1d52decdac264c5d927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862875
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706220}

With the Service Manager going away, the manifest files that previously
mediated access to Mojo services across processes are going away too.
Under the new system, various //content classes have methods that bind
mojo::Receiver<T> objects via GenericPendingReceiver. Since these call
sites control access to objects across a privilege boundary, they should
be under the SECURITY_OWNERS review system.

This first pass splits out several //content and //chrome ones, but
more to come.

Bug: 1012033
Change-Id: Ic09c825c8503c570393fa7ce4d89b58bb6efe391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848416
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706219}

This patch is one of a series of changes adding support
for resolving ESNI DNS responses [1] to the built-in resolver.

It contains
- a new RecordRdata subclass representing an ESNI record
- relevant parsing logic for ESNI-type RDATA
- unit tests exercising this parsing logic

A follow-up CL will contain additions to HostResolverManager and
HostCache to handle parsed records of the new type and propagate
the results up the callstack.

[1]: https://tools.ietf.org/html/draft-ietf-tls-esni-04

R=ericorth

Bug: 1003494
Test: Added unit tests to record_rdata_unittest.cc
Change-Id: Ib4446b46b19633fba92a8d14d34cf2f38ed14d1d
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845793
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706218}

Invalidate() is called more frequently (e.g. on color changes), while SetMatch()
is called only when the match actually changes.  So anything that is tied to the
match's content (e.g. the suggestion or keyword contents/description) can be
updated in SetMatch() instead of Invalidate() to save work without visible
change.

Also tweaks Layout() to check the keyword view's visibility instead of the
underlying state that controls it.

Bug: none
Change-Id: Ia0b7ca2566a621ad9315e54313f584c21f999668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857649Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706217}

This reverts commit 2fcffb28.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1014742

Original change's description:
> Record latency for Impl thread in case of no begin main frame.
> 
> This CL reports the latency in case of no begin main frame.
> This can happen in any of the scenarios below:
> 
> 1) WillBeginImplFrame -> DidFinishImplFrame -> DidSubmitCompositorFrame
> 
> 2) WillBeginImplFrame -> WillBeginMainFrame -> BeginMainFrameAborted ->
> DidFinishImplFrame -> DidSubmitCompositorFrame
> 
> 3) WillBeginImplFrame -> WillBeginMainFrame -> DidFinishImplFrame ->
> BeginMainFrameAborted -> DidSubmitCompositorFrame
> 
> In these cases there will be no latency to report for stages of:
> - SendBeginMainFrameToCommit
> - Commit
> - EndCommitToActivation
> But the latency will be reported for the remaining stages.
> 
> Bug: chromium:1003038
> Change-Id: Id0d6a65603b2b15a0ee04a6974a4bd0b2a5a803b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799026
> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705964}

TBR=sadrul@chromium.org,behdadb@chromium.org

Change-Id: Ide47f697ba94bdaf4b89564272afe1d7634296c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1003038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863840Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706216}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f18342d8..65084e6f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic501f15c5258d482064f35e802a2e5281b5e6055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863435Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706215}