- 18 May, 2020 40 commits
-
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include specific Custom Elements v0 tests, which should be fairly-well covered by existing WPT tests. This CL just moves this one folder: - fast/dom/custom Bug: 937746 Change-Id: Ic76746a5a43d0c86fe4ab6492f58862356421086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202124 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#769638}
-
Mason Freed authored
This policy allowed Enterprise users to re-enable the Web Components V0 features for several milestones. It was supported until M84, which has now branched for Beta. Bug: 911943, 937746 Change-Id: I0bb06e5cddc282cc1b31b45ff49f05c1ab004a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204306Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#769637}
-
Jerry Lin authored
Add new service worker util function 'IsMainRequestDestination' to check request type and replace usage of IsMainResourceType with it in ServiceWorkerNavigationLoader::StartRequest. Use destination of ResourceRequest to check corresponding request type is kScript instead of using resource_type in ServiceWorkerSubresourceLoader::StartResponse. Bug: 1062579 Change-Id: I90e44ad7f1e06dfe65fb03e4cbba83dfbd0bbf8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108444Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Jerry Lin <wahahab11@gmail.com> Cr-Commit-Position: refs/heads/master@{#769636}
-
sandromaggi authored
Similarly to the startup condition for SRP (must come from a Google domain), if the user navigates back to a Google domain, remove the UI instead of showing the error message. Bug: b/156387203 Change-Id: I432becb75cbf138ef6a2a70a76e7c61b612e3243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203061 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#769635}
-
Kenichi Ishibashi authored
The test is failing on android-marshmallow-x86-fyi-rel. We suspect the failure comes from writing large metadata. This CL reduces the size of metadata to attempt to fix the failure. Bug: 1081502 Change-Id: I3c8ebac33b1ec757b00aff56e2d8eb9da55b652f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202825Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769634}
-
Alexey Baskakov authored
This reverts commit df7b4f83. Reason for revert: Causes MSAN failures on ChromeOS bots. First failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19151 See BrailleDisplayPrivateApiTest.KeyEvents BrailleDisplayPrivateApiTest.WriteDots Original change's description: > Plumb through an api to get display cell size from brltty > > R=dmazzoni@chromium.org > > Test: manual; verify a cell size of 8 on a display, when call chrome.brailleDisplayPrivate.getDisplayState, on a 8-dot celled braille display. > Change-Id: I25a2517e2a6ff29b38746a7ddfb8294669476d9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194339 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769511} TBR=dmazzoni@chromium.org,lazyboy@chromium.org,dtseng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2e8452b558b70eb565f824072f0ec38fd125eb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206198 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#769633}
-
Yusuke Sato authored
BUG=b:155128030 TEST=try Change-Id: Ic03e43b2ba8af5453f376417e5312b76c14274e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203274 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#769632}
-
Marc Treib authored
This CL splits the .TotalAccountsHiRes.WithScheme, .EmptyUsernames, and .InaccessiblePasswords histograms by account store vs. profile store, by adding a ".AccountStore" infix. A few metrics are left un-split (and not recorded for the account store at all); those are the ones that don't make much sense for the account store. Bug: 1063852 Change-Id: I449908e8ffb01c5b7b6729a3c8b5024a8f5b54f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198993Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#769631}
-
Keith Lee authored
The preferences are used to define persistent storage of maps of strings to boolean values which can be used for implementing crbug.com/1060965 and other assistive features. Change-Id: Ibe93ac0f4ec85333840d3e9a8547ebee4a445d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126429 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#769630}
-
Mathias Carlen authored
Before this patch we would pass an empty bundle to the unchecked Consumer callback interface. The corresponding test got disabled a while back due to trying to verify that. The Consumer interface for direct actions expects a List<>, which is what this patch fixes. This in turn exposed a bad test requirement for performing an action, where the response should be an empty bundle for disable direct actions and not fail as the test was written. Bug: 1034712 Change-Id: I1d49d6ebb65dade9e1b0967babde9443e694e4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201777Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#769629}
-
Roman Sorokin authored
Show the tpm error message by wizard controller. Remove all the dependencies on SigninScreenHandler and CoreOobeHandler Bug: 1082160 Change-Id: I171d678ed4bcce0e44fbe83094a9bc7372883553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190652 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#769628}
-
Yusuke Sato authored
This depends on ag/11478296 (and Android PFQ roll for the CL.) BUG=b:141891239 TEST=arc.Boot.vm Change-Id: Ic585c1373b0d832120cac0b553ffd590480c6dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144689 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#769627}
-
Jia authored
TokenSetRatio calculates pairwise string match ratios between the following three and returns the max as the final result. (i). intersection string (of query & text) (ii). query rewritten (intersection + query_diff_text) (iii). text rewritten (intersection + text_diff_query) If we enable partial match, then (i) and (ii) or (i) and (iii) will return extremely high ratios (close to 1) if intersection is non-empty. This means if there is any common word between query and text, the result ratio will be too high. This cl disables partial match in TokenSetRatio. Bug: 1081584 Change-Id: If4062c367f74be62a733d6b0e3d54353bfba1365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206057Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#769626}
-
chrome://media-appTrent Apted authored
This involves adding a conformance config to enforce the rule provided by com.google.javascript.jscomp.ConformanceRules$BanNullDeref. Fix the current non-conformance in release code. A follow-up will fix the test code. One instance in the Message.SAVE_COPY handler was likely a real bug. Bug: 1068428, b/156695190 Change-Id: I80cb6b78b8b734cc272e636a1c680066af8ef0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203348 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#769625}
-
Roman Sorokin authored
A lot of edge cases could happen during online signin. So disabling it for the multiprofile user adding flow. Fixed: 690187 Change-Id: Idce44f3ef3c63a9dbd9d9e32af07733cd317f836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202805 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#769624}
-
Glen Robertson authored
interaction." Disabled all added tests on Mac as they are flaky. Original CL: crrev.com/c/2160638 Revert 1 CL: crrev.com/c/2203240 Reland 1 CL: crrev.com/c/2206060 Revert 2 CL: crrev.com/c/2206294 Original change's description: > Implement capture of metrics events for web app daily interaction. > > Captures basic static information on all web apps used and more detailed > sums of foreground/background duration and session count for installed > web apps that are set to open in a window. > > WebAppMetrics now listens on BrowserList events and TabStripModel > changes in order to determine when web apps move into the foreground or > background. It keeps a record of the last time each web app was seen so > that intervening time can be counted as foreground time if switching > away from the web app (and background time if switching to the web app). > > Tbr: achuith@chromium.org > Bug: 1026148 > Bug: 1081187 > Change-Id: Iae6460c678b59380cf0fad8408e2014918bc2864 > Fixed: 1026148 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160638 > Commit-Queue: Glen Robertson <glenrob@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Auto-Submit: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769125} TBR=achuith@chromium.org,dominickn@chromium.org Fixed: 1026148 Bug: 1026148 Bug: 1081187 Bug: 1083813 Change-Id: Ibe84183ad86baef12b01423d88a230b4951c9666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206144Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#769623}
-
Jeevan Shikaram authored
This CL performs digital asset link verification on a TWA to ensure the TWA and the website is owned by the same entity. If the digital asset link verification fails, the CCT is shown and the URL and title of the page is displayed. The verification is performed when the app is launched and the result is cached until the window is closed. Change-Id: Ieb2e32c08f1d301a444cca01eba6ccbaabc94e0e Bug: 1026469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198705Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#769622}
-
chrome://media-appTrent Apted authored
Handles errors that may result when trying to open (or "stat") files upon launch or navigate. Modifies the mediaApp API to include an 'error' field on AbstractFile, which associates a file error name with files that could not be opened. These errors are ignored unless that file is navigated to. Translated UX for the more common errors needs to be built in the app. "Unexpected" file errors are also dumped to console in the privileged context because we don't try to send over the full error message. The unprivileged context will also generate a crash report for unknown error names, and do UMA for "known" error names. Errors on the *launch* file are always dumped, and a placeholder file with just the name (and the error) are sent to the guest so that some UX can be built around it. Currently it just says "unable to decode." in a toast. Bug: b/149801176, b/134975059, b/156437880 Test: MediaAppUIBrowserTest.LaunchFile Test: MediaAppUIBrowserTest.LaunchUnopenableFile Test: MediaAppUIBrowserTest.LaunchWithUnopenableSibling Test: MediaAppUIBrowserTest.NavigateWithUnopenableSibling Test: MediaAppUIBrowserTest.FileThatBecomesDirectory Change-Id: I0468e54b6f9fa24d19a49288b223b696f440e840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200822 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#769621}
-
Koji Ishii authored
After the rename of NGLogicalLineItem in r769156 <crrev.com/c/2203036>. NOTRY=true Bug: 982194 Change-Id: Ib8b92f13f82b26081df864f2e5be88463b7c5805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203564Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#769620}
-
Koji Ishii authored
|MayHaveMultipleFragmentItems| turned out to be hot, and |NGFragmentItem| version is slower than |NGPaintFragment| version. This patch uses |Is{First,Last}ForNode| flags added for the block fragmentation. Also changes |FinalizeAfterLayout| to compute them for non-block fragmented cases. Bug: 982194 Change-Id: Idbc374b65ff39d877d727848431e50a521fe2008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203082 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769619}
-
Joel Hockey authored
After removing the crosh builtin component extension in crrev.com/c/2196626, the terminalPrivate.getCroshSettings function needs to guard for an empty extension when it calls GetTerminalExtension. Bug: 1083831 Change-Id: I205e544ea51283df87850851e111d5d6c8cb36e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206143 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#769618}
-
Rushan Suleymanov authored
Bug: 1083061 Change-Id: Ib63cd6bb6618b8314e15c4a22ca331c903223187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204020 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#769617}
-
Yutaka Hirano authored
This is a follow-up of https://crrev.com/c/2189716. As including //net/quic/quic_transport_client.h from //services/network/public/cpp/quic_transport_error_mojom_traits.h led to build errors this CL splits the net::QuicTransportError definition into a new file. Bug: 1069744 Change-Id: I406a0d2f8f1c682aa9b36ad48eb6629e281f12c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203242 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#769616}
-
Ramin Halavati authored
Profile::DestroyOffTheRecordProfile function without arguments is deprecated and replaced with a function that receives the OTR profile. The few remaining use cases of the function are replaced with the new API and the old function is removed. Bug: 1033903 Change-Id: Ie417f4ef12f449774c658228dc3850b65811b3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196168Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#769615}
-
Ramin Halavati authored
VariationsClient::IsIncognito returns true for all off-the-record profiles and is always initialized with BrowserContext::IsOffTheRecord. To remove misinterpretations, the function is renamed to IsOffTheRecord. This CL does not create any behavioral change. Bug: 968028, 1074201 Change-Id: I19a0a81794e7838c8f882faa6aeab9d7b085f756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202980Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#769614}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I69d9d2756f10835942dfd47d8ab239cc35443c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206217Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769613}
-
George Burgess IV authored
This reverts commit 03ac3720. Caused syncing breakages; see bug. Tbr: tluk@chromium.org Bug: 1083381 Change-Id: I46516c7a8a2969bf58f188dcc0f91789f338d4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206214Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#769612}
-
Alexey Baskakov authored
Disable geolocation-api/watchPosition-page-visibility.html blink web test. It's flaky on OSX. TBR=scheib@chromium.org Bug: 1083824 Change-Id: Ice34348bc3e9e6de24b04859269c04d379b2be7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206194Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#769611}
-
Wei Lee authored
We should use the default value if the key does not exist. And if the key does not exist and no default value is specified, set the value to null. Bug: 980846 Test: Manually Change-Id: I82d7a7e35284d0816da8a0cc09853c5106a705e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131667 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#769610}
-
Evan Stade authored
This will allow WebLayer to reuse webshare java code. 1. Portions of share are moved to //components/browser_ui/share * ShareDialogAdapter * ShareImageFileUtils[Test] * ShareParams - saveLastUsed and shareDirectly are only used in Chrome, so are removed from shareParams. saveLastUsed is implemented with a TargetChosenReceiver. * parts of ShareHelper - TargetChosenReceiver and some helper functions - custom share dialog for sdk <= 21 2. Almost all of webshare is moved to //components/browser_ui/webshare * ShareServiceImplementationFactory is left behind * WebShareDelegate interface is introduced to delegate the share implementation (Chrome passes off to the Activity's ShareDelegate) Bug: 1066285 Change-Id: I0d211c0996e1517267413aa3e569f0cbde21d3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181491 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#769609}
-
Glen Robertson authored
This reverts commit 91cc0984. Reason for revert: Other tests still flaking on mac eg. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/50389 Original change's description: > Reland "Implement capture of metrics events for web app daily > interaction." > > Disabled 3 tests on Mac as they are failing/flaky. > > Original CL: crrev.com/c/2160638 > Revert CL: crrev.com/c/2203240 > > Original change's description: > > Implement capture of metrics events for web app daily interaction. > > > > Captures basic static information on all web apps used and more detailed > > sums of foreground/background duration and session count for installed > > web apps that are set to open in a window. > > > > WebAppMetrics now listens on BrowserList events and TabStripModel > > changes in order to determine when web apps move into the foreground or > > background. It keeps a record of the last time each web app was seen so > > that intervening time can be counted as foreground time if switching > > away from the web app (and background time if switching to the web app). > > > > Tbr: achuith@chromium.org > > Bug: 1026148 > > Bug: 1081187 > > Change-Id: Iae6460c678b59380cf0fad8408e2014918bc2864 > > Fixed: 1026148 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160638 > > Commit-Queue: Glen Robertson <glenrob@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Alan Cutter <alancutter@chromium.org> > > Auto-Submit: Glen Robertson <glenrob@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#769125} > > TBR=achuith@chromium.org,dominickn@chromium.org > > Fixed: 1026148 > Bug: 1026148 > Bug: 1081187 > Bug: 1083813 > Change-Id: I38d92958255c4db055ddfa3b731de9309dd7219c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206060 > Commit-Queue: Glen Robertson <glenrob@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769600} TBR=achuith@chromium.org,alancutter@chromium.org,dominickn@chromium.org,glenrob@chromium.org Change-Id: I7d5ca8e984f305f0a56d0f6f49941e26beb816f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026148, 1081187, 1083813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206294Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#769608}
-
Lukasz Anforowicz authored
This CL helps with: 1. Meeting one of the requirements that says "Ideal proposal should be as close to a drop-in replacement for raw pointers as possible" 2. Compiling a handful of places in Chromium that depend on these operators. So far we know about: .../blink/renderer/core/css/parser/css_parser_token_range.h:45 third_party/blink/renderer/platform/json/json_parser.cc:187 third_party/blink/renderer/platform/json/json_parser.cc:85 components/metrics/file_metrics_provider_unittest.cc:252 Bug: 1073933 Change-Id: Icb69c906dd1cfad2cc6242e81517969ff0da344c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199177Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#769607}
-
Tal Pressman authored
Instead of the ctor registering the newly created scheduler with the "parent" scheduler (page scheduler for frame scheduler, main thread scheduler for page scheduler), the parent now creates the new child scheduler and then registers it. Change-Id: I903ac5d459827fabbce86b6b5a95b747f856e9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198447 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#769606}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85ae1392c509..074a542237bb git log 85ae1392c509..074a542237bb --date=short --first-parent --format='%ad %ae %s' 2020-05-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@074a542237bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib0f45a45426982d9bbc5f9998e9ef052bdf7bb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205870Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769605}
-
Kent Tamura authored
... to ListBoxSelectType. This function is used for |option:-internal-spatial-navigation-focus| selector matching, and it's unnecessary for menulist SELECTs because OPTIONs in menulist SELECTs are not rendered by CSS. This CL has no behavior changes. Bug: 1052232 Change-Id: Id71c303ebe75113acb767656b41fd4b21eb5a972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206136 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769604}
-
Julie Jeongeun Kim authored
This CL replaces the PrintHostMsg_DidPrepareDocumentForPreview IPC message with a new DidPrepareDocumentForPreview Mojo method in the PrintPreviewUI interface. Bug: 1008939 Change-Id: I0ecdb60982baf3074af290005502204080f9cc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201496 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#769603}
-
Christopher Cameron authored
This is towards allowing apps to run with no windows open. Two different messages differentiated here: - applicationWillBecomeActive (aka Focus) - happens when any window in the app is focused, or when the app is command-tabbed to be active - should focus existing windows - applicationShouldHandleReopen (aka Reopen) - happens when the dock icon is clicked - should launch a new window if no window is open It used to be that Focus was used by legacy apps and ignored by PWAs. Also, Focus was used to re-open the app (inappropriately), and also was used to close the app if it somehow was uninstalled while still running. Update the legacy app behavior to open new windows only on Reopen, and remove the "close the app" behavior. The next step here will be to handle Reopen for PWAs, and to allow them to keep running even if no windows are open. Bug: 1080729 Change-Id: I5bf86e7e7874b71c030d8dc9c5440ee7fec430d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197231 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#769602}
-
nancy authored
Change-Id: I0ad2659380ca0792dc7b779e3669186720be5896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203786Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#769601}
-
Glen Robertson authored
interaction." Disabled 3 tests on Mac as they are failing/flaky. Original CL: crrev.com/c/2160638 Revert CL: crrev.com/c/2203240 Original change's description: > Implement capture of metrics events for web app daily interaction. > > Captures basic static information on all web apps used and more detailed > sums of foreground/background duration and session count for installed > web apps that are set to open in a window. > > WebAppMetrics now listens on BrowserList events and TabStripModel > changes in order to determine when web apps move into the foreground or > background. It keeps a record of the last time each web app was seen so > that intervening time can be counted as foreground time if switching > away from the web app (and background time if switching to the web app). > > Tbr: achuith@chromium.org > Bug: 1026148 > Bug: 1081187 > Change-Id: Iae6460c678b59380cf0fad8408e2014918bc2864 > Fixed: 1026148 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160638 > Commit-Queue: Glen Robertson <glenrob@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Auto-Submit: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769125} TBR=achuith@chromium.org,dominickn@chromium.org Fixed: 1026148 Bug: 1026148 Bug: 1081187 Bug: 1083813 Change-Id: I38d92958255c4db055ddfa3b731de9309dd7219c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206060 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#769600}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic5d203135090b43762fb8870b3e4bd81bc236dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769599}
-