GitLab

Fixes a raw pointer in MainThreadTaskRunner.

BUG=509911
R=haraken@chromium.org, keishi@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/1296243004

git-svn-id: svn://svn.chromium.org/blink/trunk@200972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |isVisuallyEquivalentCandidate()| to "VisibleUnits.{cpp,h} from
"Position.{cpp,h}" to consolidate |InlineBox| dependency to "VisibleUnits.cpp"
for ease of working them later.

This patch also gets rid of unused include directives from "Position.cpp".

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1304063002

git-svn-id: svn://svn.chromium.org/blink/trunk@200971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |computeInlineBoxPosition()| to "VisibleUnits.{cpp,h} from
"Position.{cpp,h}" and "VisiblePosition.{cpp,h}" to consolidate |InlineBox|
dependency to "VisibleUnits.cpp" for ease of working them later.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303173002

git-svn-id: svn://svn.chromium.org/blink/trunk@200970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/1297383003

git-svn-id: svn://svn.chromium.org/blink/trunk@200969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They don't work until we switch to wptserve because they have links to
/html/resources/common.js.

BUG=490511
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1305983002

git-svn-id: svn://svn.chromium.org/blink/trunk@200968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=523051

Review URL: https://codereview.chromium.org/1309603002

git-svn-id: svn://svn.chromium.org/blink/trunk@200967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add IDL for Navigator.Nfc and Nfc. Add the supporting .h|cpp files.
Add simple Layout tests.
Add nfc in webexposed layout test.

Intent to Implement:
https://mail.google.com/mail/u/1/#label/blink-dev/14f261c80935592e

BUG=520391

Review URL: https://codereview.chromium.org/1291663004

git-svn-id: svn://svn.chromium.org/blink/trunk@200966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cssFloat does not show up as an enumerated property of 
CSSStyleDeclaration even though it does evaluate to a value. FF and 
IE both treat cssFloat as an enumerable property of CSSStyleDeclaration

BUG=492999

Review URL: https://codereview.chromium.org/1288623005

git-svn-id: svn://svn.chromium.org/blink/trunk@200965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Consequently, update its IDL attribute to [GarbageCollected] and adjust
the return type of its constructor.

R=haraken
BUG=522949

Review URL: https://codereview.chromium.org/1309463002

git-svn-id: svn://svn.chromium.org/blink/trunk@200964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the v8 callback objects that PromiseTrackers create, insist on using
a WeakPersistent<> back reference to the PromiseTracker when Oilpan
is enabled.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/1301253002

git-svn-id: svn://svn.chromium.org/blink/trunk@200963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fully transition MediaError, MediaKeyError and TimeRanges to Oilpan.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/1306613002

git-svn-id: svn://svn.chromium.org/blink/trunk@200962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, add a RELEASE_ASSERT when creating an ArrayBuffer from an
ArrayBufferContents that the backing store is non-NULL.

BUG=522128

Review URL: https://codereview.chromium.org/1302193002

git-svn-id: svn://svn.chromium.org/blink/trunk@200961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
R=ksakamoto

Review URL: https://codereview.chromium.org/1300493004

git-svn-id: svn://svn.chromium.org/blink/trunk@200960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This series of CLs fixes WebCallback parameter types used in PushMessaging.

 - WebPushSubscription* (ownership transferred)
  => PassOwnPtr<WebPushSubscription>
 - WebPushPermissionStatus* (ownership not transferred)
  => WebPushPermissionStatus
 - WebPushError* (ownership transferred)
  => const WebPushError&

1/3: https://codereview.chromium.org/1304723002/
2/3: https://codereview.chromium.org/1291023005/
3/3: https://codereview.chromium.org/1302833004/

BUG=493531

Review URL: https://codereview.chromium.org/1302833004

git-svn-id: svn://svn.chromium.org/blink/trunk@200959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The issue 521655 causes bad case in |toShadowRoot()| with a test script in
|TextIterator::advance()|. However, I could not get a HTML fragment causing
this situation since the test script generates HTML fragment and I could not
reproduce on my machines.

This patch changes |TextIterator| to stop when it fails to handle shadow tree
to avoid bad cast for preventing attacker to use this.

We'll add a test case for this once we have HTML fragment to cause this
bad cast.

BUG=521655
TEST=n/a; It is hard to create a test case for this issue

Review URL: https://codereview.chromium.org/1293703006

git-svn-id: svn://svn.chromium.org/blink/trunk@200958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We only need the size of the invalidation rect, so don't need
paintInvalidationContainer to adjust the offset of the rect.

Review URL: https://codereview.chromium.org/1307663002

git-svn-id: svn://svn.chromium.org/blink/trunk@200957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The while loop starting from L163 in insertOrderedList::doApply uses two loop 
variables, |startOfCurrentParagrap| and |startOfLastParagraph|.
They are of Position type and modified in loop.
Old implementation can go into infinite loop if |startOfCurrentParagrap| skips over 
|startOfLastParagraph|.
Thus this CL adds condition that |startOfCurrentParagrap| 
 should be before |startOfLastParagraph|.

TEST=LayoutTests/editing/execCommand/execCommand/insert-list-infinite-loop2.html

Review URL: https://codereview.chromium.org/1285103002

git-svn-id: svn://svn.chromium.org/blink/trunk@200956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow failure until chromium change is landed and test is updated.

TBR=wolenetz@chromium.org
BUG=523073

Review URL: https://codereview.chromium.org/1293543007

git-svn-id: svn://svn.chromium.org/blink/trunk@200955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to gather data for this intent: https://groups.google.com/a/chromium.org/d/topic/blink-dev/qBqeSQeyVXc/discussion

R=leviw@chromium.org
BUG=240765

Review URL: https://codereview.chromium.org/1304853002

git-svn-id: svn://svn.chromium.org/blink/trunk@200953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Increase information density and address broken layout.

BUG=519609

Review URL: https://codereview.chromium.org/1291483002

git-svn-id: svn://svn.chromium.org/blink/trunk@200951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't consider must-revalidate as uncacheable

BUG=520353

Review URL: https://codereview.chromium.org/1294473004

git-svn-id: svn://svn.chromium.org/blink/trunk@200950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Here is the piece of code that categorizes various file types:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/filesystem/InspectorFileSystemAgent.cpp&rcl=1424812033&l=280
Note that it doesn't handle media (audio/video, e.g. "audio/mp3",
"video/mp4" and so on) types explicitly. Currently
MIMETypeRegistry::isSupportedNonImageMIMEType will return true for
supported media types, and that will cause media files to be reported
as ResourceType::Document and we'll do
entryForFrontend->setIsTextFile(true) for media files as well.

BUG=462329

Review URL: https://codereview.chromium.org/960333002

git-svn-id: svn://svn.chromium.org/blink/trunk@200949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Adding support for Smart GO NEXT feature in Android Chrome (patchset #23 id:460001 of https://codereview.chromium.org/939603002/ )

Reason for revert:
Regression in power.android_acceptance.
crbug.com/520952


Original issue's description:
> Adding support for Smart GO NEXT feature in Android Chrome
> 
> This change takes care of providing easy navigation among text input
> elements inside a form.
> 
> Corresponding changes to control the PREVIOUS, NEXT and GO button is done
> at https://codereview.chromium.org/1080693002/
> 
> BUG=410785
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200398

TBR=kochi@chromium.org,l.gombos@samsung.com,ajith.v@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=410785,520952

Review URL: https://codereview.chromium.org/1303123002

git-svn-id: svn://svn.chromium.org/blink/trunk@200948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522939
TBR=pfeldman

Review URL: https://codereview.chromium.org/1307643002

git-svn-id: svn://svn.chromium.org/blink/trunk@200947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL exposes the outgoingReferrer() method on the public WebDocument
interface. This allows Chromium to access a page's outgoing referrer
(stripped of undesirable information) via WebDocument.

BUG=522734

Review URL: https://codereview.chromium.org/1289343006

git-svn-id: svn://svn.chromium.org/blink/trunk@200946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch sets up the scaffolding for plumbing the new
composited display list to the compositor.

Review URL: https://codereview.chromium.org/1301033002

git-svn-id: svn://svn.chromium.org/blink/trunk@200945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The static strings were destructed at the exit instead of leaked,
causing performance regression. Since the GCInfo objects are leaked,
holding a reference in the struct will leak the strings.

BUG=520948

Review URL: https://codereview.chromium.org/1300263003

git-svn-id: svn://svn.chromium.org/blink/trunk@200944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

API in WebFrameClient will be removed after corresponding test harness logic
is removed.

BUG=523091

Review URL: https://codereview.chromium.org/1288323006

git-svn-id: svn://svn.chromium.org/blink/trunk@200943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1303823004

git-svn-id: svn://svn.chromium.org/blink/trunk@200942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixed AXLayoutObject::getSelection() so that it doesn't return nullptr for anchor and focus objects.

BUG=491027
R=dtseng@chromium.org, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1300113006

git-svn-id: svn://svn.chromium.org/blink/trunk@200941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The 'referrerpolicy' attribute controls the referrer for the outgoing
request when an image is loaded.

BUG=490608

Review URL: https://codereview.chromium.org/1291613010

git-svn-id: svn://svn.chromium.org/blink/trunk@200940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521226

Review URL: https://codereview.chromium.org/1303883002

git-svn-id: svn://svn.chromium.org/blink/trunk@200939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Manually verified to be correct.

BUG=509025
TBR=joelo

Review URL: https://codereview.chromium.org/1304813003

git-svn-id: svn://svn.chromium.org/blink/trunk@200938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also converting fast/forms/button-generated-content.html to use
the Ahem font, which eliminates a sub-pixel font-related issue
that was causing the ref test to fail on Yosemite.

BUG=509025
R=eae,joelo,ojan

Review URL: https://codereview.chromium.org/1303943002

git-svn-id: svn://svn.chromium.org/blink/trunk@200937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL computes the mixed content status (blockable, optionally
blockable, or not mixed) of resource requests before they are sent to
DevTools via the InspectorResourceAgent. The ResourceRequests's mixed
content status gets sent to DevTools as part of the Request parameter to
the requestWillBeSent event. The mixed content status will be used to
display mixed resources in the Security panel.

BUG=518065

Review URL: https://codereview.chromium.org/1299493003

git-svn-id: svn://svn.chromium.org/blink/trunk@200936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the object passed to onconnected and ondisconnected event
handlers connected to navigator.usb.

BUG=492204

Review URL: https://codereview.chromium.org/1307483002

git-svn-id: svn://svn.chromium.org/blink/trunk@200935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This removes a user of didLayoutWithPendingStylesheets() and instead moves
the call to dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl so the
notification to the embedder is tied to the pumping of frames. This changes the
behavior of this notification to only dispatch for the top level frame,
but Chromium already has a check for that:

https://chromium.googlesource.com/chromium/src/+/976d4d9a2735bdc11e5a641c84b6382566d48f1d/content/renderer/render_frame_impl.cc#3472

RenderFrameImpl::didFirstVisuallyNonEmptyLayout's first check is

if (frame->parent())
    return;

so we already ignore all frames that are not the main frame. Future patches will
clean up this interface so it's obvious this really only happens for the main
frame.

This was originally comitted as r200664, but got reverted due to making a test
flaky in Chromium that was depending on very specific timing of this callback.
That test was fixed by:
https://crrev.com/0ea17fce0d5218c909985e2216051eab79419463

BUG=521692
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1295053002

git-svn-id: svn://svn.chromium.org/blink/trunk@200934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a new target which provides test support for Source/platform/.
These can be used in platform unit tests, or unit tests of targets which
depend on platform.

GYP: blink_platform_test_support (static_library)
GN: //third_party/WebKit/Source/platform:test_support (source_set)

Existing GTest print support for Source/platform/geometry/ types has been
made more consistent, and moved into this target. Both
blink_platform_unittests and webkit_unit_tests depend on it.

To avoid ODR violations, the declarations of these are in the headers
of the types that are being printed. If these are called outside unit tests,
a link error will occur.

This is similar to how ui/gfx/ does things in Chromium; it's seems like
a more reasonable approach than what we do today.

BUG=522198

Review URL: https://codereview.chromium.org/1285413007

git-svn-id: svn://svn.chromium.org/blink/trunk@200933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200859

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1301253005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200859

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1287273003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200931 bbb929c8-8fbe-4397-9dbb-9b2b20218538