- 15 Oct, 2020 30 commits
-
-
Lukasz Anforowicz authored
The "RelaxIsolatedWorldCorsInFileUrlLoaderFactory" feature was introduced in r740899 in Q1 2020 just in case more extensions encounter https://crbug.com/1049604 forcing us to revert to the old behavior. This never happened and the feature was never enabled (and we don't have any plans of using this feature in the future - quite the opposite, we want to keep the feature disabled). Based on the above this CL removes the feature (~reverting r740899). Bug: 1049604 Change-Id: I4e2c2b61965661e61c75fd8cf7878715da4882d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466511Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#817309}
-
Alexey Baskakov authored
This reverts commit 290037a8. Reason for revert: Breaks compilation on lacros https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/1132 Original change's description: > Set use_dawn=true on Linux > > This enables WebGPU on Linux behind --enable-unsafe-webgpu > and --enable-features=Vulkan. Shared image support requires > SkiaRenderer (default on Linux) and Vulkan to be enabled. > > Bug: 976495 > Change-Id: I97065f2ac6aadd110971254bfe3526d366318b83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368534 > Commit-Queue: Austin Eng <enga@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817266} TBR=kbr@chromium.org,cwallez@chromium.org,kainino@chromium.org,enga@chromium.org Change-Id: I050e90c36094f047d4e311d467c603b47d2abf82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473858Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#817308}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ib72fae06192b4fea7f9e87bf6a4f55bd50c136b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459187Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#817307}
-
Joon Ahn authored
https://screenshot.googleplex.com/4Cu2NuqTLYKXMpM Bug: 1125150 Change-Id: I6211f47c2d05405bfad0e935325622caede41fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472202Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817306}
-
Clark DuVall authored
This change pulls weblayer out of the base module and into the chrome module. WebLayer supports being loaded from a "weblayer" split, so an empty split is created which depends on the "chrome" split (which has the weblayer implementation). WebLayer java was not added directly to the "weblayer" split, because it would end up pulling a bunch of code shared with chrome into the base module. Bug: 1126301 Change-Id: I78aaec57a9b970bec964c36421d759bbbf7039eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463963Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817305}
-
Xiaohui Chen authored
Follow up on thread https://groups.google.com/a/chromium.org/g/security-dev/c/ul731DpnsR0 Bug: None Change-Id: Ic289e297865d6323e587a6b8d843b4293886101e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472702 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817304}
-
Nancy Wang authored
When the ARC raw icon image rep has the correct size, it should be added to the imageskia as well, otherwise, the imageskia might miss the rep for one scale, which could cause the scale mismatching issue. BUG=1124679 Change-Id: Ib6332a0b0924afff590a72b3c4e3158522f254c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472718Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817303}
-
Mustafa Emre Acer authored
Bug: 1077426 Change-Id: Ia2d5a44bf8ba63aaaec915ae93cdb4afd0bafea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466818Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817302}
-
Karthika Pai authored
This is part of a migration that replaces the old <histogram-suffixes> syntax that was used to denote groups of histogram to the new patterned histogram syntax. Bug: 758782 Change-Id: I74e4f195782cd5e236d401d0bbeb8402c0f53143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472435Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#817301}
-
Kyle Williams authored
Removing the CfmServiceRegistry allows for more succinct APIs and a more clear design. * Replace |RequestBindService| with |BindRegistry| * Fix Tests and function definitions BUG=b:170679101 TEST='./out/Default/chromeos_unittests --dbus-stub --single-process-tests --gtest_filter=Cfm* && xvfb-run ./out/Default/unit_tests --single-process-tests --gtest_filter=Cfm*' Change-Id: I9e2a0abc0a1ad388db28d096d9e4080d80945b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467279Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#817300}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fb3d4294864a..b7c1c3f1140b 2020-10-14 jeremya@chromium.org fix v8 sample processing in multiprocess context If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:731804 Tbr: wenbinzhang@google.com Change-Id: I01424de5929a653cee61c77eeb3ca524fe8ba114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817299}
-
Kent Tamura authored
This CL has no behavior changes. No-Try: true Change-Id: Id12d1876e22f8c40c3998573fa8cef36b06ab012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467038Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#817298}
-
David Dorwin authored
Previously, the file was always written, even in the case of an exception. Change-Id: I0cee215b529f6864c8c14fc90934de2fc7f44974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466738Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817297}
-
Thomas Lukaszewicz authored
Bug: 1130078 Change-Id: Ie2011526a9e9e75327895441af629758fa49b715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471879 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#817296}
-
Scott Violet authored
BUG=1133893 TEST=test only change Change-Id: Idcc6912a75b2e9919fd8391926ff771b323d887e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473340 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d6e2c46968d..2f0cad0f053e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1135660 Tbr: msw@google.com Change-Id: I5dae22b9131fe05ebd2f9417a56dc3e0e4c548ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473027Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817294}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ios/chrome/browser. R=rohitrao@chromium.org Bug: 1113033 Change-Id: Iddc26c3a0adcdaaf0e9a9dfda5f3244e3e1b5ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472457 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#817293}
-
Keren Zhu authored
Bug: 772945 Change-Id: I972c061fcc008f3c37308c5186e6432d766de1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470237 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#817292}
-
Akihiro Ota authored
Fix two assertion errors: 1. The first error was firing because we were asserting things in the wrong order; to fix it, we just needed to move the assertion after the speech expectation. 2. The second error was firing because we were asserting the current range before it changed. To fix this, we add an extra speech expectation, which is spoken after the range has changed. Bug: N/A Change-Id: I06f9ead1815ce2e2e2c0ce77a6459d8cf3dc8f12 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461587Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#817291}
-
Alexey Baskakov authored
This reverts commit abedddf0. Reason for revert: Breaks compilation on lacros https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/1132 Original change's description: > Roll Dawn from 73b70229af3a to 84b70a6e4d93 (3 revisions) > > https://dawn.googlesource.com/dawn.git/+log/73b70229af3a..84b70a6e4d93 > > 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f2b8b6e87396 to ff267ca60e14 (2 revisions) > 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 435916e544cc to f2b8b6e87396 (1 revision) > 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 4311dd05c883 to 435916e544cc (1 revision) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-chromium-autoroll > Please CC enga@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel > Bug: None > Tbr: enga@google.com > Change-Id: Ib445bb81fe3a552451171cf1b0d2626e307bfdae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473020 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#817270} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,enga@chromium.org,enga@google.com Change-Id: I0c0878b4b2640dae5f2bc496597d03e2876d31dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473777Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#817290}
-
Alex Newcomer authored
Just check for whether something can be rendered in HTML using the same criteria. Forgot to update this line when I changed the criteria on OnClipboardHistoryItemAdded. Bug: 1138665 Change-Id: Ic50fcec0bd78a1ab5d6090024fb54de79141bec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473165Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817289}
-
Jamie Madill authored
This adds an is_unexpected tag, and handles multiple results (e.g. from retries) correctly. Bug: 931731 Bug: 1138507 Bug: angleproject:5124 Change-Id: I23054010db058eaa9d275c9b5de3052030210024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472338Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#817288}
-
Clark DuVall authored
These changes are needed to allow feed to access resources from the feed isolated split. The implementation of the DFM is in the internal change here: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3336642 The feed DFM also uncovered a bug in how we were handling feature jars in R8. If multiple features specified a jar that was not in the base module, the jar would only be applied to the first feature that specified it instead of moving to the base module. Bug: 1126301 Change-Id: Iedc67a97358414adfa82e7a199bf5c72b1f47eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469235 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#817287}
-
Toni Barzic authored
It's currently always returning nullptr. BUG=None Change-Id: Ib953cf14ae956309ef6077adb000edbbec8561f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472701Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#817286}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I052c6ec2f1bd27625e8ba1567026ccbffd750719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473028Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817285}
-
Avi Drissman authored
Removing cross-origin dialogs is being worked on in https://chromestatus.com/feature/5148698084376576. Make sure that relevant UMAs don't expire. Fixed: 1138390 Bug: 1065085 Change-Id: I6cb9c05bb838e065ff98e7b4af9f2d9fcc5adf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472481 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817284}
-
Marc Treib authored
Out of its many past buckets, only two remained, neither of them particularly useful: CANCEL_DURING_CONFIGURE: This is rare, and doesn't seem worth tracking specifically. STOP_FROM_OPTIONS: Similar information is available in Sync.StopSource. Bug: 939752 Change-Id: Ia2392f498aa994880642059a603a23aecdaf4ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467902 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817283}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba4c87c9..b901b8f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibbcbd4ec9d6a22136b00466fd65e678e391e8da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472205Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817282}
-
Eric Lawrence authored
Today, the NetLog's |constants| data contains the list of field trials that were active when the capture begins. Field Trials may be enabled lazily and will not appear in the NetLog if enabled after logging begins. To ensure that the NetLog reflects all active trials, also record the list of active field trials in the |polledData| info recorded when the capture ends. Bug: 1133396 Change-Id: I94211d1c006882ab4cd28e7dd6e08ac3c6217710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469216 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817281}
-
Etienne Pierre-doray authored
Reset max_allowed_sort_key_ when a worker decides to yield to avoid having many workers yielding for the same task. I considered using compare_exchange_weak but figured that was unnecessary. The drawback is that a worker might overwrite an update and wrongly prevent another worker from yielding. Once it returns though, max_allowed_sort_key_ is updated again so a worker will always *eventually* yield. This causes ShouldYield to be non const. Change-Id: I81bef8e632becba758eec8d96720fa32c4ef78e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453110 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#817280}
-
- 14 Oct, 2020 10 commits
-
-
Muyao Xu authored
Bug: b/170651374, 1117673 Change-Id: Iba8a5c71033514e560bb5b3d1b5274379cbe5245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464788Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#817279}
-
Klaus Weidner authored
This reverts commit f2038e2b. Reason for revert: causes crashes on Android 10+: https://crbug.com/1138664 Original change's description: > Fill in usage flags and sample fields on skia GrVkImageInfo. > > Change-Id: I1da7035e84173f5e9d8021ec3d2639f2ba96bf89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469261 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Greg Daniel <egdaniel@google.com> > Cr-Commit-Position: refs/heads/master@{#817141} TBR=penghuang@chromium.org,egdaniel@google.com Change-Id: Ide84d237760384033a83e71137602cd6718d5683 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473439Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#817278}
-
Peter Kasting authored
Bug: 772945 Change-Id: I5729038963db819ab639cc105ae7d6272eb3ea8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472436 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#817277}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/61aa96cc7a59..6d2775c5ef51 2020-10-14 vidorteg@microsoft.com Modifying scripts for i18nString localization call If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I67e18ac6854d7011c194720d27e7957daacdb2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473022Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817276}
-
Aaron Colwell authored
Moving is_guest field from SiteInstanceImpl into SiteInfo since this information should really be part of the security principal represented by SiteInfo. This also cleans up several call sites where a SiteInfo and is_guest flag were being passed in. These have been simplified to only require the SiteInfo now. This change simply moves the field and updates function signatures. There is no change in behavior other than the guest boolean now being considered in all SiteInfo comparisons. This shouldn't result in any observable behavior changes though because guest and non-guest SiteInfo comparisons usually failed anyways because the site_url fields do not match. Bug: 1085275 Change-Id: I7cd264728d1f82ce2dae97193c77a0380ae40cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429605 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#817275}
-
Ryan Heise authored
Change-Id: If8268b5526f9e8c294dd63aa365f650f7e0a0a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472018Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817274}
-
Brian Sheedy authored
Updates the following GPU expectation tags: 1. angle-no-backend is now angle-disabled, as that is more accurate. 2. The Skia Renderer tags now use skia-renderer as a prefix instead of a suffix. Bug: 1111876, 1011107 Change-Id: I3b8ee3175449e4e55eebdd78e575ac2ebcfeaf3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472903Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817273}
-
Bao-Duy Tran authored
This is a mock for ComponentExtensionIMEManagerDelegate interface, so had better be named after it with just a prefix "Mock" added, for some little consistency that would facilitate code browsing and readability. It's not quite worth it to shorten "Extension" to "Ext" for small length savings on a test-only thing, while adversely impacting consistency. It's out of scope here to make conciseness improvement to the existing naming scheme of this whole family of interfaces and classes. The rename here also makes it precisely consistent with the names of .h and .cc files where the Mock is declared and defined. Bug: 1134465 Change-Id: Ie8ed0d1ee39813ae722e677c4a58628a8e49d52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442649 Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817272}
-
Sunny Sachanandani authored
TBR=zmo@chromium.org Bug: 1136971 Change-Id: I0471013bd944851bd23953d7d1e90df4ba79e229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472909 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#817271}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/73b70229af3a..84b70a6e4d93 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f2b8b6e87396 to ff267ca60e14 (2 revisions) 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 435916e544cc to f2b8b6e87396 (1 revision) 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 4311dd05c883 to 435916e544cc (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ib445bb81fe3a552451171cf1b0d2626e307bfdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473020Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817270}
-