GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149771 0039d316-1c4b-4281-b951-d872f2087c98

It appears the sizeof change was to make the code more future proof:

sizeof(float) -> sizeof(audio_data[0])

However, audio_data[0] is a float*, not the intended float.  Adding the deref
to fix this.

CID_COUNT=1
CID=104561
BUG=none
R=scherkus


Review URL: https://chromiumcodereview.appspot.com/10832123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149770 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/10850032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149769 0039d316-1c4b-4281-b951-d872f2087c98

Parent means a folder containing a file in Drive v2 API.
If a file does not contain any reference to its parent, it should be
interpreted as the file is under the root directory.
Changed existing unit test for checking the case that parent is missing.

BUG=chromium:127728
TEST=unit_tests --gtest_filter="DriveAPIParserTest.*"

Review URL: https://chromiumcodereview.appspot.com/10829139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149768 0039d316-1c4b-4281-b951-d872f2087c98

Mapping from extension.location():

INTERNAL -> 'normal'
LOAD -> 'development'
EXTERNAL_POLICY_DOWNLOAD -> 'admin'
EXTERNAL* -> 'sideload'
(all others) -> 'other'

BUG=135564
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10750010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149767 0039d316-1c4b-4281-b951-d872f2087c98

Dependent upon https://chromiumcodereview.appspot.com/10568014

TBR=brettw@chromium.org

BUG=130212
TEST=included


Review URL: https://chromiumcodereview.appspot.com/10656052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149766 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=1
CID=104610
BUG=none
R=khorimoto@chromium.org
TBR=sky


Review URL: https://chromiumcodereview.appspot.com/10829154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149765 0039d316-1c4b-4281-b951-d872f2087c98

I forgot to re-enable it after tuning parameters in http://codereview.chromium.org/10782017/

BUG=


Review URL: https://chromiumcodereview.appspot.com/10823152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149764 0039d316-1c4b-4281-b951-d872f2087c98

SpawnCleanup may trigger the destruction of a partially created TargetProcess.

BUG=139898
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10831133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149763 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10850035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149762 0039d316-1c4b-4281-b951-d872f2087c98

This is often uninitialized in UI and browser tests. This blocks issue 10829031
from landing.

BUG=139093


Review URL: https://chromiumcodereview.appspot.com/10831104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149761 0039d316-1c4b-4281-b951-d872f2087c98

Revert 149610 - Extension resources should only load in contexts the extension has permission to access.

See http://codereview.chromium.org/10792008/ for background.

BUG=139592

Review URL: https://chromiumcodereview.appspot.com/10828067

TBR=mkwst@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10826134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149760 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10834037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149759 0039d316-1c4b-4281-b951-d872f2087c98

default_defines is no longer set in untrusted.gypi
Using normal define merging instead.

R=bbudge@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10825145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149758 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136438
TBR=acolwell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149757 0039d316-1c4b-4281-b951-d872f2087c98

observers properly if the resizer stayed visible after a resize.

BUG=139227
TEST=covered by unit tests
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10830148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149756 0039d316-1c4b-4281-b951-d872f2087c98

certain things needed to be done. Hopefully this
fixes these bugs.

BUG=140116,139791

Review URL: https://chromiumcodereview.appspot.com/10830147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149755 0039d316-1c4b-4281-b951-d872f2087c98

Use empty string as the mid before it's ready from WebKit. Label is not the correct mid, so we shouldn't use it, otherwise there will be a mismatch of mid and mline_index.

BUG= http://code.google.com/p/webrtc/issues/detail?id=717
TEST=Test page from http://code.google.com/p/webrtc/issues/detail?id=717.

Review URL: https://chromiumcodereview.appspot.com/10834137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149754 0039d316-1c4b-4281-b951-d872f2087c98

Started to fail in Chrome r149732

TBR=lambroslambrou
BUG=140397

Review URL: https://chromiumcodereview.appspot.com/10836089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149753 0039d316-1c4b-4281-b951-d872f2087c98

Change 1: fix a problem where the docs test fails when the UI unexpectedly
and automatically reloads.  The fix is to identify when this happens and
invoke some setup code that allows the test scenario to work properly in
the event that it does happen.

Change 2: modify two xpaths in the plus test to account for UI changes.

BUG=None
TEST=Verified that both tests run for at least several minutes with
these changes.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10825166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149751 0039d316-1c4b-4281-b951-d872f2087c98

This sets 2048 to select the high-latency path rather than the low one. This
allows us to make Flash use power-of-two buffers and still get the high latency
path, avoiding bugs in the current low-latency path.

BUG=

Review URL: https://chromiumcodereview.appspot.com/10830153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149750 0039d316-1c4b-4281-b951-d872f2087c98

before deciding to cache a translated nexe (current cache
mechanism won't work in incognito). Use this to decide
whether or not to cache translations for now.

For now, the linker always writes to a self-deleting temp
file, instead of to the cache directly.  We then copy the
data from the temp file to the cache as a separate step.

Took about 60ms to copy a 4.6MB nexe in debug mode with a
128kb buffer and 15ms with a 1mb buffer...

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2683
TEST= try compiling an app that doesn't use the File system
in incognito mode -- we should add a test though...
we should add a test though

Review URL: https://chromiumcodereview.appspot.com/10826107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149749 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10831141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149748 0039d316-1c4b-4281-b951-d872f2087c98

Plumb the registrations from the UI thread to the sync thread, and plumb the invalidations back.

Add ObjectIdSet <-> ObjectIdPayloadMap conversions.

Rename syncapi_unittest.cc to sync_manager_impl_unittest.cc.

BUG=137087
TEST=


Review URL: https://chromiumcodereview.appspot.com/10805002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149747 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes a problem with the way error cases were returned:
RunImpl should not call SendResponse when returning false.

TEST=updated api test
BUG=134583


Review URL: https://chromiumcodereview.appspot.com/10816023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/10830132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149745 0039d316-1c4b-4281-b951-d872f2087c98

This only fixes the avatar-related part of the bug.
UserImageLoader now always passes raw data to the callback.


BUG=139887


Review URL: https://chromiumcodereview.appspot.com/10830111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149744 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140336
TBR=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149743 0039d316-1c4b-4281-b951-d872f2087c98

We found that, with Pepper plugins (e.g., Pepper Flash), even 50 ms buffers
weren't enough to avoid occasional clicks (with 3 wave out buffers). (On my
Vista test machine with 4 wave out buffers we could manage ~43 ms buffers.)

Review URL: https://chromiumcodereview.appspot.com/10830150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149741 0039d316-1c4b-4281-b951-d872f2087c98

Fixed Create/Manage Profile dialog spacing due to Mac bug. Updated margin to account for added space due to border added.

Review URL: https://chromiumcodereview.appspot.com/10832120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149740 0039d316-1c4b-4281-b951-d872f2087c98

TBR=xhwang@chromium.org
BUG=140378
TEST=All media_uinttests pass.

Review URL: https://chromiumcodereview.appspot.com/10828137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149739 0039d316-1c4b-4281-b951-d872f2087c98

This adds a SandboxSeccompBpf class to centralize Seccomp BPF sandbox
policies inside of content/

LinuxSandbox is the only user of this class and Linux sandboxing is now fully
unified through LinuxSandbox.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10843042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149738 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149737 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

Review URL: https://chromiumcodereview.appspot.com/10834136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149736 0039d316-1c4b-4281-b951-d872f2087c98

A common error when using BMFF with Media Source is to begin appending at an
incorrect offset, such that the parser sees an extremely large value for the
box size and consequently waits forever for input without failing. This change
adds a whitelist of permitted top-level boxes, which allows these situations
to be detected as soon as the header is read.

BUG=
TEST=BoxReaderTest.WrongFourCCTest


Review URL: https://chromiumcodereview.appspot.com/10823139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149735 0039d316-1c4b-4281-b951-d872f2087c98

The LinuxSandbox class aims to become the central place for Linux
sandboxing inside content/.

For now, this refactors mostly code from the Zygote.

(Note: this is a re-land of https://chromiumcodereview.appspot.com/10826093/
 with a trivial fix for ARM architectures).

BUG=
TBR=piman@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10843059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149734 0039d316-1c4b-4281-b951-d872f2087c98

TEST=H264BitReaderTest::ReadStreamWithoutEscapeAndTrailingZeroBytes in h264_parser_unittest.

Review URL: https://chromiumcodereview.appspot.com/10843057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149733 0039d316-1c4b-4281-b951-d872f2087c98

so that we can make sure we invalidate all file systems associated to a given path (e.g. for a detached device)

BUG=none
TEST=IsolatedContextTest.*

Review URL: https://chromiumcodereview.appspot.com/10829136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149732 0039d316-1c4b-4281-b951-d872f2087c98

This removes a whole bunch of IPC stubs for methods that don't exist anymore:
IDBCursorBackendInterface::update
IDBObjectStoreBackendInterface::put
IDBTransaction::mode

BUG=129471


Review URL: https://chromiumcodereview.appspot.com/10831138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149731 0039d316-1c4b-4281-b951-d872f2087c98

MP4StreamParser::Flush() (called eventually by sourceAbort()) did not reset the
parser state, and so would only work if the call happened to come when the
parser was already in a particular state (which happened to always be true for
the browser test harness it was originally tested with).

Additionally, the format-specific buffer conversion methods did not cause
an error to be propagated to the caller on failure, resulting in unexpected
success for the added test.

BUG=
TEST=MP4StreamParserTest.TestFlush


Review URL: https://chromiumcodereview.appspot.com/10843044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149730 0039d316-1c4b-4281-b951-d872f2087c98