GitLab

The original attempt to land the CL incorrectly interacted with another
recently landed CL that added the tabStripBackgroundView
(https://codereview.chromium.org/611453004). This CL was causing that view to
become layer backed, which caused it to draw on top of non-layer backed window
content, including the window controls.

This reland reworks the logic so that the tabStripBackgroundView is added to
the root view and does not become layer backed. This reland also updates
browser_tests to catch similar such errors in the future.

--------------Original CL Description---------------
Make the window's contentView have the same size as the window itself. Adjust
the view hierarchy so that Chrome does not add subviews directly to the root
view.

By default, the contentView does not occupy the full size of a framed window.
Chrome still wants to draw in the title bar. Historically, Chrome has done this
by adding subviews directly to the root view. This causes several problems. The
most egregious is related to layer ordering when the root view does not have a
layer. By making the window's contentView full-sized, there is no longer any
need to add subviews to the root view.

I deleted the tests in presentation_mode_controller_unittest.mm since they were
layout tests for the browser_window_controller, but the tests in
browser_window_layout_unittest.mm are both more robust and more comprehensive.

I fixed a bug in moveViewsForImmersiveFullscreen:... where the tabStripView was
being added to the source window rather than the destination window.

This CL is mostly a reland of https://codereview.chromium.org/399803002/.

Original CL Committed: https://crrev.com/746dbb9cfefaac243704956db431ff9bb9b0485b
Original CL Cr-Commit-Position: refs/heads/master@{#298584}

BUG=417923

Review URL: https://codereview.chromium.org/646703002

Cr-Commit-Position: refs/heads/master@{#299168}

BUG=422450
TBR=govind@chromium.org

Review URL: https://codereview.chromium.org/641183007

Cr-Commit-Position: refs/heads/master@{#299167}

Revert of Roll WebGL conformance tests. (patchset #4 id:250001 of https://codereview.chromium.org/641173002/)

Reason for revert:
might cause a bunch of texture related tests to timeout

conformance_textures_texture_formats_test
conformance_textures_texture_hd_dpi
conformance_textures_texture_mips
conformance_textures_texture_npot
conformance_textures_texture_npot_video
conformance_textures_texture_size
conformance_textures_texture_size_cube_maps
conformance_textures_texture_size_limit
conformance_textures_texture_sub_image_cube_maps
conformance_textures_texture_transparent_pixels_initialized
conformance_textures_texture_upload_cube_maps

Original issue's description:
> Roll WebGL conformance tests.
>
> BUG=401311,421705
> TEST=gpu bots
> NOTRY=true
> R=kbr@chromium.org
>
> Committed: https://crrev.com/84d03b89afa3baade276d0f7ac7892ab77ed8d21
> Cr-Commit-Position: refs/heads/master@{#299134}

TBR=kbr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401311,421705

Review URL: https://codereview.chromium.org/648833003

Cr-Commit-Position: refs/heads/master@{#299166}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c96f7be..853a4b9

TBR=eseidel@chromium.org,caseq@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/644063002

Cr-Commit-Position: refs/heads/master@{#299165}

Check to see if previously-allocated queries are done before allocating
new ones. It turns out that destroying a massive list of queries
accounts for 50% of our watchdog timeouts in the GPU process.

BUG=398072

Review URL: https://codereview.chromium.org/642993002

Cr-Commit-Position: refs/heads/master@{#299164}

This is a first pass only changing values of string resources, so we can
smoothly merge it to M38.

Note: strings that are not in M38 are not changed.

BUG=421466
TEST=manual, no merge conflicts for 2125

Review URL: https://codereview.chromium.org/649723002

Cr-Commit-Position: refs/heads/master@{#299163}

Two changes here:
1. When finding the max scale of an animation, only consider the scales
at each of the animations keyframes excluding the animations origin.

This is done because the origin is not an interesting scale to use, we
are animating away from it. And in the case of a layer at a high scale,
we are unable to raster all of its content at that scale. It would be
better to use the scale at the end of the transform since that is what
we will want to raster eventually.

2. When PictureLayerImpl chooses to use the animation scale:
a) Always allow using it if the scale is less than the current raster
scale choice. It can only put us in a better position memory-wise.
b) Don't use the max() with the current raster scale choice, that means
we will never use the animation scale if it is zooming out, which is
not what we want. This would also mean we choose a new raster scale on
every frame, which is bad. Just use the scale of the animation straight
up, and if it's not known, use a source scale of 1.

R=ajuma, vmpstr
BUG=421812

Review URL: https://codereview.chromium.org/642983003

Cr-Commit-Position: refs/heads/master@{#299162}

This CL turns const by value return values into const by ref.

Replacing const value by a const ref when a member variable is safe, because
the member variable will live at least as long as the temporary object returned
now. It can also be more efficient, because returning a ref can spare copying.

BUG=393155

Review URL: https://codereview.chromium.org/646853003

Cr-Commit-Position: refs/heads/master@{#299161}

Turns out attributes like AXPosition will crash with @[] :/

BUG=412707
TEST=Start Chrome with --enable-new-avatar-menu. Provided you have zooming
enabled in your Mac Accessibility settings, press Ctrl and scroll up to zoom
in. Click on the avatar button. The avatar bubble should open and Chrome should
not crash.

Review URL: https://codereview.chromium.org/645933002

Cr-Commit-Position: refs/heads/master@{#299160}

This execution path is currently seen used when destroying a
VideoDecoderJob that's still decoding:
* MediaDecoderJob::Release (early return, destroy_pending_=true)
* ...
* MediaDecoderJob::OnDecodeComplete
* ~VideoDecoderJob
* ~MediaDecoderJob
* MediaDecoderJob::ReleaseMediaCodecBridge
* MediaDecoderJob::OnMediaCodecBridgeReleased <-- !!!

The last line should be:
* VideoDecoderJob::OnMediaCodecBridgeReleased

but since it is invoked during the destructor the overridden
implementation is not executed.

R=qinmin@chromium.org,xhwang@chromium.org
BUG=internal b/17671489

Review URL: https://codereview.chromium.org/647553003

Cr-Commit-Position: refs/heads/master@{#299159}

This introduces the new files and dependencies (not used yet). A further improvement will be to switch to use gfx::Image.

TBR=senorblanco
BUG=409156

Review URL: https://codereview.chromium.org/641513003

Cr-Commit-Position: refs/heads/master@{#299158}

Only space seems to work by default.

BUG=415823

Review URL: https://codereview.chromium.org/644023002

Cr-Commit-Position: refs/heads/master@{#299157}

BUG=

Review URL: https://codereview.chromium.org/427953005

Cr-Commit-Position: refs/heads/master@{#299156}

Review URL: https://codereview.chromium.org/647623002

Cr-Commit-Position: refs/heads/master@{#299155}

BUG=

Review URL: https://codereview.chromium.org/647843002

Cr-Commit-Position: refs/heads/master@{#299154}

URLDataSource can specify the value for 'Access-Control-Allow-Origin' response header based on 'Origin' request header.

SharedResourcesDataSource allows access for all 'chrome://*' origins.

BUG=418199

Review URL: https://codereview.chromium.org/613733002

Cr-Commit-Position: refs/heads/master@{#299153}

BUG=419901

Review URL: https://codereview.chromium.org/642363002

Cr-Commit-Position: refs/heads/master@{#299152}

When packing is enabled, the profiler can no longer properly map the
symbols which results in incorrect callstacks. Packing should be
disable when profiling is turned on.

R=vmiura@chromium.org
BUG=None
TEST=trybots

Review URL: https://codereview.chromium.org/641373005

Cr-Commit-Position: refs/heads/master@{#299151}

Now that ANGLE's overcome some performance problems it had on Intel
devices, enable D3D11 on newer drivers. Leave older drivers, in this
case prior to 8.16, disabled for now.

BUG=363721,363721

Review URL: https://codereview.chromium.org/645653002

Cr-Commit-Position: refs/heads/master@{#299150}

Adding flags to check if SPen button is pressed
when gesture text selection is in progress.
The selection should be updated only when the
button is pressed.

BUG=416004

Review URL: https://codereview.chromium.org/590483002

Cr-Commit-Position: refs/heads/master@{#299149}

This CL moves the app_view.js API to extensions.

This is still not enough to get app_view working in app_shell, this will be addressed in a future CL.

BUG=352293

Review URL: https://codereview.chromium.org/642863003

Cr-Commit-Position: refs/heads/master@{#299148}

With this we can reduce the dependency of CVC on AW module. Hence removing
this unwanted parameter.

BUG=398263

Review URL: https://codereview.chromium.org/646693003

Cr-Commit-Position: refs/heads/master@{#299147}

This is an equivalent of DCHECK() in IDMap.
According to crbug.com/381990, this can occasionally crash.
I'd like to enable this to collect more data if it still crashes.
If you see this CHECK() being hit in the wild,
please revert this change and let me know.

BUG=381990, 415059
R=nasko@chromium.org, amineer@chromium.org

Review URL: https://codereview.chromium.org/647623003

Cr-Commit-Position: refs/heads/master@{#299146}

Currently we place a 2-second on URLRequestContextAdapter initialization, so
that context can be initialized when embedders make requests. This CL changes
so that tasks that depend on context being initialized will be run after the
context is initialized properly, and URLRequestContextAdapter initialization
won't block.

BUG=

Review URL: https://codereview.chromium.org/617393005

Cr-Commit-Position: refs/heads/master@{#299145}

onGetYUV8Planes() exposes internal data of a VideoFrame and then delete the
VideoFrame. VideoImageGenerator must keep the VideoFrame until exposed data is
used.

BUG=91208

Review URL: https://codereview.chromium.org/624633002

Cr-Commit-Position: refs/heads/master@{#299144}

When a package is selected in the file opener, it is automatically zipped, and
the zipped file is passed to the render view host.

This CL fixes 2 unrelated bugs in file_select_helper:
- If the render_view_host_ was destroyed before the user finished with the
file_select_helper, then Release() would never be called and the
file_select_helper would leak.

- If the render_view_host_ was destroyed before the user finished with the
file_select_helper, the default directory would be updated if the user was
opening multiple files, but it would not be updated if the user was opening a
single file. Now both update the default directory.

Note: When a large package is being zipped, the UI thread and renderer are
still responsive, but display no indication of the ongoing work.

BUG=33920

Review URL: https://codereview.chromium.org/634833003

Cr-Commit-Position: refs/heads/master@{#299143}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1dfb44f..c96f7be

TBR=eseidel@chromium.org,caseq@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/644003002

Cr-Commit-Position: refs/heads/master@{#299142}

On lock screen focusPOD evend happened before user input mathods were saved,
thus changing user input method to login. This CL fixes initialization order.

BUG=418878

Review URL: https://codereview.chromium.org/646743002

Cr-Commit-Position: refs/heads/master@{#299141}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bc92163..71856d5

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/649703002

Cr-Commit-Position: refs/heads/master@{#299140}

BUG=none
TESTS=Ran ash_unittests and ran TouchTransformerControllerTest.* with memcheck
NOTRY=true
TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/647023003

Cr-Commit-Position: refs/heads/master@{#299139}

This logic will need to move to the browser process to capture text
from frames that live in other processes.

BUG=346764
TEST=Navigate in an out-of-process iframe and wait 10 seconds.

Review URL: https://codereview.chromium.org/645803002

Cr-Commit-Position: refs/heads/master@{#299138}

Since the video is actually playing on a remote device, there's no need to prevent
the screen from fading and locking.

BUG=420665
TEST=manual

Review URL: https://codereview.chromium.org/644463003

Cr-Commit-Position: refs/heads/master@{#299137}

Provide a single implementation of WebGestureCurve, instead relying on
platform-specific ui::GestureCurve implementations for core
functionality. This eliminates the duplicated curve code used for
content and view-targetted flings on Aura.

BUG=420214

Review URL: https://codereview.chromium.org/634373003

Cr-Commit-Position: refs/heads/master@{#299136}

Since we're using a spiral iterator, we run into a situations where
a shared tile is visited by an iterator, but it is meant to be returned
by the twin (since it has higher priority). We already skip these types
of tiles in the Pop function. However, it could be the case that
the very first tile is of this kind. The fix is to ensure we skip these
types of tiles in the constructor as well.

BUG=422178
R=reveman

Review URL: https://codereview.chromium.org/647683002

Cr-Commit-Position: refs/heads/master@{#299135}

BUG=401311,421705
TEST=gpu bots
NOTRY=true
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/641173002

Cr-Commit-Position: refs/heads/master@{#299134}

Broke telemetry_perf_unittests on Android Tests.

TBR=craigdh@chromium.org,cjhopman@chromium.org,klundberg@chromium.org,tonyg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400440

Review URL: https://codereview.chromium.org/645093002

Cr-Commit-Position: refs/heads/master@{#299133}

This is making people ignore other presubmit warnings in all the noise.

R=ajuma, enne, vmpstr

Review URL: https://codereview.chromium.org/639183005

Cr-Commit-Position: refs/heads/master@{#299132}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bfa492a..1dfb44f

TBR=eseidel@chromium.org,caseq@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/637303004

Cr-Commit-Position: refs/heads/master@{#299131}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d8088f8..bc92163

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/643133002

Cr-Commit-Position: refs/heads/master@{#299130}

Page flips arrive in random order so we want to make sure that we
process the page flips for all affected controllers.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/641173003

Cr-Commit-Position: refs/heads/master@{#299129}