GitLab

Revert of Use new SafeBrowsing redirect tracking code in CWS pings. (patchset #6 id:140001 of https://codereview.chromium.org/2779643002/ )

Reason for revert:
Reverting in hopes of fixing 717315. See it for details.

Original issue's description:
> Use new SafeBrowsing redirect tracking code in CWS pings.
>
> The SafeBrowsing code tracks more types of redirects than the /net code which strictly adheres to spec and so can drop various types of redirects which can obscure the referrer chain.
>
> BUG=685905
>
> Review-Url: https://codereview.chromium.org/2779643002
> Cr-Commit-Position: refs/heads/master@{#468389}
> Committed: https://chromium.googlesource.com/chromium/src/+/39d1ffe7ba2c6fc8ebe6245472e0191b6f29aa9c

TBR=jialiul@chromium.org,rdevlin.cronin@chromium.org,robertshield@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=685905

Review-Url: https://codereview.chromium.org/2854763002
Cr-Commit-Position: refs/heads/master@{#468495}

Changes to the Infobar spec and how they lay out controls are coming.
Split off radio buttons into a separate layout that InfoBarControls
use and can be added by other layouts to prevent conflating changes
between them.

Also fixes up how the promo dialog (which used the RadioButtons)
assigns widths to some of its children.

Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDYkxiQWNwS1JzR2c

BUG=712836,712833

Review-Url: https://codereview.chromium.org/2850063002
Cr-Commit-Position: refs/heads/master@{#468494}

The previous ignore logic was incorrect as it was both calling
create and set index.  Thus the zero tabs case was resulting in
switch tabs always.

Adds tests to catch regressions going forward.

BUG=717062

Review-Url: https://codereview.chromium.org/2850163002
Cr-Commit-Position: refs/heads/master@{#468493}

Last two usages in RFH:
- media interface registry
- java interface provider bridge

both replaced by ad-hoc InterfaceProvider impls

R=rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2847743003
Cr-Commit-Position: refs/heads/master@{#468492}

This CL fixes a problem when checking for if timezone autodetection should
startfor signin screen, when unset preference was treated as "false".

BUG=622555

Review-Url: https://codereview.chromium.org/2855433002
Cr-Commit-Position: refs/heads/master@{#468491}

Added trailing comments displaying the property api pointed to by all
the non-null entries of the CSSDescriptorIndices table in
CSSPropertyDescriptor.cpp. This improves the readability of the table.

Changes to generated files:
https://gist.github.com/BugsNash/44fa796f876d5b4727931a4b63cec386/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2849133002
Cr-Commit-Position: refs/heads/master@{#468490}

Depending on selected call frame, we only use one specific
context per debugger model to evaluate in while on pause.

BUG=716306

Review-Url: https://codereview.chromium.org/2849583006
Cr-Commit-Position: refs/heads/master@{#468489}

Previously, GpuSurfaceTracker would add accelerated widgets and java
Surfaces via separate API calls.  Now, a java surface is required
when registering an accelerated widget (ANativeWindow) on Android.

BUG=710230
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2791723003
Cr-Commit-Position: refs/heads/master@{#468488}

Generated externs instruct maintainers to reference this doc to
regenerate them, so add the expected instructions here.

R=dbeam@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2852143002
Cr-Commit-Position: refs/heads/master@{#468487}

Curry up the errors from argument parsing to signature parsing in order
to indicate to scripts which argument threw the error.  Update the
APISignature unittests to test the new behavior.

BUG=653596

Review-Url: https://codereview.chromium.org/2847853002
Cr-Commit-Position: refs/heads/master@{#468486}

This CL also fixes the log which coverts an EID to a hex string.

Review-Url: https://codereview.chromium.org/2847233003
Cr-Commit-Position: refs/heads/master@{#468485}

Currently, if a pref is changed and the pref service is enabled, the
entire value is sent to the pref service and other clients. For large
prefs used by extensions or content settings this can result
milliseconds of busy time on the UI thread.

ScopedDictionaryPrefUpdate tracks which components of a pref are changed
so only the changes need to be sent to the pref service and other pref
clients.

Bug: 654988
Change-Id: Ied5dc6d0fadaa04817330fddce08efdc8b1d0fce
Reviewed-on: https://chromium-review.googlesource.com/476370Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468484}

https://pdfium.googlesource.com/pdfium.git/+log/a0a69233cafa..40baddef7fda

$ git log a0a69233c..40baddef7 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 tsepez Remove more |new|s, part 6

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ie95ca95037f72c413496e9f853f08ef2c381a2ae
Reviewed-on: https://chromium-review.googlesource.com/492346
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468483}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/58c56c18..447fde34

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2850283002
Cr-Commit-Position: refs/heads/master@{#468482}

Revert of Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk (patchset #1 id:1 of https://codereview.chromium.org/2856583002/ )

Reason for revert:
Possible failure: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Tests__dbg__1_%2F25521%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCaptivePortalWindowTest.OnRedirected%2F0

Original issue's description:
> Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk
>
> This reverts commit f07732ec
> (https://codereview.chromium.org/2791933004)
> and reapplies b6d0c9a0
> (https://codereview.chromium.org/2690183002/).
>
> BUG=653916, 707986
> TBR=jam@chromium.org, rkaplow@chromium.org
> Previously reviewed at https://codereview.chromium.org/2690183002/
>
> Review-Url: https://codereview.chromium.org/2856583002
> Cr-Commit-Position: refs/heads/master@{#468376}
> Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d566487590518ec223

TBR=jam@chromium.org,rkaplow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=653916, 707986

Review-Url: https://codereview.chromium.org/2848413002
Cr-Commit-Position: refs/heads/master@{#468481}

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2848443002
Cr-Commit-Position: refs/heads/master@{#468480}

Remove a host_resolver()->ClearRules call in a test body and replace it with an AddRule call that happens in SetUpOnMainThread.

This allows us to enforce that mock host resolver isn't modified in a test body.

BUG=713847

Review-Url: https://codereview.chromium.org/2854693002
Cr-Commit-Position: refs/heads/master@{#468479}

The minidump uploader attempts to sanitize multipart boundary lines present in
minidumps, but was not checking for invalid characters. Only alphanumeric
characters, plus dash, are valid.

BUG=712420
TEST=MinidumpUploadCallableTest
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2853653002
Cr-Commit-Position: refs/heads/master@{#468478}

BUG=640835
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2821203003
Cr-Commit-Position: refs/heads/master@{#468477}

Cr-Commit-Position: refs/heads/master@{#468476}

Before the change, an update check error would terminate the update but leave the
components unhandled. Therefore, for an external observer, it would appear that the
components were stuck on checking for updates.

BUG=687231

Review-Url: https://codereview.chromium.org/2853903002
Cr-Commit-Position: refs/heads/master@{#468475}

BUG=690179

Review-Url: https://codereview.chromium.org/2843383004
Cr-Commit-Position: refs/heads/master@{#468474}

If the Smart Select classifier suggests shortening the selection, we discard the
suggestion. This makes it so Smart Select can only extend a selection and thus
fixes the issue where sometimes it would shorten a SelectAll selection.

BUG=714106

Review-Url: https://codereview.chromium.org/2847133004
Cr-Commit-Position: refs/heads/master@{#468473}

Make file names more consistent in cc/surfaces.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2852163002
Cr-Commit-Position: refs/heads/master@{#468472}

This CL adds CSS for .separator which is a grey separator line
between controls on a row (e.g. settings-box). The intent is to replace
.secondary-action (a TODO has been added to that effect). This initial
CL changes the separator lines seen in the basic main page of MD
settings.

(a step to fix, but not complete fix).
BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847583002
Cr-Commit-Position: refs/heads/master@{#468471}

Additionally this resolves an incoming margin strut once we know the inline node
isn't empty. In this respect we treat it like a zero-height div.

This regresses some tests that were using the existing LayoutBlockFlow layout.
I.e. when we are inside a LayoutTableCell.

BUG=635619

Review-Url: https://codereview.chromium.org/2851983002
Cr-Commit-Position: refs/heads/master@{#468470}

This is because launcher closes after voice queries.

Also fixing a bug where a voice query was treated as a non-voice query for some short period of time. This happened because while "is voice query" flag was cleared, the query text remained non-empty. This caused, in particular, unnecessary answer server queries after the voice query is over. Stack example (with "is voice" already cleared, and query text is still non-empty):

0  app_list::SearchAnswerWebContentsDelegate::Update (this=0x48a03b686e0, is_voice_query=<optimized out>) at ../../chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc:93
1  0x000064441d08df8a in AppListViewDelegate::OnTemplateURLServiceChanged (this=0x48a046fa000) at ../../chrome/browser/ui/app_list/app_list_view_delegate.cc:534
2  0x000064441c687230 in TemplateURLService::NotifyObservers (this=<optimized out>) at ../../components/search_engines/template_url_service.cc:2124
3  0x000064441c68ec06 in Update (this=0x48a0265a340, existing_turl=0x48a0350d600, new_values=...) at ../../components/search_engines/template_url_service.cc:1713
4  TemplateURLService::UpdateTemplateURLVisitTime (this=0x48a0265a340, url=0x48a0350d600) at ../../components/search_engines/template_url_service.cc:1787
5  0x000064441c689375 in TemplateURLService::UpdateKeywordSearchTermsForURL (this=0x48a0265a340, details=...) at ../../components/search_engines/template_url_service.cc:1781
6  0x000064441af6bb4f in non-virtual thunk to ChromeTemplateURLServiceClient::OnURLVisited(history::HistoryService*, ui::PageTransition, history::URLRow const&, std::vector<GURL, std::allocator<GURL> > const&, base::Time) ()
    at ../../chrome/browser/search_engines/chrome_template_url_service_client.cc:85
7  0x000064441c62bf32 in history::HistoryService::NotifyURLVisited (this=0x48a027df500, transition=805306373, row=..., redirects=std::vector of length 0, capacity 0, visit_time=...) at ../../components/history/core/browser/history_service.cc:1092
......

Some frames may be optimized away due to inlining.

Also other optimizations and cleanups; as a result, we now have exactly as many expensive requests (such as server queries) as necessary.

Bug=712331

Review-Url: https://codereview.chromium.org/2846733004
Cr-Commit-Position: refs/heads/master@{#468469}

BUG=663085

Review-Url: https://codereview.chromium.org/2856653002
Cr-Commit-Position: refs/heads/master@{#468468}

This verifies that one request per page has pid= and that 5 consecutive
page loads generates 5 unique IDs.

BUG=709516

Review-Url: https://codereview.chromium.org/2845803002
Cr-Commit-Position: refs/heads/master@{#468467}

getLocationInWindow adjusts for the Android nav bar, while the
positioning of the parent is exclusive of the nav bar.  This causes
the suggestions be too bar left aligned and cut off.

Only visible if you have the nav bar aligned with the start of
the text (i.e. on the left with LTR text).

BUG=669150

Review-Url: https://codereview.chromium.org/2849283002
Cr-Commit-Position: refs/heads/master@{#468466}

BUG=687231

Review-Url: https://codereview.chromium.org/2856573003
Cr-Commit-Position: refs/heads/master@{#468465}

I believe we aren't always getting the begin main frame signal leading
to an increase in hung renderers when rAF mouse aligned input is
enabled. Test my theory by adding a timer that fires after a
significantly long time (5s) if we are waiting for a signal but
haven't received it.

BUG=703344

Review-Url: https://codereview.chromium.org/2846333002
Cr-Commit-Position: refs/heads/master@{#468464}

https://skia.googlesource.com/skia.git/+log/d170c0fb48aa..5664e65eb168

$ git log d170c0fb4..5664e65eb --date=short --no-merges --format='%ad %ae %s'
2017-05-01 mtklein finish up constants
2017-05-01 mtklein refactor hsl_to_rgb a touch
2017-05-01 benjaminwagner Update Nexus6p to Android O developer release.
2017-05-01 mtklein fix t / t2 confusion in hsl_to_rgb
2017-05-01 mtklein getting close on float constants
2017-05-01 bungeman SkFontMgr::matchFamily should not crash on nullptr.
2017-05-01 mtklein some float constants
2017-05-01 scroggo Blacklist SkImage_makeTextureImage on NVIDIA Win10 Vulkan
2017-05-01 egdaniel Fix Creation of GrBackendRenderTarget from GrBackendRenderTargetDesc in GL

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I6a61e519ac953988db16f774779576650a855c8e
Reviewed-on: https://chromium-review.googlesource.com/492090Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468463}

BUG=684839

Review-Url: https://codereview.chromium.org/2847823004
Cr-Commit-Position: refs/heads/master@{#468462}

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2837023004
Cr-Commit-Position: refs/heads/master@{#468461}

Revert of [Android] Keep extracted secondary dex files when clearing data in tests. (patchset #2 id:20001 of https://codereview.chromium.org/2854503002/ )

Reason for revert:
primary suspect for crbug.com/717267

Original issue's description:
> [Android] Keep extracted secondary dex files when clearing data in tests.
>
> BUG=716029
>
> Review-Url: https://codereview.chromium.org/2854503002
> Cr-Commit-Position: refs/heads/master@{#468356}
> Committed: https://chromium.googlesource.com/chromium/src/+/039ec1ad2eaec6f13bfdda8cb3ac5e5d8cdc32b3

TBR=agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=716029

Review-Url: https://codereview.chromium.org/2849323002
Cr-Commit-Position: refs/heads/master@{#468460}

Review-Url: https://codereview.chromium.org/2846333003
Cr-Commit-Position: refs/heads/master@{#468459}

- Adds new shared pref key and values for search engine promo state
- Exposes prevous promo type features in ChromeFeatureList to java

BUG=712833, 712836

Review-Url: https://codereview.chromium.org/2848333002
Cr-Commit-Position: refs/heads/master@{#468458}

On Windows, we can use GPU IO thread to filter some messages for GPUVEA.
In that case, while GpuVideoEncodeAccelerator::OnWillDestroyStub() is running
on main thread, GpuVideoEncodeAccelerator::OnEncodeFrameCreated() can run
on IO thread. If |encoder_| is reset on main thread and accessed on IO
thread, we see the crashes listed on the bug.
This CL solves the issue by:
- Checking |filter_removed_| which is signaled on IO thread before deciding
to continue with encode GpuVideoEncodeAccelerator::OnEncodeFrameCreated() on
IO thread.
- Making sure that |encoder_worker_thread_| tasks are completed before reset.

BUG=715759
TEST=Tested AppRTC loopback with H264.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849443003
Cr-Commit-Position: refs/heads/master@{#468457}

This patch switches UsbServiceLinux to being initialized with a
SequencedTaskRunner that puts it on its own non-shutdown-blocking
sequence. Individual device connections are also put on their own
sequences because there is no dependency between them and the global
service.

As DeviceMonitorLinux is global and owned by the FILE thread a new
UdevWatcher class has been added which can be owned by each service
that needs to monitor udev and lives on its own sequence.

This should resolve issue 694496 by allowing Chrome to exit even if a
faulty driver or device has locked up the USB service.

BUG=694496

Review-Url: https://codereview.chromium.org/2849953003
Cr-Commit-Position: refs/heads/master@{#468456}