- 25 Jul, 2020 40 commits
-
-
Andrey Zaytsev authored
UI demo: https://screenshot.googleplex.com/PdYajrS8FfE.gif Bug: 1070620, 1107807 Change-Id: I2fac517d4aefd5999449988cfe7d289f76e67563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303714Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#791461}
-
Ben Wagner authored
The Chromium logging of SkDebugf messages was originally intended to be INFO, but was sometimes changed to ERROR because otherwise the SkDebugf in SK_ABORT was not logged, making crashes more difficult to diagnose. This was done with https://crrev.com/c/1348630 but this leads to all SkDebugf calls being logged as ERROR when DCHECK_IS_ON. Instead, restore SkDebugf messages to INFO and define SK_ABORT directly and define it to work the way it is expected to work, as a FATAL message which aborts. Bug: chromium:1050863 Change-Id: If4c5525cd3f0ee762ed9a95c22148970e6962dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316816 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#791460}
-
Alexei Svitkine authored
It now lives in variations_field_trial_creator.cc, so this copy is not used. Bug: none Change-Id: I8bccc220e29b550a5b45ebd95aa557f3cf2ac64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305112 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#791459}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia0c4797f00ad39ec656e1f36fa3c2042d9238424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317828Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#791458}
-
Koji Ishii authored
Pointed out in crrev.com/c/2315897 that this member name is confusing, whether it is a frame rect used in layout, or ink overflow. Renamed to clarify it is a frame rect. Bug: 1108580 Change-Id: I3cc1b32930c60068ac6a63514f6216c07b4b8129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315462Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#791457}
-
Francois Beaufort authored
This CL makes sure the list of ports visible in the serial port chooser is ordered by file paths so that users can quickly jump to the desired serial port. It is especially useful when system has plenty of tty ports. Screenshot: https://i.imgur.com/MoRcx5z.png Bug: 884928 Change-Id: Ib0efe74eb2bd03263b7bf8e2fc6b8a719c839410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312316 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#791456}
-
Orin Jaworski authored
This CL fully deletes two Pedals that won't be launched, including all data and related unit tests. This is done to simplify upcoming changes to the full set of remaining Pedals (no sense maintaining code that isn't going to fly). Bug: 893183 Change-Id: I1687774557efe416f17b1da852e0e6e0da6e88d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316950 Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#791455}
-
Dominic Mazzoni authored
One call had some extra logic that was missing from the other call. Most likely it didn't trigger a bug because it's unlikely we'd ever have a scenario where the root object's AXRelativeBounds changes but the root isn't serialized. Still, this is definitely the right thing to do, and it makes the code in RenderAccessibilityImpl simpler and more readable. Bug: 1109081 Change-Id: If4ccb9d5dab5393c9b965af48943161c549fd272 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314874 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#791454}
-
Gauthier Ambard authored
It seems that resetting the alert coordinator is actually dismissing the ReadingList ViewController. This is not needed as nothing is relying on the coordinator to be nil, so removing the nil assignment is working. Fixed: 1105852 Change-Id: I1cf8c38e6f6b8d1f8456e6b2ed439e38c44db275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316204 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791453}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9e1fc05ef7a2..df34e3c37407 2020-07-25 tsepez@chromium.org Make ownership of XML document slightly saner. 2020-07-24 tsepez@chromium.org Rename CFXA_DocumentParser to CXFA_DocumentBuilder. 2020-07-24 tsepez@chromium.org Make an XML-tree be the input to CFXA_DocumentParser(). 2020-07-24 tsepez@chromium.org Retain layout items rather than raw widgets in CFXA_TabParam. 2020-07-24 tsepez@chromium.org Make CPDFXFA_Context::m_DocEnv into a pointer. 2020-07-24 tsepez@chromium.org Simplify ~CPDFXFA_Context(), part 2 2020-07-24 tsepez@chromium.org Slightly simplify ~CPDFXFA_Context(). 2020-07-24 thestig@chromium.org Fix issue with FPDFText_GetLooseCharBox() and the tranformation matrix. 2020-07-24 thestig@chromium.org Add experimental APIs to get XFA data. 2020-07-23 tsepez@chromium.org Move fxv8_unittests.{cpp,h} and fxgc_unittests.{cpp,h} to testing/ 2020-07-22 tsepez@chromium.org Make test environment setup consistent with gtest model. 2020-07-22 tsepez@chromium.org Move class EmbedderTestEnvironment to standalone V8TestEnvironment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109108 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I58d04da158120610f2cc3dbc3c36eec5a169c806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791452}
-
Tanmoy Mollik authored
Unable to produce this failure locally. As discussed on the bug the reason for the failure is most probably because SettingsActivity was not closed. Closing SettingsActivity should resolve the failure. The test will be enabled in a separate cl. Bug: 1102296 Change-Id: I1cfae80f48dc84d04abb8d3e87ff7c7879987bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317207 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#791451}
-
Marijn Kruisselbrink authored
Make sure this actually fails on posix, and return the correct error code when trying to create a file or directory fails because the other type already exists. Bug: 1098001 Change-Id: I265c079a436e2107e1ee9c146e87c9e9ea3db7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317989 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791450}
-
Amr Aboelkher authored
Previously, private_membership was depending on specific targets in abseil before facilitating the component build for it. Now, it can directly depend on its component build. Bug: 1094745 Change-Id: I1c4e57fa1686c899fe5cfb49423ad033e0f40d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245613Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#791449}
-
yjliu authored
The problem was caused by the expansion of damage under the pixel-moving backdrop filters didn't take into account the damage coming from an earlier stage (cc) in the pipeline. Bug: 1107376 Change-Id: Ie734cdbec910b17bb4b12fc9f209345e04ad12e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310389 Commit-Queue: Jun Liu <yjliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#791448}
-
Sergei Datsenko authored
BUG=chromium:1012031 Change-Id: I03841d12598ae6df7eaf63d466ac8b1719b59340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312396Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#791447}
-
Paul Jensen authored
Previous implementation used RTM_GETLINK which is no longer supported in Android 11 as per https://developer.android.com/preview/privacy/mac-address I verified the results roughly the same on my Pixel 2. Bug: webrtc:11775 Change-Id: I8c152823b3921d483aaec9c281c09720f17e6263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297712 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791446}
-
Jose Dapena Paz authored
libstdc++ std::vector does not allow const value types: /usr/include/c++/9/bits/stl_vector.h: In instantiation of ‘class std::vector<const std::__cxx11::basic_string<short unsigned int, base::string16_internals::string16_char_traits> >’: ../../components/autofill/core/browser/data_model/autofill_structured_address_component.cc:436:37: required from here /usr/include/c++/9/bits/stl_vector.h:398:66: error: static assertion failed: std::vector must have a non-const, non-volatile value_type Bug: 957519 Change-Id: I0887c89a185749014a180cca8aec20f646bd16b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317192Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#791445}
-
Evan Stade authored
Bug: 1076098 Change-Id: I75b7e21fcf0eacef7fa4690eaab19fbb800a3f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316295Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#791444}
-
Siye Liu authored
On Windows platform, omnibox has a special handling that if the input method is Chinese, Japanese or Korean, then the input type of is changed to TEXT_INPUT_TYPE_SEARCH. We should notify input mothod that the input type has been changed. Bug: 1108845 Change-Id: I0266d9617277696ccb8bfa42ad76f9cbc3d802f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314686 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#791443}
-
Sadrul Habib Chowdhury authored
Presubmit API is changing: . input_api.DEFAULT_BLACK_LIST -> input_api.DEFAULT_FILES_TO_SKIP Update the presubmit scripts for cc and viz accordingly. BUG=1101491 R=kylechar@chromium.org Change-Id: I40963a559aa0f519bfe3925c535a8dd6ca7cdfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316928Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#791442}
-
Xiaohui Chen authored
Bug: b:156522092 Change-Id: Ia43529bfd8372db5c9f2362715db742fd356b940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315246 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791441}
-
Chris Harrelson authored
The callsites are not needed, and just need to either call PaintInvalidationOnCompositingChange directly or be removed, because PaintInvalidationOnCompositingChange was going to be called later because the PaintLayer was going to be added to layers_needing_paint_invalidation anyway. When PrePaint is moved before compositing, we should be able to get rid of the remaining two callsites to InvalidatePaintIncludingNonCompositingDescendants. Change-Id: I012a1319f1ad0afbbcbf4024b35f1c2b7a222c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316949Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791440}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I20b06a7fa762d6b9d5f0c46739eff4c253b24d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791439}
-
rbpotter authored
These tests are occasionally failing with timeouts, and seem slow when run locally in a debug build, so split the tests into 3 suites instead of one to reduce the chances of timing out. Also re-enabling a test case that no longer appears to be flaky, and adding closure compilation for this test file. Bug: 1000989, 1060981 Change-Id: I8d6f17bc398e40b9585f3f21c8e30e75565a126d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316856Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791438}
-
Sven Zheng authored
Disable for pixel test suites. This test is flaky even when pixel verification is not enabled. Bug: 1108988 Change-Id: I1c5b09fc340d2ee9cb89c6b6b4540671ce66f29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316786Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791437}
-
Marijn Kruisselbrink authored
Makes sure quarantine is invoked whenever a file is successfully moved, even if the writer itself happens to be destroyed during the move operation. Bug: 1108091 Change-Id: I809f0238870315d54f103fd5a3d27ba747ba2a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311416 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791436}
-
Tommy Nyquist authored
An earlier refactoring CL had a side effect that lead to the VersionConfig data not being stored to disk anymore, which meant there was never any data available. This CL adds back storing the VersionConfig the same times as the code before the refactor did. Two regression tests are also added to ensure we continue to store the data going forward. Bug: 1095755 Change-Id: Id285758db0d37e0ef05cefe51c18bd4895b2744e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317170Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#791435}
-
Yuwei Huang authored
Turns out I just accidentally deleted the register_request creation code. Bug: 1103416 Change-Id: I99e0a8e54be01ebe3aef29e1051840b36a1277d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318051 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#791434}
-
Garrett Beaty authored
This reverts commit cb86ee41. Reason for revert: Restoring full functionality Original change's description: > Remove GPU's Linux tests from the CQ. > > The datacenter holding GPU's bots is offline, so these CQ tests are > stuck. Remove them from the CQ while we work on getting ATL back online. > > TBR=gbeaty > > No-Try: true > Bug: 1108842 > Change-Id: I3833475c71d7f79380c22303c989d05baf2fd8fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316438 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#791275} TBR=estaab@chromium.org,gbeaty@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108842 Change-Id: I7da7f5d8bb91a4d9e5f6fe50ca97dbd0be0dbd89 No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318509 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#791433}
-
Lei Zhang authored
They are inactive on Chromium. Change-Id: I3a02442bf520a1b619fabea8cc741b58a930106b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315821Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791432}
-
Rahul Arakeri authored
This CL refactors InputScrollElasticityController and introduces 2 new subclasses - InputScrollElasticityControllerBezier will be used for managing Windows based overscroll and bounce back. The other subclass InputScrollElasticityControllerExponential will be used on Mac for the same purpose. The CL also allows an overscrolled root scroller to "bounce back" via an animation based on a Bezier curve. This animation is driven by OverscrollBounceController::Animate. The duration of this animation is determined by how far the scroller has been stretched. At every "tick" of the animation, the progress of the animation is determined based on the elapsed time. Animating flings will be added in a follow up CL. Bug: 1058071 Change-Id: Ia4278105eac5cadae191a50c25654c88a92c5a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231254 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791431}
-
James Long authored
A few UI controls have been added with the aim of making edge directions easier to see in the visualization. * Curve checkbox: Determines if edges should be curved to the right of their direction. * Color on hover checkbox: Determines if the edge colors should only be shown when hovering on a node that touches those edges. * Color scheme dropdown: Various preset color schemes determined to work well. Bug: 1106107 Change-Id: I15585251ad1ef3eef4b16e1ce536a1b1f527868c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314818 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#791430}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ba92b11e1fca..ff8fe2df3529 2020-07-23 dneto@google.com Use the non-posix MinGW compiler as fallback (#1117) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I69fae3d9bc784205128c26f92794e50fe1294d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791429}
-
Yi Xu authored
Moved 7 more tests from fast/canvas to wpt tests: Deleted 2 due to duplications, canvas-context-attributes-default-value.html and canvas-ImageData-behaviour.html, created 5 new tests. Bug: 1071659 Change-Id: Ib439525798a4fe899d77a5469dc5590bbc8be5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314991Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#791428}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I6a09abce38e97b5ff0c04fb9eec29d39f1494adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317763Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#791427}
-
Lijin Shen authored
This reverts commit 61ac41eb. Reason for revert: Constant failures on checking components/browser_ui/strings/android/browser_ui_strings.grd Original change's description: > Add presubmit to detect inappropriate punctuation usage in strings > > Google material standards usually prefer curly double/single quotes to > neutral quotes. The presubmit detects these punctuations in string > resources and then prints warnings. > > Bug: 1100941 > Change-Id: I2b21c146be352b6857e55b3dd9c4bb5f27a9e5c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290774 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788187} TBR=twellington@chromium.org,agrieve@chromium.org,lazzzis@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1100941 Change-Id: I8f981e9afd3f42e5f054cf636b39852542bbe987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317775Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#791426}
-
Tarun Bansal authored
(i) If the mainframe is ineligible (e.g., if it's a non-http/https) page, then skip recording metrics. (ii) Update main frame navigation ID on same-document main frame navigations Bug: 1109068 Change-Id: I839393b607b6c2d090ff75ae927be7049fa4cd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317167Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#791425}
-
Maxim Kolosovskiy authored
Bug: 1108692 Change-Id: I86a4d8618cd36563b1819ede1a6c7c734f96a1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315865 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#791424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f89cfd4944e..df7cabc2cd02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1077274 Tbr: melzhang@google.com Change-Id: I4dcf697c5b8f2c026395e73cfa47b8bb601c6fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316251Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791423}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a503e42..803227b Bug: 1097235 Tbr: jdarpinian@chromium.org Tbr: shrekshao@google.com Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I256ec579eef86885e20a183806b30aad58f812c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318649Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791422}
-