- 16 Oct, 2019 40 commits
-
-
Daniel McArdle authored
This CL adds net_base_address_tracker_linux_fuzzer. Change-Id: I89c7c087f7c9c85deabcaf7d265bdc88564c312d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863151Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#706415}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..cc071e45bb9c $ git log 1093c4de2..cc071e45b --date=short --no-merges --format='%ad %ae %s' 2019-10-16 enga Split generation of dawncpp headers from libdawncpp 2019-10-16 natlee D3D12 replace ASSERT_SUCCESS with better error handling 2019-10-16 hao.x.li Prioritize discrete GPU in end2end tests 2019-10-15 senorblanco clang-win compile files for skia-dawn. 2019-10-15 cwallez Add dawnGetProcAddress. 2019-10-15 cwallez Split the libdawn target in components with a single purpose. Created with: roll-dep src/third_party/dawn TBR=kbr@chromium.org BUG=dawn:22 Change-Id: Ib61611e5455abf1b66f33b1b68c311a428c3bf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864683Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#706414}
-
arthursonzogni authored
The tests aren't failing locally. TBR=altimin@chromium.org Bug=976218 Change-Id: Ic5e8c3984584f7388c80bee64da40ce4e88deebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864780Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706413}
-
Miyoung Shin authored
This CL converts MdnsListenClientPtr and Binding<MdnsListenClient> in chrome and services to the new Mojo type, and uses pending_remote<T> in host_resolver.mojom. Bug: 955171 Change-Id: Ie1821bd2d5edbbbcfc14ce8380053ce9cfaa2be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860535 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#706412}
-
Parastoo Geranmayeh authored
This reverts commit 50b0289b. Reason for revert: UDPSocketTest.TestUnexpectedSequences fails. Bug: 1014916 Original change's description: > Roll Fuchsia SDK from 889950275648 to 889947586298 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > TBR=cr-fuchsia+bot@chromium.org > > Change-Id: I654114143b038a86cc813bd5ce57508260abed5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864551 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#706330} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: I1b5fbffa51bb3ecef38f2d370c89902ff33c911f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864710Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706411}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/44806300adbd..fc9cfb00f341 git log 44806300adbd..fc9cfb00f341 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 perezju@chromium.org [Telemetry] Add new LegacyPageTestCase Created with: gclient setdep -r src/third_party/catapult@fc9cfb00f341 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:999484 Change-Id: Iaf35530fcda2e136fa909dc5b7a76e6705d38838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706410}
-
Camille Lamy authored
This reverts commit 9293d5c8. Reason for revert: this is breaking compilation on linux-builder-perf. https://ci.chromium.org/p/chrome/builders/ci/linux-builder-perf/120938 Original change's description: > GCC: Fix base::internal::InvokeFuncImpl > > GCC doesn't like that the Value data member has no out-of-line > definition. The problem is triggered specifically only when compiling > > components/services/leveldb/leveldb_database_impl.cc > > which has lambda functions returning locally-defined classes. > > The current code works as-is in C++17 mode which introduces the concept > of inline variables, but in C++14 we need either an explicit out-of-line > definition or a function member instead of a data member. > > Use std::integral_constant for defining the value. > > Bug: 819294 > Change-Id: I5c68e14ce3fa9d8b4d8a2cb42d7f9b53938aabf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862451 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jüri Valdmann <juri.valdmann@qt.io> > Cr-Commit-Position: refs/heads/master@{#706384} TBR=dcheng@chromium.org,jdoerrie@chromium.org,juri.valdmann@qt.io Change-Id: I14e3e77219874f186fb04d63ee657630e8ee73fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864782Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706409}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1b6fd37fa6f9..00170cc5e6fb git log 1b6fd37fa6f9..00170cc5e6fb --date=short --no-merges --format='%ad %ae %s' 2019-10-15 afdx@google.com spirv-fuzz: Refactor 'copy object' and 'construct composite' transformations (#2966) 2019-10-15 dneto@google.com Update SPIR-V binary header test for SPIR-V 1.5 (#2967) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@00170cc5e6fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Bug: None Change-Id: Ib1188523fb6a7f3aa600343d516260fe09f81d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864577Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f410c266cfa..48014ea23a48 Created with: gclient setdep -r src-internal@48014ea23a48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib5e5ab6296229caa19236c86552bc3b8555c3b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864459Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706407}
-
Shik Chen authored
Echo cancellation is mainly for video conferencing. Disable it in CCA could save ~10% cpu on Nocturne in video recording. Bug: b:139788862 Test: Record video on Nocturne, measure performance by pprof and top. Change-Id: Ib531c338a46e9a6c611e269ade1e96541be764ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864757Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#706406}
-
Jan Scheffler authored
This patch keeps the focus on the main menu when changing from undocked back to docked again. Bug: chromium:1002424 Change-Id: Ic36f3e6852cb4e0a43ced6387dfeb3e2491d1d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798344Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#706405}
-
Jan Scheffler authored
This patch uses the descriptions from composititing_reasons.cc when tracing layers but transfers the reason via their short name to make it compatible with LayerTree.compositingReasons from the devtools protocol. Bug: chromium:737838 Change-Id: Id019d725d51ae7b740ab10bd94a470c8a053bc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800410Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Parastoo Geranmayeh authored
Test is flaky for search/india and social. See bug. TBR=sullivan@chromium.org Bug: 1014661 Change-Id: I2c098f543ed2f6acd2575e821a21328e474735c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863379Reviewed-by:
-
jonross authored
This is based on the original change: https://chromium-review.googlesource.com/c/chromium/src/+/1478489 The goal is to be able to capture the peak of GPU Memory usage. So that we can detect regressions caused by changes in gpu code/skia In order to do this we are introducing the PeakGpuMemoryTracker in content/ This can be used to connect to the GPU service, to request the peak memory seen over an interval. The GPU service expands the MemoryTracker class with an Observer. GpuChannelManager implements this in order to aggregate the memory allocations. It responds to requests from content/ A new UMA group "Memory.GPU.PeakMemoryUsage" has been added, with "TabChange" as the initial implementation. We will use the new API to record the max memory seen during a tab change. Bug: 908462 Change-Id: Iadb959b895edc7b2e756a812972b8410353ed571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756206 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#706402}
-
Mikel Astiz authored
Nigori is a special datatype because failing to commit local changes (e.g. custom passphrase set) can lead to problematic scenarios (e.g. user data exposed unencrypted) or in rare cases complicated conflict-resolution scenarios (e.g. keystore rotation took place before committing the custom passphrase) that worst-case cannot be resolved synchronously (e.g. keystore keys are missing and hence keys are pending for some time, until keystore keys are received). It's very hard to universally reason about all side effects of local commits and conflict resolution cases. Instead, this patch introduces infrastructure that adopts the command design pattern to concisely represent what the intended local change is. Local changes may now fail to apply, in particular if there is a conflict. But in such case the infrastructure allows dealing with the failure, with custom logic that depends on the precise command type. Similarly, success is only reported once the commit is acked by the sync server, which is a desirable property and useful foundation for future work. This may introduce additional latency in the existing UX, e.g. while setting up a custom passphrase, but manual tests indicate that it's not noticeable. In this patch, only the infrastructure is introduced without actually adopting it for the various local changes. Future patches will take care of such adoption. Bug: 922900 Change-Id: Ib55d3a401f1f68a1a910ee1e2b9119889d4f73b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864770 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#706401}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/810ee9415435..692ad2ff20be git log 810ee9415435..692ad2ff20be --date=short --no-merges --format='%ad %ae %s' 2019-10-16 engeg@google.com chromite: make ResponseNotReady python3 compat Created with: gclient setdep -r src/third_party/chromite@692ad2ff20be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I32207fdf87a8a0e032ba77ba6d87cf7e8dcc372c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864486Reviewed-by:
-
Alex Chau authored
- Refactored VAPID key manager to separate get key and refresh key - Derive from sync secret if kSharingDeriveVapidKey is enabled - Observe for VAPID key source changes, refresh cached key and re-register if cached VAPID key has changed Bug: 1010968 Change-Id: I178a6cd931ad41ab0184dd8a511e8ac0569e2269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848171 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706399}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74f3784d..be181e24 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65adae7dbf5021bc194eebd35424cb303610720d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864870Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706398}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the XRInputSourceButtonListener interface. Bug: 955171, 978694 Change-Id: I2647b973b9784061918030bd2fb5f10e04b98212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844995Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#706397}
-
Alex Chau authored
- As a follow-up of https://crrev.com/c/1841451, return the ECPrivateKey directly to avoid unnecessary hashing Bug: 1010968 Change-Id: Iff13d775f511ba031eba33d63e4d47403d205280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863297 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Antonio Gomes authored
.. by calling PeerConnectionDependencyFactory::GetWebRtcWorkerThreadRtcThread() directly. This is now possible, after [1], where peer_connection_dependency_factory.cc|h is moved to Blink. [1] https://crrev.com/c/1805159 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7e1a516dff8ffbfbe69101a70b02b3da71e3b632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807396 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#706395}
-
Rune Lillesveen authored
Reset the forced colors mode in the tests and re-enable disabled tests that failed because of the missing reset. Bug: 1014380 Change-Id: I95064e021c3dd1be4ade08e1edd0c0f4092bd03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863010Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#706394}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLSelectElement> and DynamicTo<HTMLSelectElement> as new downcast helper 2. Use IsA<HTMLSelectElement>(element) in place of IsHTMLSelectElement(element) Bug: 891908 Change-Id: I1b9d2a5dfef3729ba294ff105ef12d1640c1f534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859988 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706393}
-
Emilio Cobos Álvarez authored
It was introduced in I0ad30908e76a9084ba8d685285e613a7194c02fb, but without giving it a name it just creates and destroys a temporary, which is useless. Bug: 1009806 Change-Id: I900a4f652c1ef4233a182d69a742c5162479af72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863796 Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706392}
-
Abhijeet Kandalkar authored
This CL converts, - |Binding<TracingSessionHost>| to |Receiver<TracingSessionHost>| - |Binding<TracingSessionClient>| to |Receiver<TracingSessionClient>| - |TracingSessionHostPtr| to |Remote<TracingSessionHost>| - |ProducerClientRequest| to |PendingReceiver<ProducerClient>| Bug: 955171, 978694 Change-Id: I52566c7c7561149f73df2a5aa7ecd494eafdd489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843993Reviewed-by:
-
Pavel Shmakov authored
Currently the cookies are not persisted because the default implementation of ContentBrowserClient::CreateNetworkContext doesn't specify cookie_path parameter. In this CL CreateNetworkContext is overridden in WebLayer implementation. Bug: 1014048 Change-Id: I1b7a307a64cd836eb5c4a45817412b997b89f1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862677 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706390}
-
Stepan Khapugin authored
This is a reland of http://crrev.com/c/1827373. The original CL broke downstream multitasking fix. This includes a fix to multitasking tests. Original description: Adds |window| property to SceneState. It is backed by SceneDelegate's |window| property and by UIWindowScene's |scenes| property on iOS 13 with multiwindow; or with an ivar otherwise. When it's an ivar, SceneController is now responsible for window creation. Note that the getter for AppDelegate's window remains for iOS 12 compat. Note that the window is always a ChromeOverlayWindow. have tested it manually on my machine and it still works) Change-Id: Id286f8c8d957504558effdfd1e9d7ac22ad2a23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856320Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706389}
-
Hans Wennborg authored
This reduces the number of preprocessor tokens in content_browser_client.h from 1,335,281 to 754,474. Since this is a widely included file, reducing build times a fair bit (see bug). TBR=tsepez for content/browser/child_process_security_policy_* Bug: 1014009 Change-Id: Id3c2de29f5b08cab80820d01aff722afeb1618e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857126 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#706388}
-
Armando Miraglia authored
BUG=796964 Change-Id: Ife3b4b9d4ded591b162884df4c83bd8a0a51d449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859985 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
-
Antonio Gomes authored
.. by calling PeerConnectionDependencyFactory::GetSenderCapabilities() directly. This is now possible, after [1], where peer_connection_dependency_factory.cc|h is moved to Blink. As a bonus, blink::Platform::GetRtpReceiverCapabilities was not being used and got removed. [1] https://crrev.com/c/1805159 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I8614838651a388d81d2d913fbd3657b31a195f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807157 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch supports adding list markers to |NGFragmentItems|. List markers are not part of the line box it belongs to in the |NGPhysicalFragment| tree. In |NGFragmentItem| world, it is an |NGFragmentItem| in the inline formatting context in most cases. When a list marker is attached to a block boxes, there is no change; i.e., it still appears in the |NGPhysicalFragment| tree. e.g., <li><div>text</div></li> then the list marker is propagated to a block formatting context. Some tests should turn to pass, but since bots are not setup yet, I'll update FlagExpectation later. Bug: 982194 Change-Id: I6af233360d1872de3e9507d69ef3c50275689267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846627Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706385}
-
Jüri Valdmann authored
GCC doesn't like that the Value data member has no out-of-line definition. The problem is triggered specifically only when compiling components/services/leveldb/leveldb_database_impl.cc which has lambda functions returning locally-defined classes. The current code works as-is in C++17 mode which introduces the concept of inline variables, but in C++14 we need either an explicit out-of-line definition or a function member instead of a data member. Use std::integral_constant for defining the value. Bug: 819294 Change-Id: I5c68e14ce3fa9d8b4d8a2cb42d7f9b53938aabf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862451Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jüri Valdmann <juri.valdmann@qt.io> Cr-Commit-Position: refs/heads/master@{#706384}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/febc913dd024..5f410c266cfa Created with: gclient setdep -r src-internal@5f410c266cfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8663b38726403be30f76db125e8e03a9445ff07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864453Reviewed-by:
-
Takashi Toyoshima authored
This patch adds the "WebView P OOR-CORS FYI (rel)" bot to run WebView instrumentation tests, unittests, and CTS tests with OOR-CORS enabled. Preceding tools/build side change is here: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1863899 Bug: 1013529 Change-Id: Ia35a9928138be322e9b6cab3531807957da0ffa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864502 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#706382}
-
Mikel Astiz authored
No behavioral changes: this avoids repeated for loops in the bridge, and unblocks the option to pass around a single observer to helper functions/classes in follow-up patches. Bug: 922900 Change-Id: I3c58cae19858404e2bce0eb865536397e273797d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862923Reviewed-by:
-
Anatoliy Potapchuk authored
There will help us mitigate code duplication for regular kiosk,arc kiosk managers, and the future web kiosk app manager. Bug: 1006230 Change-Id: Iede5c0d400caee03f4ed9f5aefb1e68a42f9f7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852254Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706380}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactoryPtr from //third_party/blink to new Mojo types using PendingRemote and Remote. It also update some appcache APIs which has URLLoaderFactoryPtr and communicate with blink. Bug: 955171 Change-Id: I1c9caaf4937eebac04d9aa703f9a7163cc976ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855626 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706379}
-
Miyoung Shin authored
This CL converts ResolveHostHandle{Ptr, Request} in services to the new Mojo type, and uses pending_receiver<ResolveHostHandle> in host_resolver.mojom. Bug: 955171 Change-Id: Icff06d2041c33437b0e1d8b76d50ce5b1d86b958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859969 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: -
Vadym Doroshenko authored
This teat failed, because input form data wasn't updated after removal of the old parser. Bug: 1008818 Change-Id: I145a4da89092fd72f197a62536e1d37e99f06797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862921Reviewed-by:
-
Andy Paicu authored
Bug: 1014085 Change-Id: Ibc831829014e235b964c62417d9b7c8d8467b7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860030 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706376}
-
