GitLab

We'd like to know if various error states of the hashed logging system
occur, eg. an unreasonably large number of hashed logging events being
produced. This CL adds UMA metrics to track errors.

Bug: 951287
Change-Id: Idde86c05b7c5ad3733a0aceeb6af11e4d815c2bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633871Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664981}

With the removal of STYLE_BUTTON, this is now dead code.

BUG=642920

Change-Id: I6eb5e048ebecb7daa308b616d4162e30280ef26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636856
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664980}

Some ARC++ tests (those that explicitly disable wait_default_apps_) want
to examine some state before the default apps are brought up.

Regardless of whether ARC++ tests want to examine that state, this
commit shifts the responsibility for calling RunUntilIdle from during
ArcAppTest::SetUp to inside the test functions.

This fixes `unit_tests --enable-features=AppServiceAsh
--gtest_filter="ArcAppLauncherForDefaulAppTest.AppIconUpdated/*"`. It
fails before and passes after this commit.

Note that `unit_tests
--gtest_filter="ArcAppLauncherForDefaulAppTest.AppIconUpdated/*"`,
without AppServiceAsh enabled, passes both before and after this commit.

BUG=826982

Change-Id: I3eade1eca429280b7aa1e6756561bb97c595ea1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634569
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664979}

Bug: 922813
Change-Id: I608412fb0c8b41e347f1363b5e4da58dab464efe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623269
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664978}

BUG=None

Change-Id: I020c09e3375d9a84df1f3672541409740a24ca07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637872
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664977}

Bug: 968375
Test: covered by unit tests
Change-Id: Ic682a9d2b5ee26af2a8fd29d89b842363b99e709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636766
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664976}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3acbc749e4a6..bad01ad3adaa


git log 3acbc749e4a6..bad01ad3adaa --date=short --no-merges --format='%ad %ae %s'
2019-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@bad01ad3adaa

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I829baca7e0640563e9a477db472a71702da1905e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637918Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664975}

SSP used to use _hasBeenEditedIncrementally to know whether a
property's name or value was dirty. It would skip cleanup if it was
not dirty.

A recent change made _hasBeenEditedIncrementally() reset when moving
focus from name > value editor, which broke the cleanup phase.
This CL re-adds a dirty flag state.

Bug: 968792
Change-Id: I0b3b167d88ce2ee20e222e3e23d7accf179cebfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637608Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664974}

If there is only one valid device to share tab/link to, a menu item
with inline device name will be displayed as contextual menu entry point.

This change will applies on:
- tab menu
- content menu
- link menu
- omnibox text menu

Corresponding histograms added.

Also corrected the position of entry point in omnibox menu.

Change-Id: If6f0bb8a09af4ad77269d0c4f60ff86da6b42fc8
Bug: 968376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636470
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664973}

This does the bare minimum to log to the new API. Ideally, we'd use the
protobuf throughout and get rid of the value dictionary, but that change
is a lot more involved.

Bug: 968348
Change-Id: Ie9a2fde2aa268b56f23d1fa86cb382d63c7bafbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637178
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664972}

Remove unnecessary valueExists calls in OS Settings as they are always defined.

Change-Id: I916c2194a02ce8aef997d9fb62752c20da8f1924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636996Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664971}

This also creates a proper preview for SadTab.

Bug: 952331
Change-Id: I53b7debf3fcc92fb7fbe27a13244f9a9466f49ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631361Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664970}

We are not using background time logging for TabDiscarder for now;
so it's better to disable it.

We still need to enable it in some unit tests for the test to
verify the logic.

Bug: 968390
Change-Id: Ic6a16bcd53d9feed918c29cddf86777a4583d5ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636663Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664969}

Bug: 921746
Change-Id: I27883781239fcb914088f6ce3fc4a82581177729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632530Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664968}

Now that there is only one style, the temporary |label| is no longer
needed.

BUG=642920

Change-Id: Iddb86740c94142b35d5e2da66bdbcdd443441863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637641
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664967}

The backing bitmap was not released after the Grid-to-Tab transition
animation.

Bug: 964406
Change-Id: I33cd9249528202b83851721f3ffa824c52aeaa63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636833Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664966}

This fixes `unit_tests --enable-features=AppServiceAsh
--gtest_filter="AppSearchProviderTest.InstallUninstallArc"`. It fails
before and passes after this commit.

Note that `unit_tests
--gtest_filter="AppSearchProviderTest.InstallUninstallArc"`, without
AppServiceAsh enabled, passes both before and after this commit.

BUG=826982

Change-Id: I50f782a0d7d7b40392809421ea4705c5f1df571b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637010Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664965}

Prior to this CL, the filter scale was not being used when applying
backdrop-filters. This had the effect of making blur radii (etc.)
incorrect on high-dpi screens, with a device scale factor != 1.

Bug: 965523, 968791
Change-Id: I0eac2d6775cbfa96239d91fb199d8905bb330524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637585
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664964}

When using a Daydream controller with a Mirage headset, the controller
position and orientation would get stuck when taking the headset off
and putting it back on. Doing so fires an input state change event which
causes the XRInputSource to be re-created. The copy constructor for
XRInputSource did a shallow copy of its grip and target ray spaces which
meant they still point to the old XRInputSource object which no longer
is exposed to the webpage or receives updates via mojo.

Fix this by making the XRInputSource copy constructor create new
target ray and grip space objects that point to the new XRInputSource
object.

Bug: 968544
Change-Id: I33542bde17bac70d57569bcdcce4a0206d8f45ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637239
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664963}

TBR=toyoshim@chromium.org
NOTRY=true

Bug: 966624
Change-Id: I9428e8b686498f46c7c15ad75e83b08ad996a6c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636261Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664962}

In its current form, the screenshot mode only disables modal dialogs.

We observed that in-product help bubbles are sometimes visible in the
screenshots.

This CL adds to the screenshot mode by disabling all IPH.

Bug: 964012
Change-Id: I778708ad3d5f6d59c65c9da3097ca7f020e2b151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630226
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664961}

Chrome forwards the proxy exception bypass list as a string with host names
delimited by semicolon [;] while ARC expects a colon [,] delimiter. This
causes loss of network conectivity in ARC.

This CL formats the proxy bypass list sent to ARC by replacing delimiters
and removing the rendundant delimiter at the end of the string bypass list.

  1. setup an Ethernet proxy connection with no bypass list
  2. verified ARC and ARC app have network connectivity
  3. added one host in the bypass list
  4. verified ARC connectivity is lost
  5. deployed Chrome with fix on the device
  6. verified ARC has network connectivity
  7. verified app on ARC respects proxy and proxy bypass item
  8. added three host names in the bypass list
  9. verified ARC app respects bypass list for all hostnames

Bug: b:133193788
Change-Id: I363879fe886e3c7abc6557ef163b0d930398b7d7
Tests: manually tested with following steps
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630481Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664960}

All known issues should be fixed, so lets try this again.

BUG=879406
TEST=bots
TBR=liberato

Change-Id: I88e703e65d767d5a501b5f4ae4f7334572481672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637606Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664959}

This CL adds deprecation messages for cookies that would be blocked
under SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure,
to be logged to the console on getting/setting potentially affected
cookies via `document.cookie`.

Bug: 966576
Change-Id: Ic8a4b535b019254b8021abb583db1d32b6023a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633972
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664958}

Instead, ask readers to use the isolated output directory to find the
exact logs that they are looking for. This will clean up the swarming
task output to simply become a summary explaining which benchmark runs
were kicked off.


Bug: 947103
Change-Id: I199530972acd5f1402396ddda10ac82cf61fc229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629432Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664957}

This change exposes platform specific functions through the
manager to allow for iframe traversal in AXNodePosition. Such
traversals were not previously possible since AXNode and
AXNodePosition have no concept of iframes.

Functions GetParentTreeID(), GetParentNodeID(), GetChildTreeID(),
GetChildNodeID(), and GetChildCount() were added to AXTreeManager and
BrowserAccessibilityManager in order to allow callers to access nodes
outside their own tree, as in the case of iframes.

In AXNodePosition, AnchorChild(), AnchorParent(), AnchorChildCount()
and GetAncestorAnchors() were all updated to use the newly added
manager functions. The result is that AXNodePosition now more closely
matches iframe functionality in BrowserAccessibilityPosition.

Bug: 928948
Change-Id: If74bfc66f1265110797e5eb315e23e2462da2a47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591484
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664956}

Identify cookies on get/set in URLRequestHttpJob that come up as
CookieInclusionStatus::INCLUDE, but would be blocked if
SameSiteByDefaultCookies or CookiesWithoutSameSiteMustBeSecure were
enabled, and copy them into the list of excluded cookies, so that
appropriate console messages can be displayed about the impending
deprecation.

This only covers get/set via HTTP headers. Get/set via document.cookie
will be handled separately.

Bug: 966576
Change-Id: I7edffc66956743cdad3bee6eb13e342eb3e07ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625841
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664955}

This CL cleans up the layout tests for backdrop-filter:
 - The backdrop-filter-bleeding.html test was never really complete, and
   the effect it was testing for is completely covered by the existing
   external/wpt/css/filter-effects/backdrop-filter-edge-pixels.html
   test.
 - The backdrop-filter-boundary.html test never had a valid expectation
   file. It now does, and the test has been made a bit more obvious. It
   already passed.
 - Another CL (http://crrev.com/663338) made the
   backdrop-filter-clipped.html test pass.

Bug: 497522
Change-Id: Ib95edda9dfb15fc451eaeb225310d422d70787df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637490
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664954}

https://pdfium.googlesource.com/pdfium.git/+log/12899533d341..8fd3d327fa3c


git log 12899533d341..8fd3d327fa3c --date=short --no-merges --format='%ad %ae %s'
2019-05-30 vtsyrklevich@chromium.org Update PDFium PartitionAlloc hooking
2019-05-30 thestig@chromium.org Add a test for CCodec_ProgressiveDecoder.
2019-05-30 thestig@chromium.org Add more tests for FPDF_SetPrintMode().
2019-05-30 thestig@chromium.org Use SkAutoCanvasRestore in fx_skia_device.cpp.
2019-05-30 tsepez@chromium.org Add another interface to prevent fwl -> fxfa inclusion.
2019-05-30 thestig@chromium.org Delete infra/config/cq.cfg.


Created with:
  gclient setdep -r src/third_party/pdfium@8fd3d327fa3c

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:956824,chromium:895009
TBR=pdfium-deps-rolls@chromium.org

Change-Id: I6b061e6159db33528d48e0b4e85d9b68e278090c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636404Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664953}

Since we started allowing play() to occur before the future data state,
we can now run into cases where MultiBuffer ends up increasing its
buffer sizes before renderer initialization starts. It will not satisfy
reads until the new larger buffer sizes are fulfilled, which causes
playback startup delays.

There's no reason to do this since we can just increase the size after
playback starts without penalty. So prevent size increases before
kReadyStateHaveEnough and invoke them only after reaching that state.

BUG=965684
TEST=new unittest.
R=sandersd

Change-Id: I0a7a37528f8c814731a34b6bcc4a6c9a3f9ca5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637527
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664952}

This is a port of the "app drawer" tests from
chrome/test/data/webui/settings/settings_ui_browsertest.js

For now, we have a similar side-nav drawer UI, so we use similar tests.

Bug: 967876
Test: browser_tests

Change-Id: I9feda52127f4ffb51b8d56c6cd0160ecb8153bb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636590
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664951}

Change-Id: Iabc239d78dde1bf746f6184fdc5f539a0a02637c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637601
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664950}

These methods will (eventually) be used to pass raw header information
(both request and response) from the network service directly to the
browser process, bypassing the render process. Currently sends
information about cookies that were excluded or flagged before being
sent in a request or stored in a response.

In NetworkServiceClient, a deprecation warning is fired if a cookie
runs afoul of the new samesite cookie rules (described in
draft-west-cookie-incrementalism) and then fires a verbose message for
each cookie. These messages will fire if the feature is on and the cookies
are truly blocked and also when the feature is turned off and the feature is
flagged by the code in <crrev.com/c/1625841>

Also adds use counters for the deprecation messages to measure compat risk.

Bug: 856777,966576

Change-Id: Ibf49035bdaf4b20cf0d82e1c1b00e54d4050c0c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600541
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664949}

The opacity check is unnecessary for FCP++ because: "we won't paint
opacity:0 layers if the layer has no hint that it will change opacity".

Bug: 968575, 957674
Change-Id: I4adf1c2bba37fcdfc1511580d40481943ce1a444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637724Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664948}

It's better to grab it from SurfaceClient since it's constant for all
surfaces of the client.

Bug: 938947
Change-Id: I4e5c5d986ac7a91146f9fa1677fa472ba5b9a4d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637436Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664947}

The starvation scores for the high and very high priorities were
inverted, so very high was acting as if it was between normal and
high priority instead of high and highest.

Bug: 863341
Change-Id: I98c62cbdc859560b2883375b251c711b8dc13e1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634549Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664946}

Using wpt-import in Chromium e6d52d6c.
With Chromium commits locally applied on WPT:
e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo"
abf2ac5e "webrtc wpt: avoid race conditions"
d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property."
0882bebe "Change ICE connection state on transceiver changes"
1bbbd106 "Add feature policy for client hints, used for third-party subresources."
2229f484 "Revert "Change ICE connection state on transceiver changes""
ab94a58b "Add the remaining Client Hints to Feature Policy."
e1be827e "Reland "Use promise in wpt pointer event tests to finish the tests""
5b933889 "Reland "Adding support to bitmaprenderer in OffscreenCanvas""
22e874da "Reland "Keep scroll by keyboard after child focused node is removed""
9d90efc8 "Deflaky pointerevent_touch-action-inherit_child-auto-child-none_touch.html"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/selectors

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ie7162112c61ac4fcbc2eebdf6d92413310c17333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637530Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664945}

Before this change, selectAndScrollToMatch() was selecting the n-th total
match, including invisible matches, and if the n-th match was not visible,
the next visible match was selected. In addition, it was returning the
total index value of the  selected match, which included invisible matches.
This is particularly problematic when the first overall match was not visible.
The logic would select the next visible match and return that match's overall index.
It could not return 0 because the logic has no idea how many visible matches precede
that index. To remedy these issues, always select the n-th
visible index and return that n-th visible index value.

Bug: 965834
Change-Id: I45607c18b8532132de304d230b6a9537c37c9f6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626658
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664944}

This CL only prints out the info in a test, so we could take
a look and wire them up in a follow-up.

Part of this CL will be reverted after we get the info.

This should only affect gl_unittests and should not turn any
bots red.

I believe this is the least intrusive way to gather what we need.

BUG=967860
TEST=bots
R=sunnyps@chromium.org

Change-Id: I216151660263a575a48542a2c21d914d0f12e3a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637863Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664943}

Test is flaky.

TBR: gogerald@chromium.org, rouslan@chromium.org
Bug: 968797
Change-Id: Ifda5c81c08142428ef25cd7093ea823eb68bc639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637862Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664942}