- 31 May, 2019 40 commits
-
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=maxmorin@chromium.org Change-Id: I32710534bd1ce31feda549e8fea8b7e4156c933b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636355 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665064}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=maxmorin@chromium.org Change-Id: Ia7812103242968ac29a9055488c9d10e285d9b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635823 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e7a8ca8acb4..87cf28bc7a26 Created with: gclient setdep -r src-internal@87cf28bc7a26 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ic44d2e03ca42769e305025b15e20da79f47d10da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637220Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665062}
-
Fish Lin authored
First, make mojo support deliver storage type, this is needed for v4l2_video_encode_accelerator to read DMABUF correctly, otherwise it will use kShmem. Sencond, DMABUF contains stride, size, and file handle, add the conversion code between VideoFrameData and VideoFrame. Current implementation only support 2 planes DMABUF for NV12, if we'll support more format, may need to modify some code to support them. BUG=chromium:963812 TEST=Deliver DMABUF frame from camera and send it into video encoder through mojo interface, and it can encode correct video out. Change-Id: Ibf9614b6389e080bc0599226c4a20a410bb9666b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631160 Commit-Queue: Fish Lin <linfish@google.com> Auto-Submit: Fish Lin <linfish@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#665061}
-
Timothy Loh authored
As Plugin VM can take a few seconds to start up, we should show a spinner similar to ARC and Crostini. Subsequent launches in a session tend to be slightly faster so we only show a spinner for the first launch. A subsequent CL will make us also show a spinner if we have to wait for the VM to finish shutting down or suspending before starting it (which isn't yet implemented). Bug: 940319 Change-Id: I9ef4078e21f15e4c926a2c23860de14095679f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634294Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665060}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I04f273a42c38251e2485cfd39a7b9b468e9aeac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635070 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665059}
-
Timothy Loh authored
BUG=966391 Change-Id: I619862abcd348510ae3a90a465b8c091d97a06cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635113Reviewed-by:
-
Ken Rockot authored
WebView environments are configured to run the media service in the GPU process even though GPU runs in browser process. This means we have a valid GpuProcessHost with null process_id(). Recent refactoring of Service Manager code in content misinterpreted this to mean the GpuProcessHost was invalid and that services couldn't be launched by it. This fixes that assumption and always attempts to launch an in-GPU-process service if the GpuProcessHost is non-null. Also in such cases where the reported PID is null, this correctly uses the browser's own PID as the PID for the PID of the launched service instance. This mirrors the behavior of in-GPU-process services prior to the refactoring in r663141. Bug: 967288 Change-Id: Idc9223815f45a2e65766077fa4e695af3e6ceff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637980Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#665057}
-
Alex Newcomer authored
Keep the launcher widget alive for the duration of a user session. It is expensive to create and this will make the opening animation smoother after the first open. The view should be build using the Ctor, then call BuildView(). After the BuildView call we can just call SetupAndShow(), which will set the state of the view to be shown, and show the view. Also in this cl: - Update some stale code that was found. - Make the launcher show/hide animations interruptible (except by drag because this is likely not done on purpose). - Move all AppListView layer animations into AppListView, since the AppListPresenterImpl::ScheduleDismissAnimation() copies most of the code in AppListView::SetState(). I will move the close flow further into AppListView in a follow-up cl (crbug.com/965116). - Consolidate the animation observers of AppListView. - Move the WidgetObserver from AppListView to the presenter. This is a bit easier to understand because there will not be multiple widget observers. - Move the AppListBackgroundShieldView implementation details into the class to make the AppListView code a bit simpler. Bug:943356,911740,895688,965310,965311 TEST=automated and manual Change-Id: I87631d07e2ab54b0d83da3f127bc7181c448edc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555239Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#665056}
-
Noel Gordon authored
After CL:16311550, the piex wasm module C++ provides image photographic details derived from the RAW image EXIF. Parse the data for display to users. Store the result in the piex_loader.js {PiexLoaderResponse}. Update the piex/tests.html with the details parser: output the details data and hash to the test output. Update golden test file results. Test: piex/tests.sh PASS, speed unchanged. Bug: 965370 Change-Id: I9e36ff6bac741d0ba8793b9f4120ec27a8069c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632133 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665055}
-
Kent Tamura authored
Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ONvzLM5fPvk/FZDswIOpAwAJ Bug: 825684 Change-Id: I5b1108b72a345e2fb59596e58f7e13d6b772efe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635111Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#665054}
-
Kent Tamura authored
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/0w_Z-9_kSNs/QV6ChIapAwAJ Bug: 905922 Change-Id: Ic5bec9cab0f56e8a95684896536eabb0205d5c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636990Reviewed-by:
-
Lucas Tenório authored
With this change we add basic error reporting (to be improved with UMA later) as well as more UI configuration options. This essentially decouples the webview loading from the presentation of the flow, so we don't flicker when we make async decisions. Example: 1: WebviewHost finishes load and reports header value. 2: WebviewHost shows empty webview contents. 3: Controller processes the value and decides to exit the flow. 4: The screen flickers since steps 2 and 3 happen too fast and are racing. Introducing a presentation struct solves this issue and also helps to implement another requirement, optional buttons for flow pages. This leaves us with the Controller holding all the important state for the flow, which allows us to write pretty detailed unit tests that cover most issues. This will remove some of the burden from the browser_tests, which are already too complex. Bug: 958995 Change-Id: I5929688ee6a753f817b023937f5d56be597b9fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628035Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#665052}
-
Rob Schonberger authored
This results in impression counts and open records for packages being mis-recorded. I've tested this fix to the bug and note that impressions of >5 are indeed hidden now. Bug: 960468 Change-Id: If0047fb0b9f8eb7a888032b778f374eff136c5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638200Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#665051}
-
Alexey Baskakov authored
DumpAccessibilityTreeTest.AccessibilityIframePostEnable/win fails on bulders: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/92023 https://ci.chromium.org/p/chromium/builders/ci/win-asan/5481 TBR=kschmi@microsoft.com Bug: None Change-Id: I986c5083365d079388e8933231ad0c3745b4cbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638201 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#665050}
-
Dominic Farolino authored
This CL makes a SingleThreadTaskRunner example more explicit by using the SingleThreadTaskRunner type instead of using the SequencedTaskRunner base class. Bug: N/A Change-Id: I77fa2affacbda0f4847e4b808eab267f0977fb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636668Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#665049}
-
Leon Han authored
Putting ElidedString().Utf8().data() to a trace object leads to UAF! Because Utf8() generates a temporary CString, but its .data() (a char*) is kept/used by the trace object without awareness that the CString is already gone. BUG=968558 Change-Id: I55187f3de2954fea2419707a45d92d53f56c5344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637240 Commit-Queue: Leon Han <leon.han@intel.com> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665048}
-
Renjie authored
When a pending stream is closed, a Rst stream will be sent. And in this case, SendRstStream() would create a normal stream. This behavior is uninteded. Bug: 968621, 968406 Change-Id: I4240314a0a816a3d2409093e091341225a963da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637743Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#665047}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3f79ed1d18e..1e7a8ca8acb4 Created with: gclient setdep -r src-internal@1e7a8ca8acb4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ib3ed9fd0752393a27bb1bd1978e731cf3f28bf69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638278Reviewed-by:
-
Tsuyoshi Horo authored
When this feature is enabled, prefetched signed exchange is stored to PrefetchedSignedExchangeCache. The body of the inner response is stored as a blob and the verification process of the signed exchange is skipped for the succeeding navigation. Bug: 968427 Change-Id: Ic0132e6a5aa7d7d167d03bfdc2ee8e44a5d8ee3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636998Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665045}
-
Raymes Khoury authored
This whitelists management.installReplacementWebApp to specific extensions as restrictions to ensure apps are related aren't yet implemented on the Webstore. For tests we need to generate manifest.json files based on the URL of the related app. Hence we can't check in a static crx/extension. This means that we need to provide a private key when generating the crx to ensure that the extension ID stays the same across test runs. Bug: 968407 Change-Id: Ieceadeaf59011b7209fece3de06e89f2bea4b9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635118 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#665044}
-
Alexey Baskakov authored
This reverts commit 22e874da. Reason for revert: WebKit Linux Leak failures https://crbug.com/968811 Original change's description: > Reland "Keep scroll by keyboard after child focused node is removed" > > This CL re-lands > https://chromium-review.googlesource.com/c/chromium/src/+/1611620, > which is reverted because the test is flaky on Chrome Dev on upstream > WPT. We should land the code first, once the code reaches to Chrome > Dev, I will enable the test. > > Bug: 493078 > Change-Id: I34f23e4fb47b8d781a8459471fd69740da25792e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632795 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664838} TBR=bokan@chromium.org,lanwei@chromium.org Change-Id: Id7b327b4f1cacc38ff7b61982d9af8b3b33b90d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638198Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#665043}
-
Satoshi Niwa authored
This is required for selecting and installing Android certificate files while testing ARC++ on Chrome OS. (See b/133848333) BUG=b:133848333 TEST=net_unittests Change-Id: I8e7a45cbd2436e9a2c013dd04a55df6b6a06623c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637012 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#665042}
-
Findit authored
This reverts commit 5b933889. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 664818 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWI5MzM4ODk4YjRhNzU5YzMxOWQzN2UwNzg2ZjI1NTc1NjUwNzMwNQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/14933 Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6 Sample Flaky Test: virtual/gpu-threaded-compositing/fast/canvas/gpu-threaded-compositing/OffscreenCanvas-Bitmaprenderer-TransferControl-worker.html Original change's description: > Reland "Adding support to bitmaprenderer in OffscreenCanvas" > > Registering the factory on OffscreenCanvas in modules, adding > ImageBitmapRenderer to the union type for OffscreenCanvas. > Adding new functionality to bitmaprenderer to let it be used > in offscreencanvas. > Changing IDL and some tests to validate new functionality. > Adding a new virtual test to guarantee testing validation > of trasnsfertooffscreencanvas for bitmaprenderer. > > > Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ufFQ4OvtqxQ > > Bug: 907141 > Change-Id: I18b4af39d13289a26abee1f36564538d9f8a14c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630970 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664818} Change-Id: I85849e601b5729b8ecacf7df609094e147b412ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636908 Cr-Commit-Position: refs/heads/master@{#665041}
-
Donn Denman authored
Re-enables two disabled tests that used a swipe gesture to animate the panel, and turned flaky or failing due to some animation changes recently landed. Details in the bug. Also rename a test that had my initials on it. BUG=965706 Change-Id: I6427236492e4db9d0209355b9a03aac8cde69a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625378 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665040}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I07779066ddd480ead793ef2b1a36ffbdf81deb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638002Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#665039}
-
Matthew Denton authored
~InProcessUtilityThread calls Stop(), which calls PlatformThread::Join(). So it needs to use ScopedAllowBaseSyncPrimitivesOutsideBlockingScope instead of ThreadRestrictions::SetIOAllowed(true). Change-Id: Idf729959a1a1d77902a623806560b1cc86299e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637613Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#665038}
-
Caitlin Fischer authored
Bullet points are now used before a credit card's last four digits. Bug: 968494 Change-Id: I7cd582374b2754fcf79c3b928902da21d71a4b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637142Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#665037}
-
Antonio Gomes authored
... ref counted, instead of a raw WebAudioSourceProvider*. This is now possible after webaudiosourceprovider_impl.cc|h was Onion soup'ed [1]. [1] crrev.com/c/1629948 Reason: the original point of returning * so that no one would take refs. But if someone is taking refs code should be changed to pass scoped_reptr. BUG=787261 R=dalecurtis@chromium.org, haraken@chromium.org Change-Id: I1545e1a846ccf258e833179ae971ae713c22406f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637335 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#665036}
-
cjamcl@google.com authored
Change-Id: Ibc5f1dfcbf8ecffde51f65198cd496a8084f569b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614691 Commit-Queue: Connor Clark <cjamcl@google.com> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#665035}
-
Antonio Gomes authored
This is the last CL on Onion Soup'ing content/renderer/media_capture_from_element. The migration was straightforward. Highlights: - CreateHTMLAudioElementCapturer was moved from blink::Platform to html_media_element_capture.cc's anonymous namespace, where it is used. - content -> blink namespace - base::Bind{Once,Repeating} -> WTF::Bind{Repeating} - Removed the use of ScopedTaskEnvironment from the unit tests, since the run_blink_ has it already. BUG=787261 R=dalecurtis@chromium.org, guidou@chromium.org, haraken@chromium.org Change-Id: I187cfc0889bac56e66d92b2aab79a3a7eb25f76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631871 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Antonio Gomes authored
.. as well as its header and unit test. This is a prepration CL to Onion Soup the remaining bits in //content/renderer/media_capture_from_element/ (namely class HtmlAudioElementCapturerSource). Note that this opens room for some possible follow ups, including - the rename of the files itself, using the convension in Blink, eg web_audio_source_provider_impl.cc|h|test.cc - considering unifying webaudiosourceprovider_impl.cc|h and web_audio_source_provider.h now that they are sibling headers, or alternatively rename it to something that indicates it also implements media::SwitchableAudioRendererSink. BUG=787261 R=dalecurtis@chromium.org, guidou@chromium.org, haraken@chromium.org Change-Id: Ifd1da4e7001f39c1740e2df94d723cbca26f160d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629948Reviewed-by:
-
Junyi Xiao authored
Accessibility testing revealed the following issues within the tool: 1. color swatches is not keyboard accessible 2. link is not keyboard accessible This change adds: 1. alt text description for img 2. tab stop for links 3. test coverage Bug: 963183 Change-Id: Ibea9f935a421ab2a158fe49cf2010b90e5e503fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580199Reviewed-by:
-
John Abd-El-Malek authored
We already enforced this for browser tests. Change-Id: I9481f3949f5ddfd71f54d6627243c4b4266d292c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636458Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#665031}
-
Simon Que authored
The arm-nacl-clang toolchain is not currently uploaded to Goma RBE. Instead of adding it (NaCl is deprecated), just use ATS to pass in the compiler as an input file. Bug: 950413 Change-Id: I482f8661cf1e1f54468f40cbf6692f48d3d591ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635116Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Auto-Submit: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#665030}
-
Reilly Grant authored
When a USB device is disconnected Mojo connections to it are closed. The UsbDeviceResource object should listen for this connection failures and clear the InterfacePtr as otherwise calls are still allowed but their callbacks will never be executed. Bug: 968111 Change-Id: I9e704b8b9bf0c067167374bb9910f83d566cdb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636725Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/74053b47b03b..94246cb21c8f git log 74053b47b03b..94246cb21c8f --date=short --no-merges --format='%ad %ae %s' 2019-05-30 thestig@chromium.org Remove checks for _WIN32 in Windows-only files. 2019-05-30 thestig@chromium.org Use more defines from build/build_config.h. Created with: gclient setdep -r src/third_party/pdfium@94246cb21c8f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I8515a31e64cf5dd3c8f7b04248f67f9e79f4f3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636405Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665028}
-
Abhishek Arya authored
R=bpastene@chromium.org Bug: 968862 Change-Id: I28c04c9ba7e7d919d4bca7c07e5785ed7afc2bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638121 Commit-Queue: Abhishek Arya <inferno@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
This reverts commit 5418a092. Reason for revert: <INSERT REASONING HERE> Original change's description: > Clean up backdrop-filter layout tests and expectations > > This CL cleans up the layout tests for backdrop-filter: > - The backdrop-filter-bleeding.html test was never really complete, and > the effect it was testing for is completely covered by the existing > external/wpt/css/filter-effects/backdrop-filter-edge-pixels.html > test. > - The backdrop-filter-boundary.html test never had a valid expectation > file. It now does, and the test has been made a bit more obvious. It > already passed. > - Another CL (http://crrev.com/663338) made the > backdrop-filter-clipped.html test pass. > > Bug: 497522 > Change-Id: Ib95edda9dfb15fc451eaeb225310d422d70787df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637490 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664954} TBR=chrishtr@chromium.org,masonfreed@chromium.org Change-Id: Icc4c8d92c3ba54958b73c0c4b090ac0185335959 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 497522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638199Reviewed-by:
-
Rouslan Solomakhin authored
To be enabled on Canary via a server-side config. Waiting for approvals from launch review to enable on other channels due to impact to UX. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JwSN1yEVvnk Bug: 861704 Change-Id: Ie12abb92f52fc10ac68cc5671f7a868431902a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634932Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
-
