- 25 Apr, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f45d1f80..d011b980 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibfa3a58ddaa1ffe9b1e63500e4a459979c64e840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165911Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762645}
-
Gang Wu authored
Add support for native side that can commit the image to Android system clipboard. Before https://crrev.com/c/2071287, clipboard_android stored image data in local cache, and when clipboard_android receive a request for images, clipboard_android will return the image data from local cache. BTW, Only tests used this code path. The CL https://crrev.com/c/2071287 changed the request path, when clipboard_android receive the request for images, it will retrieve the image from Android system clipboard, and return to the request. This CL will allow clipboard_android commit the image data to Android System clipboard. Bug:1071324 Change-Id: If3c91bf6ff62371081787e48fe65e1ae440fc77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147890 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762644}
-
Daniel Cheng authored
Bug: 1059157 Tbr: reillyg@chromium.org Tbr: tguilbert@chromium.org Tbr: thestig@chromium.org Tbr: tommycli@chromium.org Change-Id: If97030e8e8b18bc2317187f6ebd15b37c82a54a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165451 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762643}
-
Nektarios Paisios authored
Assistive software cannot readily distinguish between various user or page actions when it receives an accessibility event. For example, if a text change or a selection change event is raised, the AT will not know if the text changed because the user has typed something, if a script has written something to the page, or if the user has pasted something. This will affect the way that the AT might choose to verbalize the newly added text, including choosing not to verbalize the text at all. On the Mac, VoiceOver needs to be told the cause of selection change and text change events, AKA the event intents. On Windows, the AT currently relies on monitoring the keyboard in order to identify such intents. On Chrome OS, we currently rely on heuristics. This patch creates a new class, AXEventIntent, which describes the cause of an accessibility event, e.g. "cut to the end of word". Code in Blink should use instances of ScopedAXEventIntent to place information about which intents are active on the stack. This patch modifies the accessibility event dispatch mechanism to include all active intents with each event that is sent to the browser. Relnotes: N/A R=dmazzoni@chromium.org Change-Id: I547e1c8cd980c1ec7b3a265d085317aae27c86f2 Bug: 989156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031047Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#762642}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/76b3969cd89a..6ba2c4fdcd1b git log 76b3969cd89a..6ba2c4fdcd1b --date=short --first-parent --format='%ad %ae %s' 2020-04-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@6ba2c4fdcd1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I78abfd86077e742e615361e26939abfa12ad7743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166706Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762641}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6b1aabd4d10a..6a5a91e1643a git log 6b1aabd4d10a..6a5a91e1643a --date=short --first-parent --format='%ad %ae %s' 2020-04-25 egdaniel@google.com Revert "Make compiling the amd vulkan memory allocator optional." 2020-04-24 jcgregorio@google.com Add Galaxy S20 to the tree. 2020-04-24 jvanverth@google.com Some more minor fixes for D3D tests. 2020-04-24 herb@google.com Reland "fix crbug 1073670" 2020-04-24 mtklein@google.com Revert "Add Abseil to third_party." 2020-04-24 brianosman@google.com Remove support for reading old serialized SkVertices 2020-04-24 jcgregorio@google.com Revert "fix crbug 1073670" 2020-04-24 johnstiles@google.com Add Abseil to third_party. 2020-04-24 egdaniel@google.com Rename GrSpirv* files to GrSPIRV. 2020-04-24 herb@google.com fix crbug 1073670 2020-04-24 mtklein@google.com skx matches hsw now 2020-04-24 scroggo@google.com Reland "Move SkFrontBufferedStream into Android-only dir" 2020-04-24 egdaniel@google.com Make compiling the amd vulkan memory allocator optional. 2020-04-24 mtklein@google.com stack hint 2020-04-24 fmalita@chromium.org Fix skottie2movie build Created with: gclient setdep -r src/third_party/skia@6a5a91e1643a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1073670 Tbr: jcgregorio@google.com Change-Id: I23b2951004b2bec5acb6c9bf6be654042c3e8369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166705Reviewed-by:
-
Nigel Tao authored
Bug: 1070409 Change-Id: If13342c6f2240d73c6e0a083adf5ade14c2b0fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160668Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#762639}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I01c7629eafcce600f15a80eaa48d07dc40e56b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166704Reviewed-by:
-
Bartek Nowierski authored
CheckedPtr is meant to be a pointer wrapper, that will crash on Use-After-Free (UaF) to prevent security issues. This is very much in the experimental phase. For now, landing a no-op wrapper to aid local testing. More context: https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg Bug: 1073933 Change-Id: I9fee61dda5c436880653f58feae1a5c7b0f188d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158433Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#762637}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a98e9a6ff531..40cb0b2a809e Created with: gclient setdep -r src-internal@40cb0b2a809e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588 Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I2cf3da96c4b2de506e1ce7f696575c7551ca7d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166702Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762636}
-
Kyle Horimoto authored
This CL migrates Languages UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I4f7ff55f5ef3ec17769354acd73c906f6a2925a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165666 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#762635}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8368d4a5..f45d1f80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If62255c2fabec52fe32ebb22b5f59dcf57ad9aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166564Reviewed-by:
-
rajendrant authored
When an image is cleared (src='' or img element moved) lazyload state should be reset. This allows proper lazyload handling to happen when src is set again. TBR=hiroshige@chromium.org Fixed: 10019689 Change-Id: I6f5a2500d63db4e82b3400f49592e183244b12e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164106 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#762633}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I249b2b4e895d7a8f6d94e34fad95a778f2caaaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166612Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762632}
-
Gauthier Ambard authored
This CL updates the way the navigation handler is getting the item used to determine which user agent should be used. Using GetVisibleItem() allows to take the restoration item if a restoration is occurring. Fixed: 1070593 Change-Id: If99a1ec4b8815616b81ef4f48cdf962e5c1a5dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150428 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762631}
-
Jeongwoo Park authored
Specify parameter as unsigned when calling SetSize with int. Bug: 954190 Change-Id: I5d3ecb5ac0531cb5a826b1485eaf4a17854c286e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158209Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#762630}
-
Kyle Horimoto authored
This CL migrates Privacy UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: Ie57b1999fc6c547b337ac09a45d4041a0714b3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164110 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
This reverts commit 711d17f3. Reason for revert: broke All/DumpAccessibilityTreeTest.AccessibilityButtonContentChanged/blink BUG=1073677 Original change's description: > Reland "Add Screen Reader support to color picker popup" > > The initial change was reverted due to a failure in > DumpAccessibilityTreeTest.AccessibilityButtonAltChanged/blink. The > failure is a timing issue; I can repro locally with my change reverted > if I lower the test's setTimeout value. Presumably it now needs a > longer timeout because these tests no longer suppress pixel output, > which changes the timing. So, the reland increases the timeout value. > > Original change description follows: > > Add ARIA attributes to the components of the color picker popup so that > it works with accessibility tools. There were a few nontrivial > aspects to this. > > Firstly, when using the ColorWell or HueSlider the raw positions don't > provide enough information on their own to be useful to a screen reader > user lacking any visual feedback. To make up for this, this change > includes a live region that announces the color in the currently > specified format whenever the ColorWell or HueSlider are changed or > focused. > > Secondly, Narrator has a bug where it doesn't announce aria-valuetext > for spinbuttons, which prevented FormatToggler from announcing format > changes. So, the live region is also used to announce formats whenever > the toggler is focused or changed, yielding a result very close to > a spinbutton that uses aria-text. > > There is still an issue where focus is sometimes not set properly when > the popup opens, causing ATs to continue reading content outside the > popup. The fix for that will come in a separate change. > > TBR=tkent@chromium.org,masonfreed@chromium.org,iopopesc@microsoft.com > > Bug: 1026183 > Change-Id: I1c667b773b54d1d02f376cc33387ebf3657f19b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163072 > Reviewed-by: Dan Clark <daniec@microsoft.com> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Dan Clark <daniec@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#762591} TBR=tkent@chromium.org,aleventhal@chromium.org,masonfreed@chromium.org,kbabbitt@microsoft.com,daniec@microsoft.com,iopopesc@microsoft.com Change-Id: I0c6ddf5351d1201073f61203bf9e2896bc8f19e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166473Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#762628}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59850f2c018b..a98e9a6ff531 Created with: gclient setdep -r src-internal@a98e9a6ff531 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1064181 Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: Iab50cf01062568e5aa71c53266ae8d88bd8c3e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166309Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/479812a4..8368d4a5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0793fc4500992b84eb12b6505c9a4ba944b3d940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166563Reviewed-by:
-
rbpotter authored
Not checking in languages.* or languages_browser_proxy.* as these are still used by OS settings. Bug: 1069258 Change-Id: I0db1bdffa03156e9b95fdd7a3ac71c2b26f15579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165864 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#762625}
-
Robbie McElrath authored
This CL adds BrowserContextHandle parameters to all WebsitePreferenceBridge methods, finishing the work started in crrev.com/c/2140954. Bug: 1058600 Change-Id: I68dd61dedc7174f22048216a675d47271954478f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148534 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#762624}
-
Kai Ninomiya authored
rgba8unorm swap chains are enforced to be only used with OUTPUT_ATTACHMENT. Other usages will behave incorrectly, because the internal format is actually bgra8unorm on Mac. rgba8unorm swap chains are deprecated, for now, as support is not required IIRC (only bgra8unorm and rgba16float are core). Also make the logic in SharedImageBackingFactoryIOSurface more explicit. This shouldn't change the result of the logic at all. Change-Id: I23c1f1172511fd63fdf01000b571f59b142cb275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163041 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#762623}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c41eb9ab. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 01b29d67 "[EventTiming] Implement durationThreshold" 6d36e845 "Migrate pointerevents/mouse-on-object.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm cbiesinger@chromium.org: external/wpt/css/css-flexbox dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams jsbell@chromium.org: external/wpt/resources mkwst@chromium.org: external/wpt/cookies yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0dec85415018afcaf62d5c2ca8224be2a6895c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166562Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762622}
-
Shengfa Lin authored
When modal dialog is opened, DevTools has a nested message loop to dispatch DevTools commands; however, promises are only resolved at the top message loop so if we sent a command with awaitPromise to true, chromedriver will hang waiting for response. The fix is to specify awaitPromise case by case. Bug: chromedriver:3420 Change-Id: Id9395fe0cd4f9d719a2b11617c78d9ccda7c65aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163437 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762621}
-
Kyle Horimoto authored
This CL migrates Date & Time UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: Icbe41022b94c30831fab716357e49437deaf788c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163037 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Fixed by crrev.com/c/2158976. TBR=wangxianzhu@chromium.org Bug: 1072824 Change-Id: I8f7b1fb72d1b943e851394dd85d501690d127f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166603Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762619}
-
Natalie Chouinard authored
TBR=changwan@chromium.org Bug: 1074525, 1074279 Change-Id: Ia732351318ee96ae2be7a55e0bf942f4eb4245a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166468Reviewed-by:
-
John Smith authored
This updates the color pipeline and NativeThemeMac ways of getting colors to stop relying on the NSApp level NSAppearance. Instead they use the passed in color_scheme to set a (thread) local NSAppearance value when they load system colors so they get the correct light/dark color. This value is removed at the end of the function to clean up the state. Bug: 1071671 Change-Id: Ie8bc333bd955b64594fa2b0b538895d6749853e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161318 Commit-Queue: Joan Barnett <johnsm@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#762617}
-
Kevin Marshall authored
FDIO_SPAWN_CLONE_LDSVC was renamed to FDIO_SPAWN_DEFAULT_LDSVC. The flag's value and behavior are unchanged. Bug: fuchsia:32866 Change-Id: Iad27e95fc519c14bc2b453903ea1ca2bb2748001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165882Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#762616}
-
Nate Fischer authored
This removes the WebViewWakeMetricsService switch, since this is launching to 100%. Fixed: 1003204 Test: CQ Change-Id: I779b714b41e65b40f04d1e8cb7ed9fda7fbdf785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161579 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762615}
-
Ted Meyer authored
As can be seen in the test case, the pipeline controller can get a resume event after the track change has been sent to the pipeline, but before the pipeline has responded. In that case, the resume event would just be dropped. This change causes the resume to stick around in that one specific case so that the track change can re-evaluate it's necessity afterwards. Thanks to marcel333mail@gmail.com for the testcase. Bug: 1072230 Change-Id: Ia88beb51cde085632346b1b5ba930af4d971337f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163866 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#762614}
-
Xida Chen authored
We are seeing OOM crashes from FrameSequenceTracker, and suspect that a tracker may never be terminated. This CL adds some debugging instrumentation to investigate what happens after a tracker is scheduled to terminate. Bug: 1072482 Change-Id: Id0e685e8d178688200d910ee22a8c6b0130979bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157868Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762613}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6cdd21a66ce7..dd2f620cce58 git log 6cdd21a66ce7..dd2f620cce58 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@dd2f620cce58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4495d0d05f70dd4e8e8a7f13f711078a4e351f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166307Reviewed-by:
-
Xiaocheng Hu authored
This patch adds an "intervention-mode" parameter to feature AlignFontDisplayAutoTimeoutWithLCPGoal, with two values "failure" and "swap": - "failure" is the existing behavior that moves all pending 'font-display: auto' fonts to the failure display period when reaching the LCP limit - "swap" is a new behavior the moves all those fonts to the swap display period instead This allows us to try out different intervention ideas more easily. Bug: 1065508 Change-Id: I16fcd00588e3ece5596ea5e8d5354c69210d6909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163756Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#762611}
-
Xida Chen authored
There is a small problem in this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2154498 The above CL did fix the OOM crash, but results in a small problem where in certain cases the last impl frame might get lost. Bug: 1070209 Change-Id: I58e1ad031dee9358e7bfbaeea3457076c2ec6fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163062Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5dc591fc6198..784cc7b22b21 git log 5dc591fc6198..784cc7b22b21 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 tsepez@chromium.org Cover more comparison operators in cpdf_psengine.cpp 2020-04-24 kmoon@chromium.org Fix gclient sync noise for clang-format 2020-04-24 tsepez@chromium.org Cover built-in arithmetic functions in cpdf_psengine.cpp 2020-04-24 tsepez@chromium.org Cover integer divide by zero cases in cpdf_psengine.cpp 2020-04-24 kmoon@chromium.org Enhance encode_pdf_filter.py to extract PNG IDAT Created with: gclient setdep -r src/third_party/pdfium@784cc7b22b21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:587182 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1908e1885d6c4c6f2fb71d34ec90c835796192d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166404Reviewed-by:
-
David Bienvenu authored
Bug: 813093 Change-Id: I1bdcc872d66967480a2729e7b1cb5271f4db9106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164991Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762608}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f727d4670d60..fb23afc21f05 git log f727d4670d60..fb23afc21f05 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 bpastene@chromium.org Add pywin32 to catapult's root .vpython spec. 2020-04-24 chonggu@google.com [Fuchsia] Allow specify name of the Fuchsia repo used to serve packages in tests Created with: gclient setdep -r src/third_party/catapult@fb23afc21f05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1074405 Tbr: nuskos@google.com Change-Id: I0a6f45b3ca5d3bb579e0a0e1a08162a7ae336afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166305Reviewed-by:
-
Khushal Sagar authored
R=dalecurtis@chromium.org TBR=kylechar@chromium.org Bug: 976583 Change-Id: I15e09fce18943eb986823a180be41c91d136b363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157970 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#762606}
-
