GitLab

Replace 1x SkBitmaps in shelf mojo structs with ImageSkia.
Fixes shelf item icons and icons in application menus.

Revise unit tests to support the new handle-bearing struct.
(add a test service to echo ShelfItem for struct traits)

Bug: 655874, 771311
Test: Shelf icons look good with --ash-host-window-bounds=1000x1000*2
Change-Id: I646b9c3f5cdb1aac1413a26f166e401968cec865
Reviewed-on: https://chromium-review.googlesource.com/699417Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506655}

HidService will be internal of device service,
so remove all references that outside of //device.

BUG=728223

Change-Id: I9e89c45db947f59d92c3f4a36f1317222b86b5d7
Reviewed-on: https://chromium-review.googlesource.com/700618
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506654}

1. Extract not LayoutText branch to function head.
2. Define const unsigned offsets.

This patch improves readability and is ready for introducing
 Option<int> offset type.

Bug: 739062
Change-Id: Ia1abddcda7aeaff88b8d3d834f5a1c59ec72b59d
Reviewed-on: https://chromium-review.googlesource.com/700155Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506653}

https://chromium.googlesource.com/catapult.git/+log/120c1cb3fd18..63a614b75273

$ git log 120c1cb3f..63a614b75 --date=short --no-merges --format='%ad %ae %s'
2017-10-05 shimazu Factored out EnsureCacheTemperature into each temperature

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If46bad86450040a8ffec85650ef62644552994bc
Reviewed-on: https://chromium-review.googlesource.com/701586
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506652}

TBR=peria@chromium.org
NOTRY=True

Change-Id: I67b8255871066f725f63069c0d002b11e17f49b1
Reviewed-on: https://chromium-review.googlesource.com/702179Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506651}

TBR=peria@chromium.org

Change-Id: I2df1b960d4fea915777c1aa9039d4b64844f5b9e
Reviewed-on: https://chromium-review.googlesource.com/702178Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506650}

To avoid introducing dependency on //content in //device/u2f, the client of
//device/u2f is responsible for connecting the device service and passing a
service_manager::Connector raw pointer.

After this converting, all clients of device::HidService have been converted
to use the hid mojo interface. So we move the device::HidService to be owned
by HidManager which is owned by service device.

Make sure all the u2f unittest pass after this converting.

BUG=728223

Change-Id: I141a88c6480937e344d2ad3a73bb2e92a24c323c
Reviewed-on: https://chromium-review.googlesource.com/667801
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506649}

It is possible to receive a capture-lost message while destroying a
WindowTreeHost. Make sure the code works correctly if that happens.

BUG=770670

Change-Id: Idc176e7df5c9b9516264379cd086d441b71c4460
Reviewed-on: https://chromium-review.googlesource.com/696846
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506648}

The default background of notification has vertical gray line for some reason
and the background sometimes appears during expanding animation for a short
time. This is not good look so this CL overdraws it with a blank background.

Bug: none
Change-Id: Icf046a8e66c2091b0698850391871087a01118ef
Reviewed-on: https://chromium-review.googlesource.com/618530
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506647}

Having this flag will allow VR feature work without putting the shipping
code at risk. Having it available via about:flags makes for much easier
use on Android.

Bug: None
Change-Id: I12cf3edaad80f9129fe4b00fcbf630f71b5e0b53
Reviewed-on: https://chromium-review.googlesource.com/700477
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506646}

Bug=None

Change-Id: Ie7434c1f64cf98509b7986bef00dc88f380546a4
Reviewed-on: https://chromium-review.googlesource.com/697245
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506645}

for snake_case.

Bug: 770603
Change-Id: I6a7aafad637f0d3fcecf447e9e0bf0e853c00498
Reviewed-on: https://chromium-review.googlesource.com/701954Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506644}

This change reverts 7875d555.

Currently we only defer images for async decoding if they are on a tile
that is required for activation, which effectively means images coming
into the viewport from a compositor scroll would always be sync decoded.
Since this can lead to excessive checkerboarding in some cases,
eliminate this veto.

This veto condition was initially added to avoid overhead of creating
pending trees for pre-paint/pre-decode checker-imaged tiles. Follow up
changes should still attempt to minimize this overhead.

Also note that comparing the UMA data for
CheckerboardedNeedRasterContentArea for the CheckerImaging experiment on
canary, async decoding on the active tree shows an overall decrease in
checkerboarding. For a 28-day aggregation:

1) Async decoding without activation veto
0-1 pixels/frame : 99.608% for checkerimaging group compared with
99.567% for control.

2) Async decoding with activation veto
0-1 pixels/frame : 99.19% for checkerimaging group compared with
99.176% for control.

R=vmpstr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I79aed0a7b3c4b14b50ff54c6237839c23d1ff5c1
Reviewed-on: https://chromium-review.googlesource.com/698875
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506643}

This is a follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/619252

BUG=None

Change-Id: I8ede7cbf035fec5cba4884a4078b025e54e07cd3
Reviewed-on: https://chromium-review.googlesource.com/701694
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506642}

https://skia.googlesource.com/skia.git/+log/98156c4592d9..e5ccb29e1eca

$ git log 98156c459..e5ccb29e1 --date=short --no-merges --format='%ad %ae %s'
2017-10-04 angle-deps-roller Roll skia/third_party/externals/angle2/ 10d4026b3..c1abf9178 (2 commits)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I9b7945011cd1ab8ad46ff46581c10469ed9c5e8d
Reviewed-on: https://chromium-review.googlesource.com/701931Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506641}

Adds lock screen app windows to the lock screen focus cycle for views
based lock screen. The focus cycle is as follows:
Lock screen -> lock screen apps -> system shelf -> system tray

On lock screen apps side nothing changed, though views screen locker now
implements lock_screen_apps::FocusCyclerDelegate interface, and adds itself
to lock screen apps state as the focus cycler delegate implementation).
FocusCyclerDelegate is used by state controller to accept and hand off focus
between lock screen app windows and the rest of lock screen UI (and is
already in use for Web UI lock screen).

As lock_screen_apps::FocusCyclerDelegate, ViewsScreenLocker delegates
focus handout requests between lock_screen_apps::StateController and
LockContentsView using lock_screen mojo interface.

General flow is as follows:
1.  LockContentsView is notified that system tray or lock screen apps
    have lost focus.
2.  LockContentsView determines whether it is next in line to get focus
    *   if it is, it focuses the appropriate child
    *   if not, it passes focus on - either
            *   to lock screen apps using FocusLockScreenApps
                mojo message
            *   to system tray/shelf using shell's focus cycler
3.  Once the focus is leaving lock screen apps or system shelf/tray
    they notify LockScreenContents view the focus should be handed off:
    *   lock screen apps using HandleFocusLeavingLockScreenApps mojo
        request (which gets passed on to LockContentsView using
        LoginDataDispatcher)
    *   system tray/shelf using system tray notifier

BUG=746596

Change-Id: Ic4e1edd77193ae90203358671a2dd000c9aeefa2
Reviewed-on: https://chromium-review.googlesource.com/696673
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506640}

Client InputMethodMus needs a way to know if there's candidate pop up
window which is created in different process, i.e., Chrome. We can
provide SetCandidateWindowVisible() interface in ime.mojom to allow
RemoteTextInputClient in Chrome process to send visible property of
candidate window pop up to InputMethodMus in client process.

Bug: 637416
Change-Id: I5c5785972ba90d6ec2e6ceabc9e29043ee226761
Reviewed-on: https://chromium-review.googlesource.com/680037Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thanh Pham <thanhph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506639}

Remove `overridable` parameter from ContentBrowserClient::AllowCertificateError() and its overrides.

content::SSLManager previously contained some logic for computing whether/how an
interstitial should be bypassable, which it then passed into
ContentBrowserClient::AllowCertificateError(), though only
ChromeContentBrowserClient's implementation was using it. This presented a
problem for the interstitial refactor because this logic is needed for
interstitial display, but
SSLManager/ChromeContentBrowserClient::AllowCertificateError() is no longer
going to be the point that triggers interstitial display.

crrev.com/c/679937 moved this logic into //chrome's SSLErrorHandler, which is a
more convenient place for the logic to live because both the old and new
interstitial display codepaths pass through that point. In order to simplify
reviews, that CL kept the interface of
`ContentBrowserClient::AllowCertificateError()` intact, even though the
`overridable` calculation is now done in SSLErrorHandler. This follow-up CL
modifies `AllowCertificateError` to remove the defunct `overridable` parameter.

Note that this change does not update the similar parameter in
WebClient::AllowCertificateError() on iOS.

TBR=jochen@chromium.org

Bug: 768105
Change-Id: I8214a89b6497108dea3dfe636735c865041a0673
Reviewed-on: https://chromium-review.googlesource.com/680114
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506638}

This reverts commit b2aea62a.

Reason for revert: The offending change has been reverted on https://chromium-review.googlesource.com/c/chromium/src/+/699755.

Original change's description:
> //tools/perf: Disable story on smoothness benchmark
> 
> TBR=rnephew
> 
> Bug: 771368
> Change-Id: Ic194b890084702105f00b9246b1971f9062dbf2f
> Reviewed-on: https://chromium-review.googlesource.com/699312
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: rnephew <rnephew@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506228}

TBR=rnephew@chromium.org,martiniss@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 771368
Change-Id: I3de10e67b4ab36c08d1a82ab4e8fcef226295037
Reviewed-on: https://chromium-review.googlesource.com/701316Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506637}

1 - This CL tries to fix the coordinates where the media download IPH bubble
should be shown. Currently we show it as soon as it starts playing, but
the controls moves down afterwards and we should probably set it after
it has settled.

2 - Added a y-offset to account for the viewport location offset on screen.

3 - Dismiss the in-product-help message after a orientation change.
This should be unnecessary if blink could send us the correct coordinates
after the rotate.

4 - Added a pulse highlight around the download button.

Bug: 761085
Change-Id: Id21c67f65f077ac69fd2d8c862433f1e476085d8
Reviewed-on: https://chromium-review.googlesource.com/661051
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506636}

Using wpt-import in Chromium e34fde0f.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2561

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: Ice0eeca1959fe65db3bdff88b41837345aab6e9a
Reviewed-on: https://chromium-review.googlesource.com/701697
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506635}

Bug: 768636
Change-Id: Iaa49f32a16a57c079c6aaaf4fd3ba84756aa88a7
Reviewed-on: https://chromium-review.googlesource.com/701139Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506634}

Currently, when we encounter something like:

   .a { @extends }

We would consume up the '}', expecting a semicolon. We then erroneously
consume '}' thinking that it's a ';', which would cause the next rule
to be parsed incorrectly.

This patch fixes this issue by only consuming if it is a ';'. We also
add DCHECK to ensure that we never consume a '}' to catch these errors
in the future.

I also manually tested this on the pixel 2 page which has this issue
(see bug) and it seems to work fine.

Bug: 771679
Change-Id: Idbe014f76e32af60af0c18fdcac9d68e95bcfa2c
Reviewed-on: https://chromium-review.googlesource.com/701894Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506633}

Swarming task IDs aren't comparable to BuildBot build numbers.  We'll need
something smarter in a post-BuildBot world, but this gets things working for
now.

Bug: 755401, 771438
Change-Id: Ifa13bc95c3a7527d7272fa3f35cbd385328aa945
Reviewed-on: https://chromium-review.googlesource.com/701916
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506632}

They made commits in the past, however were never added to AUTHORS. This
confuses some of our internal search queries.

Bug: None
Change-Id: I0076827d6338dca98b9b1bde1b0dda39d934c086
Reviewed-on: https://chromium-review.googlesource.com/701405Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#506631}

TBR=mmoss@chromium.org

Change-Id: I475c68ce35e7d5d46a8e9667e7add3d39d26b710
Reviewed-on: https://chromium-review.googlesource.com/701699Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506630}

The release is being pushed back from M63 to M64.

BUG=689802

Change-Id: I3528170d37d6b9725709afc61274447355d13d78
Reviewed-on: https://chromium-review.googlesource.com/700194Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506629}

https://chromium.googlesource.com/catapult.git/+log/813882679eb6..120c1cb3fd18

$ git log 813882679..120c1cb3f --date=short --no-merges --format='%ad %ae %s'
2017-10-03 dtu [pinpoint] Add trace links.
2017-10-04 joelaf atrace: Increase timeout of collect to 10 mins
2017-10-04 joelaf tracing: add preempt and irqsoff events importer

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I537ac1c3c4b303a63b1f75dd15e1c9f0881447d7
Reviewed-on: https://chromium-review.googlesource.com/702015
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506628}

Bug: 753660
Change-Id: I52b05e132bde91651fc4c8cae944fc650812d72e
Reviewed-on: https://chromium-review.googlesource.com/659481
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506627}

Bug: 771398
Change-Id: Ic35d94a75a5bb9d4ef00fc9abdb839c0e26c2c78
Reviewed-on: https://chromium-review.googlesource.com/701414Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506626}

Implemented ClearDigestTask which is responsible for cleaning the digest
field of an offline page in the metadata store.
Also had minor fix for MarkPageAccessedTask and AddPageTask.

Bug: 753595
Change-Id: I74757781d50d93faa14590892dd7eecdec8ec7b5
Reviewed-on: https://chromium-review.googlesource.com/699157
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506625}

Based on test results this test is all green on try bots [1].

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&showExpectations=true&tests=http%2Ftests%2Fdevtools%2Fsources%2Fdebugger-breakpoints%2Fdom-breakpoints.html

TBR=dgozman@chromium.org

Bug: chromium:233303
Change-Id: I817a6c24157c91814c4586f86e2874d3de380040
Reviewed-on: https://chromium-review.googlesource.com/701276Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506624}

The tests were commented out as they were failing, but they are also invalid.
https://bugs.chromium.org/p/chromium/issues/detail?id=273092#c5

BUG=273092

Change-Id: Ia33c9dbeb877b627789714c606e621e10996bf01
Reviewed-on: https://chromium-review.googlesource.com/701934Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506623}

Bug: 
Change-Id: I8b414973cb4f8e22c5e088898a8b8d1045f5c03e
Reviewed-on: https://chromium-review.googlesource.com/700977
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506622}

The validation macros for javascript generate whitespace in the
resultant file.  This change cuts out that whitespace.

This is important so that unmodified versions of these generated files
can be placed into the third_party/WebKit/LayoutTests/external/wpt/
directory which is exported to github.

BUG=509038

Change-Id: Ie09e90935324a87380376ddeaf7d527ea9f9e93b
Reviewed-on: https://chromium-review.googlesource.com/701370Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506621}

Currently ImeMenuTray is getting information about the extended input
methods (emoji, handwriting, voice) from the InputMethodManager directly
whenever the UI for this menu loads. Instead of querying 
InputMethodManager directly from ImeMenuTray, store this information in
the ImeController and update from the ImeControllerClient which is
conveniently an InputMethodManager::Observer.

Bug: 738213
Change-Id: I6bfe9281434f6ec68a5ff4f77be10829f8e787c8
Reviewed-on: https://chromium-review.googlesource.com/675084Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lan Wei <azurewei@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506620}

CompositorFrames can have opaque SkImageFilters which internally may
contain codec backed images. No cc client should be using such filters.
Assert this during filter serialization.

R=enne@chromium.org, reed@chromium.org

Bug: 768511
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I222cf4f7189e879537c19d723bf57b739aa9ad57
Reviewed-on: https://chromium-review.googlesource.com/688656
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506619}

Bug: none
Change-Id: I7e0731abe89efa49a80a7a731798005ecf6e5830
Reviewed-on: https://chromium-review.googlesource.com/639069
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506618}

The icon in the install dialog is just the icon of the extension, whose
name is included in the title. Currently, this icon simply says "image"
when VoiceOver is used to highlight the element.

We could add an alt-text of "<Extension name> icon", but this doesn't
add any additional context beyond what the title (immediately before
the image) provides. Instead, remove the icon from the VoiceOver tree
entirely.

Bug: 747624
Change-Id: Ic5373ca4a766b72696839062ffa89d8780d97e35
Reviewed-on: https://chromium-review.googlesource.com/701918Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506617}

The UI is not implemented yet on desktop.

Bug: 661629
Change-Id: Iee0b2134d02eb63325b20376c38500a38d49fb9a
Reviewed-on: https://chromium-review.googlesource.com/701474Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506616}