- 27 Nov, 2018 40 commits
-
-
Xida Chen authored
When the kCompositorTouchAction flag is enabled, and browser receives the touch start ack from the compositor, if there is no white listed touch action, then the touch start must be non-blocking, thus setting the touch action to Auto. Unit tests are modified to account for this change. Bug: 907959 Change-Id: Ife589533a959ccce1376926e14935639341f32ea Reviewed-on: https://chromium-review.googlesource.com/c/1349673Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611092}
-
David Jean authored
Also gray out "No Username" label. Bug: 905663 Change-Id: Iabbbf1ce7d20f62e72896ad08b5a239d0fbd14dc Reviewed-on: https://chromium-review.googlesource.com/c/1350616 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611091}
-
David Roger authored
SigninClient implementations should not depend on SigninErrorController. The dependency should be the other way around. This CL fixes the WebView implementation of SigninClient. NOTRY=true Change-Id: I0592028bd988036bc01a2a48d375337f077bfbd7 Bug: 836212 Reviewed-on: https://chromium-review.googlesource.com/c/1348035 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#611090}
-
Sebastien Lalancette authored
This fixes the issue where Chrome would hang if the user had a lot (tested with 5000) profiles. After debugging, the following bottlenecks were identified (listed in order of execution): - Finding matching profiles (impact small), - Deduping matching profiles to create a unique set (impact medium), - Calculating width of every rows (impact high), - Eliding strings (impact high) The approach this CL is taking to solving the issue is to limit the number of profiles that are shown to the user. This is done gradually to optimize perf while keeping the same precision. Effectively, in the worst case, we are limiting our search to: - Find the first 50 matching profiles, - Dedupe matching profiles until you have 10 unique to show. This way we are optimizing where perf cost is high, while keeping our results relevant since users will get other results not shown by default as they keep typing. Metrics considered for choosing the numbers: 50 matching profiles: - Very few users have more than 3 profiles, but recorded extreme cases go up to 53 (see UMA chart link), - Since perf cost for this part of the code is not high, we can accommodate these extreme cases. 10 suggestions: - Over 99% of our users will choose a suggestion that is within the first 10 suggestions. Fixes: 753481 Change-Id: I59a9529f9ba4cf6da56a1c1167aa6bb7562d0f81 Reviewed-on: https://chromium-review.googlesource.com/c/1343609Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#611089}
-
Henrik Boström authored
This makes the RTCPeerConnection aware, through the help of the tracker, what its call setup state is. This is confirmed by unittests. UMA metrics and trigger point for collecting this will be added in a follow-up CL. Bug: 906029 Change-Id: Ib71ec03d7560c5ee9ac65fd5427b297808e8c4fa Reviewed-on: https://chromium-review.googlesource.com/c/1349340Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611088}
-
Tim Schumann authored
Test case: TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex Bug: 908771 Change-Id: Ibf0166436b5639caaeb5583a3a6b7ab541e3cd9c Reviewed-on: https://chromium-review.googlesource.com/c/1352129Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611087}
-
Henrik Grunell authored
Change-Id: Ib142a395db29f8ed48c35b5f7c8ffc13cbce1fca Bug: 830624, 826664 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1346455 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#611086}
-
Benoît Lizé authored
Relax the restriction on parallel requests. Most of the changes are in tests: - Don't always initialize the browser in tests - Detached requests are tried before and after native is loaded. Bug: 901835 Change-Id: Iecd16e976eb3bdea44871097528ef799b9678051 Reviewed-on: https://chromium-review.googlesource.com/c/1350891Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611085}
-
Hiroki Nakagawa authored
To make browser-side loader classes for PlzSharedWorker reusable for PlzDedicatedWorker, this CL renames the classes as follows: - SharedWorkerScriptFetcher => WorkerScriptFetcher - SharedWorkerScriptLoader => WorkerScriptLoader - SharedWorkerScriptLoaderFactory => WorkerScriptLoaderFactory - SharedWorkerMainScriptLoadParams => WorkerMainScriptLoadParams This doesn't change functional behavior. See the design doc for details: https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing Bug: 906991 Change-Id: If25f463655f2f53a533a6c1504f57f05937860a1 Reviewed-on: https://chromium-review.googlesource.com/c/1350018Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#611084}
-
Marc Treib authored
The previous logic failed to handle various edge cases, such as when Sync as a whole is disabled or fails to start up. The new logic checks whether the user has chosen to sync themes, independent of the current runtime state of Sync. Bug: 907027 Change-Id: If9974c0cfd99ad66c28726e319b6f3c565073d5d Reviewed-on: https://chromium-review.googlesource.com/c/1346391 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#611083}
-
Gauthier Ambard authored
This CL uses the callbacks used when the user tab an omnibox result to switch to an open tab. It allows to record the same metrics as desktop. Bug: 906598 Change-Id: I12d848915b1a8a266d887d1eec11f71d2daef1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1341538 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611082}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/483d8219..62e154db Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. Passing a NOTRY because the mac_chromium_rel_ng and mac_optional_gpu_tests_rel bots experience an infra failure, see https://crbug.com/908729. All the others are green. NOTRY=true CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6369c6500454aec9f21c08e78b9a14b65b2a54a4 Reviewed-on: https://chromium-review.googlesource.com/c/1351463 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611081}
-
Friedrich Horschig authored
This CL adds callbacks to the AccessorySheetData java class. They are needed for the rework of the UI. Bug: 902425 Change-Id: Idaa321a21268b9b071d244633553a86a9733408c Reviewed-on: https://chromium-review.googlesource.com/c/1348331Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Instead of relying on an implementation of IdentityManager::Observer and a private flag to know when a RefreshToken is available before requesting using PrimaryAccountAccessTokenFetcher, use PAATF's mode to wait until the primary account has a refresh token available (i.e. kWaitUntilAvailable) whenever needed when TokenHandleFetcher::BackfillToken() is invoked, or simply using kImmediate if such refresh token is already available. Bug: 905689 Change-Id: Idf8e8b58a9bda518f2bd11d140b4e8776194a8f4 Reviewed-on: https://chromium-review.googlesource.com/c/1343264 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611079}
-
Tim Volodine authored
Remove passing tests from the filter. Passing tests: -ClientOnPageStartedTest.testBrowserInitiatedHangingNavigation -ClientOnPageStartedTest.testRendererInitiatedHangingNavigation passing due to: https://chromium-review.googlesource.com/c/chromium/src/+/1345029 The above tests rely on onLoadResource call, which is implemented via shouldInterceptRequest. BUG=893572,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo TBR=cduvall@chromium.org,jam@chromium.org Change-Id: I0062fd921ac0ce8f859a335674fd25b82fd07e9b Reviewed-on: https://chromium-review.googlesource.com/c/1350919Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611078}
-
Gauthier Ambard authored
This CL let the toolbar be contracted even if it is animating. This is needed, because calling twice the same method could yield different results based on the state of the device (portrait vs landscape for example). Bug: 900761 Change-Id: Ie3f44e871e411162bc63467d6cf5e7df3d02cc22 Reviewed-on: https://chromium-review.googlesource.com/c/1349347Reviewed-by:
-
Raymes Khoury authored
This histogram hasn't been used in a long time. The last collected value of these histograms was: Settings.JsonDataWriteCount.Local_State -Most values close to 0 writes -99.31st percentile: 1 write -99.9th percentile: 11 writes Settings.JsonDataWriteCount.Preferences -99.05th percentile: 0 write -99.9th percentile: 12 writes Settings.JsonDataWriteCount.Secure_Preferences -99.7th percentile: 0 writes -99.86th percentile: 2 writes Bug: 902187 Change-Id: I17cf198066fe400e29df156207222e444a8da9dc Reviewed-on: https://chromium-review.googlesource.com/c/1329708Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#611076}
-
Tim Schumann authored
This reverts commit 409ceb85. Reason for revert: Introduced flaky tests (http://crbug.com/908804) Original change's description: > GWP-ASan: Add crash handler hook. > > After a GWP-ASan exception occurs, a crash handler hook (e.g. a crashpad > UserStreamDataSource) is responsible for looking at the crash and > 1) determining if the exception was related to GWP-ASan, and 2) adding > additional debug information to the minidump if so. > > The crash handler hook determines if the exception was related to > GWP-ASan by finding the AllocatorState address (using a crash key), > reading the allocator state and seeing if the exception occurred in the > bounds of the allocator region. If it did, we extract debug information > about that allocation and report it in the minidump. > > CQ-DEPEND=CL:1339246 > > Bug: 896019 > Change-Id: I63d12b5137098b20ec946e3bddbdcabaf20e430a > Reviewed-on: https://chromium-review.googlesource.com/c/1330283 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611033} TBR=ajwong@chromium.org,bcwhite@chromium.org,mark@chromium.org,vtsyrklevich@chromium.org,vitalybuka@chromium.org Change-Id: If79e66f0852b0bb5ff6ea5d97e0197f0c5924ab8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896019 Reviewed-on: https://chromium-review.googlesource.com/c/1352173Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611075}
-
Hitoshi Yoshida authored
Make this method match in Chromium style guide. This CL has no behavior changes. Bug: 761242 Change-Id: Ie2fda83b51525812a20472cb157e855ee57a561c Reviewed-on: https://chromium-review.googlesource.com/c/1351345Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#611074}
-
Shao-Chuan Lee authored
The code assumes OnTaskCreated and OnTaskDestroyed are called in pairs for the same task_id, soft fail if it's not the case. Bug: 908308 Change-Id: I6d8bf5bdabbb601f53cf25e1d03edbc562613a84 Reviewed-on: https://chromium-review.googlesource.com/c/1351347Reviewed-by:
Maajid <maajid@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611073}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9a061a5c2b22..98cb15912130 git log 9a061a5c2b22..98cb15912130 --date=short --no-merges --format='%ad %ae %s' 2018-11-26 borenet@google.com Revert "Optimize trivial per-edge aa rect tessellation" 2018-11-26 csmartdalton@google.com Remove the arc coord matrix from GrAAFillRRectOp attribs 2018-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b4935512629..d689d1c05272 (4 commits) 2018-11-26 borenet@google.com [infra] Blacklist crashing SKP on IntelHD405 Vulkan bot 2018-11-26 kjlubick@google.com [canvaskit] Make transforms work properly 2018-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8d2cf7525167..9b4935512629 (1 commits) 2018-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 15992bef28d8..573f76b3eebf (1 commits) 2018-11-26 caryclark@skia.org minor SkFont interface edits 2018-11-26 bsalomon@google.com Fix audit trail when ops merge after chaining change. 2018-11-26 reed@google.com expose autoglyphs to fontpriv 2018-11-26 brianosman@google.com Remove gamut GM 2018-11-26 reed@google.com Revert "add SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT for google3" 2018-11-26 egdaniel@google.com Privately include our version of vulkan header file in all our src files. 2018-11-26 brianosman@google.com Use GrVertexWriter::writeQuad in ellipse ops 2018-11-26 michaelludwig@google.com Optimize trivial per-edge aa rect tessellation Created with: gclient setdep -r src/third_party/skia@98cb15912130 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ie7f4012bbf5444616161f7deefaf8028ac52292d Reviewed-on: https://chromium-review.googlesource.com/c/1351469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Eric Boren <borenet@chromium.org> Cr-Commit-Position: refs/heads/master@{#611072}
-
Justin Cohen authored
Adds a suggested Siri shortcut 'Search in Chrome'. As this is the first Siri shortcut added, also adds some of the framework for where to place the 'intentdefinition' file and localization. SearchInChromeIntent.m/.h were generated natively within a sample Xcode project. Tbr: marq No-try: true Bug: 906693 Change-Id: Ib00b82d94af64ce0b2d8397b8cbd121d2b1345b2 Reviewed-on: https://chromium-review.googlesource.com/c/1351373 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Sam McNally authored
Hosted docs need to be redirected to their URLs to open successfully. Hosted docs opened from the files app apply this transformation, but files selected via the open dialog do not. Add this special-casing for open dialog opens as well. Bug: 906902 No-try: true Change-Id: Ie64a6d25c97a3954cfa6d7e2694f29e191777257 Reviewed-on: https://chromium-review.googlesource.com/c/1343473 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#611070}
-
Giovanni Ortuño Urquidi authored
Before TrayBluetoothHelper would get notified of any changes to devices. This caused problems in busy environments because TrayBluetoothHelper would get notified hundreds or even thousands of times per second of devices changes. This CL changes to a "pull" pattern where TrayBluetootHelper queries for devices every second. The devices are then cached so that clients of TrayBluetoothHelper can access them synchronously. TrayBluetoothHelper queries for devices as long as the state is kPoweredOn. If the state changes, the device list is cleared. Bug: 882346 TEST=The following actions should be performed: 1. Turn bluetooth on and off in system tray. 2. Open device list in system menu. 3. Connect to a device. 4. See that the pod feature button in the system tray indicates a device is connected when connected to a device. Change-Id: Id9028546a627f260527aa737f51c032f74a447ec Reviewed-on: https://chromium-review.googlesource.com/c/1347638 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#611069}
-
Sam McNally authored
The old scrolling scrolled the entire footer; since the progress-center-open-view is always present, but below the fold, this allowed the progress-center-open-view to be scrolled off the top of the footer element. Avoid this by only allowing scrolling on the progress-center-open-view element. Additionally, restrict its height to 40% of the window so the directory tree can remain usable while the progress center is expanded. Slightly improve the position of notification dismiss buttons: align them to flex-start instead of flex-end and use display: none for the cancel button when hidden. Bug: 627371 No-try: true Change-Id: I2180eb8382c37c1fc03ec32b4894f449f4c7a681 Reviewed-on: https://chromium-review.googlesource.com/c/1351202 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#611068}
-
Jia authored
This cl changes when training should start. 1. Previously, training will only start after user has been inactive for a certain amount of time (the training delay), and also if there are at least certain number of training points. A training point is created when a user makes a brightness adjustment. 2. Now, training can still be delayed, but if the delay is 0, we will start training immediately after a training point is received. We no longer need to accumulate data points before training. - We run the training job and also disk-writing job (for writing trained curves) in a non-UI thread, hence it's non-blocking. Bug: 881215 Change-Id: Ifcb0714bd74d278722d1c718f57ca82dd16aed1b Reviewed-on: https://chromium-review.googlesource.com/c/1350020Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#611067}
-
Morten Stenshorne authored
Everything is first clamped to [INT_MIN, INT_MAX]. Then, if the value is negative, it will be negated to become positive. This won't work if the value is exactly INT_MIN, though, since INT_MIN (MSB set to 1; all other bits set to 0) has no positive counterpart. So handle this manually. Adding a non-exportable web test for this, since the behavior for such numbers is only defined between -9999 and 9999 [1]. [1] https://www.w3.org/TR/css-counter-styles-3/#complex-cjk Bug: 893954 Change-Id: I9f3bfad6e73623c27f2e1e427a96c45ad81d6265 Reviewed-on: https://chromium-review.googlesource.com/c/1350949Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#611066}
-
Noel Gordon authored
- update the comments to match what the actually code does - check progress center item state like other unittests do No change in test behavior. Bug: 907964 Tbr: slangley No-try: true Change-Id: I8f307b699d5005cbdefe346d838088610c9f88cf Reviewed-on: https://chromium-review.googlesource.com/c/1352072Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#611065}
-
Hirokazu Honda authored
ArcVideoEncoder has two patterns to encode: 1.) I420 buffer (OMX_COLOR_FormatYUV420Planar) 2.) several formats, including YV12, NV12, ARGB (OMX_COLOR_FormatAndroidOpaque) In the latter case, no detail about pixel format of video frame to be encoded is provided in initialization. We always configure I420 in initializing and perform pixel format conversion in ArcVideoEncoder using libyuv. One of the most common encoder use case is video capture. It is the latter case. The pixel format of video frame is dependent on platform, YV12 on mediatek devices, and NV12 on others. Furtheremore, video frame is provided as DmaBuf. If no pixel format conversion is done anywhere, we can pass video frame to VDA as DmaBuf without any mapping. Our design is we configure flexible format on Initialize() if OMX_COLOR_FormatAndroidOpaque is configured in ArcVideoEncoder. Thereafter, if the different pixel format is provided on Encode(), we convert pixel format on GpuArcVEA. We can have a chance to use Image Processor with HW Acceleration like V4L2 Image Processor. This is the first step for this task, attach format information on Encode() and split GpuArcVideoEncoder::Encode() to EncodeSharedMemory() (I420 case) and EncodeDmabuf() (Flexible format case). EncodeDmaBuf() is not implemented yet. BUG=chromium:895230, b:118544836 TEST=CtsMediaTestCases Change-Id: Ia12447b93f71fb2af579a9e27a1055b43e81cc2a Reviewed-on: https://chromium-review.googlesource.com/c/1343593 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#611064}
-
Keishi Hattori authored
Convert S* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I20c9b11fdfb83621083bda1d3434ba23679e0a5a Reviewed-on: https://chromium-review.googlesource.com/c/1351196Reviewed-by:
-
Nico Weber authored
Remove a few whitelist entries for the "Windows deterministic" and "Deterministic Linux (dbg)" bots. These are no longer nondeterministic following https://chromium-review.googlesource.com/c/chromium/src/+/1351492 Bug: 899438 Change-Id: I2f72531111fdc62c340032df610fcd256e524504 Reviewed-on: https://chromium-review.googlesource.com/c/1351721 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#611062}
-
Tobias Sargeant authored
:dev suffixed features will only be available if the device is userdebug. This makes it possible to develop support library changes in multiple steps, and then expose the feature with a final CL that removes the suffix, without running the risk that applications will inadvertently release code depending on the behaviour of an in-progress implementation of a feature. Bug: 908648 Change-Id: Iae98386992eb113356cf74be3eda125af10d867a Reviewed-on: https://chromium-review.googlesource.com/c/1349327 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611061}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/63997221d7d8..0da9494a4fe9 $ git log 63997221d..0da9494a4 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 cwallez Run mac-dawn-rel on the CQ 2018-11-21 cwallez Suppress failing tests on Metal Intel. 2018-11-21 cwallez CommandBuffer/PassEncoders: Correctly validate we can record 2018-11-21 cwallez BindGroupLayout: Fix off-by-one kMaxBindingsPerGroup validation 2018-11-21 jiawei.shao Fix missing validations and Vulkan flags on cube map texture views Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org Change-Id: Icfa9db045ccb1eac01da1ab4b84aae3cb0a97f22 Reviewed-on: https://chromium-review.googlesource.com/c/1350918Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#611060}
-
Alex Clarke authored
According to our perf test on linux this shaves off ~0.1 us/task or about 10% of our current overhead. Bug: 897751 Change-Id: I79d6cf6bacd2b62be68b7ee028bf6749bec1ff57 Reviewed-on: https://chromium-review.googlesource.com/c/1348097 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#611059}
-
Mythri Alle authored
Change the soon to be deprecated API calls to use the alternate non-deprecated versions in set_icon_natives.cc Bug: v8:8238 Change-Id: I5b2365fe09bb89dcce5a52979823faee141c5070 Reviewed-on: https://chromium-review.googlesource.com/c/1349696Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#611058}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cf927b1f0823..b4c95fe2ded4 git log cf927b1f0823..b4c95fe2ded4 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 tsepez@chromium.org Rename WideString::{UTF8,UTF16LE}_Encode() to To{UTF8,UTF16LE}(). 2018-11-27 tsepez@chromium.org Rename WideString::FromLocal() to FromDefANSI(). 2018-11-27 tsepez@chromium.org XFA: Do not use UnownedPtr between CXFA_Nodes. 2018-11-27 tsepez@chromium.org Use checked downcasts between CFXA_LayoutItem and CXFA_FFWidget. 2018-11-26 tsepez@chromium.org Break circular dependence between {Byte,Wide}String Created with: gclient setdep -r src/third_party/pdfium@b4c95fe2ded4 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:907427,chromium:907430 TBR=dsinclair@chromium.org Change-Id: I25a82288ee6ebf33c7fad0e1688c1d416bb8dbff Reviewed-on: https://chromium-review.googlesource.com/c/1351883Reviewed-by:
-
Rune Lillesveen authored
This CL implements support for specifying a default value for font-display for @font-face rules which do not provide a font-display descriptor. See spec [1]. The implementation is currently behind a flag which is off by default (not tested, not in experimental). For intent-to-implement, see [4]. There is a question if we should mix descriptors with @-rules in @font-feature-values because an unrecognized descriptor would be seen as part of the following rule as the start of a qualified ruled which means forward-compatibility could break. Also, there is a question if this is a font feature value and should be added to that @-rule at all. Both these issue are discussed/mentioned in [2]. Since using a descriptor directly in @font-feature values is not compatible with Gecko, we're wrapping the font-display descriptor in a block with no prelude for now. Note that the default font-display cannot currently apply to fonts loaded by FontFace.load() because the dictionary passed to FontFace have default values which effectively overrides any @font-feature-values descriptors[3]. [1] https://drafts.csswg.org/css-fonts-4/#font-display-font-feature-values [2] https://github.com/w3c/csswg-drafts/issues/2973 [3] https://github.com/w3c/csswg-drafts/issues/3188 [4] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/C6taiCkYayU Bug: 777846 Change-Id: I290f23e7489afeef64812d7604417268c2464455 Reviewed-on: https://chromium-review.googlesource.com/c/1222966Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#611056}
-
Kent Tamura authored
- In web_tests, we mapped the keyword "file:///tmp/LayoutTests/" to the actual web_tests directory. This CL updates the keyword to "file:///tmp/web_tests". - In image decoder tests, we mapped the keyword "LayoutTests/" to the actual web_tests directory. This CL updates the keyword to "web_tests/". Bug: 843412 Change-Id: I6f4ef498a9052a701aa2211a180d87781f45d8dc Reviewed-on: https://chromium-review.googlesource.com/c/1351195Reviewed-by:
-
Benoît Lizé authored
Parallel requests are initiated when an intent is dispatched to a CustomTabs activity. At that point, native is not guaranteed to be initialized, but the request needs the browser to be initialized, not merely the native library to be loaded. In this case, delay the call until this condition is fullfilled. To that end, add a delayed task mechanism to ChromeBrowserInitializer. Add tests to this class, and while in the neighborhood, convert Runnable to lambdas. Note that this is not exposed to clients yet, as enabling the feature still requires the browser to be initialized. This first CL introduces the mechanism and ensures that existing behavior is preserved. Bug: 901835 Change-Id: I184e1da5ae974458d19f6a88a3f26ba6c443cb57 Reviewed-on: https://chromium-review.googlesource.com/c/1349227Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
Dan Elphick authored
Since BooleanValue cannot actually throw, the Maybe version of the function is now deprecated. Bug: v8:7279, v8:8238 Change-Id: Ic7fc9ff21d4cee2fe65de19cb800e76bce3d10bf Reviewed-on: https://chromium-review.googlesource.com/c/1350916Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
