- 07 Dec, 2019 26 commits
-
-
Xianzhu Wang authored
The flag has been no use after BGPT. Change-Id: I00e71065799516bc1388ba9fe00dd4217292ea3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945949 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722721}
-
Jiawei Li authored
CastWebContents now provides a getter to access QueryableDataHost. If InitParams::provide_queryable_data_host is set false, the getter will return a nullptr (for non Cast application page). Merge-With: eureka-internal/342948 Bug: internal b/144316072 Test: CQ Change-Id: I44a2aefbed9fcdcf5481423d073ffc42a8ee358d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956252Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#722720}
-
Tomasz Wiszkowski authored
This change is needed to properly manage suggestions with no decoration icons. These suggestions will receive additional padding at the front of the view. Bug: 1021263 Change-Id: I78c3d8ef6ad95882a812d9a076c36fe9dd3d29e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955088Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#722719}
-
David Tseng authored
Change-Id: Iff73bb8018053690ec88a6152a5c0740ef462e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937131 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#722718}
-
Xianzhu Wang authored
The line "ASSERT_EQ(1u, invalidations.size());" was mistakenly removed in https://chromium-review.googlesource.com/c/chromium/src/+/1955484/3/third_party/blink/renderer/platform/graphics/paint/raster_invalidator_test.cc#b98. Change the test to use EXPECT_THAT(..., ElementsAre()) for better readability of code and failure message. TBR=pdr@chromium.org Change-Id: If818878796390e86d5b30761be27b985c2593516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955486Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#722717}
-
Natalie Chouinard authored
This is a purely mechanical rename done with Android Studio. This class is being renamed to adhere to the conventions described in go/clank-preferences-refactor. Bug: 1029146 Change-Id: Ic564eca70b2abfabab219ea7bafab9f2d9f8c7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947390 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I747d7593985639dda16b028a18978210eeb70288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955758Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722715}
-
Jack Lynch authored
This CL disables a test that will be broken by the UI.ListControl changes here [1] and fixed after that is merged here [2]. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880309 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089 Bug: 963183 Change-Id: Ie74c350af90e55961d12c819fe9f37e1eb085584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881715Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#722714}
-
Azeem Arshad authored
This CL removes unnecessary tab stops from the bluetooth-page element. Secondary details that appear in the item viz. On/Off status are already added in the button's aria description. Tab stop for policy indicators were left as such since removing this makes this detail inaccessible to some users. Bug: 1025414 Change-Id: I40cc98b3871f7cc77a9252b05e39c669ebf12358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940813 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#722713}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c166eb7c0f9a..18c6a78448dd git log c166eb7c0f9a..18c6a78448dd --date=short --first-parent --format='%ad %ae %s' 2019-12-06 bclayton@google.com SpirvShader: Use struct for MemoryVisitor callback. 2019-12-06 bclayton@google.com Regres: Update dEQP to include fence timeout fix. 2019-12-06 bclayton@google.com Vulkan: Tidy VkCommandBuffer.cpp Created with: gclient setdep -r src/third_party/swiftshader@18c6a78448dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5087ca9e05a100fef7583edf81fb99d04e90c49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722712}
-
Clark DuVall authored
This can happen if the original network loader is not used for the redirect, and the loader is recreated instead of calling FollowRedirect(). Bug: 1029944 Change-Id: I51c76a8c2ba3db6b4ed523edf60bff3dd891440d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949403 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722711}
-
Sunny Sachanandani authored
Validating command decoder hasn't been shipped since M75, but CQ bots still use it for webgl conformance tests in preference to passthrough command decoder which is only used on FYI waterfall. This CL makes the CQ bots test the shipping configuration by removing validating decoder command line flag. It also includes the following changes: 1) Explicit validating decoder variants for the conformance tests have been added and these are used on Linux and Mac GPU FYI bots where we need to test both configurations until passsthrough is shipped to those platforms and enabled by default. Windows GPU FYI bots only run the passthrough variant of conformance tests. 2) gl_tests and command buffer perf tests which used validating decoder and were only run on Windows bots are removed. gl_tests_passthrough and gl_tests_validating test suites are also removed and so is gpu_command_buffer_perf_validating_isolated_scripts. gpu_win_specific_gtests test suite is removed since it's empty now. 3) gpu_fyi_win_and_linux_telemetry_tests and release_telemetry_tests are renamed to remove "win_and_" since these are only used for linux. Bug: 1028850 Change-Id: I5e7f72effbf2103110bb2f4b75a9336cd9e91b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939845 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#722710}
-
Mandy Chen authored
Security tests are disabled in crrev.com/c/1947944. This CL fixes the tests to handle the new VisibleSecurityStateChanged event. Bug: 946860 Change-Id: I70df252e54d6fa1776136364c78f530518d01010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947420 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
-
Sorin Jianu authored
R=ganesh Bug: 1031759 Change-Id: Ie10b00e0637b9f21ba00ddf1af72f868fa2d7550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956370 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#722708}
-
Khushal authored
Replace the use of texture creation via skia with shared images in ImageBitmap. The motivation behind this change is to ensure that the resources created for ImageBitmap can be used by the compositor using a different backend and to eliminate usage of skia in client code for OOPR. This change uses CanvasResourceProvider, instead of SkSurface, to issue work executed using skia. This both replaces the resources created with shared images and allows a natural transition to OOPR, managed internally by CanvasResourceProvider, going forward. R=kbr@chromium.org Bug: 962630 Change-Id: Ibd9c9fc0358a2423b73c15c4e05e1926f6ebb640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948237 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#722707}
-
Xianzhu Wang authored
Real world PaintChunks are never empty, but previously we allowed empty PaintChunks in unit tests. Refactor tests to avoid empty PaintChunks. The main change is in PaintArtifactTest which now creates a dummy display item when the test doesn't specify any display item for a PaintChunk. Change-Id: I256151578afb5b98f656841b05ff60687a4b077e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955484Reviewed-by:
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/5debd13b6484..b7ac1042fa4b $ git log 5debd13b6..b7ac1042f --date=short --no-merges --format='%ad %ae %s' 2019-12-06 bnc Add header_list_size_limit_exceeded argument to OnHeadersDecoded(). 2019-12-06 fayang gfe-relnote: When new 0RTT key is available, only allow client to write application data as server application data should be written in forward secure. Protected by gfe2_reloadable_flag_quic_use_handshaker_delegate2 which replaces gfe2_reloadable_flag_quic_use_handshaker_delegate. 2019-12-06 wub gfe-relnote: (n/a) Rename QuicRecordTestOutput to QuicRecordTrace. Test only rename, not protected. 2019-12-06 vasilvv Use client-supplied path instead of external configuration to switch between ECHO and DISCARD mode in QuicTransportSimpleServer 2019-12-06 vasilvv Parse the path component of the indication on the server. 2019-12-05 dschinazi Drop support for QUIC T048 and T049 2019-12-05 bnc Fix gcc compilation error. 2019-12-05 nharper gfe-relnote: deprecate gfe2_reloadable_flag_quic_enable_version_50 2019-12-05 renjietang Add stream number in GetSpdyDataStream() messages for better debugging. 2019-12-05 bnc Use IsStreamError() and friends gMock matchers in quic/core/crypto. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Id82bf325818a47923ad0aa28740e500097b634fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956071 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#722705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dca1c7eb4884..9777a8561d00 Created with: gclient setdep -r src-internal@9777a8561d00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia395fb1bdc99154e02540b005c46f31c17c9aa03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954334Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722704}
-
Carlos IL authored
Checking CanGoBack when constructing an interstitial from a throttle (the way they are created with committed interstitials) resulted in false negatives in some cases. This functionality is not used in Chrome but is in Android Webview for safe browsing interstitials (they do not show the Back To Safety button if there is nothing to go back to). This CL introduces a separate method to check in that case. Test: Covered by testSafeBrowsingDontProceedNavigatesBackForMainFrame Bug: 1031620 Change-Id: I3638e173dcc226a18110153c6a33595a5cf45ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956120 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#722703}
-
rbpotter authored
- Remove setForeignSessions global function - Replace chrome.send call in history.js with starting foreign session fetch in C++ when the UI is constructed - Convert getForeignSessions to use sendWithPromise - Send sessions to JS on receiving getForeignSessions Web UI message Bug: 1022212 Change-Id: Ia4613335a4cd3d0c8090f030cc0206661f81886d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949773Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#722702}
-
Connie Wan authored
See attached bug for reasoning and future plans Bug: 1030744 Change-Id: I193d161ec55bef318d52ed27fca6fba45b2d232a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954143Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#722701}
-
Changwan Ryu authored
For pre-Q devices, Q-specific references causes ART verification failures, and this slows down the creation time. Move Q-specific references into a smaller class to minimize the time taken for ART to re-verify verification failures at the run time. Expected to reduce creation time by 7-10%. WebViewChromium Test: list_class_verification_failures.py no longer shows Bug: 1031362 Change-Id: I2a27079f22ef3f51b2a192182fba218af1ecf1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954711Reviewed-by:Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#722700}
-
Victor Hsieh authored
From UX's feedback, the changes include: - Color link to Google Blue 600 - Remove horizontal separator in Settings - Add space between policy indicator and the goggle Test: visually looks good Bug: chromium:893332 Change-Id: Ib24a44df02574301902012b6b480dc88a4b57f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956067Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#722699}
-
Caleb Rouleau authored
It is useful to keep this up to data to make it easy to figure out costs of benchmarks. Note that this is essentially a no-op from production perspective. This simply entailed running /chromium/src/tools/perf$ ./generate_perf_sharding update-timing --waterfall=all R=johnchen@chromium.org, ushesh@chromium.org Bug: 1030840 Change-Id: I041e7f6b5668a6e86c97c343de69f2c4d228482a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956108Reviewed-by:
Ushesh Desai <ushesh@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ushesh Desai <ushesh@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#722698}
-
Michael Spang authored
This #define is only present in some downstream builds and should probably not be used upstream. Use the upstream BUIDLFLAG(IS_CHROMECAST) flag instead, so that upstream tests running with is_chromecast=true take the right code path. Bug: 1030969 Change-Id: Iffb1b41e616904450f4946e23899613b811fd2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951982Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722697}
-
Caleb Raitto authored
The UKM aggregation pipeline wasn't ready for additional aggregations when https://crrev.com/c/1907147 was authored; now aggregations can be added again. Bug: 1025945 Change-Id: I634ca76bd9b3c189d2d60d4ceb41a91af2b190a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953667Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#722696}
-
- 06 Dec, 2019 14 commits
-
-
Yu Shan authored
Fix a bug where empty incoming_transfer is not checked that would cause cast_runner to panic. Test: Manual test, passing an empty message port on control port would not cause crash. Bug: b/145814982 Change-Id: Icdeee7ad3f829e8ac07a08e8b544f364d106e916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955089Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#722695}
-
Kai Ninomiya authored
This reverts commit 9e845692. Reason for revert: M80 branched @{#722274} Original change's description: > Disable use_dawn for the branch point > > Bug: chromium:985142 > Change-Id: Ifa9b692c47def3cbe1f3b030467a0bb122a2cfd9 > TBR: cwallez@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951895 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721788} TBR=kainino@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:985142, chromium:1031607 Change-Id: I4690e9cb042047c4d06db8412c0bb8729469857d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955087Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#722694}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/170f685582e1..95443cff5aef git log 170f685582e1..95443cff5aef --date=short --first-parent --format='%ad %ae %s' 2019-12-06 tsepez@chromium.org Better tests for CJS_Field properties. Created with: gclient setdep -r src/third_party/pdfium@95443cff5aef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9c616f1c30fa4c49aeb2bdaf938541f600211bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954335Reviewed-by:
-
Tommy Li authored
This CL takes out ZeroSuggest triggering on-focus for Desktop, as well as some blacklisting logic. Instead, we now trigger ZeroSuggest specifically on a select whitelist of gestures. This enables ZeroSuggest to work on repeated Ctrl+L presses now. It also likely turns off ZeroSuggest for some focus events that are triggered via Accessibility features. That's probably a good thing though, as those users should get as little "noise" as possible. TBR=thestig@chromium.org Bug: 1026948 Change-Id: Iabbaca73a5ef93ae5676a363c1e44ece61cc74d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935208 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#722692}
-
Scott Haseley authored
BlinkSchedulerDisableAntiStarvationForPriorities was enabled by default in https://crrev.com/c/1952164, which obviates the need for these virtual tests. Bug: 979017 Change-Id: Ia520fb6370c635f8e3a6809583d1c31293968542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953746Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#722691}
-
Ken MacKay authored
Bug: internal b/143135800 Change-Id: I748a92d5239b1631a5fcf96aaf811a801c9a2264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956006Reviewed-by:
-
chrome://componentsDemetrios Papadopoulos authored
Bug: 1028829 Change-Id: I4bf1a0b88de65fc9b6c084f058b1f430b03e1371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947771 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#722689}
-
David Black authored
We want to differentiate between first show attempt/result and subsequent re-show attempts/results in UMA histograms for proactive suggestions so that we can measure engagement of users the first time they are presented w/ content in comparison to re-presentations of the same content. To accomplish this we add: - Assistant.ProactiveSuggestions.FirstShowAttempt - Assistant.ProactiveSuggestions.FirstShowAttempt.<Prefix>.ByCategory - Assistant.ProactiveSuggestions.FirstShowResult - Assistant.ProactiveSuggestions.FirstShowResult.<Prefix>.ByCategory - Assistant.ProactiveSuggestions.ReshowAttempt - Assistant.ProactiveSuggestions.ReshowAttempt.<Prefix>.ByCategory - Assistant.ProactiveSuggestions.ReshowResult - Assistant.ProactiveSuggestions.ReshowResult.<Prefix>.ByCategory We mark the following pre-existing histograms as obsolete: - Assistant.ProactiveSuggestions.ShowAttempt - Assistant.ProactiveSuggestions.ShowAttempt.<Suffix> - Assistant.ProactiveSuggestions.ShowResult - Assistant.ProactiveSuggestions.ShowResult.<Suffix> Bug: b:144875278 Change-Id: I8af637b43bb485d8ed1a7356311dd25a9aabb7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951549 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#722688}
-
Gyuyoung Kim authored
This CL converts MediaDrmStorageRequest to PendingReceiver<MediaDrmStorage>. Bug: 955171 Change-Id: Ia9b255c0a0719ad9a3a5aa0fef04dbd4a9d970e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954992Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#722687}
-
Gyuyoung Kim authored
This CL converts P2PSocketManagerRequest to PendingReceiver<P2PSocketManager> as well as renames BindRequest to BindReceiver. Bug: 955171 Change-Id: I11f552f9615fad2bfa0f04e5bb69394a3126ad7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954818Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#722686}
-
Darwin Huang authored
Adds the allowWithoutSanitization property to clipboard permissions, to support raw clipboard access. This is exposed to the web as changing the permission descriptor, so that navigator.permission, and later navigator.clipboard, can expose allowWithoutSanitization. This change is web compatible, as no existing web API usage is affected. Blink: Adds the allowWithoutSanitization concept to blink-exposed classes, such as ClipboardPromise, PermissionName, and permission.mojom. This matches the direction proposed for specifications in the explainer[1]. Browser: Renames the existing CLIPBOARD_READ to CLIPBOARD_READ_WRITE, and CLIPBOARD_WRITE to CLIPBOARD_SANITIZED_WRITE. This affects browser-side classes, such as PermissionType and ContentSettings. This matches the direction proposed for Chrome's permission model. Translation: Translates between blink and browser permission models, where: (1) CLIPBOARD_READ_WRITE = clipboard-write with allowWithoutSanitization:true, and clipboard-read with any allowWithoutSanitization value. (2) CLIPBOARD_SANITIZED_WRITE = clipboard-write with allowWithoutSanitization:false. UMA: Renames histogram and enum values accordingly. This does mean new graphs will be generated to track existing forms of clipboard permissions usage. Test infrastructure: PermissionsHelper and TestRunner will have a visible change in API, to use "clipboard-read-write" and "clipboard-sanitized-write". Public-facing APIs: ChromeDriver, navigator.permission.query, and in the future navigator.clipboard.{read,write} may now be able to access the new allowWithoutSanitization property via updates to the permission descriptor. Existing API use is not affected. Here's a (slightly messy) diagram of Permissions classes and concepts relevant to this review: https://drive.google.com/file/d/1hjqE9oyCoI3cBxDDH7H1-Cl7xDqk4LJ5/view?usp=sharing These permissions were first implemented through CLs in https://crbug.com/677564 Design Doc Permission Section: https://docs.google.com/document/d/1XDOtTv8DtwTi4GaszwRFIJCOuzAEA4g9Tk0HrasQAdE/edit#heading=h.121tek4wy4sh [1]: https://github.com/WICG/raw-clipboard-access/blob/master/explainer.md Bug: 897289 Change-Id: Ia5d20a1c602aff813c07ae37634914033b6c4418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895749 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:Brian White <bcwhite@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#722685}
-
Sophie Chang authored
This is a simple check to allow us to be able to easily run a limit study to understand the effectiveness of previews. By limit study, we mean showing Previews on all page loads for a subset of the population. The limit study will still utilize the CanApplyPreview logic (e.g., hints and blacklists). Bug: 1031593 Change-Id: I4fd6aec779447615a0660f3d22167091441d4e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954710 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#722684}
-
Stephen Martinis authored
Also fixes throwing a raw Exception when led errors. This also got lost in bad rebases earlier I think. Change-Id: Icb02f538c70dd1425b4d6f8e825022813c8fecf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881813 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#722683}
-
Jinsuk Kim authored
Clicking on a link that would open a new tab should just navigate to that website when the link is clicked in a preview tab. The request for urls to be opened in a new tab goes through WebContentsDelegate |shouldCreateWebContents| -> |webContentsCreated| -> |addNewContents|. This CL handles it by having |shouldCreateWebContents| return false so that no new WebContents object is created. The passed URL is loaded into the preview tab instead. Bug: 1014777 Change-Id: If4fd76f563427aaae230af4e0519c2c388791fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954990Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#722682}
-
