- 10 Oct, 2019 40 commits
-
-
yilkal authored
Bug: 850328 Change-Id: I7bc5fcd828f7f47230c4c967a28fb24525fd59b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838382 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704462}
-
Alex Cooper authored
A page may not be submitting frames because blink isn't allowing it to submit frames based on various states. In these cases, the browser should not be showing UI indicating that the page is unresponsive. This change adds plumbing for blink to inform the browser process that it is the one throttling frame requests so that the browser can suspend any timeout logic, and potentially (in the future) take over rendering a more customized message. Bug: 1009813 Change-Id: I2d1a3bb609eb305225493b67c630b32999735a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841585Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#704461}
-
Giovanni Ortuño Urquidi authored
Replaces usage of DataPipe, which is deprecated, with CreateDataPipe. There is no change in behavior, if the pipe fails to be created we will crash. Bug: 1012150 Change-Id: Ib077284f14c7232a0a78afcf0d1d3e1cc4f07380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846621Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#704460}
-
nancy authored
BUG=1005640 Change-Id: I441c389203be3c7eb1f06ddbdce09d3441677958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830483 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704459}
-
Aidan Beggs authored
heuristic. This CL adds a set of the top 500 keywords to the binary at compile time, to enable usage of this information in the phishing detection keywords heuristic. Additionally, this CL cleans up and refactors the compile-time processing and embedding of information related to the top 500 keywords, into the binary. Bug: 1012476 Change-Id: I9d75d962d0425b0f037c87a5d6801c7c9299c476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849183 Commit-Queue: Aidan Beggs <beggs@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#704458}
-
Alexander Timin authored
NativeFileSystem uses RenderFrameHost::IsCurrent which is problematic for bfcache, as it means that for some frames the permissions might be requested while the frame is in back-forward cache (IsCurrent is true for iframes) and for some the requests will be denied and will not be resumed after restoring from back-forward cache. Disable back-forward cache as soon as we make a request for now. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 R=mek@chromium.org CC=bfcache-bugs@chromium.org BUG=1001087 Change-Id: I6a1f0153df4c13fbaba900af049e0c852d340513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837813Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704457}
-
John Emau authored
This change adds basic tests that capture current behavior around the Audio Context Selector. It is meant as a start and not a complete list of tests, more tests should be added in the future. This also indirectly tests the UI.ListModel, UI.SoftDropDown, and UI.ToolbarItem. Change-Id: I7506c06e6cf8b865ab2645c9e9e4004df162e629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824060Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704456}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I467c6ee86c44e581a6fee3cdcb8a5fdf6ed29aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847599Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704455}
-
Kenichi Ishibashi authored
Bug: 692909 Change-Id: If4c656288728f6c52440fc4b2e834e3e2b6e8c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846611Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704454}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5ee5b8853db6..992c5b481bab git log 5ee5b8853db6..992c5b481bab --date=short --no-merges --format='%ad %ae %s' 2019-10-09 engeg@google.com buildbucket_api: Add retry to GetBuild and extend sleep duration Created with: gclient setdep -r src/third_party/chromite@992c5b481bab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ifbc28622327883953b1353a19241e44bcb2626c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704453}
-
Sanket Joshi authored
Bug: 1012387 Change-Id: I9627134583db5f0b0c8390ccf4792b5287a5a0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847869Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704452}
-
Anand K. Mistry authored
When the dropdown is opened, the entire element should appear as a single element, with no space between the input field and the opened dropdown. http://go/siygs BUG=977313 Change-Id: I81912cb7f6101a8fc8a54f60a4095e42a210ca8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847703 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704451}
-
Yulun Wu authored
This reverts changes from: CL:1808426 which caused the ripple circle around the page switcher button to get cut off. Bug: 1011518 Change-Id: I5da49ce4122cdb5dbf083eda6a8f23ec371f5946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846012Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704450}
-
Avery Musbach authored
Change-Id: Ie673d63862039d35a1c769db62c5d59562d4fde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850725 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#704449}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ebc6287a..8374dec2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide31ca94326b5f09a84e8946cc70248dd1596643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850174Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704448}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb1eb4896663..71681bf1e84a git log cb1eb4896663..71681bf1e84a --date=short --no-merges --format='%ad %ae %s' 2019-10-09 ehmaldonado@chromium.org git-common: Explicitly specify utf-8 when encoding. 2019-10-09 tandrii@google.com git cl: record additional tag for builds triggered via retry-failed. Created with: gclient setdep -r src/third_party/depot_tools@71681bf1e84a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1012773,chromium:445502 Change-Id: Idb99126e85be36c35ccd468ea5a0824a049baebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704447}
-
John Budorick authored
results in a screen width of 480dp, which should put it in the middle of large portrait phones per https://bit.ly/311hcJ1 Bug: 922145 Change-Id: I7bb00196dfa48a53467dc35646b81160f9fd8892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849429 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704446}
-
Sophie Chang authored
Bug: 1001194 Change-Id: I91e678bf04c15864618ec69fa1e2fa20c6c43af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848153 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#704445}
-
Meilin Wang authored
This change extends the expiration date of AssistantExitPoint UMA histogram for another one year, as this UMA will still be actively in use for collecting data. Bug: None. Test: manually. Change-Id: Ic963434386363c12b9f65e6c666954e72f4847c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848939Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704444}
-
Nate Fischer authored
No change to logic. This cleans up a temporary adapter version of AwSafeBrowsingConfigHelper, as it is no longer needed by downstream code. Bug: 934597 Test: ninja -C out/Default system_webview_google_apk Change-Id: Iac5de65423e1444b14b5c2e249c24764d97f40d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845884 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704443}
-
David Tseng authored
This change breaks up incremental change utterances spoken by ChromeVox. For example: - Search+/ - type 'chromi' - speak 'Chromi, ', ' um, an open source project' - type 'u' - speak 'Chromiu, ' 'm, an open source project'. - Change-Id: Ic34cfac814d8d376a041ae21c0cee44f75c9906e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832529 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#704442}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1007760 Change-Id: I915acf6516bd67d6c244dfb2fd6688df7717ace6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849534 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704441}
-
yilkal authored
Bug: 850328 Change-Id: Iae5af42094a9ac0943b7a50f270abaae11b23f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838521 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#704440}
-
Miyoung Shin authored
This CL converts IsolatedXRGamepadProvider{Ptr, Request} in device to the new Mojo type, and use pending_receiver<IsolatedXRGamepadProvider> in isolated_xr_service.mojom. Bug: 955171 Change-Id: Ib42d1a7f36c748849bbab5f058fbe7f2c0d129e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847531Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#704439}
-
Julie Jeongeun Kim authored
This CL converts ColorPanel and ColorPanelHost to new Mojo types using PendingReceiver, Receiver, PendingRemote, Remote and SelfOwnedReceiver. Bug: 955171 Change-Id: Ie147c1bde436e427ca086a21a5ba7dd16e33b26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847491Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704438}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0947ef87. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7e34273895ad7b98d12412bce287f65a233f5b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849952Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704437}
-
Ken Rockot authored
All clients can now make direct calls into LevelDBDatabaseImpl. This deletes the LevelDBDatabase mojom interface definition as well as the OpenOptions struct, its corresponding type traits and tests, and the leveldb_service_unittests test suite which was only used to test the latter code. Bug: 1000959 Change-Id: Ibb542604885e16abbf135e9af6ba9b3777aae026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838293 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#704436}
-
Darren Shen authored
In a previous CL [1], we fixed a bug with autocapitalize="off". However, we forgot to handle autocapitalize="sentence", because in the old code, "sentence" was automatically handled as a default case, but we changed the default behaviour to "none", so sentence was treated as none. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1762254 Bug: 995703 Change-Id: Id1e634386676c62270d00f365004bebbc170538a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850673Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#704435}
-
Lijin Shen authored
This CL defaults enabling tab switcher longpress menu feature. Bug: 1012914 Change-Id: I39cb104bdfb8017fa4e57abce87fbdb18b2a32e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850798Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#704434}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce36989ab9e3..9514a2a7642d Created with: gclient setdep -r src-internal@9514a2a7642d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I85b412c6200b598fc0d313007b31ee93c566d896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850776Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704433}
-
David Benjamin authored
The logic was picking up the default argument in the GroupId constructor and, as a result, when double-keyed socket pools were enabled, client certs didn't quite behave right. It was possible to get double-prompted as a consequence of preconnects. Bug: 1011190 Change-Id: If8a3ffebbc0246b3d3dcf35bc90c08c53ba12120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849985 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#704432}
-
yilkal authored
This cl updates IsMainFrameWhitelisted to include domains which the parents have manually whitelisted. This can happen when a child asks for permission and the parent manually approves it. Bug: 850328 Change-Id: I056ccf9f5bc1385013eb0f41cf0014c2c859a45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837409 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704431}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7951a0da32d5..0a9ec07ff393 git log 7951a0da32d5..0a9ec07ff393 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-09 jvanverth@google.com Draw perspective text as paths. Created with: gclient setdep -r src/third_party/skia@0a9ec07ff393 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Id0511ad6649ec7ce3fbe4d672f283399fcfd67dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704430}
-
Jack Lynch authored
This CL adds an axe accessibility test for the call stack pane. It was previously reviewed in [1] but was split out because the CL was unwieldy and it isn't dependent on those changes. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/ Bug: 963183 Change-Id: I247a5e6dfc6a5331c67944e6b95a34f7b06b2e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716213 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#704429}
-
Jinsuk Kim authored
Moves |createHistoricalTab| to TabState as a static helper method. TabState already provides a method creating a historical Tab from WebContentsState, so could be a good fit for hosting another creating Tab from WebContents. Bug: 995903 Change-Id: Ied744eb3292a9b0793f0baf93abdaf84ac8aac0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846613Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#704428}
-
Ahmed Mehfooz authored
Temporarily disabling color for all notification types. This will be enabled once ARC notifications provide accent color in Chrome OS. Bug: 1002714 Change-Id: I2fb6b6f33ee27dd2d2ecd865f7b5a6c360d00c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838166Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704427}
-
Bence Béky authored
Change-Id: I048554ee726f17b5a0b14d487728f0ad90085ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835159 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#704426}
-
cjamcl@google.com authored
Related: https://github.com/GoogleChrome/lighthouse/pull/9783 Bug: 1011228 Change-Id: I8c232c8f440df72d3780dc66a03166cddc9f5287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838310 Commit-Queue: Connor Clark <cjamcl@google.com> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#704425}
-
Piotr Pawliczek authored
Since the CL:1838051, each BulkPrintersCalculator is created by the first object that asks for it. BulkPrinterCalculator for User Policy is deleted in NativePrintersExternalDataHandler or in the first called destructor of corresponding EnterprisePrintersProvider or CalculatorsPoliciesBinder objects. BulkPrinterCalculator for Device Policy is deleted in DeviceNativePrintersExternalDataHandler. All instances of BulkPrintersCalculator are accesses in the UI thread and by using WeakPtr. BUG=chromium:1009062 TEST=on nautilus Change-Id: I09d4b9b4deea4f0cc06847abbd18f4800a7c5e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836660Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#704424}
-
Findit authored
This reverts commit 9b161472. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 704421 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzliMTYxNDcyODQ4ZGE1YmE1ZDI0MGExZDE1YWIyYmUwNjFlNGQ3NDcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-archive-rel/5897 Sample Failed Step: compile Original change's description: > Remove change_password_handler code. > > The change password card in the settings is not triggered > from password protection so it should be removed completely. > This is part 2 of the removal of the change password handler. > First part was crrev.com/c/1834950. > > Bug: 991764 > Change-Id: I2d877366f67bb7e30763b232211df62458554084 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834906 > Commit-Queue: Bettina Dea <bdea@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704421} Change-Id: I43b87004899419781cb8021b7f2946158c679411 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 991764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851233 Cr-Commit-Position: refs/heads/master@{#704423}
-