- 23 Apr, 2020 40 commits
-
-
Jeremy Roman authored
This reduces noise due to this warning, which can happen on the order of 10 times at browser launch and more times thereafter. Change-Id: Iecdb28d995eb5867a506f84112ef8fcf8794dbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160037Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762047}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/f738fbde1726..b4810d5b775c $ git log f738fbde1..b4810d5b7 --date=short --no-merges --format='%ad %ae %s' 2020-04-23 wub Add QuicHash(Map|Set) as a general-purpose hash map and set, which doesn't gurantee pointer stability. And switch to QuicHashSet in various places. 2020-04-22 dschinazi Introduce TlsChloExtractor 2020-04-22 renjietang Make transport_params in SessionCache a const reference, because it should always be present. 2020-04-22 dschinazi Make ALPN an array in QuicBufferedPacketStore Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I57fd95bcc3a33ced3ac829336326d0f34b315302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163365Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#762046}
-
Mason Freed authored
This case was not previously tested. Bug: 1042130 Change-Id: I5874bc08abba57b6d5150ab8ae772ecec6113b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161767 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#762045}
-
James Cook authored
Add a new ShelfItemType for TYPE_LACROS_BROWSER, following the pattern of TYPE_BROWSER_SHORTCUT. Wire it to its own ShelfItemDelegate in //chrome/browser/ui/ash. For now, the icon does nothing when clicked. We need to wire it to upstart to actually start the browser. Bug: 1072472 Test: manually deploy to device, two browser icons appear Change-Id: I12578745f627df4452fcd99fe41716eedfb834d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155991 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762044}
-
spdonghao authored
Bug: 1071503 Change-Id: Idf2067f16cbdb4970965ddea980b5679621613cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149514Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#762043}
-
Xing Liu authored
Removes unused code for image cache, we use components/image_fetcher now. Bug: 1058534 Change-Id: I2f33cd418249d1770dd44f8cbb381f9c718f8553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162108 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762042}
-
Tarun Bansal authored
Remove data reduction proxy features that are no longer in use. Change-Id: I1856baf0cb4239a84d30bd7bdfb2268beb0364b8 Bug: 1073611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161584Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#762041}
-
Gabriel Charette authored
Leaving it there resulted in it being picked up on urelated stacks. R=ajwong@chromium.org Bug: 1073500 Change-Id: If8816da156e89122d3c599e1f355e9d6703940b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161465 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#762040}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7fc367463824..bb3010037266 git log 7fc367463824..bb3010037266 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 eseckler@google.com Merge "processor: Migrate more TrackEvent arguments to reflection-based parsing" 2020-04-23 eseckler@google.com Merge "processor: Fix 3 clusterfuzz-found issues related to TrackEvent parsing" 2020-04-23 ilkos@google.com Merge "Add ion_stat to config muxer for memory" Created with: gclient setdep -r src/third_party/perfetto@bb3010037266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifc2d084df5f5266d42faa3edb943a4f134cd8e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163448Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762039}
-
Yi Xu authored
fix canvas-getImageData-large-crash.html always passes: it passes regardless if any exception is thrown. Remove test. Bug: 1073721 Change-Id: I5abde013194b45e3804ac2c215c5b2c79614c29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160346Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#762038}
-
Sergey Kipet authored
Building the Chrome browser configured to engage the Ozone/Wayland as its backend by using the gcc compiler collection is failed due to the 'declaration changes meaning' compile-time error. This CL fixes the error and gets the sources compiled by both modern compilers - clang and gcc. Bug: 1073877 Change-Id: Ib6e480e9b3d1b9dfc3640909b2b3dd1c78cdb7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162865Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#762037}
-
Andrew Grieve authored
Rather than generating a different ${Foo}Jni class for every target when use_hashed_jni_names=true, also have classes use org.chromium.base.natives.GEN_JNI. Then, at the final step, have GEN_JNI forward calls to J.N.$HASH. Makes a bit more work for R8 (it needs to inline all the GEN_JNI methods), but move the "hashed functions" logic to live in one spot at the end of the pipeline. A byproduct of this is that toggling use_hashed_jni_names no long requires all libraries to be recompiled (attached bug) Bug: 1073921 Change-Id: I8df7c751b51d60e878f270c06e2e979dd9dbc821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162109Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#762036}
-
Mugdha Lakhani authored
Before this change, the browser process would crash if the SecurityStateClient wasn't set early in the startup path. This change makes having a SecurityStateClient optional for the embedder and defaults to the components logic to get security level. Bug: 1052375 Change-Id: I7336e375908137aed3187debddd3860b7d657e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162985 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#762035}
-
Naomi Musgrave authored
Clean up crypto import, since uses of crypto::ECPrivateKey were removed in change I153949d11b923131b404ee603a6d885aec57706d Bug: 1012226 Change-Id: Ic698f872e6441894e4330fb784609aba72d25ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161827 Auto-Submit: Naomi Musgrave <nmusgrave@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#762034}
-
Kevin Marshall authored
Implements the UrlRequestAction FIDL API, which allows embedders to specify requests to block based on the the requests' host and/or scheme. * Fix issue where wildcards passed in "hosts_filter" are URL-escaped. * Add "page_type" edge transition detection to TestNavigationListener. * Report early navigation errors in NavigationControllerImpl. Bug: 1054475 Change-Id: If4df4889f980c5a239719d09f039eee32efd1c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070103Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#762033}
-
Kyle Horimoto authored
This CL ignores settings changes which are <200ms from each other, which fixes false positives logged with the metric. Bug: 1073714 Change-Id: I07f81a6243ccad85cd92b34e4b639ba2b6b87442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162126Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#762032}
-
Trent Begin authored
Move a brace so that telemetry logic is properly parsed. Previously multiple telemetry items were only parsed it the battery information is present. Bug: none Change-Id: I0cea4e12c9a8c504bde11917aefd4d0548b77800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153694 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#762031}
-
Kai Ninomiya authored
This changes the default filtering from nearest to bilinear, to match other canvases. The filter quality gets passed through from CSS's image-rendering. Bug: 852089 Change-Id: I704c91940bd495a55a1afe29600dff9cec448b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161869Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#762030}
-
Rob Buis authored
Use LayoutObjectFactory for MathML layout object creation where possible. Bug: 1070600 Change-Id: I1f02ca9ab4018798559ad3334fd4b316f31330d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162927 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#762029}
-
Wan-Teh Chang authored
Remove the pending_decoded_image_ member of AVIFImageDecoder. It is apparently intended to avoid calling avifDecoderNthImage() with index 0 twice. But libavif allows us to do that, and the second call will return immediately. Move the SetSize() call and size check out of DecodeImage() to the two call sites. Bug: 960620 Change-Id: I4c7beaed4ca5aa8040aa7b3cb2facd92e18eb38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161871Reviewed-by:
Leon Scroggins <scroggo@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#762028}
-
Garrett Beaty authored
This reverts commit 8af6bfe2. Reason for revert: The branched versions have not been updated to run the non-isolated tests on the builder instead of the tester. Original change's description: > Use linux hosts for all mac triggered testers > > We've already shown this to work on Mac10.15 Tests on the FYI > waterfall, so let's do this for the rest of the Mac triggered > testers on the main waterfall as well. This will allow us to > free up some Mac resources to do more important tasks (e.g. > compile, run tests). It also makes these builders builderless, > increasing our flexibility and improving our utilization. > > This CL also introduces a new ci.triggered_tester starlark > function to enable easily specifying builders as "we don't care > what OS you use", and to enable easily turning all of them into > "thin testers" if/when we go down that path. > > Bug: 1061582 > Change-Id: Iffd5a4afbadeabc19d9d0e3b28f33151a9474191 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161689 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Aaron Gable <agable@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761718} TBR=ellyjones@chromium.org,agable@chromium.org,gbeaty@chromium.org Change-Id: I786079f17db5e32643b11bb43775b7e52a44e4cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163254Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#762027}
-
Fredrik Söderqvist authored
Per: "If decoding does not need to be performed for this image (for example because it is a vector graphic), resolve promise with undefined." (https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode) we can skip the decode request and just resolve the promise up front. Since the SVG format is context sensitive (and, well, scalable), decoding them outside of that context will likely just waste resources. Fixed: 1073361 Change-Id: Iedf3a6636d9525e243ce9a8cf9c3835a1468b34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160915 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#762026}
-
danakj authored
v8::Persistent will leak on destruction by default, unless marked as copyable. As such, we must call Reset() before destroying any v8::Persistent with the default, non-copyable, traits. Then we can remove the JS cleanup code added to the spellcheck tests. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I3da663bda02c8916c1a4ae5d21234c54311a1dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161652 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#762025}
-
Nnamdi Theodore Johnson-Kanu authored
This CL is in preparation for enabling Polymer3 in ChromeOS settings pages. It fixed issues in os_printing_page/ folder that break semi-automatic Polymer3 migration. These changes include splitting up files that contain multiple <dom-module> elements, as this is required by Polymer3 conversion tools. Bug: 1045266 Change-Id: Idf9b18aac87b74d34a431ffe5383fd2f845554fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151090Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#762024}
-
Hongchan Choi authored
This is for the detailed audio stack tracing. There have been several audio performance issues reported from the applications that use Web Audio and MediaSteam together. We need more information on why the audio rendering thread or AudioWorkletThread is blocked. Bug: 1072727 Change-Id: I56d33d6bf471938815c7aba3f8b94ad461f9c3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145557 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#762023}
-
Lijin Shen authored
Encourage to use org.chromium.ui.widget.TextViewWithLeading instead of android:lineSpacingExtra or android:lineSpacingMultiplier. Bug: 1069805 Change-Id: I3eea084ac83034d99c27ecdb7b1c69c0877ff800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163427Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#762022}
-
Alex Turner authored
Currently, AdTagging uses the presence of ad scripts on the v8 stack and the execution context at the time of the fetch as a signal for tagging. However, CSS stylesheets often defer their resource requests until needed. E.g., the fonts defined by the stylesheet may not be requested until a style recalculation occurs. This results in erroneous tagging, as the stack contains the script which caused the style recalculation rather than the one that added the stylesheet. To fix this, we tag stylesheet-requested resources with an is_ad_related bit. This is set through the CSSParserContext according to the stylesheet's ResourceRequest. Finally, a was_requested_by_stylesheet bit is set on these resources, which allows the ad tracker to ignore the v8 stack at request time. Note that, despite constructing a CSSParserContext, the WebVTT parser can be ignored as its CSS is prevented from making network requests. Bug: 1051605 Change-Id: I131586f8c58c4ae0073b1cedae22fa1f92ed408a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050887 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#762021}
-
Haiyang Pan authored
Make them the same as the ones run on the to-be-retired android-kitkat-arm-rel Bug: 1032336 Change-Id: I7916451b2a0bb2fb25cdba8147493326292de507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161660Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#762020}
-
Raymond Toy authored
The DCHECK was checking that the arrays have positive lengths, but the spec allows zero-length arrays too. So change the spec to check for non-negative values. And also modify getFrequencyResponse to return quickly if the length is 0. This applies to both BiquadFilterNodes and IIRFilterNodes. Bug: 1073557 Change-Id: I8c98cf01021c9ece5731ccf8fdbc1fe8fe97f39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163054Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#762019}
-
Alexander Timin authored
Instead of passing WebContentsGetter to ContentBrowserClient, add explicit callbacks to WebContentsObserver taking RenderFrameHost* or NavigationHandle* as a parameter. This allows to attribute cookie/javascript accesses to the correct frame or navigation request, which is a prerequisite for attributing content settings to the correct document and making them per-document. R=falken@chromium.org,engedy@chromium.org BUG=998171,1061899 Change-Id: Iec55a1db235b26bab44f1c1de76900b73ac6614d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151866 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#762018}
-
Avery Musbach authored
The present CL fixes a bug where if you rip an item off the shelf on one display, it shows at the right or bottom of the shelf on other displays. Test: manual Change-Id: I75813306ec0a11f3ac4ec39ed08ad736e5788fa0 Fixed: 1014721 Bug: 1014721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161900 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762017}
-
Omid Tourzan authored
The drive long welcome banner is removed and the new GM2 looks applied to drive welcome banner and drive and download warning banners. Also Dismiss buttons changed from X to text buttons. Modified cr-button is used for text buttons. cr-button provides most of the text button styles, specially ripple (inkdrop) effect. The changed css classes duplicated for existing UI and files-ng with body:not(.files-ng) and body.files-ng prefixes respectively. The icon/logo changed to svg version. rtl/ltr direction tested. It's supported in this CL by using flex system and inline start/ends rules while the non-filesng uses dir attribute and absolution positioning. It helps to reduce the complexity by using one set of rules for both directions. For files-ng clean up: - js: can be caught where isFilesNG() method used - css: body:not(.files-ng) - Other: ToDos added in string resource files Bug: 1002400 Change-Id: Icc04ff6193d164e677d6d39294152ec440c73e48 Patchset 10: - Fix class of welcome banner in non-filesng mode. - Update outline rule to comply percentage convention. Change-Id: Icc04ff6193d164e677d6d39294152ec440c73e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148917 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#762016}
-
Ramin Halavati authored
Profile Manager and its tests are updated to match the new profile APIs for multiple OTR profile support. Bug: 1033903 Change-Id: I01c5c6389c75e9288deb1b03c5a18aa7307bf270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144131Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#762015}
-
Sinan Sahin authored
When we're hiding the status indicator, we make the Java view GONE and start animating the cc layer. However, at this point, the cc layer can have an old texture (or a texture that makes no sense). With this CL, we invalidate the cc texture when the Java animation ends and request a render from the LayoutUpdateHost. Please note that this CL doesn't completely fix the issue. However, it makes it much less common. Bug: 1068346 Change-Id: I8e889fec82d5f33c9f5ba30695715a6d6fa67171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144629 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#762014}
-
Joshua Bell authored
There are no matching test files for these - deleted or renamed. Change-Id: I18046adcb151ca7846e7511c39f5721b31218b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161418 Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#762013}
-
edchin authored
This is a simple string change required by legal. TBR=sczs@chromium.org Change-Id: Ia2406a23ca6125d36a4f3675a6d001306c1f9d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161786Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762012}
-
Xiqi Ruan authored
If Family Link is not installed, open Play store instead. Bug: 1056458 Change-Id: I31e3356fbe9efba93fd75e9f786d9b84ecc87655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135383 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#762011}
-
Xiqi Ruan authored
Set notification with system priority when create system notification. Bug: 903545 Change-Id: Ie1b92f2361f7d5564102d1719b95c41753def556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161771Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762010}
-
Tibor Goldschwendt authored
Invokes the NTPUserDataLogger machinery to log the following histograms when loading the WebUI NTP: - NewTabPage.LoadTime - NewTabPage.LoadTime.MostLikely - NewTabPage.LoadTime.MostVisited - NewTabPage.LoadTime.NewTab - NewTabPage.LoadTime.Startup Additionally, adds logging for the new histogram NewTabPage.LoadTime.WebUINTP, which only gets logged when loading the WebUI NTP while the histograms mentioned above get logged when loading any NTP. The local NTP is considered loaded as soon as the most visited tiles have been displayed. We follow the same logic on the WebUI NTP to make the load times comparable. Thus, the logging gets triggered as soon as the most visited tiles have been stamped out. Fixed: 1072865 Change-Id: I2f908a23dffc911b4338c0611c017bbbc38d0ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159954Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#762009}
-
Garrett Beaty authored
Using MAC_ANY caused it to pick up Mac 10.15 machines, which don't support the GN args currently used by mac-rel. Which causes them to fail quickly and then get re-used frequently. Until we determine the solution going forward, changing the os dimension will get the builds back to green. # mac-rel is broken, this change will fix it Bug: 1073694, 1073965 Change-Id: I2620c570c443be89f27ace27cbbd9c3c25cd4010 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163151 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#762008}
-