- 30 May, 2018 40 commits
-
-
Reid Kleckner authored
ASan and CFG leads to slow process startup. Chromium's test runner uses lots of child processes, so this means things are really slow. Disable CFG for now. This should help keep the ASan bots from timing out. BUG=846966 R=brucedawson@chromium.org Change-Id: Id2d66e97badc67dc29af557ff6bdbbd9cfd3c0b5 Reviewed-on: https://chromium-review.googlesource.com/1074337Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#563059}
-
Sergey Ulanov authored
Previously ServerAliveInterval and ServerAliveCountMax were both set to 1 in SSH config used to connect to Fuchsia from the runner script. This means that SSH diconnects after it fails to deliver 1 keep-alive message within 1 second. This interval is too short, which was causing timeouts and spurious test failures in net_unittests. Increase these values to 2 and 5. BUG=847915 Change-Id: I88d786626512f08da19444615f13285aac461dcb Reviewed-on: https://chromium-review.googlesource.com/1079325Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#563058}
-
Bill Orr authored
This change removes a synchronous call from browser code into VRDevice, in anticipation of making VRDevice a mojo interface. Browser-side now controls whether a device is fallback. The change here is temporary until further refactors to support XR. Fallback devices will be removed, and requestSession will have more logic to determine which device should be returned. Change-Id: I4707eecf3a0ca8356f7139934c2e1fc79f934d37 Reviewed-on: https://chromium-review.googlesource.com/1080039Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#563057}
-
Tien-Ren Chen authored
With the new layout test flag --enable-display-compositor-pixel-dump, BrowserCompositorMac gets desired viewport size in device pixel from the renderer through BrowserCompositorMac::SynchronizeVisualProperties(), and convert that from device pixel to DIP and cache it. However BrowserCompositorMac doesn't know the overriden device scale factor by test scripts, thus the DIP viewport size will not be properly divided by the overriden device scale factor. When next time RenderWidgetHostImpl::SynchronizeVisualProperties is invoked, it will query the current viewport size, we would get the already scaled value and multiply it by the overriden device scale factor again. This makes the viewport size keeps growing until it exceeds the maximum texture size and crash. This CL makes BrowserCompositorMac to use the device scale factor from the render frame metadata, so the correct DIP size of the viewport can be derived. BUG=667551 Change-Id: I21f042ba8c158ce139d1ca6693d135b2fbb7b852 Reviewed-on: https://chromium-review.googlesource.com/1080031 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#563056}
-
Aldo Culquicondor authored
Bug: 846478 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: If825417bb9682cfc98299df85bb3e4960001977c Reviewed-on: https://chromium-review.googlesource.com/1073871 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#563055}
-
Scott Violet authored
If an embedding is created such that the embedder intercepts events, then the embedder should get events regardless of capture. BUG=837692,837696 TEST=covered by test Change-Id: I8ed3e30ff7973d319bb5ac91323382c1743818c1 Reviewed-on: https://chromium-review.googlesource.com/1080092Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#563054}
-
Daniel Erat authored
Update StatisticsProvider to drop pairs received from crossystem that have "(error)" values. NameValuePairsParser ignores duplicate values, so we should get rid of these so they don't prevent us from saving real values later. Also downgrade a "Statistics loaded after waiting ___ ms" LOG(WARNING) to VLOG(1), since this seems to be the common case on a caroline ToT device and it just ends up cluttering the logs. Bug: 844258 Change-Id: Idf869617a03992e51a720359b4ebfdac91dec6e9 Reviewed-on: https://chromium-review.googlesource.com/1072706Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#563053}
-
Robert Ogden authored
Also adds an option to sort by hostname on the DataSaver settings page so that the TalkBack navigation experience is consistent with the other table headers. Bug: 836018 Change-Id: Ic837d520ea613185398b0b2214640b80a41bcfa4 Reviewed-on: https://chromium-review.googlesource.com/1077588Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#563052}
-
Karan Bhatia authored
Currently we create default web request rules registries for the declarative web request API even if the API is not available to the current environment. This is wasteful and detrimental to performance, since the initial registry load blocks the first network request (tracked via Extensions.NetworkDelayRegistryLoad UMA). This CL changes RulesRegistryService so that the default WebRequestRulesRegistry is registered only if the declarative web request API is avaialble to the current environment. This, for example, means that no default web request rule registries would be created on the stable channel. Rules registries corresponding to webviews and the default content rules registry would still be created. This also helps fix issue 777717 and renderer cache is not cleared redundantly on each extension load/unload/uninstall when the API is not available. BUG=693243, 777717 Change-Id: I7384fed71a86aea3f5cc8d2eafd1445b439dd76a Reviewed-on: https://chromium-review.googlesource.com/1072497Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#563051}
-
Malay Keshav authored
This patch changes the logic the list of zoom values are computed for a given display. The new logic has 2 scenarios for listing the zoom values for a given display. 1) Displays with device scale factors assigned to them, will now have zoom values ranging from the inverse of device scale factor to device scale factor. If there are still slider ticks avaiable we use them to add zoom levels beyond the device scale factor. Doing this allows the user to go to the native resolution of the display and on the other hand it also allows them to zoom in if required. We no longer allow the user to go to a zoom below the native resolution of the display as this is a very unlikely scenario and introduces artifacts. This also gives finer control to the user in setting the zoom level. How this effects a pixelbook for example? On pixelbook we used to have a zoom range of 50% to 175%. Due to the wide range, the consecutive values were too far apart and users wanted zoom values that were mostly in the range of 70% to 100%. With the new change, the range will go from 50% to 130%. 2) Displays with no device scale factors assigned to them will use a static list of initialized zoom values. Bug: 845634 Change-Id: I69a761856dab4e5b37b85420f6f6dfebdb2dead5 Component: Display zoom, display util Reviewed-on: https://chromium-review.googlesource.com/1069561 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#563050}
-
Thomas Guilbert authored
Bug: 842402 Change-Id: I0639f8bd383481f8727e149fedb8b46201b895ad Reviewed-on: https://chromium-review.googlesource.com/1077616Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#563049}
-
Min Chen authored
- Add "Feedback" item to power button menu if user is logged in and screen is unlocked. Since sending feedback was not allowed at login and lock screen. finch side change: https://critique.corp.google.com/#review/197648342 spec: https://drive.google.com/file/d/1JNH0ZDknXSvV00C7TeT4xT_rFx48OdZd/view Bug: 845558 Change-Id: I93dadb2f3e12fd389ed649c2fa5884a31971704b Reviewed-on: https://chromium-review.googlesource.com/1069627 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#563048}
-
Devlin Cronin authored
Update references to ExtensionService in c/b/task_manager to use extensions::ExtensionService. There should be no behavior change as a result of this CL. Bug: 117261 Change-Id: I18111ab851102ba21239b4ae7b7ee54ec0fc1076 Reviewed-on: https://chromium-review.googlesource.com/1080021Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563047}
-
Johannes Henkel authored
This is a reland of 888c9108 Original change's description: > Delete HeadlessBrowserContext::Observer::OnChildContentsCreated. > > This isn't used. > > Change-Id: Id61efee5ce35617c6ab65c6c19a059b36323176f > Reviewed-on: https://chromium-review.googlesource.com/1065076 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559821} Change-Id: I52e6f2361da7dd900eef24dea4aefd57fa8dda9a Reviewed-on: https://chromium-review.googlesource.com/1073619Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#563046}
-
danakj authored
It was being used to report if it was there or not, and in some dead functions. The test checking IsSoftware() didn't actually care, (it used it to pass HARDWARE or SOFTWARE to a funciton that only checks for RESOURCELESS_SOFTWARE) and the dead code is now removed. TBR=jam Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia5c19a3ac25dc3d2ae58e44cee25d2c44ec61dff Reviewed-on: https://chromium-review.googlesource.com/1079688 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#563045}
-
Devlin Cronin authored
Update references to ExtensionService in c/b/notifications to use extensions::ExtensionService. There should be no behavior change as a result of this CL. Bug: 117261 Change-Id: Ie3133eeb0a9778c909420b3f531e2d34d4270686 Reviewed-on: https://chromium-review.googlesource.com/1079901Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563044}
-
Reid Kleckner authored
It was recently enabled in https://chromium-review.googlesource.com/c/chromium/src/+/1076594, but it does not pass. I have not debugged it, I'm just trying to get things back to green now that we are running this test more widely. TBR=sky@chromium.org, thakis@chromium.org BUG=848049 Change-Id: Ic0842dce2ddc10951b28e3e095f746c06076ecfe Reviewed-on: https://chromium-review.googlesource.com/1080073Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#563043}
-
Devlin Cronin authored
URLRequests terminate with a status of canceled if the device is suspended during download. In order to accommodate for this when downloading an extension, add this to the cases in which we retry automatically. Bug: 824454 Change-Id: Ia3187c0ca0150968d8eae67f8f265bb6f7e7ab6e Reviewed-on: https://chromium-review.googlesource.com/1079689Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563042}
-
Qiang Xu authored
Bug: 846890 Test: manual Change-Id: I37b4a89130d282a497058485bcd1c24fd87b326d Reviewed-on: https://chromium-review.googlesource.com/1074224Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#563041}
-
Hwanseung Lee authored
GamepadDispatcher caches the last gamepad that was connected or disconnected as well as its index and connection state. but The cached value is no longer used. Bug: 843305 Change-Id: I20b30f88d638f94b4a41f593a6976f7ae5f3d4e8 Reviewed-on: https://chromium-review.googlesource.com/1077879Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#563040}
-
Jialiu Lin authored
DownloadItem::GetHash() returns raw SHA-256 hash that is not hex encoded. This may cause DCHCEK failure when passing on the DangerousDownloadInfo::ToValue() since the raw hash may not be UTF8. Therefore, this CL HexEncode the raw sha256 first before passing onto the event router. Bug: 846156,796087 Change-Id: Iab51535d7de0b37841851b4887ffca9cf099bd39 Reviewed-on: https://chromium-review.googlesource.com/1079436Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#563039}
-
Joe Downing authored
These tests are similar to the tests in the content layer, however these test exercise Chrome E2E instead of using stubs. BUG=680809 Change-Id: I371d1cdec025517634e62b7ee4cde674c480307c Reviewed-on: https://chromium-review.googlesource.com/1068122 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#563038}
-
Mike Wasserman authored
Use PrefRegistrySyncable's new whitelist for delayed pref registration. (there's a race between ash prefs connecting to chrome and sync init) Avoids PrefServiceSyncable::AddRegisteredSyncablePreference DCHECKs. See the bug and earlier patch sets for debug code to trigger the race: 1) Build chromeos=1 on linux desktop with this patch applied 2) Run chrome --user-data-dir=/tmp/foo --login-manager 3) Go through setup, sign in to an existing account 4) Launch chrome again, sign in quickly, wait ~10s for a DCHECK Bug: 788918 Change-Id: Ib505194900b34154b3896373b93c951a6eeb8715 Reviewed-on: https://chromium-review.googlesource.com/1012788Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#563037}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5033ec9..2cf653be Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4cc42260783ae16d8711536fc234e96a54f4d432 Reviewed-on: https://chromium-review.googlesource.com/1079256Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#563036}
-
wutao authored
When SetIcon in the SearchResultTileItemview, the icon is not resized for different display size. Therefore the image quality is bad when the scale is not 1. Resizing the icon will fix this bug. Bug: 842997 Test: manual Change-Id: I00189636fbb2499e778f777d7e93cd60a3cc9057 Reviewed-on: https://chromium-review.googlesource.com/1080011Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#563035}
-
Takumi Fujimoto authored
Make MRViewsUI filter out pseudo sink, since it is not used in the Views dialog and should not show up on the sink list. Bug: 842778 Change-Id: Icb7b5197bfcf15b7abd14389025e16f2d6391f4e Reviewed-on: https://chromium-review.googlesource.com/1070494Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#563034}
-
erikchen authored
Previously, OOP HP relied on base TLS to implement its re-entrancy bit. Base TLS cannot be used after thread destruction has started. This means that frees that occurred during thread destruction were not being logged. This CL implements a very simple cross-platform TLS re-entrancy bit. Since it's only a single bit, the data can be stored in the TLS value without needing any additional allocations. This means that it can be safely used during thread destruction. With this CL, frees that occur in thread destruction will be correctly recorded. Allocations still depend on base TLS, so they will be missed. Bug: 839416 Change-Id: I2e1aab9de73122f234a4b11b826e491c347dcfd5 TBR: gab@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1076448Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#563033}
-
Alexei Filippov authored
This is a reland of 250e7ef1 Original change's description: > Reland "DevTools: Support CPU profiles in OOPIFs" > > This is a reland of 91d5ec53 > > Original change's description: > > DevTools: Support CPU profiles in OOPIFs > > > > BUG=832313,820250 > > > > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf > > Reviewed-on: https://chromium-review.googlesource.com/1011350 > > Commit-Queue: Alexei Filippov <alph@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553688} > > TBR=dgozman > > Bug: 832313, 820250 > Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de > Reviewed-on: https://chromium-review.googlesource.com/1065230 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560049} TBR=dgozman Bug: 832313, 820250 Change-Id: I7eee078d51e23034ac8c08ce315949c4d78c7092 Reviewed-on: https://chromium-review.googlesource.com/1079729Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#563032}
-
Karan Bhatia authored
r487664 disallowed content script injection in the New Tab Page. However, the check in RendererPermissionsPolicyDelegate::IsRestrictedUrl for the same, might not work due to the following reasons: - There might be a race between checking if the extension can inject the script and setting the new tab url in the renderer (SearchBouncer). - The New Tab page url in the SearchBouncer might be set incorrectly due to incorrect handling of multiple profiles by InstantService. Fix this by checking if the current renderer process is an Instant (NTP) renderer. This should work since the NTP renderer process should not be shared with other sites. BUG=844428, 662610 Change-Id: I45f6b27fb2680d3b8df6e1da223452ffee09b0d8 Reviewed-on: https://chromium-review.googlesource.com/1068607Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#563031}
-
Stephen Chenney authored
LayoutRectOutsets appear in painting code and are otherwise cumbersome to log. R=pdr@chromium.org Change-Id: Iab1cb66b3692bf48250d896e0448dfbd8e3ee8ec Reviewed-on: https://chromium-review.googlesource.com/1078938Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#563030}
-
Max Moroz authored
The CL depends on https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1073394 Bug: 846721 Change-Id: I183e6adf370da3de30f16b2b6917a9a5d927e37b Reviewed-on: https://chromium-review.googlesource.com/1073395Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#563029}
-
Tom Anderson authored
After [1], a manual dependency on exe_and_shlib_deps is no longer necessary since it's automatically added. This CL removes all remaining manual references to exe_and_shlib_deps. [1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5 BUG=845700 R=dpranke TBR=sky,mark Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I647442fb09eba4c055697bf26504abc3b3284d94 Reviewed-on: https://chromium-review.googlesource.com/1073613Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#563028}
-
Xing Liu authored
This CL adds a prefix with bold text style to download location preference summary. Bug: 847541 Change-Id: I9260197460b055b3ffa161e13bf98c7a7459d594 Reviewed-on: https://chromium-review.googlesource.com/1077651 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#563027}
-
Matt Menke authored
Also make NetworkService object take ownership of the HostResolver when it's constructed in the legacy in-process path, so that ChearHostCache() calls in production can go through the NetworkService API. Bug: 835470 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic9293aabbc3708ec57823c9a36b992a49bae8f42 Reviewed-on: https://chromium-review.googlesource.com/1070649Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#563026}
-
Xiaohan Wang authored
Previously CdmProxyTest serves as a unittest in ClearKeyCdm to talk to ClearKeyCdmProxy to make sure the CdmProxy path is connected and works. Recently we have updated ClearKeyCdm and ClearKeyCdmProxy such that it we can actually set keys in ClearKeyCdmProxy, which can then support decryption of media buffers. The CdmProxy browser_test case is also updated to cover this whole path. As such, CdmProxyTest is not a unittest any more. Instead, it serves as a simle class hanlding CdmProxy related tasks, e.g. forward CdmProxy calls and serve as a CdmProxyClient. This CL renames CdmProxyTest to CdmProxyHandler to better reflect its new role. For the same reason, also renames "cdmproxytest" test key system to "cdmproxy". TBR=rkuroiwa@chromium.org Bug: 806018 Test: No functionality change Change-Id: I479d2194d092435fe3b9cac1bc072fbd7b1c53be Reviewed-on: https://chromium-review.googlesource.com/1073082 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#563025}
-
Yves Arrouye authored
Formally changed the type in the proto (as on server). Also include a zero byte in the EID in unit tests. BUG=chromium:840496 TEST=unit_tests Change-Id: I4e0acaf70547658421c16a8d4731f72f7dc2caa1 Reviewed-on: https://chromium-review.googlesource.com/1079255 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#563024}
-
Ryan Tseng authored
Bug: 790269 TBR: tandrii Change-Id: I45e883f69dd418be814a6ed96cb41e2e40b256d1 Reviewed-on: https://chromium-review.googlesource.com/1079895Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#563023}
-
Byungchul Kim authored
Bug: internal b/80473501 Change-Id: I999de9a2db930f7eab10fb94cd53790431f22b8c Reviewed-on: https://chromium-review.googlesource.com/1079702Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Byungchul Kim <byungchul@chromium.org> Cr-Commit-Position: refs/heads/master@{#563022}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d637b5fa. With Chromium commits locally applied on WPT: 6534acd9 "[css-grid] Baseline alignment inside the tracks sizing algorithm" e8832df8 "webrtc wpt: remove test_state_change_event" d637b5fa "Support groupId in MediaDevices.getUserMedia() for audio tracks" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18939 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/workers TBR=robertma No-Export: true Change-Id: I2f6fb9d8f79e9cac37e957884a432ec582d28ac1 Reviewed-on: https://chromium-review.googlesource.com/1079807 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#563021}
-
Peter Collingbourne authored
For the moment, this is the configuration that we plan to deploy in official builds. Bug: 821860 Change-Id: I70ff3df79988a741676b52a18a0d6c3fe4f2438e Reviewed-on: https://chromium-review.googlesource.com/1053230Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#563020}
-