GitLab

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/57476cefd25ae2063bd373156fefab4f756ed90d Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/e328cf9c78a02f44b24dfa809284a6e94bcec935 git cl issue: add --json switch for machine-readable output (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=none

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2261193002
Cr-Commit-Position: refs/heads/master@{#413443}

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640

Review-Url: https://codereview.chromium.org/2259823007
Cr-Commit-Position: refs/heads/master@{#413442}

UpdatePreferredLoginState needs to update PasswordStore with a slightly
modified version of some of the forms in PasswordFormManager's |best_matches_|.
Currently it does so by modifying |best_matches_| directly, and then updating
the PasswordStore.

That has the advantage of keeping an up-to-date copy in |best_matches_| without
reloading from PasswordStore (and also sparing PasswordForm copies inside
UpdatePreferredLoginState.

It also has a disadvantage: |best_matches_| cannot be const. That will become
a problem once the ownership of |best_matches_| will be transferred from
PasswordFormManager to a new class, FormFetcher, shared by multiple
PasswordFormManager instances. While it is possible to let all
PasswordFormManager instances modify the forms owned by a FormFetcher, that
will make the code hard to understand and prone to unexpected side-effects.

The advantage seems limited -- at the point UpdatePreferredLoginState is called,
the PasswordFormManager is saving a password form, and will be deleted soon.
It will not need the |best_matches_|. Once FormFetcher starts owning them,
it will need to wait for a refresh from PasswordStore to get them updated.
But that's not worse than today, when different PasswordFormManager instances do
not share their |best_matches_| at all.

BUG=621355

Review-Url: https://codereview.chromium.org/2261723002
Cr-Commit-Position: refs/heads/master@{#413441}

BUG=skia:5227

Review-Url: https://codereview.chromium.org/2264673003
Cr-Commit-Position: refs/heads/master@{#413440}

Since the RootScroller proposal allows arbitrary elements to become the outer
viewport scroll layer, the scroll chaining behavior need a bit of an
adjustment. Specifically, we shouldn't chain past the outer viewport scroll
layer. The current code assumes that once we hit the outer viewport scroll
layer, we can continue chaining since we'll get to the inner viewport scroll
layer.

In this CL, we'll add the inner viewport scroll layer to the scroll chain and
immediately break when we encounter the outer viewport scroll layer, relying on
the fact that the scrolling code will use cc::Viewport to scroll the inner
viewport scroll layer.

Also added a test to make sure TopControls movement works correctly when a non-
default outer viewport layer is used.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2243973002
Cr-Commit-Position: refs/heads/master@{#413439}

It's possible for frame_ to be deleted after this call, so add null
checks after call sites.

BUG=639688, 639689
TEST=No more OnStop or NavigateInternal crashes in RenderFrameImpl.

Review-Url: https://codereview.chromium.org/2260383002
Cr-Commit-Position: refs/heads/master@{#413438}

It turns out that the original patch
(https://codereview.chromium.org/2133093002) didn't actually enable
browser logging in the System Health smoke tests.

BUG=623058,639538

Review-Url: https://codereview.chromium.org/2267663003
Cr-Commit-Position: refs/heads/master@{#413437}

Inside PasswordFormManager and FormSaver, the |credentials_to_update| argument is used to pass copies of non-best matches with a modified password, in order to be saved to PasswordStore.

Currently, the PasswordForm in |not_best_matches_| is changed directly, and a pointer to it is passed in |credentials_to_update|. However, |not_best_matches_| will need to become constant as its ownership transfers to the coming FormFetcher class, to avoid potential for surprising side-effects when multiple PasswordFormManager change the shared object inside one FormFetcher.

This CL makes that possible by changing the element type of |credentials_to_update| from a pointer to a PasswordForm to a PasswordForm itself. That way it is possible to modify just the copy inside |credentials_to_update| and not the original in |not_best_matches_|. The fact that |not_best_matches_| fall out of sync with the PasswordStore at that point does not matter: the current PasswordFormManager is currently saving a PasswordForm, so it will be destroyed soon and will not need |not_best_matches_|.

BUG=621355

Review-Url: https://codereview.chromium.org/2263683002
Cr-Commit-Position: refs/heads/master@{#413436}

Google Cloud Messaging recently started including a "google.sent_time"
Long in the incoming message Bundle from Google Play Services. This
patch filters out non-String values to prevent warnings about
ClassCastExceptions.

BUG=639313

Review-Url: https://codereview.chromium.org/2265543002
Cr-Commit-Position: refs/heads/master@{#413435}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e0e1556b..e0af8c62

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2264013003
Cr-Commit-Position: refs/heads/master@{#413434}

In mus+ash, toplevel windows don't share the same focus_client,
so we have to use exo::WMHelper for handling window focus.

BUG=637914

Review-Url: https://codereview.chromium.org/2259243002
Cr-Commit-Position: refs/heads/master@{#413433}

GMSCore uses Parcelables for IPCs, and so we can't safely rename
anything.

BUG=639722

Review-Url: https://codereview.chromium.org/2269553003
Cr-Commit-Position: refs/heads/master@{#413432}

CrashDumpManager watches for generated microdumps when child processes
die, and CrashMicroDumpManager is responsible for aborting the WebView
browser process. Both share similarities that can be combined, and doing
so allows us to eventually support generating a minidump and then dying
in WebView.

BUG=633979

Review-Url: https://codereview.chromium.org/2200693002
Cr-Commit-Position: refs/heads/master@{#413431}

RenderThreadImpl::Shutdown has been trying to shut down Blink and V8 gracefully,
but the graceful shutdown has caused tons of use-after-free bugs
(and many engineers has spent lots of time fixing ordering issues around the shutdown).

As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion)
and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion),
there is no reason we have to shut down the renderer gracefully.
It's just causing use-after-free bugs and wasting performance.
Hence, this CL stops calling blink::shutdown, which had been
shutting down *some things* in Blink and V8 gracefully.
(Remember that blink::shutdown hadn't been shutting down everything;
a lot of objects in Blink and V8 had already been left as is without getting destructed.)

Ideally we should just call ProcessDied() at an earlier stage of
RenderThreadImpl::Shutdown(), but I'd like to defer the change to a separate CL.

BUG=639244

Review-Url: https://codereview.chromium.org/2249353002
Cr-Commit-Position: refs/heads/master@{#413430}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d0987fac..e0e1556b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2266863002
Cr-Commit-Position: refs/heads/master@{#413429}

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(),
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282

Review-Url: https://codereview.chromium.org/2260703004
Cr-Commit-Position: refs/heads/master@{#413428}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/c71fa13c8ea4fef24f23d0894e8c636f3d66fe7a Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/b8f8dd796be3ff39f4801f81e6ec8d4fe0c12032 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/990f604880743564b4d20029026487d7477c3ed3 fetch: set remote.origin.url to correct value rather than failing (phajdan.jr@chromium.org)

NOTRY=true
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2268523002
Cr-Commit-Position: refs/heads/master@{#413427}

BUG=615825

Review-Url: https://codereview.chromium.org/2262733002
Cr-Commit-Position: refs/heads/master@{#413426}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/2c034e723e150b21ed4ddcd346e3d9746e4c622a Add cloudtail start/stop in recipe_modules/goma (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=544330

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2263073002
Cr-Commit-Position: refs/heads/master@{#413425}

Let a video resume automatically when changing the playback position after the playback has finished

BUG=418441
TEST=manually tested

Review-Url: https://codereview.chromium.org/2263033002
Cr-Commit-Position: refs/heads/master@{#413424}

Extracted VolumeInfo interface so that our modules which depend on only the VolumeInfo's interface
don't need to have dependencies on the VolumeInfo's implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2260133002
Cr-Commit-Position: refs/heads/master@{#413423}

In addition the code performs small related refactoring. No functional changes should happen.

BUG=555132

Review-Url: https://codereview.chromium.org/2253233005
Cr-Commit-Position: refs/heads/master@{#413422}

There are 2 places the spec uses "report the exception"[1]:

1. The document parser invokes constructors synchronously.
2. Upgrade.

Currently Blink has 2 different code paths for each, and each has
different issues:
1. The synchronous constructor uses SetVerbose(true), which works for
   thrown exceptions, but ExceptionState::throwIfNeeded() only puts
   the exception into pending exceptions, which will be cleared when
   TryCatch scope exits.
2. Upgrade fires error events and calls
   ExecutionContext::reportException() to avoid it, but it always uses
   NotSharableCrossOrigin. This works in run-layout-test where the
   origin has m_unversalAccess, but not in, for instance, file URL.

This patch unifies the 2 code paths.

[1] https://html.spec.whatwg.org/multipage/webappapis.html#report-the-exception

BUG=632940

Review-Url: https://codereview.chromium.org/2244203002
Cr-Commit-Position: refs/heads/master@{#413421}

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
graceful shutdown mechanism for WorkerThread (https://crbug.com/487050)

BUG=614272, 638877

Review-Url: https://codereview.chromium.org/2265863002
Cr-Commit-Position: refs/heads/master@{#413420}

This makes sure order of script execution in HTML imports,
which define custom elements.

BUG=594918

Review-Url: https://codereview.chromium.org/2269493002
Cr-Commit-Position: refs/heads/master@{#413419}

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
R=mkwst

Review-Url: https://codereview.chromium.org/2264503002
Cr-Commit-Position: refs/heads/master@{#413418}

This change enables the stopNotifications function for remote GATT
characteristics on Android. In order to do so, two distinct refactorings have been done;

1) The session classes have been simplified so that platform specific versions are no longer required. All code that previously used BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base BluetoothGattNotifySession class.

2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession have been rewritten so that all the code for keeping track of the different session objects and the notification state sits in the base class. Inheriting classes should no longer override these two functions, but instead override the much simpler SubscribeToNotifications and UnsubscribeFromNotifications.

BUG=584370

Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
Review-Url: https://codereview.chromium.org/2051333004
Cr-Original-Commit-Position: refs/heads/master@{#412498}
Cr-Commit-Position: refs/heads/master@{#413417}

This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to
display a more explicit custom error message if the condition is not met at
the end of the timeout.

BUG=none

Review-Url: https://codereview.chromium.org/2252723008
Cr-Commit-Position: refs/heads/master@{#413416}

- enums, including those defined inside structs and interfaces.
- struct and union internal data types (i.e., the wire format definition).

BUG=632061

Review-Url: https://codereview.chromium.org/2247083003
Cr-Commit-Position: refs/heads/master@{#413415}

BUG=626274

Review-Url: https://codereview.chromium.org/2244943002
Cr-Commit-Position: refs/heads/master@{#413414}

After ThreadedWorklet is introduced, worklet code gets more tied up with
worker code, so it'd be reasonable that they are located in the same directory.

BUG=567358

Review-Url: https://codereview.chromium.org/2262483003
Cr-Commit-Position: refs/heads/master@{#413413}

Temporarily unbind current transform feedback object to make
glResumeTransformFeedback actually work correctly.

BUG=638514
TEST=webgl2_conformance_test/deqp/functional/gles3/transformfeedback on mac
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2252153003
Cr-Commit-Position: refs/heads/master@{#413412}

It was hidden to the user since chrome://gpu was not showing
any workarounds, but they were still applied in the gpu process.

Also add a gpu test that sets
--disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing
and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND
in both browser and gpu processes.

BUG=359367

R=kbr@chromium.org, zmo@chromium.org

TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755
Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd
Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6
Review-Url: https://codereview.chromium.org/2195743005
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#409197}
Cr-Original-Original-Commit-Position: refs/heads/master@{#412685}
Cr-Original-Commit-Position: refs/heads/master@{#412989}
Cr-Commit-Position: refs/heads/master@{#413411}

According to the HTML specification [1], we should throw a TypeError if a non-Date
object is specified to valueAsDate.
 - Update toCoreDate() so that it throws a TypeError for non-Date objects.
 - Also, add DCHECKs to WTF::msToYear.

Note: Web IDL CR doesn't accept |null| for Date conversion [2]. However the
specification itself is deprecated.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-input-valueasdate
[2] https://www.w3.org/TR/WebIDL/#es-Date

BUG=637115

Review-Url: https://codereview.chromium.org/2265443002
Cr-Commit-Position: refs/heads/master@{#413410}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2258833002
Cr-Commit-Position: refs/heads/master@{#413409}

- Use single-line comments.
- Update comments
- Unexport WTFGetBacktrace() and WTFPrintBacktrace()
- Remove unused ASSERT_MSG_DISABLED macro

This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2254153002
Cr-Commit-Position: refs/heads/master@{#413408}

This patch converts "editing/deleting/delete-leading-ws-001.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2264463002
Cr-Commit-Position: refs/heads/master@{#413407}

(Note: This patch was reverted in crrev.com/2213223004 because of issues
crbug.com/633859 and crbug.com/634254. These issues were caused from
setting isInherited to false instead of true for the StyleBuilder
generated inherit functions, and a slotting bug from skipping child
recalc in HTMLSlotElement and InsertionPoints, which have both now been
fixed in this patch & have tests added.)

Add a fast-path for inherited properties which do not depend on and do
not affect any other properties on ComputedStyle. When these properties
are modified in a parent element, set them directly on ComputedStyle and
skip doing a full recalc for elements only affected by this change.

Also implemented two of these properties: visibility and pointer-events,
storing an extra 2 bits per ComputedStyle. This increases the size of
ComputedStyle by 1 byte on Windows and some Android builds (due to
aligned fields), which increases the memory usage for a standard page
with ~1000 elements by up to 1kb (although potentially up to 4/8kb on
32/64 bit builds due to packing, although this depends on the allocator
implementation details) but realistically less since style sharing only
creates one ComputedStyle object for each unique style.

Benchmarks show a speed increase of up to 2x for setting these
properties on the root element of a typical web page (Facebook, Twitter,
Pinterest, Amazon, Wikipedia) and letting the change propagate directly
onto the child ComputedStyle objects, rather than doing a full style
recalc.

Initial Benchmarks:
https://docs.google.com/spreadsheets/d/1mUuJEs8cPWyNTR7tQw27oxq6fDTvWiAwgatf_g--B4w/edit#gid=1597242813

Follow-up Benchmarks:
https://docs.google.com/spreadsheets/d/1mUuJEs8cPWyNTR7tQw27oxq6fDTvWiAwgatf_g--B4w/edit#gid=918856082

BUG=622138

Review-Url: https://codereview.chromium.org/2220873002
Cr-Commit-Position: refs/heads/master@{#413406}

BUG=402536

Review-Url: https://codereview.chromium.org/2259253002
Cr-Commit-Position: refs/heads/master@{#413405}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256733004
Cr-Commit-Position: refs/heads/master@{#413404}