- 12 Dec, 2017 40 commits
-
-
k2.nagaraju authored
updated parsing logic updated test cases and expected results Bug: 755487 Change-Id: Ia5d55a117f5f5fa7217e7671337fa4bc7fafbf41 Reviewed-on: https://chromium-review.googlesource.com/787071Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523357}
-
Lei Zhang authored
Unlike the current checks for the debug dump path, HasDebugDumpPath() is truly read only and won't create the base::FilePath when accessing the |g_debug_dump_info| base::LazyInstance. Update code to use HasDebugDumpPath() instead of accessing |g_debug_dump_info| directly, and only do that when getting / setting the path value. Change-Id: I200664a9cb70289883627c8dc7f85c6f02edd45b Reviewed-on: https://chromium-review.googlesource.com/821370Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523356}
-
Timothy Loh authored
Change-Id: I219a0dfc48e834e55b35e376378fd3775fff6ee0 Reviewed-on: https://chromium-review.googlesource.com/821331Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#523355}
-
Tom Anderson authored
BUG=789405 R=erg@chromium.org,sky@chromium.org Change-Id: I9b313c1027cd5ac69ed1b3545f909b60a648b148 Reviewed-on: https://chromium-review.googlesource.com/803666 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523354}
-
Giovanni Ortuño Urquidi authored
Add checks to current tests to make sure that BookmarkAppNavigationThrottle records the correct values for each case. Bug: 785661 Change-Id: Ic975722978309eb87acafa3b071693f0bc52f964 Reviewed-on: https://chromium-review.googlesource.com/813355 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#523353}
-
Yoichi Osato authored
This patch is a part of crrev.com/c/813336 ([LayoutNG] Paint text selection on load.) This patch depends on crrev.com/c/818864 (Implement NG offset conversion and LayoutSelectionStartEndForNG()) ng_text_fragment_painter.cc: - This paints selection background and selected text. - PaintSelection() paints selection background. This is copied from InlineTextBoxPainter::PaintSelection() w/o ltr, expanding new line wrap,,, which uses InlineTextBox functions. - NGTextFragmentPainter::Paint paints text partially: Suppose we have "b[a]r" (selected only 'a'), -- 1. Paint 'b' -- 2. Paint white 'a' -- 3. Paint 'r' Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id9001b6fdadda084dae5531a5dfd0725bae293f8 Reviewed-on: https://chromium-review.googlesource.com/818884 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523352}
-
rhalavati@google.com authored
The default network traffic annotation value is removed from the Write function of the following classes: - HttpProxyClientSocket - HttpProxyClientSocketWrapper Bug: 656607 Change-Id: Iae5bb59c2391504e457a323fa178673d70676696 Reviewed-on: https://chromium-review.googlesource.com/817416Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#523351}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/c00226132679..5e99d62f4d92 $ git log c00226132..5e99d62f4 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 thestig Roll DEPS for zlib to 91155b5d. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id258dff9dd474f41a0e57f9a1ae6de3b11887bf6 Reviewed-on: https://chromium-review.googlesource.com/821597 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523350}
-
Hidehiko Abe authored
BUG=234463 TEST=Ran bots. Change-Id: I17099f919e60e83f8add28b5ce1158e0ac9b98ba Reviewed-on: https://chromium-review.googlesource.com/819191Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523349}
-
Koji Ishii authored
Following bot results are included. 2452 2453 2454 2455 2456 2457 2460 2462 2464 2469 2470 Deflake is not included. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I2646bdf894234e14ef24236b581f19281f9f7b7d Reviewed-on: https://chromium-review.googlesource.com/821810 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523348}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/layout/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I65d0e5c366a510f573659cfdbedeb0eb8e2f6c9e Reviewed-on: https://chromium-review.googlesource.com/816174Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#523347}
-
Avi Drissman authored
This is intended to help diagnose crashes and find repro steps. While in some cases a full URL is available (and is added), in the case of a render process that may be out-of-process, full URLs may not be available. This adds as much info as is available (full URL if possible, just an origin if not). BUG=793067 TEST=none Change-Id: I11134cc5a5238839236b05717db1afe30d19328d Reviewed-on: https://chromium-review.googlesource.com/818389Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523346}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/svg/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I675071e07aaf9d5f6ad5ef06e1def1a4b796e6bb Reviewed-on: https://chromium-review.googlesource.com/816234Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#523345}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/page/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I82b2af55d42f44324e4ce4406efa0068f315a778 Reviewed-on: https://chromium-review.googlesource.com/816274Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#523344}
-
yoshiki iguchi authored
Bug: 726250 Change-Id: I421927a350dc769cfe46644845a582cea75baaca Reviewed-on: https://chromium-review.googlesource.com/811124Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#523343}
-
Xiaocheng Hu authored
The above function assumes the existence of LocalFrame client, which is not true when the frame is already detached. This patch adds a nullptr check to prevent crashes. Bug: 793358 Change-Id: I1fe6c4c2f4cef8c7709b5e76c95e3d896ce6e506 Reviewed-on: https://chromium-review.googlesource.com/821556Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#523342}
-
Eve Martin-Jones authored
Bug: 565932 Change-Id: I98a8766fd355146f8709b4057c9c6b96f9f5eb57 Reviewed-on: https://chromium-review.googlesource.com/816494Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#523341}
-
rbpotter authored
Use initial settings to populate some fields. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I817c34fabf416b7a935633bdc1830d3e69fc4086 Reviewed-on: https://chromium-review.googlesource.com/809708 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523340}
-
Hidehiko Abe authored
BUG=234463 TEST=Ran bots. Change-Id: Ic2a6ec2ba1846a1cd3fdac983134a0c6032ebbbc Reviewed-on: https://chromium-review.googlesource.com/807971Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523339}
-
Peng Huang authored
With recent changes, --mus has a separate viz process wich is launched by browser process via GpuPorcessHost. So we should use GpuProcessHost to request ARC related interfaces in Viz. Bug: 793901 Change-Id: Idd27f95fcf962b54634876024d0da4600da3f3aa Reviewed-on: https://chromium-review.googlesource.com/820151Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523338}
-
Artur Khachatryan authored
Bug: Change-Id: Iaa3396d6e2c0dbd91b5d4aaf4fa0fbb49f617fac Reviewed-on: https://chromium-review.googlesource.com/820561Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523337}
-
Peter Collingbourne authored
Bug: 607968 Change-Id: I039b18cfdecca6b9ce2d223f7ef226376b2830ef Reviewed-on: https://chromium-review.googlesource.com/821591Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523336}
-
Sergey Ulanov authored
All current implementations of AudioOutputStream allow Stop() to be called in any state (e.g. before Start() or after Stop()). Updated comments for Stop() and added unittests to verify that behavior. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8480d2faeb1090483619cab26baf23b4a39e1829 Reviewed-on: https://chromium-review.googlesource.com/818305Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523335}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/cb82b102c366..e188f9648ada $ git log cb82b102c..e188f9648 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 nednguyen Make sure cloud_storage.GetIfHashChanged also save the binary's hash upon first time fetching it Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2d1e95abc4e4846ca0b7e24e08f5168d380d20ea Reviewed-on: https://chromium-review.googlesource.com/821412 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523334}
-
Darren Shen authored
Currently we are not updating counter values correctly when we change or add counter-resets. For example, if we have something like: <div style="counter-reset: c"> <p style="counter-increment: c">First</p> <p style="counter-increment: c">Second</p> </div> we would construct the following counter tree (approximately): reset increment // first increment // second When we insert a new reset node after the first item, we would get something like: reset increment // first increment // second reset The correct behaviour would be to move every (non-reset) counter node after the first node to be a child of the new node: reset increment // first reset increment // second Bug: 463513, 599359, 591267 Change-Id: I28cbf3c13c86336ad3f6f44bf865c59d9f82d98a Reviewed-on: https://chromium-review.googlesource.com/809984Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#523333}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org Bug: 785100, 761882 Change-Id: Iab2181a6208b116eb2043446eb8edb4061a59d76 Tested: Manually with Jaws and NVDA on crbug.com and freedomscientific.com, unit test Reviewed-on: https://chromium-review.googlesource.com/820107 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#523332}
-
Tatsuhisa Yamaguchi authored
This will also affect other UI elements derived from cr.ui.MenuButton like: - Combo Button - Context Menu Button The UI elements are also referred in other places than the Files app. - "Apps" menu in login screen - media control UI in the video player - Bookmark Manager The button is made not to steal the focus when clicking it to open menu, https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/menu_button.js?q=file:menu_button.js+stealing+focus&sq=package:chromium&dr&l=139 however, it had taken focus when the menu item is activated by a click. It made the focus left on the button after finishing operation on a button using either mouse or touchscreen, requiring MenuButton class to hide that focus highlight by attaching "using-mouse" class attribute. Test: browser_tests --gtest_filter=WebUIResourceBrowserTest.MenuButtonTest* Bug: 771024,769593 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I23fb1b0ce907a21407ffca514032bfdc083e36de Reviewed-on: https://chromium-review.googlesource.com/816376 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523331}
-
Charles Reis authored
Flash requests can be distinguished by the lack of CORS, and they should be allowed since Flash has its own cross-domain policy. It is also click-to-play, making this somewhat safer to allow. TBR=nick@chromium.org BUG=793953 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I0b191e0093cc5133a9d5421b1294e4bb91e64b6c Reviewed-on: https://chromium-review.googlesource.com/817661 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#523330}
-
Tatsuhisa Yamaguchi authored
Users could move focus out of the button without triggering the logic to remove 'using-mouse' class. As a result, the focus ring (highlight) was seen missing when the button got focus again by keyboard navigation. Test: browser_tests --gtest_filter=WebUIResourceBrowserTest.MenuButtonTest* Bug: 748489 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibebe7d5dc1b89dc06490c657e20615e5001af4cc Reviewed-on: https://chromium-review.googlesource.com/814474Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523329}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: Iac6940b51fd665082b99faef092e11de79d369c7 Reviewed-on: https://chromium-review.googlesource.com/821372Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#523328}
-
Bailey Berro authored
This change removes the multiple inheritance from the SmbService class so that the SmbService class no longer has to register itself as a provider. Bug: Change-Id: Ie1eb3642f68f5f4f537e1c6c6caa5b471d0680f5 Reviewed-on: https://chromium-review.googlesource.com/820640Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#523327}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5ca9413b9bc1..40ca2087ef07 $ git log 5ca9413b9..40ca2087e --date=short --no-merges --format='%ad %ae %s' 2017-12-12 update-docs Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ibf8cf94a1ba001fdbf6489f866a1be15ab909cd9 Reviewed-on: https://chromium-review.googlesource.com/821516Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523326}
-
Xiaocheng Hu authored
IdleSpellCheckCallback asserts that the document is active when the callback is invoked, which is not true. This patch changes the assertion into aborting on inactive document. Bug: 793964 Change-Id: I4ff65ba1bdb8a7cc7f14a1fbbea2be90a337f745 Reviewed-on: https://chromium-review.googlesource.com/820604Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#523325}
-
Wenzhao Zang authored
1) Emphasize the default wallpaper selection order in DoSetDefaultWallpaper (renamed to SetDefaultWallpaperImpl). Create two additional member variables to store the customized default wallpaper file paths to make the distinction with a regular default wallpaper (ie. from the command line). Previously, these two are mixed in the code. 2) Rename |SetDefaultWallpaperPath| to |SetCustomizedDefaultWallpaperImpl|. 3) |SetDefaultWallpaperPathsFromCommandLine| is removed. We don't have the need to cache the values which come from the command line. TBR=oshima@chromium.org, ochang@chromium.org Test: Manual (device/Linux build), ash_unittests, browser tests Bug: 792233 Change-Id: I09876e23ea7609c7b7e876d4daf79c4fa35088c5 Reviewed-on: https://chromium-review.googlesource.com/808092Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523324}
-
Bill Orr authored
This change supports testing of Chrome on bots where we don't want to install or use real OpenVR/SteamVR, in order to catch regressions in Chrome. This change also fixes a few issues found in preliminary tests. BUG=780668 Change-Id: I885762e18b48961038454856743f9e7ae621001e Reviewed-on: https://chromium-review.googlesource.com/795056 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#523323}
-
sunxd authored
This CL enables composited border radius scrolling. Bug: 567296 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4753d7c557ea20d716d1a717d8ef867c996830f5 Reviewed-on: https://chromium-review.googlesource.com/760997 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523322}
-
Ilya Sherman authored
This CL only covers //components. Will migrate the other uses in sibling CLs. R=blundell@chromium.org Bug: 773850 Change-Id: Ia57dc5c75b5d2ab57436be3264b20c9d2b9b4342 Reviewed-on: https://chromium-review.googlesource.com/818726 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#523321}
-
David Tseng authored
Bug: 793332 Test: $('speech-container').hidden is false; Search+/; $('speech-container').hidden is true; escape or enter; $('speech-container').hidden is false and $('search-container').hidden is true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If8a0241140086c4089dc495fd83f8f54db4333a5 Reviewed-on: https://chromium-review.googlesource.com/820044Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#523320}
-
Tsuyoshi Horo authored
Bug: 793772 Change-Id: Ia9175cf484ba3d26c24d89a4bfcb42b1328b894b Reviewed-on: https://chromium-review.googlesource.com/818373Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#523319}
-
Daniel Cheng authored
Removes some casts where they become unnecessary. New inline variants of NumberToString are provided for long long which is necessary for some platforms to automatically convert. process_util_unittest.cc is added to the base namespace and base:: qualifiers are removed from that file. All int->string conversions in ipc_message_utils.cc are converted to use the new style. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I523c879b6e276025dd00414c283022267b3963f9 Reviewed-on: https://chromium-review.googlesource.com/813101 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#523318}
-