GitLab

BUG=167228

Review URL: https://chromiumcodereview.appspot.com/11886067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167788
Test=None

Review URL: https://chromiumcodereview.appspot.com/11910005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177210 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/162100
R=sky@chromium.org
Review URL: https://codereview.chromium.org/11885030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177209 0039d316-1c4b-4281-b951-d872f2087c98

Use pylib constants instead.

Review URL: https://codereview.chromium.org/11967019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177208 0039d316-1c4b-4281-b951-d872f2087c98

Moved the localized strings from ChromotinHost to HostUserInterface, closer to the UI objects that consume them. Removed a dependency on ChromotingHost from the continue window UI wrapper.

BUG=104544


Review URL: https://chromiumcodereview.appspot.com/11886051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177207 0039d316-1c4b-4281-b951-d872f2087c98

> Move auth-error reporting code out of SyncGlobalError and into SigninGlobalError
> 
> This is the first step towards enabling signin even when sync is disabled by
> policy.
> 
> BUG=166148,113133
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11817045

TBR=atwilson@chromium.org
Review URL: https://codereview.chromium.org/11886079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177206 0039d316-1c4b-4281-b951-d872f2087c98

This happens because an observer of kAppPack was added in crrev.com/172473.

The fix shares all the setting names with DeviceSettingsProvider to avoid similar issues in the future.

BUG=chromium:108928


Review URL: https://chromiumcodereview.appspot.com/11975009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177205 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for adding a NavigationTracker.

BUG=169078
TEST=chromedriver2_unittests


Review URL: https://chromiumcodereview.appspot.com/11975003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177204 0039d316-1c4b-4281-b951-d872f2087c98

Update some #includes in webkit/media/crypto for headers that were moved from WebKit/chromium/public/platform to Platform/chromium/public

Review URL: https://chromiumcodereview.appspot.com/11931019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177203 0039d316-1c4b-4281-b951-d872f2087c98

The optimize code is based on pngslim. A few steps are omitted, but it runs all other processes. I'll check if it
worth fixing them (for example, advdef didn't make much difference)

Using -o option requires new third party program: optpng, pngout and advdef.
The script asks to install if they're not installed. 

 So for, I've got ~30% reduction in ash/resources (it's probably because pngslim was never run on this directory), I'd expect less
on other places where pngslim was run before.

Print results

BUG=150046
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11905002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11886024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177201 0039d316-1c4b-4281-b951-d872f2087c98

The client code gets shorter, the implementation gets shorter, and there are
fewer concepts to remember.

BUG=none

Review URL: https://codereview.chromium.org/11932002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177200 0039d316-1c4b-4281-b951-d872f2087c98

Update some #includes in webkit/media/android for headers that were moved from WebKit/chromium/public/platform to Platform/chromium/public

Review URL: https://chromiumcodereview.appspot.com/11961018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177199 0039d316-1c4b-4281-b951-d872f2087c98

Now that we have common base::PostTaskAndReplyWithResult helper method
it doesn't seem necessary anymore.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/11946014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177198 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177196 0039d316-1c4b-4281-b951-d872f2087c98

destroyed (by virtue of being a child HWND), but the
NativeTextfieldWin was never destroying itself.

BUG=170369
TEST=none
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11973011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177195 0039d316-1c4b-4281-b951-d872f2087c98

This is a UI experiment that may be reverted for M26 depending on feedback.

* Ensure ImmersiveModeController always watches for window property changes.
* Trigger immersive mode in ChromeShellDelegate (this is only triggered by F4)
* Ensure we hide the immersive mode button when window isn't maximized (there
  are ordering issues with the window observers for show state that exit
  immersive mode vs. hide the button)

BUG=170167
TEST=added to browser_tests ImmersiveModeController.*


Review URL: https://chromiumcodereview.appspot.com/11969006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177194 0039d316-1c4b-4281-b951-d872f2087c98

It wasn't used anywhere other than in ipc_perftests (which, up till very
recently, weren't even compiled) in a non-essential way.


Review URL: https://chromiumcodereview.appspot.com/11964002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177192 0039d316-1c4b-4281-b951-d872f2087c98

r1557: Fix typo in error message: PARELLEL -> PARALLEL
r1558: Create intermediate PDB files in sub directories.
r1559: Change ninja rpath generation to be more like make.
r1560: windows: Add support for overriding pdb name for compile step

TBR=thakis@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11956016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177191 0039d316-1c4b-4281-b951-d872f2087c98

> Finally rip the global StackingClient bandaid off.
> 
> - Removes the aura::client::SetStackingClient(StackingClient*) interface.
> - Moves the ash StackingController from a singleton owned by ash::Shell to one StackingController per RootWindow owned by the ash::RootWindowController. (Also removes a spurious delegate method, where every implementation creates the same object, including tests.)
> - Removes the global DesktopStackingClient and related interfaces.
> - Fix the ChromeViewsDelegate so that it still sets context in chromeos builds.
> - Rename content::ShellStackingClientAsh to content::MinimalAsh to reflect what it really does.
> 
> In addition, the following fix ups apply:
> 
> - Previously, WebContentsViewAura asserted that it needed a context window. Now if no context window is provided, it isn't added to an aura hierarchy. There are times when that context doesn't exist: various chromeos dialogs that directly invoke WebView and toplevel extension/app windows that are created from background pages that don't have contexts.
> 
> BUG=161882
> 
> Review URL: https://codereview.chromium.org/11829040

TBR=erg@chromium.org
Review URL: https://codereview.chromium.org/11962021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177190 0039d316-1c4b-4281-b951-d872f2087c98

Right now there's an assumption that WebKit lives in src/third_party/, but
this is not the case when run_tests.py is ran from a WebKit checkout.

BUG=170362

Review URL: https://chromiumcodereview.appspot.com/11969014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177189 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: brush up remote debuggign browser target: use callbacks, make handlers implementation a more pleasant task.
- Migrates command handlers to the callbacks
- Introduces constants for tracing handler
- Removes notifier and replaces it with notifier callback

Test: ./tools/telemetry/run_tests --browser=release testGotTrace  -vvv

Review URL: https://chromiumcodereview.appspot.com/11958010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177188 0039d316-1c4b-4281-b951-d872f2087c98

* "naclsdk update" (i.e. update recommended) was broken
* "naclsdk update pepper_canary" would make a directory called "pepper_26" not
  "pepper_canary".

BUG=none
R=sbc@chromium.org,noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11946002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177187 0039d316-1c4b-4281-b951-d872f2087c98

Upload to the staging server and only on the FYI bot.

BUG=150801
TEST=bb_run_bot_test.py

Review URL: https://codereview.chromium.org/11972003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177186 0039d316-1c4b-4281-b951-d872f2087c98

- Removes the aura::client::SetStackingClient(StackingClient*) interface.
- Moves the ash StackingController from a singleton owned by ash::Shell to one StackingController per RootWindow owned by the ash::RootWindowController. (Also removes a spurious delegate method, where every implementation creates the same object, including tests.)
- Removes the global DesktopStackingClient and related interfaces.
- Fix the ChromeViewsDelegate so that it still sets context in chromeos builds.
- Rename content::ShellStackingClientAsh to content::MinimalAsh to reflect what it really does.

In addition, the following fix ups apply:

- Previously, WebContentsViewAura asserted that it needed a context window. Now if no context window is provided, it isn't added to an aura hierarchy. There are times when that context doesn't exist: various chromeos dialogs that directly invoke WebView and toplevel extension/app windows that are created from background pages that don't have contexts.

BUG=161882

Review URL: https://codereview.chromium.org/11829040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11962005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177181 0039d316-1c4b-4281-b951-d872f2087c98

These tests don't depend on webkit/tools/test_shell/test_shell_test.h
and can be moved to content_unittests.

Some tests were relying on the MessageLoop created by TestShell. I've
updated them to create their own MessageLoop.

BUG=126514


Review URL: https://chromiumcodereview.appspot.com/11883022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177180 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177176 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r10582: (jvoung) Roll pnacl rev to 10560 (past 10509, which previously broke pnacl+chrome).
r10583: (mseaborn) tls.c: Clarify alignment requirements in the comments
r10584: (dschuff) Update LLVM and clang rev to bring in merge to 169803
r10585: (noelallen) Update GYP files so that we match Linux behavior when OS="win" and arch is correctly
r10586: (shcherbina) Validator testing: check valid jump targets in all safe tests from testdata.
r10587: (shcherbina) Validator testing: add assert message.
r10588: (shcherbina) Add ARM support to new validator driver.
r10589: (shcherbina) Validator_ragel: get rid of spurious_data16 field, actions and macroses.
r10590: (jfb) Move CPU features into its own static library.
r10591: (jvoung) Cleanup: only skip loading the IRT if explicitly given an irt_fd that is -1.
r10592: (kschimpf) Add USES to ARM table simd_dp_3same.
r10593: (jfb) Validator driver: fix include, which I just changed and broken the build. My local rebase/scons rebuild did not catch this.
r10594: (dschuff) Disable _builtin_return_address test on x86-64
r10595: (kschimpf) Fix uses for ARM table simd_dp_3diff
r10596: (kschimpf) Add uses to ARM tables: simd_dp_2scalar, simd_pd_2shift, and simd_dp_2misc.
r10597: (kschimpf) Generate code to implement ARM baseline classes from the ARM tables.
r10598: (dschuff) Update PNaCl TOOL_REVISIONS to bring in merge
r10599: (kschimpf) Modify ARM generators to use automatically generated actual decoders.
r10600: (dschuff) Use scoped_array in pnacl stream tester.
r10601: (halyavin) Move comment that was misplaced during refactoring in revision 1008 (https://codereview.chromium.org/389022).
r10602: (halyavin) Update glibc revision.

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/11877028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177175 0039d316-1c4b-4281-b951-d872f2087c98

It's the only way to be sure...

... he doesn't get android code reviews.

Review URL: https://codereview.chromium.org/11968018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177174 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161389

Review URL: https://codereview.chromium.org/11973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177172 0039d316-1c4b-4281-b951-d872f2087c98

Especially ffmpeg may be prone to errors in this area.

Googlers: see b/1397952 for reference.

BUG=30715

Review URL: https://codereview.chromium.org/11823061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177171 0039d316-1c4b-4281-b951-d872f2087c98

This generates localized strings.xml files (e.g.
values-fr/strings.xml) from grd and xtb files at build time. This
means we no longer need to check in localized strings.xml files. Note:
the xtb files are empty until translations are available.

Benefits:
 - 41 fewer extraneous results when grepping Java string IDs
 - Switching from maintaining strings in strings.xml over to using a
   grd file is One Trivial CL* away: just include English in the list
   of languages for which we generate strings.xml files.

*Restrictions may apply

Originally landed as https://codereview.chromium.org/11659006/
This can be re-landed as of https://codereview.chromium.org/11880050/

BUG=167248
TBR=yfriedman@chromium.org,thakis,jam@chromium.org,cjhopman,shashishekhar@chromium.org

Review URL: https://codereview.chromium.org/11967005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177170 0039d316-1c4b-4281-b951-d872f2087c98

This removes unneeded gyp defines from envsetup. I still left the environment variables because some scripts (e.g. findbugs) still depend on them. I'll remove those usages and the environment variables separately.

Review URL: https://codereview.chromium.org/11886053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177169 0039d316-1c4b-4281-b951-d872f2087c98

R=danakj@chromium.org
BUG=167213


Review URL: https://chromiumcodereview.appspot.com/11887027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177168 0039d316-1c4b-4281-b951-d872f2087c98

AddNonChildChromeProcesses() appeared to be crashing sometimes on Android.
|cmd_line_args_| can be empty in some rare circumstances. One of them is when
GetProcCmdline() is called with a PID which no longer exists. This is possible
in case a render process was killed right after the list of processes was read.

TEST=Go to chrome://memory
BUG=170024


Review URL: https://chromiumcodereview.appspot.com/11878038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170034
TEST=units, watch x86-generic-asan for this not to happen periodically


Review URL: https://chromiumcodereview.appspot.com/11886068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168891
TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/11971019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177164 0039d316-1c4b-4281-b951-d872f2087c98

for clarity, and to take advantage of the fact that most of the time, we actually
want kUninitialized, which is free (doesn't call setIdentity()) and we set the entire
matrix right after it comes into scope (e.g. set3x3, setTranslate). The plan is to
hide/remove the default constructor in Skia soon.
Review URL: https://codereview.chromium.org/11931017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177163 0039d316-1c4b-4281-b951-d872f2087c98

The benchmarks first print results to stdout, then information about skipped /
failed page to stderr. The test runners also redirect both streams to the same
file. If stdout is not properly flushed, the stderr output might appear in the
middle of the stdout output, and this makes the log parser fail.

R=bulach
BUG=none

Review URL: https://codereview.chromium.org/11886071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177162 0039d316-1c4b-4281-b951-d872f2087c98