GitLab

Makes it more convenient to run multiple identical emulators at the same
time.

Change-Id: Ibbab1092c751b32ebbc0f647c61823ab9f4199bd
Reviewed-on: https://chromium-review.googlesource.com/1098468
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567724}

DelegatedFrameHostAndroid owns a CompositorFrameSinkSupport
which has a BeginFrameSource and calls DidFinishFrame at the
appropriate time. The code in RenderWidgetHostViewAndroid is
unnecessary.

Change-Id: Icf5419c2bfb542018e3bd2f63319b33aea3b8b7e
Bug: 732555
Reviewed-on: https://chromium-review.googlesource.com/1102563Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567723}

This change does not implement anything other than plumbing load
and response bits from the network stack across from the blink
loader.

BUG=348877

Change-Id: Id2b455352b8b26c93cf5e87bee054db90e774480
Reviewed-on: https://chromium-review.googlesource.com/1101237
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567722}

This is the basic polymer structure for the MultiDevice settings UI
main page. The "Set up" item is implemented concretely.

Change-Id: I4796f903b1f928bb77f5005e50574f11bb56a134
Reviewed-on: https://chromium-review.googlesource.com/1098153
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567721}

These are really common but their proper usage isn't necessarily clear.

Change-Id: I4db2e78edddee81f563f5a35f2425a92675d0949
Reviewed-on: https://chromium-review.googlesource.com/1101247
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567720}

While working in PdfPrinterHandler noticed some duplicated includes,
this cl just gets rid of those.

Bug: None
Test: Build
Change-Id: Ie19635ff093bfa135bdeb36b45acf69f5ed18d5f
Reviewed-on: https://chromium-review.googlesource.com/1102104Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567719}

Intermittent flakes in this test was caused by a V8 roll crrev/566206.
Refer to the bug for reproduction steps and regression analysis.

Symptoms were that JS Array return types would sometimes appear in the
test code as being undefined or have no .length property, which caused
intermittent JS exceptions in the test code and hence test failure.

The issue has been fixed in V8 and no longer reproduces @ crrev/567688
ToT. Re-enabling this test RELEASE therefore <eom>.

Tbr: sashab
Bug: 852246
Change-Id: If093f3357042e5e5dec7b399d373ba56e86dafea
Reviewed-on: https://chromium-review.googlesource.com/1102837Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567718}

Add an experiment arm for an alternate NTP card layout that swaps the
article thumbnail back to the end of the card.

Also increase the font size and decrease the space between cards for
Modern in general.

BUG=852163

Change-Id: Ie0c133befbb96308fc0caf08e1e9d7bc025ef079
Reviewed-on: https://chromium-review.googlesource.com/1101833
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567717}

The swap timestamp comes from the gpu process, and so it can not be
easily compared to the paint timestamp, which comes from the renderer
process. So remove the DCHECK that expects an ordering between the
two. A similar check was removed earlier in crrev.com/c/1063323

BUG=811961

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia80306f78ec82e875ec6ebe7709cf4b445a40768
Reviewed-on: https://chromium-review.googlesource.com/1102083
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567716}

On Chromecast both /dev/shm and /tmp are mounted with 'noexec' option,
which is ok, because Chromecast doesn't use NaCl. But this makes the
AnonymousExecutable tests fail. So modify the test logic to skip the
test if both /dev/shm and /tmp are mounted as 'noexec'

Bug: b/80553544
Change-Id: Ia0596153525b36c67d3f979b395c50534d1bee5c
Reviewed-on: https://chromium-review.googlesource.com/1101411Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567715}

New ErrorPage tests use EmbeddedTestServer instead of relying on DNS
resolution error. Also new tests work with enabled WebErrorPages flag.

Bug: 725241
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iad495dac2c5e3111809cf460c151187089b20698
Reviewed-on: https://chromium-review.googlesource.com/1101930Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567714}

This CL teaches the new FormData->PasswordForm parser to generate
PasswordForm::all_possible_passwords.

Bug: 845426
Change-Id: Ic75a3ade7b5ed62eaf4462ea5d00cc053c12c512
Reviewed-on: https://chromium-review.googlesource.com/1100883Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567713}

Previously any time any worklet animations were run, all worklet
animations are run regardless of whether their input time has changed.
This avoids running animations which haven't changed and reuses their
value from the previous animation call.

Note that worklet animations that are being removed still get mutated
even though the input time doesn't change.

Bug: 791279
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I212d1da620899ab3f02fceae07eda092d2b39fdb
Reviewed-on: https://chromium-review.googlesource.com/1101655
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567712}

This change should just remove the lines that have non-pass
expectations, but where the actual results don't match the
expectations.

Bug: 546215, 595483, 755405, 818107
Change-Id: Ifc42754cc6a527f6ae925d73f06076a1486f7fb2
Reviewed-on: https://chromium-review.googlesource.com/1089198Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567711}

In the event of user inactivity or lid close, this patch will prevent
the touchscreens from being disabled if an external touch device is
connected to the system.

Bug: 797411
Change-Id: I12afd55edfe343ff6508bd2fdd0f4d09c93b5a98
Component: backlights settter, touch device, wake up, power manager
Testing: Added ash unittests to check for expected behavior
Reviewed-on: https://chromium-review.googlesource.com/1102151
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567710}

During unit tests, or if the default search provider is disabled by
policy, there may not be any default search provider.

Previously, we would attempt to dereference a nullptr in that case, and
would intermittently crash. This CL fixes that by simply clearing the
placeholder text when there is no default search provider.

This is fine - as before Material Refresh there was no placeholder text
at all.

Bug: 852630
Change-Id: Id7933f7972de20a41252f8d4f0f7bb16ce623037
Reviewed-on: https://chromium-review.googlesource.com/1101710Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567709}

The logical resolution that we display on the display settings page uses
the rounded zoom factor value to do its computation. This gives an
inaccurate logical resolution text. This also results in us being unable
to tag the correct native resolution in the UI.

The rounded number is also used to set the display zoom of the display
which causes problems when the native resolution can only be reached by
a non rounded zoom factor value like in the case of a 1.6 DSF device.

Bug: 853020
Change-Id: Iba7c70c214ba57f8b21bcac72ebc0e86caeff878
Component: Display settings, display size slider
Reviewed-on: https://chromium-review.googlesource.com/1101936
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567708}

These members of CodingSpecificInfo are unused since cl
https://webrtc-review.googlesource.com/61640,
and will be deleted in webrtc.

Bug: webrtc:8830
Change-Id: I4502fc317c4e275c2890870e6a1b8f28d9c5dd88
Reviewed-on: https://chromium-review.googlesource.com/1102330
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567707}

Bug:829460

Change-Id: I6aeb5fb1026616c1d0cc92bbeed0a1004813ae76
Reviewed-on: https://chromium-review.googlesource.com/1089931Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567706}

Change-Id: I639edf669730918329f3368c73440062c3df1997
Bug: 839419,818832,852786
Reviewed-on: https://chromium-review.googlesource.com/1100962
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567705}

This just adds a link to a crbug.com comment with some thoughts about
solutions to a TODO comment inside password_field_prediction.cc.

TBR-ing Vadym, because this is a comment-only minor change.
TBR=dvadym@chromium.org

Bug: 853149
Change-Id: Id71691e9abff7cb19d069b9de30eef5c4a64fe11
Reviewed-on: https://chromium-review.googlesource.com/1102683Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567704}

We are now seeing new WPT test names like:
external/wpt/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)
which were not handled properly by Base.output_filename because it would
consider the ".*)" part as the file extension.

Change-Id: I5adc37c37fb677dc360085d395f0213d096f04ef
Reviewed-on: https://chromium-review.googlesource.com/1102182Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567703}

This removes the other check that ensures a specific number of
infobars isn't showing.  This could be breaking if the translate
infobar showed up.

Stack:
java.lang.AssertionError: Criteria not met in allotted time.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:93)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:172)
	at org.chromium.chrome.browser.PopupTest.testPopupWindowsAppearWhenAllowed(PopupTest.java:178)

BUG=771103

Change-Id: If439b42e6d0f63fa61cd75ea48bddb2e42571994
Reviewed-on: https://chromium-review.googlesource.com/1101830Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567702}

Bug: 853175
Change-Id: I3982fd6c2bc6fecbda09c3f5edb6731921c8618a
Reviewed-on: https://chromium-review.googlesource.com/1102464Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567701}

Bug: None
Change-Id: I3ab1fd657115a98baa6d88a11ecaf6d0457c83c7
Reviewed-on: https://chromium-review.googlesource.com/1101711
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567700}

Bug: 851544
Change-Id: I0504db37dce23a2cbc69624a30452e328c8d9a84
Reviewed-on: https://chromium-review.googlesource.com/1101998
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567699}

We will remove the grouping key feature in Telemetry, hence these stories need
to be named differently (right now, they are named the same but have different
grouping keys)

Bug: 849363
Change-Id: I360aea0720c13383486fdb113ceda775c9a4f136
Reviewed-on: https://chromium-review.googlesource.com/1101542
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567698}

This test was flaky due to a race condition in navigation code, which
has now been fixed. Let's try to enable it and see if the fix has helped
deflake this test.

Bug: 708139
Change-Id: I07c975eb6d6e207b6108f9f1cc6ed0e965981cde
Reviewed-on: https://chromium-review.googlesource.com/1102660Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567697}

This CL replaces UI strings of Bluetooth feature pod button in
UnifiedSystemTray. It also shows the connected device name, and if there
are multiple connected devices, it shows the number.

TEST=manual
BUG=813499

Change-Id: Ic4d840586f2ff490a9c72b19c6679bb3c5c674a6
Reviewed-on: https://chromium-review.googlesource.com/1102225Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567696}

This CL adds ConnectionRole as part of the scan filter passed to
BleScanner; then, when a scan result is returned, the delegate callback
is only invoked if a scan filter with the correct role is present. This
is necessary because BleConnectionManager should not attempt to handle
scan results for the incorrect role.

This CL also tweaks the Delegate's callback function to return a
ConnectionRole instead of a "is background" bool.

Bug: 824568, 752273
Change-Id: I6467312bfbe2057b046cbc606a55d30e90e48303
Reviewed-on: https://chromium-review.googlesource.com/1102124Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567695}

In not-surfaceless mode, webxr_ may not be initialized yet at the time
we get an incoming SetWebVrMode(false) call which calls EndPresentation.
Add a check to avoid a crash in that scenario.

BUG=846102

Change-Id: Ib5cd0d2483de831c6690cb8e1d3dbf139da44778
Reviewed-on: https://chromium-review.googlesource.com/1102122Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567694}

This CL makes the dimensions within the tab switch button a closer
to the spec: 8px between icon and text, and reduces the 18px to the
left of the icon to 16px. (The spec still wants 8px here.)

Additionally, it updates the icon using the provided SVG.

Bug: 780835
Change-Id: I4542ea03c4097b83c959f77ed86c96b2744e14ce
Reviewed-on: https://chromium-review.googlesource.com/1101399Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567693}

Some of the TouchActionBrowserTests are flaky. I was recently told by
sahel@ that setting speed_in_pixels_s to a very high number will ensure
there is one GSU only and will prevent the flaky. This does work, at
least locally. I have tried the test in this CL locally and it was
flaky without this change. With this change, I have ran this test 50
times without any failure.

This CL does that. Right now there are a few tests marked flaky, this
CL enables one of them first. I will monitor the flakiness dashboard
once this CL lands. If this does solve the problem, we will then enable
more tests.

Bug: 833015
Change-Id: I539703866094fb526e220c48aaf327836345b950
Reviewed-on: https://chromium-review.googlesource.com/1101464
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567692}

Before this CL, GetUploadToGoogleState only checked whether Sync
encryption (with a custom passphrase) was enabled at all. This wasn't
accurate for data types that are never encrypted, e.g. DEVICE_INFO or
AUTOFILL_WALLET_DATA. So this CL adds a per-data type encryption check.

One problem caused by this was that credit card autofill was broken for
users with a custom Sync passphrase. Note that credit card *upload*
should still be disabled for those users, so this CL adds an explicit
check for that.

Bug: 852815
Change-Id: I0d0119596c81fe32d9085b495a2e591d149bdad8
Reviewed-on: https://chromium-review.googlesource.com/1102328Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567691}

Bug: 852929
Change-Id: I909e627399821e61d8d0ad5ba94ff03cb45d8249
Reviewed-on: https://chromium-review.googlesource.com/1101651Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567690}

This CL prevents the is_acting_as_audio_controls_ state from updating
during an HTMLMediaElement's removal from the document. This fixes an
issue where a DCHECK was firing on the controls inserting elements into
the panel during a removal.

Bug: 851374
Change-Id: I28a4cd31dd4e0197b8fcad8cfaa9401dbf5aea61
Reviewed-on: https://chromium-review.googlesource.com/1098306Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567689}

This test was flaky due to a race condition in navigation code, which
has now been fixed. Let's try to enable it and see if the fix has helped
deflake this test.

Bug: 660288
Change-Id: Id5d74179b9719d97f712277d2fe2380b2235d74f
Reviewed-on: https://chromium-review.googlesource.com/1102569Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567688}

Setting the manager up for returning items for both a TableView model and a CollectionViewModel.

Change-Id: I27cea8787527dc8b4f28aa5abe7f38b3858dbc44
Reviewed-on: https://chromium-review.googlesource.com/1091703
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567687}

Bug: 833797
Change-Id: Ib83ba49c9cd87d8ff8723ea53b6f32404f0e066a
Reviewed-on: https://chromium-review.googlesource.com/1082473
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567686}

The Viz work on Mac has stabilized. The flakes we see in tests on our FYI bots
are general flakes. The original GL and Surface Invariants errors that prevented
us from running on the waterfall have all been fixed.

This adds the Viz testing group to the list of mac tests.

TEST=viz_browser_tests, viz_content_browsertests, viz_content_unittests

Bug: 850137
Change-Id: Ieef76cd4457bd967909cb56622fbfd243cbc38ae
Reviewed-on: https://chromium-review.googlesource.com/1095687Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567685}