- 06 Sep, 2019 40 commits
-
-
Sam Maier authored
Change-Id: I231e5e1550655976bd81fc72d26aa07fa921a80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789743 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694267}
-
Jun Mukai authored
PaginationModel::SelectPage does not stop the ongoing animation when invoked during a transition animation, which means ContentsView::TransitionStarted() is not invoked at all. This has not been addressed in the current animation scheme since ContentsView schedules the animation on TransitionStarted(). This is a quick fix to finish the existing animation before invoking SelectPage in that case. Bug: 1000920 Test: manually Change-Id: I2b69a485e04cf3965a423d6b6cbda73f1d358643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787448Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#694266}
-
Aga Wronska authored
The key event was ignored by the dialog that supports only selected events. Bug: 999385 Test: ParentAccessWidgetTest Change-Id: I76d20dcae6a5b880ecfcdd64fec61909614c3c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783861 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#694265}
-
Ian Clelland authored
This makes it easier to depend on just FeaturePolicyFeature or PolicyValue in other areas of code, without running into a possible circular import situation. Change-Id: Ic7ff6b31320f3c7d13f67153932016f966f63eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784104 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694264}
-
Tao Bai authored
This reverts commit 1a297a80. Reason for revert: The culprit https://chromium-review.googlesource.com/c/chromium/src/+/1778362 was reverted. Original change's description: > Disable flaky test AwContentCaptureTest#test* > > Tbr: michaelbai@chromium.org > Bug: 1001400 > Change-Id: I8a6e2467f020372d7b0de031b84c07948834cfdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789283 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694204} TBR=michaelbai@chromium.org,arthursonzogni@chromium.org Change-Id: Ib92233902f4e760d638d5b53e2d87ba9e19bdaf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789667Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#694263}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a3baf2a3b165..30323e2fb25a git log a3baf2a3b165..30323e2fb25a --date=short --no-merges --format='%ad %ae %s' 2019-09-06 ilnik@webrtc.org VP9 screenshare: fix incorrect assumptions on buffer contents 2019-09-06 srte@webrtc.org Fix for rare read of uninitialized value in remote estimate test. 2019-09-06 sprang@webrtc.org Implement stable rate support in SimulcastRateAllocator 2019-09-06 srte@webrtc.org Fix for deadlock in AudioUsesAbsSendTimeExtension test. Created with: gclient setdep -r src/third_party/webrtc@30323e2fb25a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Iae4067c4107fb84862187ad1459a13679681a954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694262}
-
Gabriel Charette authored
Backport some tests in /net/base/network_change_notifier_fuchsia_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /net/base/network_change_notifier_fuchsia_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=wez@chromium.org Bug: 891670 Change-Id: Idbfa9ea4a8945cbbb3e713e6d269e5427eafe4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786817 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#694261}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dff4674a483a..7285b9ab36f4 Created with: gclient setdep -r src-internal@7285b9ab36f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9d72d6b87d8c6dac678e761d4d7311089ac8b86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789554Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694260}
-
Zakhar Voit authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/0418b5904157..db31812cb239 $ git log 0418b5904..db31812cb --date=short --no-merges --format='%ad %ae %s' 2019-08-12 voit login: Add LoginScreeenStorage ListKeys() and Delete() methods. 2019-08-14 kimjae dlcservice: Error and Status propagation 2019-06-12 smbarber system_api: add ConnectChunnel method to vm_cicerone 2019-06-12 smbarber system_api: add chunneld D-Bus interface 2019-08-19 akhouderchah system_api: shill: Remove unused kTypeWimax constant Created with: roll-dep src/third_party/cros_system_api Bug: 980171 Change-Id: If66124da790bfa081429c50ef58eaec994426147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789235 Commit-Queue: Zakhar Voit <voit@google.com> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Zakhar Voit <voit@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#694259}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b2b16fad. With Chromium commits locally applied on WPT: 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." c1907c87 "[WPT/common/security-features] Rename common.js to common.sub.js" 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 17df479e "Revert "Temporarily send `Sec-Fetch-*` headers via non-secure transport."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1b041847b0e24b3dc5f1fdc2713e4cbbd5a09af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789443Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694258}
-
Tao Bai authored
This reverts commit 4a10b100. Reason for revert: <INSERT REASONING HERE> Original change's description: > Plumb proper OOPIF compositor viewport rect. > > This CL converts OOPIFs from using a compositor viewport that is the > entire size of the content layer, to a much smaller one based on the > visible intersection of the OOPIF's content with its parent's viewport. > > This should decrease compositor resources used by the OOPIF, and > prevent excessively large tiles being produced. > > Bug: 852348 > Change-Id: I27977e2513d727bc6ba1a414504157cef3436a03 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778362 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694066} TBR=pdr@chromium.org,alexmos@chromium.org,mkwst@chromium.org,wjmaclean@chromium.org Change-Id: Id0cdb4c77487861f8da76dd9de44768097bf480a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789687Reviewed-by:
-
Olga Sharonova authored
TBR=haraken@chromium.org,teib@chromium.org Bug: 1001437,997634 Change-Id: Ia8a7f795d6978a970ddf57ae42137fcb471ea1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789532Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#694256}
-
Armando Miraglia authored
The vulnerability indicated in crbug.com/995964 suggests that the core issue relates to the assumption that device_start_request_queue_ can only contain one occurrence of a controller while this might not be the case. This change makes sure that all occurrence of a controller are removed from the list, instead of removing only the first found. BUG=995964 Change-Id: Ice2a1da37d13339128d3d52d25daa252c5d61155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784726Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#694255}
-
Robbie Gibson authored
The issue with using UIView.appearance.tintColor is that becomes the new default, breaking tintColor's inheritance mechanism. In general, if tintColor is unset, UIKit walks up the view hierarchy until it finds the nearest set tintColor, and uses that. Now, because tintColor is set everywhere through UIAppearance, that never happens. In the linked bug, the close button had a tint set on the UIButton, but not the contained UIImageView. This new method sets the tintColor on the root window, so inheritance still works. If a superview has a provided tintColor, it will apply to any subviews. For a given view, if it and no ancestors have a tintColor, the root window will be the closest ancestor and thus the default. Bug: 1001501 Change-Id: I06b354e56fd43ec8e171be5b4af4b2e3c7c8bbed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789384Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#694254}
-
Eric Stevenson authored
This reverts commit 91053066. Reason for revert: Failures fixed by a0040e3d. Original change's description: > Revert JNI refactor for AwContentsClientBridge.java > > Reverting whole CL has merge conflicts, so quickly reverting this one > more known bad file. > > NOTRY=true > NOPRESUBMIT=true > TBR=estevenson > > Bug: 1000471 > Change-Id: Ica8158d081cb4e7c833787e8196e2cbf792093bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786671 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693733} TBR=agrieve@chromium.org Bug: 1000471, 1000820 Change-Id: I3a79f8af5236eb411458f85923297a8f5720bcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789684 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694253}
-
Theresa Wellington authored
BUG=985622 Change-Id: Id37b9cb7cf04282eb734fc717f2891b34e8ae279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775349 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#694252}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df0ce01870fa..e64cea302acd git log df0ce01870fa..e64cea302acd --date=short --no-merges --format='%ad %ae %s' 2019-09-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 19b256616d96..b218ad19949f (2 commits) Created with: gclient setdep -r src/third_party/angle@e64cea302acd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: I7c4c491d76656f2f820b7454c54808305f202ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789547Reviewed-by:
-
Javier Ernesto Flores Robles authored
Integration test for other password in Manual Fallback. Should fail before the fix (crrev.com/c/1784614) is merged. Bug: 997632 Change-Id: I1c9ea719c85e8ba56fe3a6ca50a1d600e8ad2f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783446Reviewed-by:
-
Dominik Röttsches authored
This reverts commit dcf25ed5. Re-enable field trial config on Windows for FontSrcLocalMatching after bot testing has stabilzied, see issue 996167. Note to sheriffs: Should you see crashes or issues with DWriteFontLookupTableBuilder or testing issues relating to matching @font-face: { src: local() } fonts on Windows, in particular Windows 7, please only revert this CL, preferably not the related one: https://chromium-review.googlesource.com/c/chromium/src/+/1777862 - if you can't reach drott@, try getting in touch with etienneb@ please before reverting. Thanks. Bug: 999787 Change-Id: I47a18fc1c31d0879700378a8924aff23de64997a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787614 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694249}
-
Andrew Grieve authored
Guessing they used to be required for ProGuard. Change-Id: I52d708459530daddbab9a20c82dd743ee3193cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786873 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694248}
-
Olga Sharonova authored
This reverts commit 74ae0216. Reason for revert: Looks like not a root cause Original change's description: > Revert "Delay SharedClipboardShareActivity init if DeviceInfoProvider not loaded" > > This reverts commit 0b7170d7. > > Reason for revert: Speculative: suspected of causing failures of > InfoCollection_basic > InfoCollection_direct_composition > https://ci.chromium.org/p/chromium/builders/ci/Win10%20x64%20Debug%20%28NVIDIA%29/829?blamelist=1#blamelist-tab > > Original change's description: > > Delay SharedClipboardShareActivity init if DeviceInfoProvider not loaded > > > > - Add a JNI method to callback when both DeviceInfoTracker and > > LocalDeviceInfoProvider are ready > > - Also removed redundant setVibration in SharingNotificationUtil > > > > Bug: 996318 > > Change-Id: Id4df6b407ac2fb1c1622071ffb7ee8bb3a747b41 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787379 > > Commit-Queue: Alex Chau <alexchau@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Richard Knoll <knollr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#694208} > > TBR=treib@chromium.org,alexchau@chromium.org,knollr@chromium.org > > Change-Id: I3837352ddf7345751b679f4065b0c00de28d5d43 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 996318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789234 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694223} TBR=treib@chromium.org,olka@chromium.org,alexchau@chromium.org,knollr@chromium.org Change-Id: I377486659e744c6d9f69659e845d6b5d88253fd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789533Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 988278, 860467 Change-Id: Ie77f86b054818f87d9d75531c5d8f160ba8e2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778499 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#694246}
-
Rune Lillesveen authored
Disconnected elements do not have style and ancestor computed styles need to be construced in order to do inheritance. Attempt at adding sanity DCHECKs in StyleResolver failed because of these tests. Change-Id: Ic61abc2dc84ccf0d303fde41900e819b6b0723ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789528 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#694245}
-
Antonio Gomes authored
... and base::flat_set. Instead WTF::String and WTF::HashSet are used, respectively. This is a follow up of [1]. [1] https://crrev.com/c/1785162 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I774b039e67c98fb07c4e01bdb64e5ca8b31c885d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786037 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/565f1b848215..3f05f651ae36 git log 565f1b848215..3f05f651ae36 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 absl-team@google.com Googletest export 2019-09-06 absl-team@google.com Googletest export 2019-09-06 krystian.kuzniarek@gmail.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@3f05f651ae36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: Id6b8a4dd5808ec674050f344332c6add93461845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789465Reviewed-by:
-
Olga Sharonova authored
This reverts commit 3df4743f. Reason for revert: suspected root cause of bug 1001496 BUG: 1001496 TBR:rockot@google.com, alevelthal@chromium.org Original change's description: > Fix LocalizedLandmarkType for contentinfo aria role and <footer> scoped to body > > Change the LocalizedLandmarkType and LocalizedControlType for the > contentinfo aria role from "content info" to "content information" per > https://www.w3.org/TR/core-aam-1.1/#role-map-contentinfo. > > Also update the LocalizedLandmarkType for <footer> when scoped to the > body element to "content information", since it inherits this from > the contentinfo role per https://w3c.github.io/html-aam/#el-footer. > > Note that this doesn't affect <footer>'s LocalizedControlType, > which should be "footer" (but is currently still "content info"). > That is handled in the separate change at > https://chromium-review.googlesource.com/c/chromium/src/+/1763243. > > Bug: 997897 > Change-Id: If958b2090447010f0c0f3839739354dd4a0ea683 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772228 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Dan Clark <daniec@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#693375} TBR=rockot@google.com,aleventhal@chromium.org,kbabbitt@microsoft.com,daniec@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997897 Change-Id: I3da07d47fd4cdd502f2ecbfb191293bcfa95ea2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789295 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Backport some tests in /components/password_manager/core/browser/android_affiliation to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/password_manager/core/browser/android_affiliation. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=engedy@chromium.org Bug: 891670 Change-Id: Ia5d73069ba593026184db80de535de0090617c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786997 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#694241}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d0131152681b..d915f1866fa0 git log d0131152681b..d915f1866fa0 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 vapier@chromium.org sysroot_lib: rename async to background for Python 3.7 Created with: gclient setdep -r src/third_party/chromite@d915f1866fa0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibde134de4b52887170bbae5ee62eb480ab165e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789546Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/19b256616d96..b218ad19949f git log 19b256616d96..b218ad19949f --date=short --no-merges --format='%ad %ae %s' 2019-09-05 stevenperron@google.com Fold Min, Max, and Clamp instructions. (#2836) 2019-09-05 stevenperron@google.com Replace uses of SPV_AMD_shader_trinary_minmax extension (#2835) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b218ad19949f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I259553b5768c437f332e53805ad759a166d8c890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788984Reviewed-by:
-
Alex Chau authored
This would avoid the timer not firing in background for Android Bug: 1001098 Change-Id: I18b8bb3a6b9fdc55a159bd936554c9331392cf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789584 Commit-Queue: Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#694238}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/50b0baf510da..a3baf2a3b165 git log 50b0baf510da..a3baf2a3b165 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 nisse@webrtc.org Add one more BasicPortAllocator constructor 2019-09-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3cccc3ec..df72a9a5 (694083:694187) 2019-09-06 titovartem@webrtc.org Refactor video analyzer injection helper 2019-09-06 nisse@webrtc.org Reland "New build target p2p:stun_types" 2019-09-06 phoglund@webrtc.org Prepare to move packet_socket_factory to api/. Created with: gclient setdep -r src/third_party/webrtc@a3baf2a3b165 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ib9df1e39dfaeb12c3e65804317719f173ca299c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789544Reviewed-by:
-
Jesse Schettler authored
Ensure the print document is being deleted on a non-UI thread when the print session ends. Bug: b:139551164 Test: Close print preview and verify print document is deleted Change-Id: I4e0afbaf2942b7a2fb89b319a3885855243963d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787558 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#694236}
-
Ulan Degenbaev authored
The filtering of GC results is now done by the GC metric. Bug: 1000187 Change-Id: Ie2c43485cef863c96ec92b4509b20c3d36f62c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789285Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#694235}
-
Matt Menke authored
There was a field trial for this two years ago, but it's been left disabled by default since then. We should enable this by default, or remove it. I've opted for the latter. Bug: 705031 Change-Id: I91a93d1b8429e08bb06377a9e379168618e2e815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788324 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#694234}
-
Marc Treib authored
This tags a PasswordForm as coming from either the profile-scoped store or the account-scoped store (or "not set", as the default value or for parsed forms). It will be used to differentiate these credentials in the filling UI and in settings. Bug: 998455 Change-Id: Idb49c7f0a5e659eb0e070c489adedd20bf192c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749187Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#694233}
-
Ilya Nikolaevskiy authored
Bug: webrtc:10925 Change-Id: I7ef59ed0387cbcb43a4c3ba03b807751593d97d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786643 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#694232}
-
Leonard Grey authored
Mac and Aura have different ideas about what it means for a widget to be "active". The check is not necessary on Mac, and certain conditions (for example, opening an internal link via the profile menu) break an important accessibility focus workaround. Bug: 926492 Change-Id: I8a0760f44703c642795396becb0807df473755f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787464Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#694231}
-
Antonio Gomes authored
Now that its child class (WebTransmissionEncodingInfoHandler) has been moved to Blink [1], it can be used directly. [1] https://crrev.com/c/1785162/ BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I6f34a60260c214e7e74e09fc36e8ff7b94a8319d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784906 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
François Beaufort authored
Following https://github.com/gpuweb/gpuweb/pull/327 change, this CL makes GPUSamplerDescriptor optional in GPUDevice.createSampler(). Change-Id: I09f931a7194063960a30a45d585963c9aa180cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789307 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#694229}
-
Joshua Pawlicki authored
Bug: 997862 Change-Id: I4e32c0f5bf8ecc1fe94ac813ab6b7806ea5fca51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772297Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#694228}
-
