GitLab

The frame tree supports remote frames now.

BUG=none

Review URL: https://codereview.chromium.org/1460353002

Cr-Commit-Position: refs/heads/master@{#361002}

- only adjust canvas size in Layers3DView upon resize and onShown;
- fix selection comparison in LayerViewHost to properly check member-wise equality;
- fix LayerTreeOutline's updateLayer() to properly check parent of root node;

BUG=

Review URL: https://codereview.chromium.org/1463143005

Cr-Commit-Position: refs/heads/master@{#361001}

Review URL: https://codereview.chromium.org/1463813003

Cr-Commit-Position: refs/heads/master@{#361000}

This starts to split out UI-manipulating code from the
InterstitialPage-specific methods. The first in a series of
CLs.

BUG=488673
TBR=sky@chromium.org,davidben@chromium.org,isherman@chromium.org

Review URL: https://codereview.chromium.org/1462353002

Cr-Commit-Position: refs/heads/master@{#360999}

BUG=558724

Review URL: https://codereview.chromium.org/1466743004

Cr-Commit-Position: refs/heads/master@{#360998}

scroll operation clears out the m_autoscrollLayoutObject member.

This typically happens when we scroll a div inside an iframe which uses
overflow:auto and during the scroll the cursor leaves the bounds of the div.
If we don't reset the state then the page gets stuck in the autoscroll state
causing it to be unresponsive to clicks etc.

BUG=336373

Review URL: https://codereview.chromium.org/1461473002

Cr-Commit-Position: refs/heads/master@{#360997}

Enables changing values in CastSysInfoDummy for unit testing.

R=halliwell@chromium.org,slan@chromium.org

Review URL: https://codereview.chromium.org/1466003003

Cr-Commit-Position: refs/heads/master@{#360996}

Save creation of ~1000 <paper-item>s (actual number probably depends on OS)
until the fonts page is opened.

This is just a quick-and-dirty solution which shaves off a few seconds
of load time, hopefully making tests less flaky.

BUG=531786

Review URL: https://codereview.chromium.org/1457383006

Cr-Commit-Position: refs/heads/master@{#360995}

BUG=558106

Review URL: https://codereview.chromium.org/1456803002

Cr-Commit-Position: refs/heads/master@{#360994}

R=dschuyler@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1465623008

Cr-Commit-Position: refs/heads/master@{#360993}

This removes uncessary increment loops.

BUG=internal b/23563097

Review URL: https://codereview.chromium.org/1423973002

Cr-Commit-Position: refs/heads/master@{#360992}

Revert of ipc: Add basic memory usage tests for attachment brokering. (patchset #4 id:60001 of https://codereview.chromium.org/1465623002/ )

Reason for revert:
Failing on Mac ASan 64 Tests (1)

Original issue's description:
> ipc: Add basic memory usage tests for attachment brokering.
>
> I added two tests for memory leaks in the attachment brokering process. The
> first checks memory usage after brokering a single, large, shared memory object.
> The second checks memory usage after brokering a thousand, smaller memory
> objects.
>
> BUG=557387
>
> Committed: https://crrev.com/a519e56d03e1f6d69b7475bdd006f5e47b4f581e
> Cr-Commit-Position: refs/heads/master@{#360935}

TBR=tsepez@chromium.org,mark@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557387

Review URL: https://codereview.chromium.org/1466633003

Cr-Commit-Position: refs/heads/master@{#360991}

BUG=549781
TEST=exo_unittests --gtest_filter=DisplayTest.CreatePrimeBuffer

Review URL: https://codereview.chromium.org/1427743004

Cr-Commit-Position: refs/heads/master@{#360990}

Absolute paths are recommended and sort better, switch to absolute
paths instead of relatives.

BUG=None

Review URL: https://codereview.chromium.org/1461143005

Cr-Commit-Position: refs/heads/master@{#360989}

This change updates and simplifies vs_toolchain.py so that it supports
VS 2015 in gn builds. The gn and gyp code now shares DLL copying code so
that they should more naturally stay in sync in the future. The
out_release_nacl64 directory now gets a PGO DLL that it didn't used to.

The six warnings globally disabled are globally disabled in gyp builds
as well. The equivalent warnings (narrowing conversions and variable
shadowing) are disabled in gcc/clang so there is no bug for enabling
them at this time.

BUG=440500

Review URL: https://codereview.chromium.org/1468643002

Cr-Commit-Position: refs/heads/master@{#360988}

BUG=558929

Review URL: https://codereview.chromium.org/1471453003

Cr-Commit-Position: refs/heads/master@{#360987}

Added kCodecALAC value from media::AudioCodec in
media/base/audio_decoder_config.h and HEVC value (from media::CodecInfo
in media/filters/stream_parser_factory.cc).

BUG=none

Review URL: https://codereview.chromium.org/1468683003

Cr-Commit-Position: refs/heads/master@{#360986}

BUG=554183

Review URL: https://codereview.chromium.org/1468513002

Cr-Commit-Position: refs/heads/master@{#360985}

It is always the equal to m_rootGraphicsLayer, since:
  https://codereview.chromium.org/1025543002

Review URL: https://codereview.chromium.org/1459113003

Cr-Commit-Position: refs/heads/master@{#360984}

Revert of [Oilpan] Prepare full definition of classes before using Member (patchset #7 id:120001 of https://codereview.chromium.org/1455943002/ )

Reason for revert:
This CL had two problems.

1) This CL regressed performance for 10% in some tests.
BUG=559311

2) This CL led compile error on win_blink_oilpan_dbg.

Original issue's description:
> Prepare full definition of classes before using Member<T>
>
> What we want to do is to instantiate some templates of
> <T> with T's full definition, in Member<T>::get() and
> Member<T>::checkPointer().
> To guarantee that template instantiations come after
> T's definition, we put static_assert() in Member<T>.
> See the change in platform/heap/Handle.h.
>
> To achieve the condition, this CL does either of
> 1) move implementation of methods using Member<T> from .h to .cpp
> 2) include necessary .h
> (1) can change inline definitions to outline definitions,
> and it may regress performance a bit.
>
> BUG=556947
>
> Committed: https://crrev.com/6486e0c8e845fc96ad9579b7c6b67e4d474f8bb2
> Cr-Commit-Position: refs/heads/master@{#360570}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org,peria@google.com,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556947

Review URL: https://codereview.chromium.org/1461193003

Cr-Commit-Position: refs/heads/master@{#360983}

https://codereview.chromium.org/1457993002 broke the closure compile.

BUG=556394

Review URL: https://codereview.chromium.org/1466473002

Cr-Commit-Position: refs/heads/master@{#360982}

This manually searches the path for python rather than executing "cmd" to find it. This saves about 80ms in run time.

Review URL: https://codereview.chromium.org/1462393003

Cr-Commit-Position: refs/heads/master@{#360981}

After keyboard event routing was updated for out-of-process iframes
(https://codereview.chromium.org/1405293002/), we started routing all
events to the main frame when site isolation is disabled.  This works
fine for things like popup menu widgets, since Blink contains a
codepath for forwarding input events to an active popup widget, if it
exists (see m_pagePopup check in WebViewImpl::handleKeyEvent()) -- so
both before and after, we reach the handling in
WebPagePopupImpl::handleKeyEvent.  Unfortunately, that forwarding
doesn't get hit for fullscreen widgets create for Pepper Flash, so
those widgets fail to receive keyboard events properly.

This CL changes keyboard event routing so that it won't try to look up
focused frames when keyboard events arrive at anything other than the
main frame widget.  I.e., all non-frame widgets like popup menus will
handle key events directly, as was the case before
https://codereview.chromium.org/1405293002/.

BUG=555524

Review URL: https://codereview.chromium.org/1463153002

Cr-Commit-Position: refs/heads/master@{#360980}

NOTRY=true

Review URL: https://codereview.chromium.org/1459373004

Cr-Commit-Position: refs/heads/master@{#360979}

Also set the default heartbeats interval for GCM driver.

BUG=517466

Review URL: https://codereview.chromium.org/1267983002

Cr-Commit-Position: refs/heads/master@{#360978}

ANGLE generates additional shader debug info during program linking.
We would miss this with the current method of caching the extended
translated source. Handle this by refreshing the translated source
after the link operation.

Unfortunately this only currently works with the GPU program cache
disabled, since we don't have the translated source attached to
the shader binaries. Use the --disable-gpu-program-cache flag to
get to the extended info.

BUG=angleproject:1179
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/1463673004

Cr-Commit-Position: refs/heads/master@{#360977}

BUG=426512
TEST=No behavior change

Review URL: https://codereview.chromium.org/1467783002

Cr-Commit-Position: refs/heads/master@{#360976}

Comment "remove this once OrderedSocketData and DelayedSocketData have been
removed" is incorrect, because StaticSocketData also depends on ASYNC writes.
Since there are no short term plans to remove StaticSocketData, this CL removes
the TODO comment.  See comments 4 and 5 on codereview for discussion.

Review URL: https://codereview.chromium.org/1460023002

Cr-Commit-Position: refs/heads/master@{#360975}

Support for CREDENTIAL frames was removed long ago (when SPDY/3 support was
removed).  This CL cleans up remaining unused data members, methods, enum
values, constants, tests, and comments.

Functionality change: incoming CREDENTIAL frames used to be ignored, now they
cause an error.

BUG=311852

Review URL: https://codereview.chromium.org/1461273003

Cr-Commit-Position: refs/heads/master@{#360974}

Adds the Workman keyboard layouts available in modern xkeyboard-config
packages to the Chromium OS builds.

BUG=None
TEST=unit_tests and browser_tests pass, manual testing on device works with new layouts

Review URL: https://codereview.chromium.org/1411603005

Cr-Commit-Position: refs/heads/master@{#360973}

BUG=557900

Review URL: https://codereview.chromium.org/1470593003

Cr-Commit-Position: refs/heads/master@{#360972}

This came up in another CL ( https://codereview.chromium.org/1433253003/ )
where we needed to nullify a private LineLayoutText object and couldn't do
the obvious m_lineLayoutText=nullptr solution. This CL will let anyone do
the obvious thing and have it work properly, without casting or separate
methods.

BUG=499321

Review URL: https://codereview.chromium.org/1460923003

Cr-Commit-Position: refs/heads/master@{#360971}

TBR=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1464983002

Cr-Commit-Position: refs/heads/master@{#360970}

Measure the number of naturally occurring cookies that begin with
$Secure- or $Host- so that we know if cookie prefixes will break real
sites.

BUG=557083

Review URL: https://codereview.chromium.org/1455693007

Cr-Commit-Position: refs/heads/master@{#360969}

Concatenate any required links to the end of the InfoBar's main message
instead of showing them as tertiary buttons.

BUG=543205

Review URL: https://codereview.chromium.org/1455353002

Cr-Commit-Position: refs/heads/master@{#360968}

BUG=558589

Review URL: https://codereview.chromium.org/1463463003

Cr-Commit-Position: refs/heads/master@{#360967}

TBR=caseq@chromium.org

Review URL: https://codereview.chromium.org/1468733002 .

Cr-Commit-Position: refs/heads/master@{#360966}

Additionally, xtends components/test_runner's generated
WebMediaStream to have a ChromeMock AudioTrack and Source

components/test_runner is used by Blink LayoutTest to
generate a MediaStream. But this MS has only Blink-side
objects, whereas some tests (e.g. MediaRecorder) need
to have Chrome counterparts of those objects. This CL
adds those, for audio.

Since components/ has a strict dependency requirement,
the added code goes into a subfolder of
components/test_runner.

BUG=528519,548290

Review URL: https://codereview.chromium.org/1448203002

Cr-Commit-Position: refs/heads/master@{#360965}

Must land at the same time as the ANGLE-side CL to change the gyp, so that we
don't break the GPU FYI bots.

https://android.googlesource.com/platform/external/deqp/+log/92f7752da8..cc0ded6c

BUG=angleproject:1092
R=geofflang@chromium.rog

Review URL: https://codereview.chromium.org/1462133002

Cr-Commit-Position: refs/heads/master@{#360964}

Remove mojo:desktop_ui and mojo:omnibox aliases from core_services.

Note: mojo:desktop_ui wasn't even resolving to mojo://core_services/.
(mojo scheme isn't registered prior to mandoline/app/desktop/main.cc)

Upload the additional mojo:omnibox component with Mandoline binaries.
(mojo:desktop_ui was already being uploaded for the app+resources)

Also, don't build mandoline/ui/phone_ui for Linux desktop builds.

BUG=NONE
TEST=Mandoline still works as intended.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1465843003

Cr-Commit-Position: refs/heads/master@{#360963}