GitLab

"Detab" content/browser/debugger.

BUG=105875
TEST=no change


Review URL: http://codereview.chromium.org/10065017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132193 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=121657
TEST=PluginFinderTest.*


Review URL: http://codereview.chromium.org/10066016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119242
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10084008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132190 0039d316-1c4b-4281-b951-d872f2087c98

This is part of removing more hard-coded file lists from the buildbot
scripts, specifically symsrc_binaries from site_config/config.py.

Review URL: https://chromiumcodereview.appspot.com/10069045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132189 0039d316-1c4b-4281-b951-d872f2087c98

This is needed, because views::Combobox does NOT own its model.

BUG=122092
TEST=play with this dialog, try the comboboxes, they should work as before, and
we shouldn't see any crashes.
R=stevenjb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10050030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132188 0039d316-1c4b-4281-b951-d872f2087c98

and change "Set Wallpaper..." string to "Set wallpaper..."

BUG=120763, 122728
TEST=Loggin as guest, close all browser windows, right click on desktop background,
verify the "Set wallpaper..." option in the context menu is disabled.

Review URL: https://chromiumcodereview.appspot.com/10038020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132187 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132186 0039d316-1c4b-4281-b951-d872f2087c98

R=danno@chromium.org


Review URL: http://codereview.chromium.org/10079001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29235
TEST=

Review URL: https://chromiumcodereview.appspot.com/10065039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromeium-os:28681
TEST=Copy files from the issue to the Downloads folder.

Review URL: https://chromiumcodereview.appspot.com/10082006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132182 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132181 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: http://codereview.chromium.org/10086002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132180 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116954
TEST=none

Review URL: http://codereview.chromium.org/9835049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22836
TEST=Move through the list or grid using arrow keys, observe that the item under the mouse is not highlighted. Move the mouse, observe the hover highlighting.

Review URL: https://chromiumcodereview.appspot.com/10079002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132178 0039d316-1c4b-4281-b951-d872f2087c98

Moved part of code from Options page to upper level so that it can be reused in Plugins page.

BUG=chromium-os:24947
TEST=Tested manually


Review URL: http://codereview.chromium.org/10006028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132177 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=dmikurube@chromium.org
BUG=
TEST=checkperms goes green


Review URL: http://codereview.chromium.org/10083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Hide the root list. Drag a file. Check there is no visual artifacts in the left top corner.

Review URL: https://chromiumcodereview.appspot.com/10086003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132175 0039d316-1c4b-4281-b951-d872f2087c98

It breaks down nonprofiled memory regions (f.k.a. 'unknown') with using information
from /proc/(pid)/maps.
'mustbezero' and 'nonprofiled-*' columns show broken down values.

- mustbezero: works as a sentinel value. it should be '0'. tell dmikurube@ if it > 0.
- nonprofiled-absent: works as a sentinel value. should be '0'.
- nonprofiled-anonymous: may be still 'unknown'. no special info from maps.
- nonprofiled-file-exec: is a mapped file here as executable.
- nonprofiled-file-nonexec: is a mapped file here as non-executable.
- nonprofiled-stack: is a stack.
- nonprofiled-other: includes [vdso] and some small portions.


It also removes dmpolicy (an old one) and adds new policy files: policy.l{0-2}.txt.
The new files 'policy.l{0-2}.txt' are recommended instead of 'dmpolicy'.
policy.l0.txt is the roughest, and policy.l2.txt is the finest breakdown.

We can check that summation from 'FROM_HERE_FOR_TOTAL' till 'UNTIL_HERE_FOR_TOTAL'
is equal to 'total-exclude-profiler'.

Finally, dmprof.py  is renamed into dmprof like pprof in tcmalloc.


BUG=none
TEST=none

Review URL: http://codereview.chromium.org/9812010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132174 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123307
TBR=antonm
Review URL: https://chromiumcodereview.appspot.com/10083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132173 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27832
TEST=manual


Review URL: http://codereview.chromium.org/9956140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132172 0039d316-1c4b-4281-b951-d872f2087c98

Looks like the dependency is accidentially introduced by http://src.chromium.org/viewvc/chrome?view=rev&revision=131801.

BUG=None
TEST=ran unit_tests


Review URL: http://codereview.chromium.org/10008105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118370
TBR=rlarocque
Review URL: https://chromiumcodereview.appspot.com/10079003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10068035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132169 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132168 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: http://codereview.chromium.org/10065036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132167 0039d316-1c4b-4281-b951-d872f2087c98

is able to change network debugging mode without going to crosh.

BUG=chromium-os:25701
TEST=Manual testing on Alex device.


Review URL: http://codereview.chromium.org/10024056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132163 0039d316-1c4b-4281-b951-d872f2087c98

Reason: multiple leak reports on the Memory FYI waterfall (Valgrind, Heapcheck).	

- to avoid file access on IO thread
- to remove duplicated code
- for further FileSystem stream related refactoring

BUG=113300,114999,123302
TEST=FileSystemURLRequestJobTest.*

Review URL: https://chromiumcodereview.appspot.com/10065011

TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10066043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132162 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a test for the "ephemeral users enabled" policy. The
policy prevents persistent information from accumulating by mounting
cryptohome vaults via tmpfs and not writing user preferences to the
local store. Information that previously accumulated on the system is
cleared when the policy is turned on and the first user logs in.

BUG=chromium-os:27702
TEST=New PyAuto: ChromeosEphemeralUsersEnabled.* (ChromeOS)
TEST=Affected PyAutos: prefs.PrefsTest.testHaveLocalStatePrefs,
TEST=    policy.* (ChromeOS, Linux); prefs.* (ChromeOS)

Review URL: http://codereview.chromium.org/9960074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29418
TEST=Run "unit_tests --gtest_filter='*GData*'"


Review URL: http://codereview.chromium.org/10008102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132160 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132159 0039d316-1c4b-4281-b951-d872f2087c98

The cache persistent directory needs to be accessible by the AVFS daemon
to allow mounting of archive files in the gdata cache.

BUG=chromium-os:28678
TEST=Verify the permissions of the cache persistent directory.


Review URL: http://codereview.chromium.org/10072003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132157 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123224

Assert we do not leak requests for the system and safe browsing contexts.

It's possible this will catch some leaks when deployed live. We should be able to analyze the crash dumps and fix the culprits.

BUG=90971
TEST=none


Review URL: http://codereview.chromium.org/10054007

TBR=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10008103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132156 0039d316-1c4b-4281-b951-d872f2087c98

SetCapture of mouse events in partial screenshot. Mouse events are routed to the capture window.  If the user presses Ctrl-Shift-F5 when a context menu appears, all of the mouse events will go to the menu instead of partial screenshot view, which causes unexpected behaviors.

BUG=120653
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/9969149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132155 0039d316-1c4b-4281-b951-d872f2087c98

While we sort out the remaining linker errors, this at least ensures we
can add compliation of a bunch of chrome code for Android to gatekeeper.
This is motivated by having the android unit_tests compilation step
broken 4 out of 4 days this week.

BUG=117407


Review URL: http://codereview.chromium.org/10065018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132154 0039d316-1c4b-4281-b951-d872f2087c98

Move full-screen detection logic from PanelManager to DisplaySettingsProvider.

Also fixed a bug that pnels remain visible with full screen apps on Snow Leopard.
The fix is to also call orderBack/orderFront when full-screen is detected. This is because the full-sreen window is still in normal level and our panel windows stay in the top of z-order when its level is changed to normal.

BUG=123058
TEST=Manual test by launching panels and make an app full-screen


Review URL: http://codereview.chromium.org/10051020

TBR=jianli@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10066041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132153 0039d316-1c4b-4281-b951-d872f2087c98

This change also reorganises the web_app::CreateShortcut code a bit to
allow us to do this without losing any functionality on gtk. Specifically
the ability to create a shortcut on the file thread and get a return value
is still available for Linux, and goes through the web_app code path.

Some of the variable names and comments in web_app.h were also updated
to be clearer.

BUG=None.
TEST=Test that shortcut creation works on Linux, both for platform apps and
  normal hosted apps.


Review URL: http://codereview.chromium.org/9958006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132151 0039d316-1c4b-4281-b951-d872f2087c98

in a second pass I will remove the strings themselves

BUG=122251
TEST=manual


Review URL: http://codereview.chromium.org/10032020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132150 0039d316-1c4b-4281-b951-d872f2087c98

It's wrong to have OnDirectoryChanged in MockGDataSyncClient,
as GDataSyncClient is not interested in the event.

BUG=none
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/10073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132149 0039d316-1c4b-4281-b951-d872f2087c98

And update launcher context menu.

BUG=122428,120472
TEST=Verify fix for issue 122428 and 120472.


Review URL: http://codereview.chromium.org/10066015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132148 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
R=apatrick@chromium.org


Review URL: http://codereview.chromium.org/10065025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132147 0039d316-1c4b-4281-b951-d872f2087c98