GitLab

Added sandbox_linux_unittests test to
linux_arm_cross_compile/linux_arm_tester builders on the
tryserver.chromium waterfall.

R=phajdan.jr@chromium.org
BUG=386445
NOTRY=true

Review URL: https://codereview.chromium.org/342943007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278626 0039d316-1c4b-4281-b951-d872f2087c98

Implement fake methods in TestSearchTermsData to test TemplateURL's code without relying on UIThreadSearchTermsData's behavior.

BUG=371535
TEST=unit_tests

Review URL: https://codereview.chromium.org/344083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278625 0039d316-1c4b-4281-b951-d872f2087c98

Generated using
src/tools/metrics/histograms/update_use_counter_feature_enum.py

Corresponding Blink changes:
https://codereview.chromium.org/337283003 (by mahesh.kk@sumsung.com)
https://codereview.chromium.org/339563004 (by me)

NOTRY=true
BUG=383749

Review URL: https://codereview.chromium.org/342113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278624 0039d316-1c4b-4281-b951-d872f2087c98

Isolate the Linux-only nacl_loader_unittests.

BUG=384515
TBR=maruel
NOTRY=true

Review URL: https://codereview.chromium.org/322333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278620 0039d316-1c4b-4281-b951-d872f2087c98

The source of the flakiness should have been fixed in r277688

BUG=171450

Review URL: https://codereview.chromium.org/337213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278619 0039d316-1c4b-4281-b951-d872f2087c98

This adds a few experimental versions of the new malware interstitial. They are all teh addition of an extra string.

1. Prior history
2. "(not recommended)" next to link
3. Advice
4. Social proof

BUG=386033

Review URL: https://codereview.chromium.org/346733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278618 0039d316-1c4b-4281-b951-d872f2087c98

This CL also re-enables NaClBrowserTestNewlib.Bad. This test was
disabled because there were unautomated "visual tests" embeded in the
test's html. These embeds declared a pdf content type.  When the PDF
plugin was open sourced, this content type started being recognized
and the test broke.

This test was historically flaky, however. One reason  was that pauses
caused by the OS crash catcher could cause the test to time out. The
OS crash catcher was triggering because NaCl calls abort() in response
to many fatal errors. This test is being re-enabled to show abort is
no longer triggering the crash catcher.

BUG=375103

Review URL: https://codereview.chromium.org/347803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278617 0039d316-1c4b-4281-b951-d872f2087c98

Fix up some references in content and webkit for targets that now exist.

TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/344873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278616 0039d316-1c4b-4281-b951-d872f2087c98

This makes the backspace key on the qwerty keyboard to behave like
an emulaed backspace key on a braille display when the IME is in braille
keyboard on standard keyboard mode.

BUG=310285
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/348533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278615 0039d316-1c4b-4281-b951-d872f2087c98

WTHMojo was unable to observe bounds changes from its associated Node. Instead WTHMojo is now bound to a Node & derives bounds from it.

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/341953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278614 0039d316-1c4b-4281-b951-d872f2087c98

patch from issue 342553006

BUG=
android failures unrelated to this CL
NOTRY=True

Review URL: https://codereview.chromium.org/344793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278613 0039d316-1c4b-4281-b951-d872f2087c98

Current value is at 50k, which is actually the average log
size on a lot of platforms. Increase it to 100k for a more
reasonable default that should cover the majority of cases
where logs are discarded due to this size limit according
to UMA data.

BUG=380282

Review URL: https://codereview.chromium.org/313613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278612 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278611 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/30e6e2af14e84216b1c113fd7500d0822bc81daa..9efd66b8451f25465abd1027e09a3bcfa7b9c554

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=reed@google.com
BUG=
android_aosp failure unrelated
NOTRY=True

Review URL: https://codereview.chromium.org/338893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3881

Review URL: https://codereview.chromium.org/345733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278609 0039d316-1c4b-4281-b951-d872f2087c98

These components are needed by chrome/common.

This also adds a "components" meta-target to avoid listing all components in the root build file.

TBR=blundell

Review URL: https://codereview.chromium.org/344993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278608 0039d316-1c4b-4281-b951-d872f2087c98

This tool has not been maintained or used in a while, and tools such as UMDH work well as a replacement.

BUG=383024

Review URL: https://codereview.chromium.org/314253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357693

Review URL: https://codereview.chromium.org/345733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278606 0039d316-1c4b-4281-b951-d872f2087c98

Instead of storing full copies of every backing file's path, re-generate
the paths as needed.

BUG=none

Review URL: https://codereview.chromium.org/340893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278605 0039d316-1c4b-4281-b951-d872f2087c98

When a layer adds a tiling, it syncs to its pending/active twin and
adds the tiling there. We "cleverly" do an UpdateTilePriorities() then
immediately if possible. But now UpdateTilePriorities() does much more
than it used to, and also adds new tilings etc, which can cause a sync
back to the other twin and re-entrancy and bad things.

Instead, split everything that isn't updating tiles priorities off to
UpdateTiles() which calls UpdateTilePriorities(), and have
UpdateDrawProperties() call that instead. This way syncing only updates
priorities, and doesn't do things like adding new tilings or changing
what is considered high res.

R=enne
BUG=386076

Review URL: https://codereview.chromium.org/343653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239879

Review URL: https://codereview.chromium.org/345493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278603 0039d316-1c4b-4281-b951-d872f2087c98

The current code is causing issues on the "Chromium Win Clang" builder,
and also contains redundancies and unneeded repacements for existing function.

BUG=82385

Review URL: https://codereview.chromium.org/343433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278602 0039d316-1c4b-4281-b951-d872f2087c98

Now extension_icon_image and image_loader are safe to be used
outside of Chrome, like AppShell/Athena.

BUG=159265, 380421
R=yoz@chromium.org, jamescook@chromium.org
TBR=sky@chromium.org, fmalita@chromium.org
TEST=unit_tests, compile succeeds

Review URL: https://codereview.chromium.org/334053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278601 0039d316-1c4b-4281-b951-d872f2087c98

It crashes while warming up the sandbox, deep inside QueryInterface

BUG=385781
TEST=see bug

Review URL: https://codereview.chromium.org/342903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375416

Review URL: https://codereview.chromium.org/345533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278599 0039d316-1c4b-4281-b951-d872f2087c98

Chrome will already link to EGL/GLES if/when it needs to.
We need not explicitly set these libraries via link settings.

This works around the fact that the chromeos arm-generic board does not
currently use EGL/GLES.  It uses GLX and OpenGL as provided by mesa's
xlib-glx.  In order to satisfy these hard coded -lEGL -lGLES linker
settings, arm-generic was forced to build a dummy EGL/GLES implementation.
Without these link settings, we can remove the dummy opengles.

BUG=chromium:330163
TEST=build chrome on arm-generic and peach_pi using
     simple chrome
TEST=emerge chromeos-chrome on arm-generic and peach_pi
     in cros chroot
TEST=For peach_pi: build video_encode_accelerator_unittest,
     scp to device and run
TEST=For peach_pi: build video_decode_accelerator_unittest,
     scp to device and run

Review URL: https://codereview.chromium.org/335393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278598 0039d316-1c4b-4281-b951-d872f2087c98

The problem:
Sync observes Invalidator state to decide whenever to use PreCommit GU
optimization, therefore INVALIDATIONS_ENABLED should be reported only
when it is certain that communication channel between client and
invalidations server works both ways.
SyncNetworkChannel::NotifyStateChange is currently used for two purposes:
- Notify observers of invalidations about InvalidatorState
- Nudge cacheinvalidations to send heartbeat on network status change.
Because of this dual purpose it is called with INVALIDATIONS_ENABLED when
network status changes. In this case sync is notified that invalidations
are enabled while there is no GCM connection established.

Solution:
- Separate two purposes into separate functions and call them appropriately
- Only set INVALIDATIONS_ENABLED when it is confirmed that both http and
gcm channels are working.

BUG=377911
R=rlarocque@chromium.org,zea@chromium.org

Review URL: https://codereview.chromium.org/348503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278597 0039d316-1c4b-4281-b951-d872f2087c98

The removes a check on initialization, because the key may be set
after initialization but before use.

BUG=382977

Review URL: https://codereview.chromium.org/347803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278596 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds BluetoothGattConnectionChromeOS and implements
BluetoothDeviceChromeOS::CreateGattConnection. At this point, creating
a connection simply calls org.bluez.Device1.Connect without pairing.
BluetoothGattConnectionChromeOS::Disconnect currently doesn't do anything,
at least until there is a system in bluetoothd for managing GATT connections
properly between Chrome and its profiles and plugins.

BUG=384620,381305
TEST=device_unittests

Review URL: https://codereview.chromium.org/333983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278595 0039d316-1c4b-4281-b951-d872f2087c98

With this change we rely on Service.Visible and only use
Manager.Services to determine which services to observe.

BUG=384380
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/330833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278594 0039d316-1c4b-4281-b951-d872f2087c98

As an intermediate step to disambiguate notifications
at notification UI manager level, we rename notification_id()
to delegate_id() to clarify that it is not an id for
notification in message center.

Also change assignment operator of message center's
notification to protected. Other members are still used by
notification list so they need to be public.

BUG=297867

Review URL: https://codereview.chromium.org/344763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384944
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/345853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278592 0039d316-1c4b-4281-b951-d872f2087c98

There is also a page transition animation to wait for after timer is fired.

BUG=385167

Review URL: https://codereview.chromium.org/344793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278591 0039d316-1c4b-4281-b951-d872f2087c98

This will allow experimentation to occur in M37 without concern about
blowing out memory.  A more thorough memory limit re-evaluation
is expected in M38.

BUG=374917
R=cbentzel@chromium.org

Review URL: https://codereview.chromium.org/342523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278590 0039d316-1c4b-4281-b951-d872f2087c98

 gfx::ImageKia will fetch the ImageSkiaRep based on resource scale factor (supported one) and scale accordingly.

BUG=381601
TEST=covered by test.
R=ananta@chromium.org, pkotwicz@chromium.org, rsesek@chromium.org

Review URL: https://codereview.chromium.org/340613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278589 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a DummySearchBoxView to the experimental app list which
forwards its input to the AppListMainView search box in a similar way
to the NTP's fakebox.

BUG=349727

Review URL: https://codereview.chromium.org/335343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385744
R=jar@chromium.org

Review URL: https://codereview.chromium.org/341553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278587 0039d316-1c4b-4281-b951-d872f2087c98

This adds more of the chrome/common target. The sources don't all compile yet so this is commented out.

Add many resources targets required my chrome/common.

R=thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/348663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278586 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/333153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278571 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278568 0039d316-1c4b-4281-b951-d872f2087c98