- 09 Dec, 2019 40 commits
-
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=drubery@chromium.org Bug: 1023677 Change-Id: I7fa9add0daaa2d43314ffaadd836db539bfd5b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957541 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#722989}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0027820ae2e2..2bca61df7746 git log 0027820ae2e2..2bca61df7746 --date=short --first-parent --format='%ad %ae %s' 2019-12-09 mathias@chromium.org Add `npm run check` command that runs all checks 2019-12-09 mathias@chromium.org Add maskable icon “safe area” overlay functionality 2019-12-09 mathias@chromium.org Restore `npm run check-json` functionality Created with: gclient setdep -r src/third_party/devtools-frontend/src@2bca61df7746 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027658 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id161eb397450e40be0e7e3bd5320d47237945af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722988}
-
Roman Sorokin authored
* Store all details from 'add' calls. * Use the passwordBytes chosen by token from 'confirm' call. * Not break existing behavior when there is not 'confirm' calls (use the last password from 'add' in that case) * Added corresponding tests. Bug: 1032073 Change-Id: I6ee39bfcc9f865985fbcdc45adea5f68965f9a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953739Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722987}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1023677 Change-Id: I7ebcfed80192fd9277ff386e58ee1b9e53f98686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957535 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#722986}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f0148c4881df..62836903bcc7 git log f0148c4881df..62836903bcc7 --date=short --first-parent --format='%ad %ae %s' 2019-12-09 kjlubick@google.com [canvaskit] Expose SkShader combiners 2019-12-09 nigeltao@google.com Add SK_WUFFS_FAVORS_PERFORMANCE_OVER_ADDITIONAL_MEMORY_SAFETY option Created with: gclient setdep -r src/third_party/skia@62836903bcc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Id0ac69ad4c4a64d9e9a66930b50320dd319b38f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958152Reviewed-by:
-
Vladimir Levin authored
This patch fixes two of the obvious uses of an unintended copies when using auto. The right hand size has a static cast to a const&, and auto cannot deduce to be a reference, which causes a copy. The fix is to use a (const) auto& instead. R=dcheng@chromium.org, kenrb@chromium.org Change-Id: I5f772d507312be3fd6a5034cd5afa6b3bc143e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955912Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722984}
-
proberge authored
The logging was a bit confusing if there were no child process logs. This makes things a bit clearer. Bug: 1030333 Change-Id: I26f0fdc47686ce1b79a2c85e8f3a9bc0bab07567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955036Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#722983}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3087709197f9..254d7a04716e Created with: gclient setdep -r src-internal@254d7a04716e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5b273817bb5e545a3e6d2f136150df41fecb2d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958155Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722982}
-
Pâris MEULEMAN authored
Align ProfileOAuth2TokenServiceDelegate's name for Android with other implementations: in Java this changes OAuth2TokenService to ProfileOAuth2TokenServiceDelegate and in C++ this change OAuth2TokenServiceDelegateAndroid to ProfileOAuth2TokenServiceDelegateAndroid. Also mark ProfileOAuth2TokenServiceDelegate ctor package private. The whole class could not be made package private due to ProfileOAuth2TokenServiceDelegate.STORED_ACCOUNTS_KEY which is accessed from other packages. The constructor is not private as used in tests. This change was partially performed automatically with the following commands: git grep -l oauth2_token_service_delegate_android| xargs sed s/oauth2_token_service_delegate_android/profile_oauth2_token_service_delegate_android/g -i git grep -l OAuth2TokenService *.java | xargs sed s/OAuth2TokenService/ProfileOAuth2TokenServiceDelegate/g -i git grep -l OAuth2TokenService.java | xargs sed s/OAuth2TokenService.java/ProfileOAuth2TokenServiceDelegate.java/g -i git grep -l OAuth2TokenServiceTest.java | xargs sed s/OAuth2TokenServiceTest.java/ProfileOAuth2TokenServiceDelegateTest.java/g -i Bug: 934688 Change-Id: I903d82d00ee9f64532f988e02758870481f7d1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780831 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#722981}
-
Joe Mason authored
This reverts commit cfdc33b0. Reason for revert: Didn't update annotations.xml, causes failing presubmits on some CL's. Original change's description: > Add links to proto files in chrome_cleaner NetworkTrafficAnnotations > > R=proberge > > Bug: 1027231 > Change-Id: I431ff44a2ca46f4942e75bb8261e9599cd96459f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953673 > Auto-Submit: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: proberge <proberge@chromium.org> > Reviewed-by: proberge <proberge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722135} TBR=joenotcharles@chromium.org,proberge@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027231 Change-Id: I13fc7f44b1be01a239bff65d7f683c8c60888351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955867Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#722980}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dtapuska@chromium.org Bug: 1023677 Change-Id: Idb4ea8dca1699c875afb60c965fa0aea7c7d787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957529 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#722979}
-
Matt Menke authored
The prevent cross-site side-channels that can be used to identify users across different browsing contexts, we're splitting most network information by NetworkIsolationKey, which can be determined from the RenderFrameHost. This CL makes WebPrescientNetworkingImpl pass a render frame ID to the browser process when performing a DNS prefetch, which is then used to issue the prefetch with the frames NetworkIsolationKey. Unfortunately, when splitting the host cache by NIK is enabled, this will prevent DNS prefetches issued by a frame with one NIK from being used for a frame with another NIK, but that's exactly the sort of information leakage this effort is intended to protect against. TBR=tbansal@chromium.org Bug: 997049 Change-Id: Ic255e0d1c977bc58af0a34090ea9c80dc59a1d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924704 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722978}
-
Mohamed Amir Yosef authored
In the meanwhile, multiple CLs have addressed most of the limitations on the MultiStorePasswordSaveManager while the comment was left untoched. This CL simply updates the outdated comment. Bug: 1012203 Change-Id: Id4a71d45ba28d82ad3ed3b5a3870975a6a0156c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955556 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#722977}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1023677 Change-Id: I484965f114f1b2a756db05ca91c3dcdbd7f3769a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957525 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Maksim Moskvitin authored
These tests are flaky and causes a lot of failures on linux-chromeos-google-rel. TBR=mek@chromium.org,cmp@chromium.org Bug: 1031088, 1031087, 1031086, 1031085, 1030837 Change-Id: I64f1029b46a1270fc61b26537e2273968c8806ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955557 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#722975}
-
Gordon Guan authored
The memory pressure handler of SoftwareImageDecodeCache currently purges all unlocked cache entries upon a critical memory pressure notification. These cache entries are primarily composed of discardable memory. However, the DiscardableSharedMemoryManager purges all unlocked discardable memory upon a critical memory pressure notification as well. It is expected that all unlocked cache entries have their respective discardable memory unlocked. Remove the unnecessary memory pressure handler in order to: - Reduce the number of memory pressure notification consumers - Reduce work performed during memory pressure handling (cache walk) Change-Id: I196b6da65ca961cdbc525869e419f37999d4f453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951134Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Gordon Guan <gordonguan@google.com> Commit-Queue: Gordon Guan <gordonguan@google.com> Cr-Commit-Position: refs/heads/master@{#722974}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 1023677 Change-Id: If3ba46aba2288d6daafb817c01364ef0d1b085da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955083Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#722973}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d519167d2ecb..ff61c18f1bbc git log d519167d2ecb..ff61c18f1bbc --date=short --first-parent --format='%ad %ae %s' 2019-12-09 johnkslang@users.noreply.github.com Merge pull request #2018 from KhronosGroup/fix-2007-rationalize-include-paths Created with: gclient setdep -r src/third_party/glslang/src@ff61c18f1bbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliot@google.com Change-Id: Ibc0f3e00fa88f38f076a0d71db4143451cd8f627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958153Reviewed-by:
-
Aaron Tagliaboschi authored
This reverts commit b7fd7c5a. Reason for revert: Mac user agent strings were not properly accounted for Original change's description: > [client-hints] Populate 'sec-ch-ua-model' and 'sec-ch-ua-arch' > > A smidge of refactoring for the user agent string code as well. > > Bug: 1001125 > Change-Id: I2ae97922d546b64a93bf55ef81ec40e30c765032 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951446 > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722970} TBR=avi@chromium.org,torne@chromium.org,yoavweiss@chromium.org,aarontag@chromium.org Change-Id: Iad1db0a43a7edebbc558edf31c401998bf4c8b73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955037Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#722971}
-
Aaron Tagliaboschi authored
A smidge of refactoring for the user agent string code as well. Bug: 1001125 Change-Id: I2ae97922d546b64a93bf55ef81ec40e30c765032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951446Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#722970}
-
Xiyuan Xia authored
Add DisplayTest, DisplayTransformHint to verify Display output size is expected for the combination of display transform hint and whether the output surface supports display transform hint. Bug: 1031043 Change-Id: I295798268fdde818b37a4fee7ed6097346ed17e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956121Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#722969}
-
Vasiliy Telezhnikov authored
This CL extracts surface damage tracking logic from DisplayScheduler to new class DisplayDamageTracker. After the change DisplayScheduler is only doing deadline planning based on damage information from tracker. Bug: 805739 Change-Id: Ibafb6e17a6ab9a3b2e0db466dcc031059896f50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944631Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#722968}
-
Markus Handell authored
Depending on timestamps recorded in WebM files, this test which uses ffmpeg to convert WebRTC peer connection video to .yuv video format will sometimes misinterpret the framerate in the recorded WebM file. This causes the resulting .yuv file to be gigantic (several GB) with loads of duplicate frames. That confuses frame_analyzer which is used in the test to compute video Ssim. The fix is to convert every frame in the WebM file to it's own YUV frame, and we accomplish this by passing -vsync=passthrough to the ffmpeg invocation. Bug: 1032031 Change-Id: I372d766561d2568ce7bd5d1c15cea27b50063202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953630Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#722967}
-
Bruce Long authored
ResolveLocaleName should only fail if buffer size insufficient, but it can succeed yet return an empty string for certain language tags such as ht. Fix is to not DCHECK when ResolveLocaleName fails to return a valid locale name, and instead fallback to the unresolved name. Also adds DVLOG logging when a language with no platform dictionary support is encountered (like zh-CN). Bug: 1031556 Change-Id: I2602f247742b9ccf96c885339f6390639f6cf981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955801Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#722966}
-
Simon Que authored
CI builders: -GPU FYI Win x64 Builder -GPU FYI Win x64 Builder (dbg) -GPU FYI XR Win x64 Builder -GPU FYI Win x64 dEQP Builder -GPU FYI Win x64 DX12 Vulkan Builder -GPU FYI Win x64 DX12 Vulkan Builder (dbg) -GPU Win x64 Builder (dbg) -Dawn Win10 x64 Builder -Dawn Win10 x64 DEPS Builder Try builders: -win-angle-rel-64 -gpu-fyi-try-win7-nvidia-rel-64 -gpu-fyi-try-win7-nvidia-dqp-64 -gpu-fyi-try-win10-intel-dqp-64 -gpu-fyi-try-win10-intel-exp-64 -gpu-fyi-try-win10-intel-rel-64 -gpu-fyi-try-win10-nvidia-dx12vk-dbg-64 -gpu-fyi-try-win10-nvidia-dx12vk-rel-64 -gpu-fyi-try-win10-nvidia-dqp-64 -gpu-fyi-try-win10-nvidia-exp-64 -gpu-fyi-try-win10-nvidia-rel-64 -gpu-fyi-try-win10-nvidia-skgl-64 -gpu-fyi-try-win10-nvidia-dbg-64 -gpu-fyi-try-win-xr-builder-64 -win-angle-deqp-rel-64 -win_optional_gpu_tests_rel -win_chromium_x64_rel_ng -win-dawn-rel -dawn-win10-x64-deps-rel Migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I9aaffd688b627ecc5ef6c159d9cdcb83b4342a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924345Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#722965}
-
Samuel Huang authored
DISABLED_OneShotAccessibilityTreeSearchTets.* were added on 2019-10-16 in: https://chromium-review.googlesource.com/c/chromium/src/+/1854682 and have been failing android-asan bot (Nexus 5) ever since. This CL fixes the typo 'Tets' to 'Test' in speculative hope that it will fix the problem. Also fix same typo (but non-suffix) in CheckAddedDepsHaveTetsApprovalsTest => CheckAddedDepsHaveTestApprovalsTest for good measure. Change-Id: If3205f5b336d335e6397becec001c05f70ce6b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956009Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722964}
-
Samuel Huang authored
This reverts commit c61c6764. Reason for reland: Fixed bug: Some deps were not moved from old target "resources" to new target "dev_ui_browser_resources". Original change's description: > Revert "[DevUI DFM] Move 17 chrome:// pages to DFM, via new dev_ui_browser_resources.pak." > > This reverts commit 852ad1d0. > > Reason for revert: Suspected to break compile on mac-archive-rel > > TBR=thakis@chromium.org,huangs@chromium.org,agrieve@chromium.org > > Change-Id: I93a24570c0be77d5fc1dad2342e83ea5d9bead25 > Bug: 927131 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956013 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722591} > > Original change's description: > > [DevUI DFM] Move 17 chrome:// pages to DFM, via new dev_ui_browser_resources.pak. > > > > Bug: 927131 > > Change-Id: Ideaf57e2997b4621d7ffdfea8c126bf78688c322 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954458 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Samuel Huang <huangs@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#722576} TBR=thakis@chromium.org,huangs@chromium.org,agrieve@chromium.org,karandeepb@chromium.org Bug: 927131 Change-Id: Ia314430669020262960f5f401991cd7f5e9328c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957162Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. base::SingleThreadTaskExecutor is equivalent to base::MessageLoop This CL was uploaded by git cl split. R=mseaborn@chromium.org Bug: 891670 Change-Id: I6bb0215dc9c5a26f560ab6bf689676c5c5d6a583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944498 Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Cr-Commit-Position: refs/heads/master@{#722962}
-
David Roger authored
This changes forces a flush of the preferences, so that it reduces the likelihood of a browser crash happening after the token has been added to the token service, but before the prefs are flushed. If such a crash happens, then on next restart, there will be an unknown account in the token service, which will trigger a DCHECK on startup. This CL is not 100% reliable, but should greatly reduce the risks. Note that this doesn't address other cases such as the preference file being corrupted. A possible future improvement would be to delete the tokens for unknown accounts at startup. Bug: 1031688 Change-Id: I448a47f4d2f2c6a630f35fdb274116e98d970b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953734Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#722961}
-
Ankit Kumar 🌪️ authored
In CL:1934130 for PDF highlights kMark role replaced kButton role. While retrieving static text node for a highlight node the check still has a kButton as the expected role type. This CL replaces the kButton role type with kMark role type for the same. Bug: 1008775 Change-Id: Ia49eef757c71194173d35e71177e3fc5fb4a3fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957747Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#722960} -
Hazem Ashmawy authored
A crash report is skipped because it's either sampled out or the user had changed their consent for crash collection (opted out). The crash report file will then be marked as skipped and left for a while so the user can see it in the Crash UI. Add a button for skipped crash reports to force upload them. This will mark the file as forced to be uploaded and then schedule a new upload job to upload all files available to be uploaded including that file. Bug: 1014821 Test: Manually Invoke crash -> skip by opting-out -> press force upload Test: run_android_webview_junit_tests -f "*ServiceNamesTest*" Change-Id: I829ea46e76a3c123d98975327b796dd3161105a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924519 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#722959}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 1023677 Change-Id: Iaf83112499e3e179cd3fbd733ee6a6ccb9c4e534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957554 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d2d2d7630206..d1980c3a28d4 git log d2d2d7630206..d1980c3a28d4 --date=short --first-parent --format='%ad %ae %s' 2019-12-09 achuith@chromium.org cros_update: Use /usr/local/tmp instead. 2019-12-08 vapier@chromium.org run_tests: check for old test entries 2019-12-07 vapier@chromium.org cidb: delete unused GetBuildMessagesNewerThanmethod 2019-12-07 vapier@chromium.org cidb: delete unused GetKeyVals method 2019-12-07 vapier@chromium.org paygen: filelib/partition_lib: use binary mode in more places 2019-12-07 vapier@chromium.org cidb: drop unused GetAnnotationsForBuilds method 2019-12-07 vapier@chromium.org cidb: drop unused ExtendDeadline/GetTimeToDeadline methods 2019-12-07 andrewlamb@chromium.org Generate platform C files in replicate_private_config. 2019-12-06 dgagnon@google.com Update gen_luci_scheduler with R80 branch 2019-12-06 vapier@chromium.org IsMasterCQ: drop dead logic 2019-12-06 lamontjones@chromium.org toolchain: updating PrepareForBuild handlers. 2019-12-06 vapier@chromium.org cros_install_debug_syms: fix encoding issues 2019-12-06 vapier@chromium.org signing: update OWNERS Created with: gclient setdep -r src/third_party/chromite@d1980c3a28d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ie57dbcf768202af2f54ed420664b5f56ebbf0346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958150Reviewed-by:
-
Victor-Gabriel Savu authored
Testers are not able to use vmc, allow root to call LockToSingleUser to not break their workflows. Used by crrev.com/c/1958005 TEST=manual on device Bug: chromium:1031985 Change-Id: I1d0008247dcdcb156c4a12830acc4e14ef3faec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954510Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#722956}
-
Robert Sesek authored
Change-Id: I0d3f76b1b71adc37ac60017cc84de305579eaf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955035Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#722955}
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: I7b79ba66e4f5a3ff04213ac74084d293432ce690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956052Reviewed-by:
-
Yuki Shiino authored
Implements if-else if-...-else chain. Bug: 839389 Change-Id: Ib9a86fe2acf2c768f8ee09e2ff1d177f65596a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958248 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#722953}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/31916f494c2e..84d0f7cbbb9b git log 31916f494c2e..84d0f7cbbb9b --date=short --first-parent --format='%ad %ae %s' 2019-12-09 amaiorano@google.com Revert "Fix materialization of function arguments" 2019-12-09 bclayton@google.com Kokoro: Add ReactorUnitTests to windows presubmits 2019-12-09 capn@google.com Remove coverage asserts for tested code Created with: gclient setdep -r src/third_party/swiftshader@84d0f7cbbb9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I969c36ecb675f4649058585df3a984763388ade6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958148Reviewed-by:
-
Ben Kelly authored
Bug: 954442 Change-Id: Ie788a333d2e2abfc5d0ba3585e607926e9bd91cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956046Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#722951}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/429eb56a9844..e691a2e65ced git log 429eb56a9844..e691a2e65ced --date=short --first-parent --format='%ad %ae %s' 2019-12-09 treehugger-gerrit@google.com Merge "protozero: add dependency on src/base" Created with: gclient setdep -r src/third_party/perfetto@e691a2e65ced If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I978d51919ee23449b531d4e39b39a9677eb9669d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958151Reviewed-by:
-
