- 04 Nov, 2020 40 commits
-
-
Peter E Conn authored
This CL takes the Mojo changes from: https://chromium-review.googlesource.com/c/chromium/src/+/2484038 and adds an Android implementation for them. Once these mojo changes are wired up on the Blink side, I'll add some tests to DigitalGoodsTests. Bug: 1139795 Change-Id: Ib8c92cbc619b8977f37d3a9b59a3045d5c1bbb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510271 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824001}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b049cadeb140..0bd50c9043c7 2020-11-04 wl@gnu.org Typo. 2020-11-04 wl@gnu.org docs/CHANGES: Updated. 2020-11-03 heftig Fix documentation build. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC drott@google.com,thestig@google.com,bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: drott@google.com,thestig@google.com,bungeman@google.com Change-Id: Ibc858fb318df6e41726fef1abe2091a2de3faef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824000}
-
Filip Gorski authored
Change-Id: I65a0590b3d745b0a209ae8c7a7fc634e50ac4f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518728Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#823999}
-
K. Moon authored
The experiment to disable PDF partial loading was successful, so we're making it the default now. The PdfPartialLoading and PdfIncrementalLoading features will be kept for now for tests that rely on these features (often to test mostly unrelated behaviors). Fixed: 1115149 Change-Id: Iea45106f919d1fa608fcf6cfc28e432c88d4d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505972 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#823998}
-
Rayan Kanso authored
Also disable it for WebLayer since it doesn't work in that context. Bug: 1051508 Change-Id: I5368d2c803547cccb54e0e981a77b688ec528a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516702 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#823997}
-
Andrew Grieve authored
This reverts commit 16ccdc07. Reason for reland: CL did improve some metrics. Original change's description: > Revert "Android: Remove -fprofile-sample-accurate from blink core" > > This reverts commit c2bb3798. > > Reason for revert: Reverting to see what perf alerts fire. > > Original change's description: > > Android: Remove -fprofile-sample-accurate from blink core > > > > This trades off some size for performance. > > > > Binary-Size: Trading size for speed > > Bug: 1125115 > > Change-Id: If18e8ef4449dec6aab4494fa7d04063d8d94b845 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491540 > > Reviewed-by: George Burgess <gbiv@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819964} > > Bug: 1125115 > Change-Id: Iebce1fffa79b590fd015d0054f9fe2da9e3bb3a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498088 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: George Burgess <gbiv@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822847} Bug: 1125115 Change-Id: I62345561bb892ba49da433f692caf317b96a1837 Binary-Size: Trading size for perf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514376 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#823996}
-
Sigurd Schneider authored
Flags removed: --harmony-import-meta https://crrev.com/c/2509943 --harmony-dynamic-import https://crrev.com/c/2509942 Bug: v8:6693, v8:5785 Change-Id: I0628db7d48f4991c185fd6f8e9f49d5f7eb91094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517685Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#823995}
-
zhiyuancai authored
Bug: 997250 Change-Id: I929aed84f8a7bee7371506a731dd453d10597662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490032 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823994}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/962b067540..e9e9b9fc74 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/962b067540..e9e9b9fc74 No .def file changes. Bug: None Change-Id: Idc3bf05ba596c683c9088d5e9fd9e6ad739b9bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517945Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#823993}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/97469f4abe0a..a8f4c91114b5 2020-11-04 kjlubick@google.com [canvaskit] Expose MakeRasterDirectSurface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I2e0d87ea46e2966327128d205f4574fb663e6a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519169Reviewed-by:
-
Illia Klimov authored
This CL fixes an issue caused by the initializetion of ScopedFeatureList in a multithread environment. Bug: 1143265, 1143584, 1143505, 1143035 Change-Id: I711cebe4a1743a01095359d93e991601603b2d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518055 Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823991}
-
Michael Thiessen authored
Updates imports in chrome/android/javatests/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: I9e789401078f5b9245b14e821cf1990b1e33acc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518893 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#823990}
-
David Tseng authored
This reverts commit 176b96aa. Reason for revert: <INSERT REASONING HERE> Tts .so works with this in a non-default config; error in config during testing. Follow up with the right perms for default build. Original change's description: > Give tts service sysinfo syscall perms > > As of > https://chromium-review.googlesource.com/c/chromium/src/+/2510736 > > the tts service, which runs a prebuilt containing tensorFlow, now asks for > sysinfo. > > R=mpdenton@chromium.org > > Test: patch the above change and makes sure the tts works. > Change-Id: If578d0bb6617390a5919ac33b4b04970a33da317 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514759 > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823347} TBR=dtseng@chromium.org,mpdenton@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I17009ffe0468e096c522fe18700c19735b5572d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519713Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823989}
-
kylechar authored
This reverts commit afc72427. Reason for revert: Speculative revert for Windows GPU process failing to start in debug. See https://crbug.com/1145558. Original change's description: > Reland "Only pass executable sections to OnDllLoaded for patching" > > This is a reland of df9e203b > > Original change's description: > > Only pass executable sections to OnDllLoaded for patching > > > > On recent Windows insider builds GetModuleHandleExW loads sections for > > inspection as non-executable images, rather than as files. This leads > > to our hooks detecting the SEC_IMAGE attribute and potentially patching > > functions (e.g. for user32.dll). > > > > This caused content_browsertests to fail as it pinned user32.dll in some > > processes. With this change, the tests run again. > > > > See crbug.com/1143397 for a full discussion. > > > > Bug: 1143397 > > Change-Id: I3b75464d0442160a417e4cb7084306841aaf76f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511531 > > Reviewed-by: Will Harris <wfh@chromium.org> > > Commit-Queue: Alex Gough <ajgo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823354} > > Bug: 1143397 > Change-Id: Ibacc1ba6105665c32ea445a7f63178163585efbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515783 > Auto-Submit: Alex Gough <ajgo@chromium.org> > Commit-Queue: Alex Gough <ajgo@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823679} TBR=wfh@chromium.org,ajgo@chromium.org Change-Id: I8d37d7dae54327ea84d9d2d327bb183a18c5337a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143397, 1145558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518917Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#823988}
-
Nick Diego Yamane authored
Context: Wayland Protocol needed to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. This patch contains the first round of Wayland Ozone backend (client side) changes needed to leverage the extended-drag protocol extension to implement the remaining tab/window dragging missing features, whereas the main one is the ability to set a toplevel shell surface (browser window) as the "dragged surface", making it to be anchored to the pointer cursor as it's dragged around, as well as being smoothly droppable anywhere in the workspace, which is not possible with the standard Wayland DND protocol. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=msisov@chromium.org Bug: 896640, 1099418 Change-Id: I8a19670fd4ad64d49a9aa202548c22065870dd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401319 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#823987}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604468747-3cefb59c2b4481c91d9a2d5b4d4a31bc448420c5.profdata to chrome-linux-master-1604491008-3c33d4506f1877c8f5c193fdb795c1a4d1ae6438.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iae7902b0f8b79fcd28b77986ec391e44dadfc8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519165Reviewed-by:
-
Sorin Jianu authored
There could be executions path in the code where early returns in the callback implementations return an empty vector instead of a vector of CrxComponent of the same size as the input parameter of the callback. When this occurs, the original code indexes out of bounds and crashes. With the fix, if the callback returns fewer values than the number of components checked for updates, the UpdateClient::Update call is rejected by the update engine, and completed with a specific error code. Bug: 1144880 Change-Id: If45910c7c9ea0ca940b2d5a3d936b96a31d9c684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518001Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823985}
-
arthursonzogni authored
This is intended to be merged into M87 Beta M87. This is actually the #3 crasher on 87.0.4280.38 I have no clue what the problem is here. This patch removes the consequences of the bug, not the cause. This is caused by receiving RFH::OnAssociatedInterfaceRequest() after the process has called ResetIPC and the RenderFrameHost has called InvalidateMojoConnection(). This patch just ignore the call when this happens, because it doesn't expect receiving any call from the renderer anymore. Bug: 1123438 Change-Id: I1ada1d3a27f53198afc84ec56f00e0a278fdbd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517586Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#823984}
-
Titouan Rigoudy authored
This removes our reliance on RenderFrameHostImpl::last_successful_url(), which is discouraged, and more directly checks that an error page is committed or not. Fixed: chromium:1137741 Change-Id: I59f51bdc2802011e82f573fb49c8ace6bb0de402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517559 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#823983}
-
Stephane Zermatten authored
This change extends the on_top filter to allow controlling: - whether it should call scrollIntoViewIfNeeded - whether it should accept element that it cannot check, because they are outside of the viewport Bug: b/171464034 Change-Id: Ifa7de037325a10ca4c5ed5fe45d962f5289e8c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513646 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#823982}
-
Frédéric Wang authored
This CL removes the title argument from registerProtocolHandler() as agreed in the WHATWG [1]. See also the discussion on the blink-dev mailing list [2]. The only other browser implementation was in Firefox but it has been removed [3]. [1] https://github.com/whatwg/html/pull/5425 [2] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cZh5f1Ymj14/rLz2Xsy0BAAJ [3] https://groups.google.com/d/msg/mozilla.dev.platform/T633aemFPJU/dbv5_iB8AgAJ Bug: 1072461 Change-Id: Ia9f60203939fc756950d511c923a3e9dd2256100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157531 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823981}
-
Corentin Wallez authored
In python3 map() return an iterable but doesn't actually do the map yet, so the exception for the file being on another drive was produced in code later and not caught. Force the expansion of the iterable using list(map(...)). Bug: 941669 Change-Id: I4f56f25a42cab102f4cd2f988907a60ec7e816af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517583Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#823980}
-
Rune Lillesveen authored
Change-Id: I182f05b751b12cd30ff44f6cb09b6c13cb128510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519450 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#823979}
-
Kevin Ellis authored
Addresses regression introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2369433 ComputedStyleUtils::ComputedPropertyValue can return a null value if the value cannot be parsed, which leads to a potential null pointer dereference. Bug: 1126364 Change-Id: I31a74283a4cbfe9c6875fb9c832d6085ab21ae39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517044Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#823978}
-
Francois Doray authored
On startup, ::NtQuerySystemInformation() is invoked to get the number of hard faults and determine if the startup is "warm" or "cold". The function can fail if the provided buffer is too small. In that case, we resize the buffer to the size requested by the function and we retry. In some cases, the size returned by the function is very large (> 1 MB). It is undesirable to invoke a function to fill a large buffer just to record startup histograms. This CL does not get the hard fault count if it requires a buffer with a size >= 512 KB. The failure to get the hard fault count is reported in the "undetermined" bucket of the Startup.Temperature histogram. Histograms suffixed with the startup temperature are obviously not recorded. Bug: 1085716 Change-Id: I0864a2af26e07cddcab4e094d344473ccbb5b9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302829Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#823977}
-
Christian Dullweber authored
This reverts commit 7b6fabaa. Reason for revert: Lots of crostini tests are failing since https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11029 Original change's description: > Reland "Reland "Crostini settings string changes."" > > This is a reland of 6b11534a > > OK, this time for sure. The tast-test change below was submitted, but the > relevant ChromeOS uprev was blocked for days. This is now through so we > can reland again, for real this time. > > Original change's description: > > Reland "Crostini settings string changes." > > > > This is a reland of da531d49 > > > > Now that https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2505407 > > is landed, this should be safe. > > > > Original change's description: > > > Crostini settings string changes. > > > > > > Instead of "Linux (Beta)", now shows as "Developers" > > > > > > Bug: 1140370 > > > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 > > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > > Reviewed-by: David Munro <davidmunro@google.com> > > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#820205} > > > > Bug: 1140370 > > Change-Id: Ibb5bd28f9647847dddaf109e9da86d91b17dd863 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505324 > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: David Munro <davidmunro@google.com> > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822525} > > Bug: 1140370 > Change-Id: I76e0dfa45877db5d633a70126c0f5bd2a70a15f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515799 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823503} TBR=khorimoto@chromium.org,nverne@chromium.org,davidmunro@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140370 Change-Id: Icc3b386e702e544e153d1e8893e5781a281d29c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519452Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823976}
-
Ewann authored
This CL updates the behavior of the Done button according to the other buttons on the top Toolbar. Bug: 1140518 Change-Id: I9e34024c4826a47fb9547ba3d0966f50596fbd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512917Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#823975}
-
Piotr Tworek authored
This is probably best illustrated by the following piece of stack trace obtained from chromium 87.0.4276.2 built against libstdc++ instead of libcxx: # base::debug::CollectStackTrace() # base::debug::StackTrace::StackTrace() # logging::LogMessage::~LogMessage() # logging::LogMessage::~LogMessage() # base::internal::LockImpl::Try() # base::SequenceCheckerImpl::CalledOnValidSequence() # base::internal::WeakReference::Flag::Invalidate() # base::internal::WeakReferenceOwner::~WeakReferenceOwner() # content::ServiceWorkerRegistrationObjectHost::~ServiceWorkerRegistrationObjectHost() # std::unique_ptr<>::~unique_ptr() # std::_Rb_tree<>::_M_drop_node() # std::_Rb_tree<>::_M_erase() # content::ServiceWorkerContainerHost::~ServiceWorkerContainerHost() # std::default_delete<>::operator()() # content::ServiceWorkerHost::~ServiceWorkerHost() # std::default_delete<>::operator()() # std::unique_ptr<>::~unique_ptr() # content::ServiceWorkerVersion::~ServiceWorkerVersion() # content::ServiceWorkerRegistration::~ServiceWorkerRegistration() # content::ServiceWorkerRegistrationObjectHost::~ServiceWorkerRegistrationObjectHost() Its important to note here that all the calls to the ~ServiceWrokerRegistrationObjectHost happen with the same "this" object, meaning this is a double-delete bug. It only happens with libstdc++ due to a difference in std::map::erase method implementation. The difference is illustrated by the following example. #include <map> #include <memory> #include <stdio.h> struct A; std::map<int, std::unique_ptr<A>> g_map; struct A { ~A() { printf("Map size on A DTOR call: %zd\n", g_map.size()); } }; int main(int argc, char* argv[]) { g_map[0] = std::make_unique<A>(); g_map.erase(0); } When compiled with clang trunk on goldbot.org with -stdlib=libc++ command line argument the size of std::map is reported as 0. When using the same compiler but with -stdlib=libstdc++ arg specified instead, the size is reported as 1. As far as I can tell the behavior here is not defined by any C++ standard version, its an implementation detail. Bug: 957519, 1135070 Change-Id: Ic7d354c2129cdf790f4731a01f8c995021d23eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509793 Commit-Queue: Piotr Tworek <ptworek@vewd.com> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#823974}
-
Renato Silva authored
LoginPinInput and LoginPasswordView view should not accept digits from the pin pad when they are read only. This fixes an issue that would trigger multiple authentication attempts when the digits are inserted too fast on the pin pad when using a PIN. Additionally, these elements will make themselves read only prior to invoking an authentication attempt and prevent any further attempts until they are no longer ReadOnly. Fixed: 1133902 Bug: 1136379 Change-Id: I12dcb158b856ac1407f55220af583e9df2a39b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489883Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#823973}
-
Travis Skare authored
For enterprises: enterprises may enable the feature, or enable did-you-mean without checks, as they know their machines' path to DNS servers. For non-enterprise users: Adds a feature to roll out a new default-off behavior. A heuristic-based approach for non-enterprise users will follow, though likely in a future milestone. Bug: 1090985, 1090985 Change-Id: I536129341c3a3eced640dd7af9d3cdf025ee28c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380212 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#823972}
-
Ramin Halavati authored
Ephemeral Guest profiles are not off-the-record. The tests are updated to cover this. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Icc1b2782ffd153ad158fecd060f325fdacfcd8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518973Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604468747-33d374fd721b6c3bc2da01359a5fc589bd022b47.profdata to chrome-mac-master-1604491008-5013724a12e21f5f9a4783fc91443d2909a128dc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8b3bfaef972af2df54cacad8822d07157cc0cce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519164Reviewed-by:
-
Sergey Poromov authored
This restriction will control access to the confidential content by websites/extensions using 3P Web/Extensions Screen Casting API, e.g.: 1) https://www.w3.org/TR/screen-capture/ 2) https://developer.chrome.com/extensions/desktopCapture 3) https://developer.chrome.com/extensions/tabCapture These API are mostly used for screen share, e.g.Google Meet, or 3P screen capture extensions, e.g.Screencastify. Bug: 1134566 Change-Id: I25dbf7b8a548c5884f81cf0d1d37308b000a8863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514206 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#823969}
-
Jinho Bang authored
It is an assert error. According to the method's description[1], we should assert that it is NOT zero. Bug: none Change-Id: I3da2e4006a147d256b4980878ae279dd9b4ee548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519535Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#823968}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af90f011ae79..5399fa01a3e1 2020-11-04 petermueller@chromium.org Add thin feedback icon 2020-11-04 tonykostowny@gmail.com Clear network search input on new instance of DevTools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099160 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic380bfee3c1733a92544f569a597ac3fd69e5fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519355Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/938932225cef..97469f4abe0a 2020-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c3b9f252 to 1f9589cf (438 revisions) 2020-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3bf9f4a2e65e to db8766bb239b (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I01bb981470df271c678f0c8e265100a8557a7307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518906Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/43ef0a365b84..9d6265bc0725 2020-11-04 cwallez@chromium.org Fix examples when using the wire. 2020-11-04 cwallez@chromium.org Rolling 7 dependencies 2020-11-04 jiawei.shao@intel.com Remove DAWN_NATIVE_EXPORT declaration from dawn_platform::Platform 2020-11-04 shaobo.yan@intel.com Support internal pipelines for Dawn 2020-11-03 cwallez@chromium.org DEPS: Download clang-format from hashes in buildtools 2020-11-03 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from fc5a9cfaf70c to de6938789ccb (13 revisions) 2020-11-03 cwallez@chromium.org Add the -Wdeprecated-copy-dtor warning. 2020-11-03 cwallez@chromium.org Add the disallow_unsafe_apis toggle. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1138528 Tbr: cwallez@google.com Change-Id: I8d0bd6b3d8c29cddc94bf4d6dc3ebee01351444f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518392Reviewed-by:
-
Andreea Costinas authored
Currently System-proxy sends the policy set credentials with every connect request to a remote proxy. Since less secure authentication schemes send the credentials in clear to the proxy, an attacker can easily obtain the policy set credentials. This CL allows admins to restrict the auth schemes for which System-proxy can use the policy set credentials. - manually tested proxies set by extensions (managed and user installed extensions) Bug: 1132247 Test: - browser_tests --gtest_filter=SystemProxyManagerPolicyCredentialsBrowserTest Change-Id: I4583762b565ec43bfdad8be4c6db87d3e2bec223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484444Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#823964}
-
Antonio Gomes authored
.... over chromeos::TabletState::Observer. This CL is a follow up of crrev.com/c/2491517. It gets rid of chromeos::TabletState::Observer class in favor of display::DisplayObserver::OnDisplayTabletStateChanged(). The CL also removes the use of the `friend class` declaration in chromeos::TabletState: ash::TabletModeController now sets the tablet state through display::DisplayManager -> display::DisplayObserver::OnDisplayTabletStateChanged(). Last, the CL deliberately did not got rid of chromeos::TabletState class. Reason: TabletState can continue to be a central read-only class for query the tablet state from any where in the source base. BUG=1113900 R=jamescook@chromium.org Change-Id: I532e8511c1173139937c36c5e4c282311ea17576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518128 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#823963}
-
Bartek Nowierski authored
On most systems partition page size is 16kB, but there are systems where it isn't true. Bug: 1144990, 11297512 Change-Id: I7c0b00e15b0ed210b293f0d17f33743c6974c82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517229 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
