GitLab

Review URL: https://codereview.chromium.org/403573006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284241 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces a utility class AwAssets, accessible by native,
which is able to retrieve references (fd + offset + size) of assets
inside the apk. This is to enable direct mmap of uncompressed assets.
This change does NOT introduce yet any change to the WebView apk itself.
At current state, no behavioral change is intended.

BUG=394502

Review URL: https://codereview.chromium.org/401743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284238 0039d316-1c4b-4281-b951-d872f2087c98

I'm adding signin_scoped_device_id to DeviceInfoSpecifics.
This value is available from SigninClient, the rest of code is to pass
value from syncBackendHostImpl where SigninClient is availble to
SyncedDeviceTracker where value is passed to protobuf.

Also there is small change to how commandline flag is handled.

BUG=382968
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/395013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284234 0039d316-1c4b-4281-b951-d872f2087c98

The extension code was hardcoded to use the default audio and video devices.
This change actually respects the requested ids (if given).

BUG=388428

Review URL: https://codereview.chromium.org/405483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284233 0039d316-1c4b-4281-b951-d872f2087c98

ChannelFactory doesn't create any channel and it just listens on
and accepts from a unix socket. So this change renames it to
represent what it actually does.

R=darin@chromium.org,cpu@chromium.org,jeremya@chromium.org,tapted@chromium.org
TEST=none
BUG=377980

Review URL: https://codereview.chromium.org/305973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284231 0039d316-1c4b-4281-b951-d872f2087c98

- updated GetProp() calls to go through DeviceUtils
- changed iptable DNAT rules to explicitly specify the host ip in
  destination address.  This is to fix the case where 127.0.0.1 is
  sometimes used as the dest ip

BUG=

Review URL: https://codereview.chromium.org/398003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284229 0039d316-1c4b-4281-b951-d872f2087c98

Adds support for updating the target of an in-progress input-triggered impl-side scroll offset animation, keeping the velocity function continuous.

BUG=575

Review URL: https://codereview.chromium.org/393713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284228 0039d316-1c4b-4281-b951-d872f2087c98

This is including some refactoring with the DestopScreenX11 implementation.

TBR=sky@chromium.org (for BUILD.gn changes because brettw@ doens't formally own it)

BUG=122863,162827

Review URL: https://codereview.chromium.org/341983008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284227 0039d316-1c4b-4281-b951-d872f2087c98

- Use '+' sign for out of country call, except US.
- Keep valid national number input as it is.

R=isherman@chromium.org
BUG=98911

Review URL: https://codereview.chromium.org/355823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284226 0039d316-1c4b-4281-b951-d872f2087c98

R=vitalybuka@chromium.org
BUG=395008

Review URL: https://codereview.chromium.org/399143009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284225 0039d316-1c4b-4281-b951-d872f2087c98

It is possible for the TaskRunner to which the tasks were posted
to be destroyed before the RenderWidgetResizeHelper is destroyed.
Make sure that RenderWidgetResizeHelper is robust to this by having
tasks remove themselves from RenderWidgetResizeHelper's queue
when they are destroyed.

BUG=394775
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/399213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284224 0039d316-1c4b-4281-b951-d872f2087c98

This has visible effect on the Mac, where WebContents has zero size initially.

BUG=none

Review URL: https://codereview.chromium.org/391363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395168

Review URL: https://codereview.chromium.org/407563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394441
R=asargent@chromium.org, asvitkine@chromium.org, vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/391413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284221 0039d316-1c4b-4281-b951-d872f2087c98

Increasing wait time for document's state to become 'complete'.

BUG=

Review URL: https://codereview.chromium.org/395133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284220 0039d316-1c4b-4281-b951-d872f2087c98

The browser test can print webpages to PDFs, then convert those PDFs to PNGs and send them to the layout test framework for an image diff. This is for print preview end to end testing.

BUG=388517

Review URL: https://codereview.chromium.org/383623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284219 0039d316-1c4b-4281-b951-d872f2087c98

During a forced signout (sync account removed from device), we signout without ever
give the token service a chance to validate accounts. Without this CL, the AO2TS
becomes out-of-sync with the device's account list.

BUG=393037

Review URL: https://codereview.chromium.org/401693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/400283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284217 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/401883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284216 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/401983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284215 0039d316-1c4b-4281-b951-d872f2087c98

To correspond to changes made in internal change 70990265.

BUG=

Review URL: https://codereview.chromium.org/399433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284214 0039d316-1c4b-4281-b951-d872f2087c98

Use the separate x/y sigma version of 
SkDropShadowImageFilter's Create() factory, so we can remove 
the single-param one from Skia.

R=danakj@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284213 0039d316-1c4b-4281-b951-d872f2087c98

All trivial.

Review URL: https://codereview.chromium.org/397933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284212 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies the management and will also make the conversion to GN easier.

BUG=299841
TEST=ui_unittests
R=yukishiino@chromium.org

Review URL: https://codereview.chromium.org/365303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284211 0039d316-1c4b-4281-b951-d872f2087c98

This allows specifying the shared_library MODULE_EXPORT constant so that stub
symbols can be called across shared library boundaries.

BUG=none
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/403493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284210 0039d316-1c4b-4281-b951-d872f2087c98

Picked up changes:
047ef5d Hookup the MarkupParser into title detection.
885a0af Also track whitespace text in TextBlocks.
39ef3db Add more colors to debug output.
0577e31 Add comments about UnicodePatternGenerator ranges
805c65e Simplify iteration in *RulesClassifier
fe610d7 Make debug output colorful
edc26e0 Introduce a DomDistillerTestSuite for running multiple tests in one context.
7a7f948 Convert relative "poster" attribute to absolute for HTML5 video.
73225c7 Remove unused Clone method from TextDocument/TextBlock.
bb65cef Don't merge non-content lists with trailing content.
3d00eba check for opacity for element visibility
79f3bae ignore invisible page links
8416ada Allow DocumentTitleMatchClassifier to match repeated titles.
8dade4b Fix id check for comment exclusion.
7f91f0d improve heuristics for tables in eval set
5fa3c95 Make DomDistiller's text-only output include all extracted text.

BUG=367233,368941,376107,378385,380792,381973

Review URL: https://codereview.chromium.org/403803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284208 0039d316-1c4b-4281-b951-d872f2087c98

This is being done with the intention to port this tool to other
platforms. The first step is to move the existing code to a common
location.

Review URL: https://codereview.chromium.org/402803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284207 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/396213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284206 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup and adding GetCongestionControlType.

Merge internal change: 71125139
https://codereview.chromium.org/400813002/


QUIC test only change to add track the observed loss rate in
SendAlgorithmSimulator.

Merge internal change: 71116533
https://codereview.chromium.org/399763004/


Minor formatting changes to keep the code similar to internal tree.

Merge internal change: 71059110
https://codereview.chromium.org/393283005/


Add more testing to QUIC's BbrTcpSender to verify it shares bandwidth
fairly with itself.

Also includes fixes to SendAlgorithmSimulator.

Merge internal change: 71000950
https://codereview.chromium.org/399793002/


Will merge BbrTcpSender changes in a future CL after the approvals.

Add a DLOG that indicates the peer sent us a QUIC_PUBLIC_RESET. Makes it
more obvious why the connection ended when running the quic_client.

Merge internal change: 70900278
https://codereview.chromium.org/399793002/


QUIC test only change to add a convenience operator for printing
SendAlgorithmSimulator stats.

Merge internal change: 70897829
https://codereview.chromium.org/399773003/


Adds dynamic setting of FEC group size based on the connection's current
congestion window.

There will be two triggers for transmitted an FEC packet, when
protection is required -- max_packets_per_fec_group, and an FEC alarm
that triggers an FEC packet if the FEC group has been open for long
enough. This CL implements dynamically setting
max_packets_per_fec_group. The FEC alarm will be written in a
subsequent CL.

Merge internal change: 70821636
https://codereview.chromium.org/398873003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/399153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284205 0039d316-1c4b-4281-b951-d872f2087c98

This update was generated on ChromeOS with:

chromite/licensing/licenses --board x86-alex -a -out about_os_credits.html

BUG=chromium:379056
TEST=Diffed license files, the changes appear to match reality.



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284204 0039d316-1c4b-4281-b951-d872f2087c98

The synthetic delay macro initializes a local atomic variable to point
to a delay implementation class. Because initializing the class involves
writing data to memory which is subsequently deferences through the
atomic pointer, we need to use memory barries when updating the pointer
to make sure the data behind it is committed.

Thanks to Alexander Potapenko for spotting this.

Review URL: https://codereview.chromium.org/392933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284203 0039d316-1c4b-4281-b951-d872f2087c98

This will be used as part of a resource/permission manager which will allow users to easily see and modify which permissions are being granted to which websites.

Design Doc: https://docs.google.com/document/d/1oQwmj3AU4QYhTyGrYEGr6zaZhHUfx-wqUgEcQGbUU-U/edit?usp=sharing

BUG=372607

Review URL: https://codereview.chromium.org/398373006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/388963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284201 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup namespace usage in cast_channel_api.h.

TESTED=Browser test.  Manually with Cast extension
BUG=331165

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266804

Review URL: https://codereview.chromium.org/255443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284200 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Experimentally disable termination on heap corrruption in order to measure the contribution of this… (https://codereview.chromium.org/402723002/)

Reason for revert:
Crashes chromium.perf bots.

	ChildEBP RetAddr  
	0052f9f4 6a47d2ff chrome_69f00000!base::debug::BreakDebugger+0x10
	0052fa64 6a47df08 chrome_69f00000!CheckIsChromeSxSProcess+0x26
	0052fa68 6a47e664 chrome_69f00000!InstallUtil::IsChromeSxSProcess+0x16
	0052fa70 6a47e53b chrome_69f00000!BrowserDistribution::GetSpecificDistribution+0x3b
	0052fa78 6a47bb77 chrome_69f00000!BrowserDistribution::GetDistribution+0x7
	0052fb64 6a47bb2e chrome_69f00000!`anonymous namespace'::GetChromeChannelInternal+0x2c
	0052fb7c 6a2d03f8 chrome_69f00000!GoogleUpdateSettings::GetChromeChannel+0x21
	0052fbe8 6a2cd0d8 chrome_69f00000!chrome::VersionInfo::GetChannel+0x60
	0052fbec 6a2cd1ab chrome_69f00000!`anonymous namespace'::GetBeaconKeyPath+0x5
	0052fc08 6a2cc624 chrome_69f00000!ShouldExperimentallyDisableTerminateOnHeapCorruption+0xe
	0052fc50 0020720b chrome_69f00000!ChromeMain+0x42
	0052fce0 00206c36 chrome!MainDllLoader::Launch+0x15f
	0052fd24 00228c9e chrome!wWinMain+0x5a
	0052fd70 766e338a chrome!__tmainCRTStartup+0xfd
	WARNING: Stack unwind information not available. Following frames may be wrong.
	0052fd7c 76f99f72 kernel32!BaseThreadInitThunk+0x12
	0052fdbc 76f99f45 ntdll!RtlInitializeExceptionChain+0x63
	0052fdd4 00000000 ntdll!RtlInitializeExceptionChain+0x36

Original issue's description:
> Experimentally disable termination on heap corruption in order to measure the contribution of this feature to missing crash reports.
> 
> Because this feature is configured very early in the process lifetime it cannot be directly controlled by a field-trial. Rather, we query the status during a given execution, store that status in the registry, and then query the registry during startup. This means the experiment will only take effect the 2nd time it is executed.
> 
> BUG=394842
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284100

TBR=jochen@chromium.org,brettw@chromium.org,jhawkins@chromium.org,wfh@chromium.org,erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=394842

Review URL: https://codereview.chromium.org/401913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284197 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: use-after-free with #3 0x897b331 in
views::NativeViewHostAura::ClippingWindowDelegate::CanFocus()
ui/views/controls/native/native_view_host_aura.cc:43 in the stack trace.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/5437

> Make NativeViewHostAura clipping window non-focusable.
> 
> This CL fixes an issue where the clipping window would get a focus event
> when the SadTab was displayed causing the focus to be set to nothing,
> disabling all keyboard shortcuts.
> 
> This is fixed by making the clipping window nonfocusable.
> 
> BUG=393119
> 
> Review URL: https://codereview.chromium.org/397493005

TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/403853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284196 0039d316-1c4b-4281-b951-d872f2087c98

Split up the monstrously large platform_crypto_nss.cc, platform_crypto_openssl.cc into multiple files.

-----------
Overview:
-----------

* algorithm_implementation.h:

This defines a base class AlgorithmImplementation, which has virtual methods for synchronous encrypt/decrypt/generatekey. All of the information about an algorithm is now encapsulated by an AlgorithmImplementation. So for instance the JWK specific knowledge, key usages for each key type are pulled into this interface.

* algorithm_registry.cc:

Contains a mapping from WebCryptoAlgorithmID --> AlgorithmImplementation, stored by a singleton.

* algorithm_dispatch.cc:

Given parameters from Blink, looks up the appropriate AlgorithmImplementation in the registry and dispatches the operation. Also implements wrap/unwrap in terms of encrypt/decrypt.

* structured_clone.cc:

Contains the code related to structured cloning (which still needs some cleanup, and is implemented in terms of import/export).

* nss/*, openssl/*:

Contains the AlgorithmImplementation concrete classes for each algorithm. 

This reorganization also unintentionally fixes a few bugs.

  * ExportKey() for spki/pkcs8/raw uses the already serialized key data rather than re-exporting
  * Some exception codes were fixed.

BUG=389325,389342,389327,374912

Review URL: https://codereview.chromium.org/379383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284192 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to https://codereview.chromium.org/393193003/ .
-fno-slp-vectorize was passed before -O2 on linux, and -O2 would
reenable it. I checked that the order of -O3 and -fno-slp-vectorize
is correct as-is on Mac.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/408523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284191 0039d316-1c4b-4281-b951-d872f2087c98

stdafx.h declared a global winstorage namespace alias, this file
declared a winstorage namespace alias in an unnamed namespace.
clang correctly points out that

  error(clang): reference to 'winstorage' is ambiguous
  note(clang): candidate found by name lookup is 'winstorage'
  note(clang): candidate found by name lookup is '(anonymous namespace)::winstorage'

Just remove the unneeded duplicate.

BUG=82385
TBR=ananta@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/393083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284190 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284189 0039d316-1c4b-4281-b951-d872f2087c98