- 20 Apr, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/devtools. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=pfeldman@chromium.org Bug: 714018 Change-Id: I8247fc695ed397a148f7e42f3d2c6529c03673a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132213 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#760522}
-
Becca Hughes authored
This reverts commit ae8f4133. Reason for revert: Crashes Original change's description: > [Media History] Retain refs and remove fatal > > Retains refs to the store when using callbacks > and also change the fatal -> error for sql > errors since it is making bots crash. > > Change-Id: Ie27d43f2044700e1b299d2a34406b1eb2fc9412b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149405 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759814} TBR=beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib90f55a1176af4ace35d0e421fc5b0ba667ccadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157165Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#760521}
-
Bo Liu authored
Read system setting and set preferred_color_scheme. Refactor code a bit to mirror password_echo_enabled. Same as password_echo_enabled, check system changes when fragment becomes foreground. Bug: 1070701 Change-Id: Iafcbf6886f8d2f1be474d87759d546182be1562f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153829Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760520}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4cd3c7a92530..be6eaf0a3d07 Created with: gclient setdep -r src-internal@be6eaf0a3d07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: Iea5caa4d72518b047e60f1e0f411b0998f94b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156443Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760519}
-
Peng Huang authored
There is an issue in NVIDIA driver, vkCreateSwapChianKHR() will fail with sandbox on Windows, if the gpu::SurfaceHandle(HWND) is created by browser process. Workaround the issue, by creating a child HWND use to create VulkanSurface. Bug: 962633,1068742 Change-Id: I471db2e1db673fece37a5746b5e42a8cf9d12965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152707 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#760518}
-
Brian Malcolm authored
BUG=950273 R=poromov Change-Id: I9ca6bec9a05b179d8cfe31c5f4a78a76bb20cbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153764Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#760517}
-
Pablo Ceballos authored
BUG=b:151160990 TEST=chromeos_unittests --gtest_filter="IpPeripheralServiceClientTest.*" Change-Id: I7ae2cd64a7c0dc4ae927142e015a8930965462d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134805 Commit-Queue: Pablo Ceballos <pceballos@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Ted Choc authored
BUG=1071247 Change-Id: I145041673b9e9779d2a342178cf26146da12cc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156108Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760515}
-
Ted Choc authored
The aim is to remove Criteria as a concept and use Assertions directly in Runnables. BUG=1071247 Change-Id: Ia68c918d3a0759333abbaaa1db236f1147b8ed8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156070Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760514}
-
Rohit Rao authored
The policy unittests need to bring up a real ChromeBrowserState because some prefs are registered in BookmarkModelFactory::RegisterBrowserStatePrefs(). BUG=None Change-Id: Ie2dddb0e41d739f240e447caf0dcaa525c22562a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155984 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#760513}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6b265ec1dc9d..8c693ae8890f git log 6b265ec1dc9d..8c693ae8890f --date=short --first-parent --format='%ad %ae %s' 2020-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 454ab259c1b8..8824107d57d3 (1 commits) 2020-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader d25ce8725224..068611f07d28 (8 commits) Created with: gclient setdep -r src/third_party/angle@8c693ae8890f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I5fce99e6cd6fdbee4ab1af1b2ad37bf7b4bc1243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760512}
-
Andrew Grieve authored
I can find only one reference to it: within //third_party/catapult. I believe catapult uses vpython, so shouldn't need this. It was added in 776da3a8, but the code there doesn't look to exist anymore. Bug: None Change-Id: Ie9636ad86474310b6ea4432dcad0e00cb2bcbfb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156746 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#760511}
-
Sean Gilhuly authored
Initialize Vulkan for both Skia Vulkan and for Skia Dawn on Linux. Vulkan and Dawn both require OOP-R, so replace use_vulkan() with either use_skia_vulkan() or use_oopr(), depending on context. Bug: 1021566 Change-Id: I68c4f789252fa700bd78ec01a44e03df6f1fc0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135006Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#760510}
-
Peter Kotwicz authored
This CL changes WebappInfo#setWebappIntentExtras() to copy the desired intent extras from the source intent instead of operating on WebappInfo. This is part 1/3 of removing WebappInfo usage in WebappLauncherActivity. The CL also merges WebappIntentUtils#copyWebApkShellLaunchTime() and WebappIntentUtils#copyNewStyleWebApkSplashShownTime() into WebappIntentUtils#copyWebApkLaunchIntentExtras(). BUG=1069311 TEST=WebappIntentUtilsTest Change-Id: I8cd014aab4ea7f39dfceca479901cb5a95231c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146788Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760509}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5d440647d3a2..449b1157a738 git log 5d440647d3a2..449b1157a738 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 brianosman@google.com Plumb SkMatrixProvider throughout Ganesh Created with: gclient setdep -r src/third_party/skia@449b1157a738 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: Ida36a5d259fd00ebfee9e8bfc2ca2a55670a079c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156444Reviewed-by:
-
Ulan Degenbaev authored
This merges kDevTools and kEnabled Blink GC trace categories so that all Blink GC events that are enabled by default are also emitted to "devtools.timeline" category. This allows offline/postmortem investigation of GC performance issues based on JSON trace. There is not need to change DevTools frontend because it whitelists trace events by name. Bug: 1072352 Change-Id: Ie827727b6fe62335c849c107438b45eb41edaa88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156496 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760507}
-
kylechar authored
Currently on Windows when the browser UI thread finds out the HWND is about to resized it blocks until any pipelined swap buffer calls have been issued. This is because if swap buffer is called when the framebuffer and window size don't match D3D will scale the texture to fit which stretches everything. For software compositing this doesn't appear to be an issue because D3D isn't involved. The direct composition path also doesn't appear to need this, since it creates a child HWND in the GPU process and draws to that. The child HWND isn't being resized by the browser so there is no stretching. This CL changes the UI thread so it only blocks for ANGLE D3D without direct composition path. Bug: 859168 Change-Id: Ie8ca1a661cdc06537e85b5be292c148ebc0503e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152998 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#760506}
-
Olivier Li authored
This requires some concept of watch state "snapshot" since we don't want to record the same hangs twice. Most of the complexity in the CL is related to that concept since the actual creation of the crash key is rather simple. Bug: 1034046 Change-Id: I41f910143c9a268451d1c88ce6684f680f873aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106486 Commit-Queue: Oliver Li <olivierli@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#760505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3e8db38..7a9eedf8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b23994fc674b62a94c4e347395eda9eb39a3eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156825Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760504}
-
Andrew Grieve authored
In order to: 1) not require recompiles when toggling is_java_debug, 2) allow incremental_install=1 to still have local variable information even when is_java_debug=false. Bug: None Change-Id: I0cd458d4445a925f02034907dc5673585e87c78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155206 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#760503}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //mojo. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=sky@chromium.org Bug: 714018 Change-Id: Iad24325ddf3b59c0f89c48cb3549331fc8ac3495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132395 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c3a7dbe1482..dc4f75f7eed2 git log 4c3a7dbe1482..dc4f75f7eed2 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 hbos@webrtc.org [Adaptation] Make ResourceUsageState nullable, remove kStable. Created with: gclient setdep -r src/third_party/webrtc@dc4f75f7eed2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic1b4d08e91be2d39e44f8cba6ea769866d02e9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156442Reviewed-by:
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/ui. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=sky@chromium.org Bug: 714018 Change-Id: I6661c11bb345bf98753aee7166bcd34a600f808b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132373Reviewed-by: -
Sasha McIntosh authored
UMA: Display.ParseEdidFailure Bug: 1031787 Change-Id: I8a70ca4813569485df01e8d781eb4e9fceacbf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150689Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#760499}
-
Nohemi Fernandez authored
The new architecture has multiple checks in place to ensure that coordinators are stopped (either by interrupt or completing an operation). Because the old architecture did not have these checks we were able to write more liberal tests. Bug: 1005509 Change-Id: I79f62b85c343b9dac8fccd5a81e0fb8a6d0dbee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156412Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#760498}
-
Gauthier Ambard authored
This CL makes sure that the feature to use the default user agent given by the WebClient is only working on iOS 13. Fixed: 1071746 Change-Id: I042b59c8ed6b993a75ebba40a5b8c7b3c9ad44a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153152 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760497}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 17d5c326. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 68a6734c "[blink] Add tests for destructive writes with JavaScript modules" 516e2447 "[WPT] Remove unused green-100x50.png images" ffd2e9cc "[css-grid] Migrate grid-automatic-minimum-for-auto-rows to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4224bf0ddbbccf2544787fc290f99c44c3759b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156512Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760496}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I8f9225a46f65ce7064cf4940f2c77e4178b962f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156605Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760495}
-
Dominique Fauteux-Chapleau authored
Bug: 1069026 Change-Id: I4dc8e84276d3e1f6a2c0d87c6e4f3ab588acbbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154732Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760494}
-
Greg Thompson authored
property_walker.Clean now logs errors so that RunCleanCommand does the best it possibly can and InstallerTest.tearDown will persist logs. BUG=1013720 R=zmin@chromium.org Change-Id: Ib936cadfc279983773457ffa3673e1f2564b64d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153056 Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760493}
-
Colin Blundell authored
As part of sharing as much as possible between the //chrome and //weblayer implementations of intent launching as possible, this CL dedupes the identical ExternalNavigationDelegateImpl#isPdfIntent() helpers into the shared ExternalNavigationHandler.java. Bug: 1071390 Change-Id: I030e22605ad1d982c339ec1a04ffdc55cef2ed35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156545Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I3d82c2cef13b3803682e2aeb2cdf4e4313b2ea30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156725Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#760491}
-
Omer Katz authored
If a not_fully_constructed object was reached again and marked by concurrent markers while the not_fully_constructed worklist was being emptied, we would get a race between setting mark bit and reading size for verification in debug modes. Bug: 986235 Change-Id: Ibb7b7619e6965901fb2a94a5c742db10070b64e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156488 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Fixed: 1071770 Change-Id: I38fc772129e93663ab7adcc650dce351bfc2128e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156546Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#760489}
-
Peng Huang authored
There is a typo which uses surface_msaa_count_ instead of final_msaa_count . But this typo shouldn't cause any problem, because surface_msaa_count_ and final_msaa_count are always 0. Bug: None Change-Id: I269324ceffc8ddea79478f7232ab6670ded00dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155622 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#760488}
-
Sebastien Lalancette authored
- Pulling up ownership from BVC to BrowserCoordinator. - Making it a short-lived coordinator instead of long-lived. - Renamed ActivityServiceLegacyCoordinator (removed Legacy). - Made ActivityServiceCoordinator a PresentationProvider for its controller. - Removing the ShareProtocol. - Calling shareDidComplete for password scenarios. - Removed "active" state from singleton controller. Bug: 1068606 Change-Id: I12105135614ef8cc45d7679bee63f34725cc058f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147778 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760487}
-
Mohamed Amir Yosef authored
This reverts commit 2d2185d8. Reason for revert: This caused ios build failures https://ci.chromium.org/p/chromium/builders/ci/ios-device/154217? Original change's description: > [iOS][Credential-Provider] Observe changes in the password store > > Updates the credential store with changes from the password store. > Renames SyncAllCredentials to RequestSyncAllCredentials to make clearer > the async nature of it. > Creates entry functions for adding, updating, and removing passwords > which will be used to also keep up to date the OS metadata in a follow > up CL. > Injects the credential store for easier testing. > > Bug: 1066803 > Change-Id: Id79c3b276517c7bb223b3988db4d1a8c25e00025 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152814 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760483} TBR=vasilii@chromium.org,javierrobles@chromium.org Change-Id: I769316c34e40c248a245553b1e5f78c834eee1aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156786Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#760486}
-
Omer Katz authored
Ephemeron tracing can occur during incremental marking steps if there is no other work for it to do and the deadline was not reached. The check whether a weak key is marked could race with a concurrent marker marking it. Bug: 986235 Change-Id: I5727a8800471dd24bb3f74430356c4dd7c12b130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156493Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/869374bcab6f..f3fda0023405 git log 869374bcab6f..f3fda0023405 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 sigurds@chromium.org [issues] Refactor issue displaying 2020-04-20 tvanderlippe@chromium.org Change waitForFunction condition to add more debugging output in network-datagrid.ts Created with: gclient setdep -r src/third_party/devtools-frontend/src@f3fda0023405 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066813,chromium:1070577,chromium:1072304 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90059b84574e13717d7898eb7b512f1ced9f9385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156440Reviewed-by:
-
Javier Ernesto Flores Robles authored
Updates the credential store with changes from the password store. Renames SyncAllCredentials to RequestSyncAllCredentials to make clearer the async nature of it. Creates entry functions for adding, updating, and removing passwords which will be used to also keep up to date the OS metadata in a follow up CL. Injects the credential store for easier testing. Bug: 1066803 Change-Id: Id79c3b276517c7bb223b3988db4d1a8c25e00025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152814 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760483}
-
