- 20 May, 2019 40 commits
-
-
Eric Willigers authored
Inheritance, parsing and computed value tests for background-position-x, background-position-y https://drafts.csswg.org/css-backgrounds-4/#background-position-longhands BUG=964885 Change-Id: I55630b41918557be536f28e3eb640bb3fc803c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614007 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661315}
-
Yoshifumi Inoue authored
This patch converts use-after-tree to CHECK() by changing Element#innerText to cause CEHCK() instead of DCHECK in StringView constructor to avoid use-after-tree. Note: We are not sure of root causes both use-after-free tree and wrong StringView constructor call. Bug: 964464 Change-Id: If4d289c8f6fe4072c1869553cd952d0c153a3369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619510Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661314}
-
Ren-Pei Zeng authored
The size of SharedMemoryHandle is now checked when mapping, so we should pass correct buffer sizes in JEA. Bug: b:133119111 Test: Take picture and check HW encoding works from /var/log/messages. Change-Id: I30c95e85a329f95083ae16cf3383ff3377e53409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619517Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661313}
-
Takashi Toyoshima authored
UMA_HISTOGRAM_COUNTS_10000 was to small for measuring total memory pressure in bytes. 10M or larger range would be preferable. Bug: 961602 Change-Id: I4e94ca973d65a74860cd16a0d424e1ea128a39b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619452 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#661312}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82728b140ee0..866576d99019 git log 82728b140ee0..866576d99019 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 taylori@google.com Merge "perfetto-ui: Replace query with fast version" 2019-05-20 taylori@google.com Merge "perfetto-ui: Fix performance issue when opening panels" Created with: gclient setdep -r src/third_party/perfetto@866576d99019 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I99aabbc59f9025dabf2e888c46a9d68e4ced3a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619644Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661311}
-
Eric Willigers authored
https://drafts.csswg.org/css-logical-1/#propdef-inset-block Change-Id: I32ba1428ab52ce8003add1fb5b0b4d4d17cfea88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615402Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#661310}
-
Peter K. Lee authored
Change-Id: I6dedc52a8f0eb4ff4bd0186158485bd15671e89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618316 Auto-Submit: Peter Lee <pkl@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#661309}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed2255b4ea13..f4c66ccafcb7 git log ed2255b4ea13..f4c66ccafcb7 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 06de90c66c18..70958d15db70 (8 commits) 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5ca9f956..4dc9df3b (533 commits) 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ab1e2b49fe88..7ab65834bc02 (24 commits) Created with: gclient setdep -r src/third_party/skia@f4c66ccafcb7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Ic5e8c89c1215cd0d85c5834056a0bc682dd087b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619551Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661308}
-
Yi Su authored
This CL moves WKNavigationDelegate.didStartProvisionalNavigation from CRWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: Ie20352c10350b00842c4ff8ce037f2e2f1df85de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617354 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661307}
-
Hirokazu Honda authored
media::BitstreamBuffer should be read-only if it is created from base::SharedMemoryHandle. The BitstreamBuffer for input buffers on video decoding and video encoding should not be modified by video decoder and encoder. In other words, they should be read-only. This CL sets |read_only| to true in VideoDecodeAccelerator/VideoEncodeAccelerator Client for ARC++ path. Bug: None Test: Play videos with YouTube app Test: Record videos with Google Camera App Change-Id: I1fd96881ee27ad46c47bd8bc0df6d1c748ccfbad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619449 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#661306}
-
Eric Willigers authored
flood-color accepts <<color>> values. https://drafts.fxtf.org/filter-effects/#propdef-flood-color The computed flood-color value for rgb() and rgba() is as specified. The computed flood-color value for color keywords, hex values and 'transparent' is an rgb() or rgba() function. https://drafts.csswg.org/css-color-3/#foreground Change-Id: Iae210734d3829964ad64ae4a7ba7899c391b1898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619518 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661305}
-
Yi Su authored
This CL moves WKNavigationDelegate.decidePolicyForNavigationResponse from CRWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: I03be8af43fd644ef87fde6ef215098725ab1f33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617491 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661304}
-
Eric Willigers authored
Computed value is per side, either the keyword auto or a computed <length-percentage> value. https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding Change-Id: Id3200ae8a8af9a2e8ee87e675d14f3a6965ea841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619454 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#661303}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I117a5cb0b4e7d28d3463b9d660763831da466a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661302}
-
Yi Su authored
This CL moves WKNavigationDelegate method "webView:decidePolicyForNavigationAction:decisionHandler" from CRWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: I174e56214a59c8f272c36d983445fe4e230fc8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609906 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661301}
-
Christian Dullweber authored
SessionStorageNamespaceImplMojo::RemoveOriginData didn't call its callback when the origin was not found in origin_areas_. Bug: 963533 Change-Id: Id71bc617d0d9d28d164a1f0ec97e76d18c2b1b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615180Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#661300}
-
Ramin Halavati authored
Profile::GetProfileType() is made protected to persuade usage of profile type functions (IsRegularProfile, IsIncognito, IsGuestProfile). Bug: 947933 Change-Id: Ie049488fa714002b3a0372946040fef82672d440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611986Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#661299}
-
Kent Tamura authored
Tests in custom-elements/tentative were upstreamed to WPT by https://github.com/web-platform-tests/wpt/pull/15740 . Bug: 905922 Change-Id: I3e0b24486562b69e6fa212fd93927d3811d13967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619590Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#661298}
-
Victor Hugo Vianna Silva authored
We introduce a new layer FaviconRequestHandler that is used by both FaviconSource and RecentTabsMenuModel to request favicons by pageurl. The layer first queries the local storage (FaviconService) and if that fails then queries sync storage (FaviconCache). No behavior is changed. Bug: 955475 Change-Id: I4836cd21cc6a7f30147c84f5de04fdef3d1a32ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603563 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#661297}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf6269b441f1..7639f1999ac1 git log cf6269b441f1..7639f1999ac1 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7639f1999ac1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id9f3e9ed2b697f705e270f996c481e20557fc3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619559Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661296}
-
Kent Tamura authored
This CL follows the latest specification PR; https://github.com/whatwg/html/pull/4383 Add the |anchor| argument to setValidity(). ElementInternals has a data member to store it. ListedElement shows a validation bubble on ValidationAnchor() result, which returns the data member if it's not null, returns the target element otherwise. Internals::isValidationMessageVisible() is updated so that it asks ValidationMessageClient directly because we can show validation bubble on any elements. Bug: 905922 Change-Id: I20e1bdfeed6ab2635fd3f171e5160feeba170681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614644 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#661295}
-
Roman Sorokin authored
Just went through all cases on a real device and corrected the mixin a bit. Bug: 952855 Change-Id: I941473ce9ea2bf92b5d8c70637a5a1b4077b3a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615143Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661294}
-
Jia authored
This contains the following changes 1. In addition to saving a trained personal curve, we also save global curve and model iteration count when a new curve is saved. 2. Saved model is discarded if initial global curve specified from config or finch is different from the saved global curve. 3. No longer need to fetch finch params "auto_brightness_als_horizon" and "model_als_horizon_seconds" from adapter.cc or modeller_impl.cc because finch-flag checking is done by model_config_loader.cc Bug: 881215 Change-Id: If6f7718948ae675909eb18ab1b216b7d83be62b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609746Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#661293}
-
David Jean authored
This is a reland of 950edae3 Original change's description: > [ios] extract JS injection from web controller > > Moved JS injection relative code to a new class in crw_js_injector. > Updated CRWJSInjectionEvaluator to have a executeUserJavaScript that > seemed to logicaly have been there already. > > Bug: 954137 > Change-Id: I3a80c995de82329f22532d791c20d84b9ecbfe46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571703 > Commit-Queue: David Jean <djean@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657195} Bug: 954137 Change-Id: I1b4950cc3bf5c7ebe0f38b82c080324bd42c845f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601051 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661292}
-
Yi Su authored
This CL adds an unittest containing one test case for wk_web_view_util.IsSafeBrowsingWarningDisplayedInWebView. Notice that private API of WKPreferences and WKWebView are used in this test case to enable safe browsing and to display the warning. It's also only supported by iOS 12.2+. Bug: 956511 Change-Id: Ib39f7b3ba544bbc07d3b579ac6bf29c619e25f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617483 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661291}
-
Ren-Pei Zeng authored
Correct the size parameters used to create SharedMemoryHandle. Bug: b:132928975 Test: Open camera app and check JDA is working in messages. Change-Id: Ib2f18ed80fce1b55b983780cea541b111d18f903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616874Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661290}
-
Peter K. Lee authored
This has been removed from @protocol ActivitySErvicePositioner Change-Id: I3a5a3676dfc8f2d3451f38bb4b3409e1429c8df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616931 Auto-Submit: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#661289}
-
Abhijeet Kandalkar authored
This CL uses IsA<FooElement> and To<FooElement> as replacement for casting helper ToFooElementOrDie. Bug: 891908 Change-Id: Ib14fc4e89089b44c6d5be94a4930e3b467283dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616927Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#661288}
-
Fergus Dall authored
TBR=perezju@chromium.org Bug: 964804 Change-Id: Ic9dbdd1cc21982fe99f16c928170456219f37f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619514Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#661287}
-
Huanzhong Huang authored
Please refer to the bug for details. -It's unclear how to instruct the table view to recover the selection states for those previously selected cells after a reload triggered by a font size change. -We've previously (1596451) made changes so that TableViewClearBrowsingDataItem's configureCell:withStyler: is again solely responsible for a TableViewClearBrowsingDataCell's appearance. -Therefore we turn back to the usual approach of not maintaining a cell's selection state: maintaining states in items, reflecting item states in cell appearances. Bug: 960756 Change-Id: I987da5e10b0745f035effb12ab493b240ccd407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601256Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#661286}
-
Fergus Dall authored
This reverts commit 7f874680. Reason for revert: This seems to have broken http/tests/devtools/network/network-log-service-worker-navigate.js on WebKit Mac10.13 (retina). https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/14412 was the first broken build and right after this landed. Original change's description: > service worker: Enable off-the-main-thread service worker script fetch by default > > Note to sheriffs: Feel free to revert this if this breaks something. > > Bug: 924043 > Change-Id: I7164ad621edafebd7fc05d9f4eeee7bd673cbe6a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583168 > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661268} TBR=falken@chromium.org,kinuko@chromium.org,bashi@chromium.org Change-Id: Icb6500aba7f6e1f1d80624f95f45a3c318b8262c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619588Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#661285}
-
Fergus Dall authored
This reverts commit 719b61da. Reason for revert: Causing failures of StartupTracingInProcessTest.TestFilledStartupBuffer on many builders Original change's description: > Perfetto: Move in-process mode behind a feature flag while investigating crash > > R=ssid@chromium.org > BUG=961609 > > Change-Id: Ic25d4eb36f90506c8d21abf3df35fb3f11474746 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616447 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660715} TBR=oysteine@chromium.org,ssid@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 961609 Change-Id: I6f19fc5f738d9a1b05cb9c76438bed20e5ee45b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619585Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#661284}
-
Philipp Hancke authored
running the html.js/codemod-peerconnection-addcleanup from the tools directory showed some places where a pc.close was missing BUG=836871 Change-Id: I135db200a4269eccfafc43217b66584603101434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610767 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#661283}
-
Matt Falkenhagen authored
Before this CL, ServiceWorkerRegistration had three states: - is_deleted - is_uninstalling - is_uninstalled It's difficult to understand the differences. The tension that caused the states seems to be that |is_deleted| was controlled by the lower-level storage layer, and |is_uninstall{ing,ed}| by the higher-level API layer like the implementation of unregister(). This CL aims to simplify things by removing the is_deleted flag. The layers get a bit more blurry but the benefit is fewer states. There are likely further cleanups and renamings possible to make this nicer. Change-Id: Iee1102da0a865f571bc8906e184dd16551541c1e Bug: 964201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616870Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#661282}
-
Anand K. Mistry authored
smbprovider requires share paths to be in the smb:// format. BUG=964198 Change-Id: I3b0236dd265a07106c5e3ddd9ec339f7042bd7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619448 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#661281}
-
Yutaka Hirano authored
OffMainThreadFetch has been stable for a long time, so let's remove it. Bug: 443374 Change-Id: If9e8f3f1059c121e2c94cf2ee6da91581e7016e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616827 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661280}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I1c6dce2dcb7424fc6cab9faa10a1b510396b78b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619526 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#661279}
-
François Degros authored
Change-Id: Id668076353fc0a3a956fe7c742a3971c1d4f6f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619451 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#661278}
-
Hirokazu Honda authored
We create VideoFrameMapper with a pixel format. Only this pixel format is when calling Map(). VFMapper client may want to know the currently allowed pixel format for Map(). This CL adds the function to VideoFrameMapper interface that returns the pixel format. Bug: 952147 Test: video_decode_accelerator_tests Change-Id: I8a48636a11b898fb39a6bbed6276cebda85e6161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609726 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#661277}
-
Tetsui Ohkubo authored
This CL modifies exo to send raw gamepad scancode to ARC when ExoRawGamepadInfo is enabled. ARC can identify if it's raw scancode by whether the gamepad was initialized by gamepad_added or gamepad_added_with_device_info. Previously, Exo was sending Web Gamepad keycode to ARC, but this will be deprecated as a part of the effort to improve ARC Gampad compatibility. Design doc: go/arc-improved-gamepad TEST=manual(--enable-features=ExoRawGamepadInfo to /etc/chrome_dev.conf) BUG=b:130597086 Change-Id: Ied4da69655623a243b9e1caa681212138d46918e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612857Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#661276}
-