GitLab

BUG=None
TEST=None
TBR=johnnyg

Review URL: http://codereview.chromium.org/8343055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107700 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a SpellCheckSubMenuObserver class and move code of the "spell-checker options" submenu there.

BUG=93746
TEST=none

Review URL: http://codereview.chromium.org/8363042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93932

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107697 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107696 0039d316-1c4b-4281-b951-d872f2087c98

stop updating tooltips after the widget is destroyed.

BUG=none
TEST=views_unittests pass

TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8414012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107695 0039d316-1c4b-4281-b951-d872f2087c98

TBR=erik.corry
Review URL: http://codereview.chromium.org/8413029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107694 0039d316-1c4b-4281-b951-d872f2087c98

Add more race/overlaps for 93932.
Renamed 93932 issues in mac to have _mac_ as same suppression exists on suppression.txt

TBR=acolwell@chromium.org,rvargas@chromium.org
BUG=101853,93932
TEST=none

Review URL: http://codereview.chromium.org/8413028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107693 0039d316-1c4b-4281-b951-d872f2087c98

- Whether notifications setup is done once already.
- Whether the user has disabled notifications.
Review URL: http://codereview.chromium.org/8399022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107692 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=johnnyg

Review URL: http://codereview.chromium.org/8400054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107690 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni@chromium.org
BUG=chromium-os:21760
TEST=Change the network state with a11y turned on


Review URL: http://codereview.chromium.org/8402023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107689 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107688 0039d316-1c4b-4281-b951-d872f2087c98

This includes the new incremental GC.

TBR=erik.corry

Review URL: http://codereview.chromium.org/8343051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107687 0039d316-1c4b-4281-b951-d872f2087c98

Propagate that flag up a few levels and add CHECKs.  Since the old code
crashed, CHECKing is no worse.

Rename some functions to add *ForTest suffixes.

BUG=100907
TEST=

Review URL: http://codereview.chromium.org/8402014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107686 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=yurys
Review URL: http://codereview.chromium.org/8416027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107684 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20044
TEST=Add two or more users.  Check that you can tab to all users and remove buttons, and that you can remove users.


Review URL: http://codereview.chromium.org/8396032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107683 0039d316-1c4b-4281-b951-d872f2087c98

R=penghuang@chromium.org
BUG=chromium-os:22107
TEST=Install two IME extensions, and ensure that they both work.

Review URL: http://codereview.chromium.org/8393038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107682 0039d316-1c4b-4281-b951-d872f2087c98

The old tests were mostly useless as they tested using a mocked VideoDecodeEngine.

Review URL: http://codereview.chromium.org/8340008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107681 0039d316-1c4b-4281-b951-d872f2087c98

Also remove some obsolete code and simplify some of the code's expectations.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8351027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100442
TEST=net_unittests:X509CertificateNameVerifyTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107075

Review URL: http://codereview.chromium.org/8362023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107679 0039d316-1c4b-4281-b951-d872f2087c98

Revert 107669 (Looks to have caused bot failures) - Register the RenderViewHost instance created when a desktop notification bubble is displayed in CF
with the AutomationResourceMessagefilter. This ensures that any HTTP requests issued by this bubble go through
the host network stack implemenation.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=64251

BUG=64251
Review URL: http://codereview.chromium.org/8414005

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/8416031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102030
Review URL: http://codereview.chromium.org/8400052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107677 0039d316-1c4b-4281-b951-d872f2087c98

Mark TransportClientSocketPoolTest.BackupSocketFailAfterStall as flaky on linux/mac, since it is sporadically timing out at 24 seconds.

BUG=89273

Review URL: http://codereview.chromium.org/8400051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107675 0039d316-1c4b-4281-b951-d872f2087c98

This hooks up the DownloadProtectionService to run after a download finishes.  For now, this does not send a download pingback since the flag defaults to off.


TEST=DownloadProtectionServiceTest
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107528

Review URL: http://codereview.chromium.org/8345033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Everything still works!


Review URL: http://codereview.chromium.org/8416007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107673 0039d316-1c4b-4281-b951-d872f2087c98

To be used with pyauto.
Usage:
    sync_server = pyauto.TestServer(pyauto.TestServer.TYPE_SYNC,
                                    pyauto.FilePath(self.DataDir()))
    sync_server.Start()
    print sync_server.GetPort(), sync_server.GetSyncXmppPort()
    sync_server.Stop()

R=dennisjeffrey@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8343044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107672 0039d316-1c4b-4281-b951-d872f2087c98

Add a "bool client_cert_sent" member to SSLInfo to extract this info
from SSLClientSocket.

R=rtenneti@chromium.org
BUG=101778
TEST=new unit test

Review URL: http://codereview.chromium.org/8401024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107671 0039d316-1c4b-4281-b951-d872f2087c98

with the AutomationResourceMessagefilter. This ensures that any HTTP requests issued by this bubble go through
the host network stack implemenation.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=64251

BUG=64251
Review URL: http://codereview.chromium.org/8414005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=33165
TEST=Manual: add an invalid #include in ppapi/examples/ime/ime.cc and
verify it to be correctly warned.


Review URL: http://codereview.chromium.org/8416016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107668 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101963
TEST=Running unit_tests --gtest_filter=AppNotificationManagerSyncTest.* should
not leave around any empty temp directories (and there should be no error log
messages from ScopedTempDir's desctructor about being unable to delete the
underlying temp dir).


Review URL: http://codereview.chromium.org/8415004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107667 0039d316-1c4b-4281-b951-d872f2087c98

When a balloon popup is open, the target of the close window/tab keyboard shortcut is still the main browser window.  Update our custom menu item rejiggering code to pay attention to the main window, rather than to the popup window, when a popup is open.

BUG=95169
TEST=(see bug)


Review URL: http://codereview.chromium.org/8302021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107666 0039d316-1c4b-4281-b951-d872f2087c98

-rename URLFetcherFactory to URLFetcherImplFactory
-rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL
-get rid of request_type in TestURLFetcher's constructor

BUG=98716
Review URL: http://codereview.chromium.org/8416020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8343040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107661 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yurys@chromium.org
BUG=102016
TEST=none

Review URL: http://codereview.chromium.org/8341096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107660 0039d316-1c4b-4281-b951-d872f2087c98

Most consumers on all platforms (including windows!) were converting the font family/GetFontName() result to UTF8. (Windows was still having to convert for the SkTypeface calls.) On Linux, we're performing a UTF16ToUTF8 on each string print (and this is showing up in pprof output.)

BUG=100803
TEST=none


Review URL: http://codereview.chromium.org/8392017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107659 0039d316-1c4b-4281-b951-d872f2087c98

This happens when the HistoryService starts closing the backend, and the
ExpireHistoryBackend then tries to notify HistoryBackend of a deletion.

BUG=101999
TEST=none

R=brettw@chromium.org

Review URL: http://codereview.chromium.org/8341087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107658 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:21732
TEST=manual


Review URL: http://codereview.chromium.org/8341046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107657 0039d316-1c4b-4281-b951-d872f2087c98

TBR=toyoshim@chromium.org
BUG=70599
TEST=none

Review URL: http://codereview.chromium.org/8418011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107656 0039d316-1c4b-4281-b951-d872f2087c98

underlying TabContents. |render_widget_host_| is NULL as
RenderWidgetHostViewWin is being destroyed.

BUG=101948
TEST=none

R=sky@chromium.org

Review URL: http://codereview.chromium.org/8418005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107655 0039d316-1c4b-4281-b951-d872f2087c98